From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 208BEA00C5; Thu, 15 Sep 2022 13:38:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B7CEE4021D; Thu, 15 Sep 2022 13:38:37 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id A806840156 for ; Thu, 15 Sep 2022 13:38:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663241915; x=1694777915; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=uTioU4X2zYtsYi0FOvN1CPRFRA+soJGKeT7R8e7nVVg=; b=fvC1SES+wyx1kPCqyUBowhgTeaBKPAoYa398WsSikreEjdhplosSENFE 5yOMeC8IDIIsCJPO4Q1e0eFETwdxDF0MVwPClhGEEJTfWlmCn8LzE2Fx8 byZt72gh3IidCye5pGLMrC7ZWQYoLFQQIaPwizhe56eKz2L5Kp/DOZFLy WapGazFNwCQidbokdCMZfbgWzkF2V6+ceZ3Gt4ZXIufVv7K/xsD/IGk0H IfwZ3SJBqNjGLEV4quFv9kvc+IOOFiEp1oBEt9ZUy6fJs2cXtDFdfP8G8 ZFsi/NxoLNthQvnZi+PV6HJKKueh2kccTx4G64o+L8s0eB4qWzfhncc8g w==; X-IronPort-AV: E=McAfee;i="6500,9779,10470"; a="300046581" X-IronPort-AV: E=Sophos;i="5.93,317,1654585200"; d="scan'208";a="300046581" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2022 04:38:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,317,1654585200"; d="scan'208";a="594783069" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga006.jf.intel.com with ESMTP; 15 Sep 2022 04:38:34 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 15 Sep 2022 04:38:34 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 15 Sep 2022 04:38:33 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 15 Sep 2022 04:38:33 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.177) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 15 Sep 2022 04:38:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m6SdKMublrRqAF1iacItOO1WK/eoIZhVIQcOy9/upzvM7IF5PhKR+gODYCCEQdK/TquZownUTpZtlgNgyFVghiJBnpDCw5Kj5z9b/o/JMQDYQZ0CvHwilPDiB5pEtKjs5ZVc3WbwlnQoqltkTYovSeXyin/aTbR9yb6nL0iyG+UD5m75o8KzW4KBXi4rNpUTXzqTl61iwlqMTSOQBkyirL1yjHPhEn4c9IquztRugHkFatKamqXPmcPh2NNdeJ6iuPjJC16AsB6/F4WgJS6a4DyhC+rupu3K2SUcdjjXrZPnRaWDmPx0M8IKzz+wiClftwGnjjuzcP3D7QgJqwW0Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZBZUtTyMbxujzB1yknCCD5SWyeFekf/v5CP+ILaEWLM=; b=EQkDIHzibbXU4q5Q7VDext1SwOUXbh50CvXLwWByIfhrsj6n6rdLc17U1g5PpAzotV0vd2MXe+mUuvT8mdd6qpQ+AXeX8jKj9IfJ6lJl8cM71Hek1R7A3dI8y7rJGqPDoTm1jlb++bj5ebagpaVqVxK8zLwFItxOui+XSajDUSbYp/3WmJv0K2RWr+8LlzulWU3vFK4qZuqCjh7v3NuvbTId88BN00H19ajNjCJPlN8ULXfzyVp9yNZaCNKqbdSCfmESKm624Qrqk8Qhnp/Gf6w7f5vF7/6gYdWAJTO4VjjQtpI7UOzRHXmPvxdEpub8usPpbQumc87a1ynmzM0Ijw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5591.namprd11.prod.outlook.com (2603:10b6:8:38::23) by CY5PR11MB6389.namprd11.prod.outlook.com (2603:10b6:930:3a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.19; Thu, 15 Sep 2022 11:38:32 +0000 Received: from DM8PR11MB5591.namprd11.prod.outlook.com ([fe80::1400:7e7f:fc3b:98fe]) by DM8PR11MB5591.namprd11.prod.outlook.com ([fe80::1400:7e7f:fc3b:98fe%3]) with mapi id 15.20.5632.015; Thu, 15 Sep 2022 11:38:32 +0000 From: "De Lara Guarch, Pablo" To: "Power, Ciara" , "Zhang, Roy Fan" CC: "dev@dpdk.org" , "Ji, Kai" , "Mrozowicz, SlawomirX" Subject: RE: [PATCH v2 2/5] crypto/ipsec_mb: fix sessionless cleanup Thread-Topic: [PATCH v2 2/5] crypto/ipsec_mb: fix sessionless cleanup Thread-Index: AQHYuI8SEpqxtPJhoU6EFXjQyfti7K3gfXBA Date: Thu, 15 Sep 2022 11:38:32 +0000 Message-ID: References: <20220812132334.75707-1-ciara.power@intel.com> <20220825142901.898007-1-ciara.power@intel.com> <20220825142901.898007-3-ciara.power@intel.com> In-Reply-To: <20220825142901.898007-3-ciara.power@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8PR11MB5591:EE_|CY5PR11MB6389:EE_ x-ms-office365-filtering-correlation-id: e15a95b1-e879-4e0a-c66e-08da970ed12f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3ypJiT5Z+a5EQRj8pVdJ52wM8Mg+MqJokPvYdAJrcm7jIjkhWKKwhYW1VKFfJmltAGlo/0IDK4dIZySGu3CI5CLJ7O8qkOZBt0oWaqexDCRKEE/I56dTflqeXLl3Si7bTcOx0WejxjAMf8GtqpRXdwiDC1/hcXwfPCU48Ha/mMElWOBF/D37eubUWRm29/lHc7ESZ5OYMi+Q9sLK0dFqtMF5gEjzqe6/7Mm0NBRZX5v+BtosEqeZiqKMuS0UOhgfU87o3Einjr6Ytsr7jPp7G03XtEJwnXO/DeyUP9jKuishXxaZUztda/hQDuXDI8riTR/ym8UCwd2zZuIziAMqK/SsyJgiXnlwUufXCTSmR8X4KmXkniC/6JS6ib0uxU2zhxkZVB/29tw8tmz2HEp+BPcz6lVJtS3eI5VqH+kuztUAemNEjCmhFQJwzXw24HeJRIzgH1zSYON1EwhN4oG7k4tSVHkukbW1CzfGT04VH70zC1khJUQ65DvCrEvm3XM5+IT/QdOb+aAci5VyTCTBUeSfhIHdbNgE52vHnB0s/vll1cdt5JqTnTVf4YvDeeilkuYAmqC9/jh5aWALKzCK9CUURD20nEYBNVDHmn+LgkRhNY8hekyGCEXZ0xhwjsp8nMRUHG5WwuZcHXtQNr0zkCHZb0l/WwdslcD+bhmvOUtM/Qr6UPlccqlLgOREpF/KI7FfOkfwS98rDDXiToCUOUwuCXcY6uCGHboXimcHbaTrHJW7q0Qc5SXVfWxZPR8CARV/+XE5tB7Ga1jCUvRRgQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5591.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(39860400002)(366004)(376002)(346002)(136003)(451199015)(41300700001)(110136005)(8676002)(66556008)(5660300002)(316002)(7696005)(76116006)(53546011)(26005)(86362001)(38100700002)(6506007)(38070700005)(6636002)(52536014)(64756008)(55016003)(9686003)(66446008)(66946007)(71200400001)(54906003)(66476007)(82960400001)(33656002)(107886003)(4326008)(8936002)(83380400001)(2906002)(186003)(122000001)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?axX6p7042rZmKz+jXjwk3a5OvyJpttJQxqd7QDIYhLb5B5du1aGJzeU2ulHV?= =?us-ascii?Q?YU6pibkthQY8kd4qlI47+5Nwx/mWe5wdjY4cnX8hh6rvgRf7BXwj9OSio4aS?= =?us-ascii?Q?WEFZO4j7rne3LlFQPtzX40J4caJi9jgBGfi0xOrfQpiGFsWYhCxGj9yQ2LsE?= =?us-ascii?Q?ODtfxQTEKbVv1J149Mc5yMvfajQsxwW+c4yCjEQiCC6zhP+iQTiLiJq4s/6B?= =?us-ascii?Q?QPL5v9A3VdUbr4zKiMOmY7p4KPKfHIzQqRmfBfKr8pogdlNI7lYo5+3u9npw?= =?us-ascii?Q?cDnUd+Y6F4nRSbiNJcSZJfLdRWUWdm3HtsT8XP2dpqsz3rLX2cCHdD9ZJWkc?= =?us-ascii?Q?2VyOh2uLrmK/cEOeAJeKpb0a/zYN+LUI6dc05HuItxhZ06/6a6bHueU2Z8DX?= =?us-ascii?Q?hWNQjk3O7By5U0eW7hoKpkNtQiWmVzQf1EvH3yiaPYHTzX1cLyUm97eT5ENd?= =?us-ascii?Q?EkhcJhWTabNt9VHNa5Ibs+yiAOnKnDbIXsdnRh3hGu7OR0dVRKJeTYPT4VQ+?= =?us-ascii?Q?ZKFhpYjVZ7D0ZFAECJ3hebmPirocOdzJ8EdF8gnxBBPp0C/Rjb77hx/Sc4w/?= =?us-ascii?Q?2lgbWDzI+bLZc6cyq3MEurFbmwl0n513AtE7uVeiX1LwM+W14y/BSYVDilL9?= =?us-ascii?Q?cTdKB7bYU1464vwZSNzwhLEwEF3alS2MQh4t/63Y66/iTzhw89m0uECWPMgO?= =?us-ascii?Q?8byQJxoezw7TQADvMkZtrzXGyklqX21L6efqkjbMNmFYXqcnUw/9/qH+4vXn?= =?us-ascii?Q?Fq3yHFB106PiBPZZMX+6JgaWqKRJTganMwkIRYFNIuXZYJeg4lMcGfeE1AZg?= =?us-ascii?Q?3ZN1F3I9FLC4gqwn3GPfeGMWcbW1g5ljKgUZWKr4Pm/jP40R4AKHURy9AW2u?= =?us-ascii?Q?o7MqVuBxE+7tGJVBifRSqMjqwvu5fA8eKsJT2Fwff+oPvthMU84pAzyJ4LBJ?= =?us-ascii?Q?cGo3rHgnU7vHhn/T1rA1+jIn7DoX4m7Arnzt4HMafgLudz3lTYMEHn6tkpjG?= =?us-ascii?Q?ce4GCoNa4EZ9+/V9638jqf8aszk/zrm96tLXYhNr0P16LIbVQqfTbOqL7iOz?= =?us-ascii?Q?bJtCieJg+66DyAlQC9ZnS251XpGZR8OPrdUr5hL41TEobaRJz8bMb3aSmnSB?= =?us-ascii?Q?S3baC8Qj5Ta08SrX70V3oqtP3OCnA0TrUjinqXZHRSnaEe4KW2Y4v8pkgd1u?= =?us-ascii?Q?rul0Sri58Ms725TOV77SLIpTeE8fDC0Hnt+tMCQ2ZgAgrUFnU8JKIn3+WzwT?= =?us-ascii?Q?VTh39iau95eCxcS1GDEu/hjVwb2OQcCUOwYcnLdPVpNlVLQnXaAcGRYVwXi+?= =?us-ascii?Q?MvENQpsEs39HBFskoh3QNpxay5q6x2M+W/ECqSCcQg8fquWEz8tt+NWmDmFt?= =?us-ascii?Q?RIPjdi2jXOmBFN/7JufP8am10Huyr+1vD9S1U/nN7emSpsupFw+TjjMY/5+U?= =?us-ascii?Q?fiPfLLhBHOjmfd5Kh9HlFcjVeTY7D82W1WieuXUCE0vqtS/+VPgh+PKv49wC?= =?us-ascii?Q?STY74qv/zaoGAp/vX08JS7yh9WBz/KIjwZ90yjz3mVbUO0gOlbS9zknH6KOt?= =?us-ascii?Q?WG2ubvt6as/FzdIWRzkYwq7EtEfcjXaEuOwMiNnzpxTCO3iuK91BsBvUiYwL?= =?us-ascii?Q?Pw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5591.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e15a95b1-e879-4e0a-c66e-08da970ed12f X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2022 11:38:32.0940 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KwconVinsP8OCh9rgwDTBTCsWcJas8WLsJZuw2rnCHXMjyCcII2FAsH7Lg6RqVxXRVC/RH42gHKaxvw7KSpsD4WL8B76L6VH4Y/ae6bDs3g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6389 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Ciara, > -----Original Message----- > From: Power, Ciara > Sent: Thursday, August 25, 2022 3:29 PM > To: Zhang, Roy Fan ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; Ji, Kai ; Power, Ciara > ; Mrozowicz, SlawomirX > > Subject: [PATCH v2 2/5] crypto/ipsec_mb: fix sessionless cleanup >=20 > Currently, for a sessionless op, the session created is reset before bein= g put > back into the mempool. This causes issues as the object isn't correctly > released into the mempool. >=20 > Fixes: c68d7aa354f6 ("crypto/aesni_mb: use architecture independent > macros") > Fixes: b3bbd9e5f265 ("cryptodev: support device independent sessions") > Fixes: f16662885472 ("crypto/ipsec_mb: add chacha_poly PMD") > Cc: roy.fan.zhang@intel.com > Cc: slawomirx.mrozowicz@intel.com > Cc: kai.ji@intel.com >=20 > Signed-off-by: Ciara Power > --- > drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 4 ---- > drivers/crypto/ipsec_mb/pmd_chacha_poly.c | 4 ---- > drivers/crypto/ipsec_mb/pmd_kasumi.c | 5 ----- > drivers/crypto/ipsec_mb/pmd_snow3g.c | 4 ---- > drivers/crypto/ipsec_mb/pmd_zuc.c | 4 ---- > 5 files changed, 21 deletions(-) >=20 > diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c > b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c > index 6d5d3ce8eb..944fce0261 100644 > --- a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c > +++ b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c > @@ -1770,10 +1770,6 @@ post_process_mb_job(struct ipsec_mb_qp *qp, > IMB_JOB *job) >=20 > /* Free session if a session-less crypto op */ > if (op->sess_type =3D=3D RTE_CRYPTO_OP_SESSIONLESS) { > - memset(sess, 0, sizeof(struct aesni_mb_session)); > - memset(op->sym->session, 0, > - This will leave some info leftover, so it may cause a problem if this objec= t is reused? Is this memset clearing mempool object header and that's the r= eason why it cannot be released properly? Maybe Fan/Kai/Slawomir will know more on this.