From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id B8A93A0350;
Mon, 10 Jan 2022 14:44:15 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 4CE3D4114F;
Mon, 10 Jan 2022 14:44:15 +0100 (CET)
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
by mails.dpdk.org (Postfix) with ESMTP id 0D0B140041;
Mon, 10 Jan 2022 14:44:12 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1641822253; x=1673358253;
h=from:to:cc:subject:date:message-id:references:
in-reply-to:content-transfer-encoding:mime-version;
bh=4bG6Ne00eLjhnsnnjOp0RPHGXRDXfTPPPVAG73HbnMc=;
b=S7G28uu044dVPaCx3XHhbEdES+8ndAzNpIbR8vSgetxXBfjEI/bC33Ou
pSwunKmPyCEUteuwQf13hDHDsLvP7kTNyGCK1wKKXqk9od1IqDA96oQ94
RShP0U9Qxoc7BugizchnTvLNYb3KCjA5ccIcUMyFG5a5t/h8lKOR4i3Fy
oLvdeEzOr7hGkMuUkZJBrUcv4ouB8MH1+qTpy+c6q+Tts/UO/0lM8nMip
1jWBAzUHCfsa8Q+3ibKDmfGFHTf3MAOFz4JnaBtclS4pi0VsbzDEGz3jn
QarC4AqtCEs1QNIGvW8NWMkJXaUxf+PVjWq1kD1PznrH0/m8k92CJ861r A==;
X-IronPort-AV: E=McAfee;i="6200,9189,10222"; a="267553826"
X-IronPort-AV: E=Sophos;i="5.88,277,1635231600"; d="scan'208";a="267553826"
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
10 Jan 2022 05:44:09 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.88,277,1635231600"; d="scan'208";a="619438872"
Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18])
by fmsmga002.fm.intel.com with ESMTP; 10 Jan 2022 05:44:09 -0800
Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by
ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2308.20; Mon, 10 Jan 2022 05:44:09 -0800
Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by
ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2308.20; Mon, 10 Jan 2022 05:44:08 -0800
Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by
orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2308.20 via Frontend Transport; Mon, 10 Jan 2022 05:44:08 -0800
Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170)
by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.2308.20; Mon, 10 Jan 2022 05:44:08 -0800
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=oWEr8DyuZYa0Km2kaPr4qvME/+ccV1pOG6BcN3i8dW0B7Pna4I3mkH7FihyR1t8N5tzRSxN8G800aO5iNC+lBe9GR4W6I2UGjj3htEijPaoOhyIxd/vr8QByb85nMnXG85vhlns8gZdrXbMhnzS2Z+V6FKwAN0GD0R52//eC8XsXxRh+MB4K3Uz5WwyrIVm95dgPliZ/sZRaMd2HndbXKa/I/UobNxTXxZV/gnsEUpuGTvVwPPW3OshoohSvvLDco7kXS2kP2WlVFm4x5nCuP7ffLSg/9vCcowqVRpYo71P97Jf2sQCdtDmM0uM/bqZwJ156GVKOTyV4CES2PEPjHw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=LE6Q62en3m8QmvCxieN1W0ohvCWZZ+MlkjVDN+lpmg8=;
b=ksvr8+iBhPzQp6s2u63aQOSpWqoag/LbIpOyO2jXfg+xj379Zb9yfTqG/YOGCTvWI7oLsnsRiczHuz2TZTtIKyapAkJaJXNIaO85WZKA4aMtZOCBuipeNEdxl4n+9uAuQyyvm0UOkvEzEz7+tNXMLGJdal73yEcfDumsMkKs1mJG1IJk1H8OSMnaEtef++vAHrdLc/xa/A5kTyRZqKMmsHuUmrJKnnu2SHSoLMr9jcNfDlflo3FjwPFxTWOdXFAYhBZbDxJFZg98G9ko4mqYYdaYmOajiaIfQpDs+H5GWoZrtsU7mQ451BpZ9JPqQMW/50eUP3FEtmtF56jZtpUS+g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
Received: from DM8PR11MB5605.namprd11.prod.outlook.com (2603:10b6:8:26::11) by
DM8PR11MB5637.namprd11.prod.outlook.com (2603:10b6:8:33::5) with
Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.4867.7; Mon, 10 Jan 2022 13:44:06 +0000
Received: from DM8PR11MB5605.namprd11.prod.outlook.com
([fe80::6d19:bd17:7a9:17e1]) by DM8PR11MB5605.namprd11.prod.outlook.com
([fe80::6d19:bd17:7a9:17e1%8]) with mapi id 15.20.4867.012; Mon, 10 Jan 2022
13:44:06 +0000
From: "Pai G, Sunil" <sunil.pai.g@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Laatz, Kevin" <kevin.laatz@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>, "Hu, Jiayu" <jiayu.hu@intel.com>
Subject: RE: [PATCH] dma/idxd: fix burst capacity calculation
Thread-Topic: [PATCH] dma/idxd: fix burst capacity calculation
Thread-Index: AQHX9cQR1Iyyg4jsP025h/EnRjKVIqxcWpgwgAAE5ACAAAG7kA==
Date: Mon, 10 Jan 2022 13:44:06 +0000
Message-ID: <DM8PR11MB56050FA06795ECBC51354370BD509@DM8PR11MB5605.namprd11.prod.outlook.com>
References: <20211220170514.736732-1-bruce.richardson@intel.com>
<DM8PR11MB5605F2B8DFA7B6D84270F9E8BD509@DM8PR11MB5605.namprd11.prod.outlook.com>
<YdwzvhBUdCXWJ669@bricha3-MOBL.ger.corp.intel.com>
In-Reply-To: <YdwzvhBUdCXWJ669@bricha3-MOBL.ger.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.200.16
authentication-results: dkim=none (message not signed)
header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 68968dce-0990-4328-195e-08d9d43f4578
x-ms-traffictypediagnostic: DM8PR11MB5637:EE_
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <DM8PR11MB56370779A3C9A299CBEC29B3BD509@DM8PR11MB5637.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7219;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: KxilmCYJqRCHAwMkMk9CkgRFJ7Q4a5QS1Pr6U8lGtIg01CP3BVniu2RVALbg5MhWLMmkzPdSA/0ls8qvNOO+HPfSYwEXDiCj58K0oziB84SGqnFO8xCNZ9wU9RVjzbZOBxODNVqiMDIrQKUOHkqXoIdGBMR4pPVCFGMQYq4M9d0fej6OblVMbUtVtOxmd3Oslv43FzwY5lvsYfg+8TcvnWMbWurEAa5Paj0/9zjEIEOwLBlgE7dK4YBtotSiHN0ZKQmm4XEUF3hoR6CkBHn6hjs7VB2+z1TRG6zGiBVHupSGIuSDSbfECZaesXMEvl8vDS1GF8ITMoFC2OsjK4IbX0AIVUaQgxlziKJw6gf5AVeHciv/wh5rzwZcTjUGc6+owoy9oqLHm50Jhu3pXnmD/o+gT/rm1gCU4AqxN5eMA8JTkA60P69t4SPtX2lX2Z7UyJCiy9rBZO1EfSFFH+7f8WNEdwxGb1qLBS8hK14e3PGCadgzlpq7AIdkHJZrzA2kNRZmYYhDxwnlO0nrye74zQewfs1LLP+9GFgoSc3Bvqgmpk2iuNDKPPEwlLj+eRbCCk650mpO7ArwwAAfSNYNC9RtyX355PEr2RgAUvvkBEsrs9RvSlIYg3+zX6FVbjCGgcvvPG3J7anicd8Zi0eTnZqbROO3hkUzpFA5lJ0RS5uAcyatLRxf5+1u1VbwJZ4OGgqJfG6F+P35v58fZwiyGQ==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:DM8PR11MB5605.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFS:(366004)(71200400001)(38070700005)(54906003)(4326008)(122000001)(82960400001)(38100700002)(186003)(6862004)(8936002)(2906002)(6636002)(5660300002)(8676002)(316002)(9686003)(55016003)(7696005)(450100002)(66946007)(66556008)(76116006)(508600001)(52536014)(33656002)(66446008)(64756008)(66476007)(107886003)(86362001)(6506007)(26005);
DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NBTBYK4eMqYixygVGjvdfKRV5vLvAMXyiJjnqOA86e1flgMYeQyoFAhMpEoU?=
=?us-ascii?Q?1uFTB3o68ZBDYSkj89LVWCtPHJ2Hzl5/faDtahVOtU1kfO9kqj+M3McBx3SR?=
=?us-ascii?Q?PxqJOtFDkQfmxlshSkPRu0ny2wi6LkJ4o5uMTrwSngeJc+CdiJKr6d+qzTTN?=
=?us-ascii?Q?Dyvx9ZfCbSCeyAAUVsATsexRpYFoGCNaw1aTrvvlGMgpdSEatW95AKnoCNtD?=
=?us-ascii?Q?AjDd1bQQPLDnKTnQ/Fxd87pR/TDYuzFoTpQ5oIGLTHJyTr1rX8s2qczE4oTB?=
=?us-ascii?Q?ADdiKH1mng7WZmOgKZN0pqYV+0lXdsmo+sJRm6r9pPyN7RRJtaknTcGl5RcI?=
=?us-ascii?Q?cCLUrYiF7qvugpqOUsf86J4j5XvpLbj6blYEFkkv7Duk0xWdsl+/+UU8mcoC?=
=?us-ascii?Q?yE8hBCbfK0vjNYybXdpcPaIiHciCZkR52O1yOc4VIYeqMKQZAVXVMJ516+yR?=
=?us-ascii?Q?NxyOpvBnP/i+7cYX1p2eYbF1aPTxUjLHDEoa4n2a9n3fQ6zbuWbDSM3s1hAu?=
=?us-ascii?Q?F5QoBzEld0pK1q57kIWOPmhB/O+DeaWkWcQwEYV482gLU9eqeiZkQe7jvnjA?=
=?us-ascii?Q?7PBNiMtB8TVM5tXJ+Xt7LrWPHeYMWMx4V9WLIey7+BHMZJJfUQN0dBP7QLON?=
=?us-ascii?Q?ZeLQJ1d+joRau4bTBh3R3BVmWUdj18Ah7IV1jYXkDmuuntssYGj0kKvVb3l/?=
=?us-ascii?Q?6B11YciyRLY/m+x64LKvPjaIUWXCSRCsL4OVUP87ddEae5Q3/LudzTZOG1xQ?=
=?us-ascii?Q?BVogp8l0PrmkSzZ/JqWuh0aBxYmJgmEiy5njGYQDiT/y4tYKPAEqVaLwa9Pq?=
=?us-ascii?Q?fMYZlfujlVqSAZiDeZzC5fxbBDDTrVeepfq7UGCAQtX0F+Ph0vUBp5KxC0Q2?=
=?us-ascii?Q?P34CnBRIR+fzl0hX/Hgemuvq9hyIsRzAAP1Kbecu1MwfZhDYT+oKygGzyM70?=
=?us-ascii?Q?r7zbl961fOq9SpYFr5cLxN4HsA1LdbpjZNznHWidm/mDFU4cHlPPfrVZL73S?=
=?us-ascii?Q?Pr+xLGBQ22RgYn1RKsKK7MmBCqX9oeZsNtljjOnOxkirwM/UjFbt7ZymF+hQ?=
=?us-ascii?Q?2pkyMfoz+ePZFFYYDtn9lGuF6v4jyLlE6n7EZ8W3hRb0hoPrn6a5s8Y6r7Yq?=
=?us-ascii?Q?/bQ28sxqhdEaL4pz7FvvKCG71zeG2GzqLRk4KobdUmRbngfQnjLrAOgQLSy7?=
=?us-ascii?Q?MagJ+bYSY3LUm5zi6vTRu4E/RRj5TuSIly6KysiyLBhYaDTvo+AdrurIXjxy?=
=?us-ascii?Q?SMzIbnqwlcbM3Lsb1On1DI/DLR6UpYTabwHpmRTNbCPUPlW8f3Bykw2q98yR?=
=?us-ascii?Q?XOEfu/lBOYNLYqDc9aA8HgFQP5xoh/qRRnHMt8+x7MLh+tM+Gi1blUZqNjvf?=
=?us-ascii?Q?w/zAVmm4dTY16cWmipQNPn8CD2eZgeMg2B99bGyk9rGRLdgRYz+p10OAXapV?=
=?us-ascii?Q?dccoHqQRoa49ER248H9s9O+zBtxGancpqq5xZoQtISZR/4gEfhSqI/YsgY+Q?=
=?us-ascii?Q?dZfBeMN9fcsEXJ+Uzb34ufSsQ5yj3pl+8OwsLaBgVULXTxCP/5OeVQbF3Hsv?=
=?us-ascii?Q?2E5yeiB8+FpeR04e7EpKxIJGgSoFPY+egINDAyfz0xLPXs/OCxpjINCQB58G?=
=?us-ascii?Q?3Q=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5605.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 68968dce-0990-4328-195e-08d9d43f4578
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2022 13:44:06.2226 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5CI5OhcVIAi/A8MenMpsDZdDuAMU4iQNpvGnnWcV5SRmTkHjcMumzlRzZLjHJWIOKqnRaWUboMwa9ikxJwVaNA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5637
X-OriginatorOrg: intel.com
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Hi Bruce,
> what values for the write_idx and ids_returned vars give this error, and =
how
> does masking help? I'd expect masking to increase the number of times the
> function returns zero, rather than decreasing it.
Here are the values from the idxd dump:
dev_capa: 0x500000051 - mem2mem sva handles_errors copy fill
max_vchans_supported: 1
nb_vchans_configured: 1
silent_mode: off
IDXD Private Data =3D=3D
Portal: 0x7ffff7ffb000
Config: { ring_size: 4096 }
Batch ring (sz =3D 129, max_batches =3D 128):
62370 62402 62434 62466 62498 62530 62562 62594 62626 62658 62690=
62722 62754 62786 62818 62850 62882 62914 62946 62978 63010 630=
42 63074 6
3106 63138 63170 63202 63234 63266 63298 63330 63362 63394 63426 =
63458 63490 63522 63554 63586 63618 63650 63682 63714 63746 6377=
8 63810 63842 63874 63906 63938 63970 64002 64034 64066 64098 64=
13
0 64162 64194 64226 64258 64290 64322 64354 64386 64418 64450 64=
482 64514 64546 64578 64610 64642 64674 64706 64738 64770 64802 =
64834 64866 64898 64930 64962 64994 65026 65058 65090 65122 65154=
=20
65186 65218 65250 65282 65314 65346 65378 65410 65442 65474 65506=
[rd ptr] 2 [wr ptr] 61442 61474 61506 61538 61570 61602 61634 616=
66 61698 61730 61762 61794 61826 61858 61890 61922 61954 61986 6=
20
18 62050 62082 62114 62146 62178 62210 62242 62274 62306 62338
Curr batch: start =3D 2, size =3D 0
IDS: avail =3D 65506, returned: 65506
max packets per batch from hw: 1024
batches left: 127, ring space left: 4064
idxd->desc_ring_mask: 4095, used_space: 4128, used_space: 4128, idxd->max_b=
atch_size: 1024, idxd->batch_size: 0
write_idx: 4098, idxd->batch_idx_read: 98, idxd->batch_idx_write: 99, idxd-=
>desc_ring_mask - used_space: 65503
relevant data from above:
write_idx: 4098 , IDS returned: 65506, idxd->desc_ring_mask: 4095
without the fix :
used_space =3D write_idx - idxd->ids_returned; (4098 - 65506) =3D -61408
with fix:=20
used_space =3D (write_idx - idxd->ids_returned)& idxd->desc_ring_mask; (409=
8 - 65506)&4095 =3D 32=20
which seems to match the rd ptr and wr ptr.
Thanks and regards,
Sunil