From: "Pai G, Sunil" <sunil.pai.g@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Laatz, Kevin" <kevin.laatz@intel.com>
Subject: RE: [PATCH] dma/idxd: fix missing default for workqueue options
Date: Mon, 20 Jun 2022 04:09:33 +0000 [thread overview]
Message-ID: <DM8PR11MB560589D93714124A423B4842BDB09@DM8PR11MB5605.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220617111750.356481-1-bruce.richardson@intel.com>
> From: Richardson, Bruce <bruce.richardson@intel.com>
> Sent: Friday, June 17, 2022 4:48 PM
> To: dev@dpdk.org
> Cc: Laatz, Kevin <kevin.laatz@intel.com>; Pai G, Sunil
> <sunil.pai.g@intel.com>; Richardson, Bruce <bruce.richardson@intel.com>
> Subject: [PATCH] dma/idxd: fix missing default for workqueue options
>
> When no --wq-option flag is passed to dpdk_idxd_cfg.py script, the default
> value used by argparse is None. This leads to later errors which are
> expecting an array value:
>
> TypeError: 'NoneType' object is not iterable
>
> This is fixed by specifying that the empty array should be the default if
> no flags are passed.
>
> Fixes: 94b0f04dc0e3 ("dma/idxd: add generic option for queue config")
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
LGTM
Acked-by: Sunil Pai G <sunil.pai.g@intel.com>
next prev parent reply other threads:[~2022-06-20 4:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 11:17 Bruce Richardson
2022-06-20 4:09 ` Pai G, Sunil [this message]
2022-06-21 15:35 ` Thomas Monjalon
2022-06-20 9:21 ` Walsh, Conor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8PR11MB560589D93714124A423B4842BDB09@DM8PR11MB5605.namprd11.prod.outlook.com \
--to=sunil.pai.g@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=kevin.laatz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).