From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F3F7A0544; Mon, 20 Jun 2022 06:09:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 522F94067C; Mon, 20 Jun 2022 06:09:38 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id AD0F240150 for ; Mon, 20 Jun 2022 06:09:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655698176; x=1687234176; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=/2TNSW12M8METJcv4SOtmNSi772cPXvChC7+yQnw/X8=; b=RK0XS3xv1HpgWGuo25Pf3ytdbBDT/a4BCUrLYRSYCRJFdiQ2akSqjZfj heAKIOWttFEZMnVvBaLYEuyoYMyGMiOQxH3ak5ApYBCFHoPK4IoVDzYfh NWf6qodShBvqK0K9XOZZZZJhN4+iY1d4RN9hgDFABkUDWfHJW/wU/iaI0 cCl52GW5mNkUFBTkDXY8LJ0F10V7F1C3EMeAj/IY/6B+OfcdD6oUNmdlU K/av+XQehNFKpX2zMj4LIXXHRn/dL0Ag2D1rslRFnMfSSA7p33Zh4wZcK /nc0PwPVHpHgxlvjej8VI5b8UdoZAMl/MkC7Yk8yBdWValEuwkDOadwDz w==; X-IronPort-AV: E=McAfee;i="6400,9594,10380"; a="343788225" X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="343788225" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2022 21:09:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="619948999" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga001.jf.intel.com with ESMTP; 19 Jun 2022 21:09:35 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 19 Jun 2022 21:09:34 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Sun, 19 Jun 2022 21:09:34 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.103) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Sun, 19 Jun 2022 21:09:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GhHi7hi6XbrZ5+R58i6mltAZfnlQw5xJg4LCtoJ3eIjitpLoD6xAEsnqeWXq886H5luUryNdxu3zo5mprz8EEgO66SJwUjc/gglHA7cTXGSTX7Ze5rN8tJ7yTYIdQ1fhi1eNz4S369xBXwiSdzGL+wwfLEvJCFcn2Y8+j1RO6XPiAr/DTJs2bKZushXj4juytUQEcCpw/Q31lXXFn3zEUBaTF2QcFEfCsjetdbBsl+k+++N3lVTJBCDnZyKLNyBr6WuVwceJbvPArtLkDi20x3KLIVrMqkvtK+YCj9FVMP0i00DWoV8+W1Kg73r/anpyGIHVb1gAh80ivRqlbYXBjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XAAbkCfvfr8fuKbfD2watKyyQLoodxXZIvv9m6bzQj0=; b=XbzoSqyP6zfIQm6rcj/gLJpWlSTBs5uo4Cv8L/x8uX+AoHMxvx75Az6YRS3ZZc1DjLglumpnuFHQ+7Z8VqNpBylHD0Kybr5RhxXRIz5/I3ju6uYIKzAXnvmgyfaxzPqehpkxECLYp12/ofoWprcoI1ZXa4nrQ/ZxpRq/7fvvP0mCU5lEaDmLqiDHLzLJUTFJqZRHlNvHVdG/9+BDBx6B7R2eiEHhjVJlLoOoXZ+eenHZV2qe5MSuSiQ1MsrvNn4leNCQBes9fqw0Hl0X4e5vA/fDlaLqhMADUMkbZZs70/QoP3MOy3npbYoARLfF2QjZNsCSvmRP5H+DI28pzJhfbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5605.namprd11.prod.outlook.com (2603:10b6:8:26::11) by DM4PR11MB6550.namprd11.prod.outlook.com (2603:10b6:8:8f::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.15; Mon, 20 Jun 2022 04:09:33 +0000 Received: from DM8PR11MB5605.namprd11.prod.outlook.com ([fe80::c883:d026:bec2:e796]) by DM8PR11MB5605.namprd11.prod.outlook.com ([fe80::c883:d026:bec2:e796%9]) with mapi id 15.20.5353.021; Mon, 20 Jun 2022 04:09:33 +0000 From: "Pai G, Sunil" To: "Richardson, Bruce" , "dev@dpdk.org" CC: "Laatz, Kevin" Subject: RE: [PATCH] dma/idxd: fix missing default for workqueue options Thread-Topic: [PATCH] dma/idxd: fix missing default for workqueue options Thread-Index: AQHYgjvrNNKLrGI7wUC/hEz2nZxSi61Xsmtw Date: Mon, 20 Jun 2022 04:09:33 +0000 Message-ID: References: <20220617111750.356481-1-bruce.richardson@intel.com> In-Reply-To: <20220617111750.356481-1-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c31703dc-7bde-40a1-c078-08da5272ae83 x-ms-traffictypediagnostic: DM4PR11MB6550:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ebHEhvHGBv02mfH5npslrGDQ98pg9+uV7x1AN+wgefu20AijKR8AhHsS3lfSdwTL3WaA0TbIRU6cZffpFLjdgv12WOjJq/hw800qiXjqZvZqAeTXN7xtjeUHbW51/dYwvFVPkvX9rM9KUB16w7pDDMxA8lZcZLwSsHKTnLRsfH7tutobnjA0TZzGZpIa0H3+Z8f21/UncuqJlUyS8BGZBnjaFWwCdea66epb+977OtBSLJIxW7EWKbBcMCRfpJHktJPjMVVw3EZGeBL7ipxOT1uNdYPpn9l7abFCcstD+0sVmWrXzA5B31QSiaQ7onKYkHNNW6Og89nn8OVa49F/UViFfHeOj59aSMzpVleNZ7W+6va4s8JC6hL8dUfGZ+yaohAJ5XJwIivEN8ZtM19gZy4r0GKgi2F43gQt3gNvQCYxIcOY78FC7/KwtsUX3XRTBw/XzrXqNTHiyoCF7Ef4OCssHLp12qkpXfh/3FS1B3zu8ZFT0rdz1DyDm2K6Qy0QPcsfXK6k8b5NhjW89cKoLj/1NmAZnh3WW8ypNnGxPMcNjdNUpemH7gW7LBReEcCGfQSbeaBj+RzsSZI6r4s2Ik9HGbljMSuA6LjcRrHqX0MF0tu88DZlIBryq27dEO4Yed2HqJ2w+w9gsVma05kEAQnrlHTz4iu0XVuLzVVRnWta7RSHy5cjhAVn+NoajMkoOU//trgP71+nwUDkHQWwRg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5605.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(396003)(136003)(376002)(39860400002)(346002)(41300700001)(186003)(107886003)(64756008)(38100700002)(8936002)(26005)(122000001)(316002)(478600001)(2906002)(52536014)(4744005)(110136005)(9686003)(33656002)(86362001)(8676002)(53546011)(7696005)(66446008)(6506007)(66556008)(66476007)(55236004)(55016003)(38070700005)(5660300002)(82960400001)(4326008)(76116006)(66946007)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pN5tt5QEqtYtN4W0CZdHU20nWw/NhUdpaf6NmAy3SwuRba2c6Iie0ScGre32?= =?us-ascii?Q?oYrGdVnQt4wTEnikE8kqNxYDxjBkGdVytSau1h8d0HGXknN7LAnhy56NWPF3?= =?us-ascii?Q?3nW7hRztjJIvHdt+IC+B9LboTDhmr7/zgflVjs5jC4+1itO7gfj7uBMAwF2X?= =?us-ascii?Q?qXUi3V0gB9WVjJZ2UHydNHPAbXXw66bL1IKc5N7YCPW/EHlJ9DM8LGvBMJqY?= =?us-ascii?Q?PwHKnJqKq0B5KvuT9o2h70qa0atjPP8zQ95WCsEeNezmY3lWv+bPT2k8hJ1D?= =?us-ascii?Q?JR5SqsTmTDG2BFeryTR/20RWnAeeWmrweu3/uj1eRAeiyOQNtJpx90YGVOuP?= =?us-ascii?Q?t1lwtxtS7nJe2ServtyTrNb3tYhmtvfA3I/eiNGyEIK3oSyH3FPpSGzWI0dH?= =?us-ascii?Q?MTRLOlmJwytaMj2lD3vLpObMEOz78AUU449/SRbe9gSArlpibXP1oFSFVZzE?= =?us-ascii?Q?BH6VYHJ3LKlmqF+mNRfzvRIeqRmGafPCd7i0ItaUXxbi92Ho0VtStg9yFEh0?= =?us-ascii?Q?LD74o/dXJWL4j3stuPe2cE6oIW4V4r+LwbcON+GO3dHxe9fPSEwc3D6Rz+B3?= =?us-ascii?Q?0f09OPs8PQipo0SdV1AWFJdMG3lw1MOjZ+/NSMO6FHGb8KCN7yDIQP1p+2tK?= =?us-ascii?Q?AvtCb50sG4CvZ0OyLLb5miVeKXmFdVGibpUsHH6FBcz459ISHrbnysoXdw3c?= =?us-ascii?Q?BVVO+WbkPWObzrv2hE5Oq3Yb16bj7ZMGjzDQaqvi648pp1o7MCO3oE6gstJC?= =?us-ascii?Q?0S1OMVQFcQnEeZ6NsszxusoCC8E1at7pDdtJ1OL85ZAqHDnaEQ4ir5eTcR42?= =?us-ascii?Q?H+QSphC1TlcFMzjUAINGkYEa4O5qM8p0JujOhZDPXaSO/z5IRprRgkp7uCX0?= =?us-ascii?Q?JE0CaHbX6yDaS38uZeTEsuEcj8lmkvrWDtmS8aBO/e3z7fA6wwNFqgz13J8T?= =?us-ascii?Q?f0OnA/7l6/vJBavTTG9NJT5RnP84S7G4iNplmwFcveLNlwlIYWqDaEMpiM4r?= =?us-ascii?Q?Ol/eWd9VgVtSO+hx6SmfcbebAGcUsH5SENJorwNvm4gZtdEroT/5G+CfqCQq?= =?us-ascii?Q?BwIrO895OHVq3Hcez5Fpig8lu+uURZzzSguj3L8/TAEhsRv8leCkyHqWVJK0?= =?us-ascii?Q?M+y3EqYWwsVyIOQFOSugH2V/o5VTTAIlrljvhaYbv9YdAyHqoNkszGivqS22?= =?us-ascii?Q?SbBfMqpFsAbY/OPiFLSH6ahqF0PLkK3OM/s9KuPPxp+Im+jWBcILltXArJ0m?= =?us-ascii?Q?c58wr2t4McQk7WwsqgMcCZFZgAuMxdCNMIPMjtEqWRfTamhzd8e4/7Chhl/B?= =?us-ascii?Q?kQBPkN2eoxThcakysSVb7xk01PMWVMQfollf7grYIstEeE0QTA/0gKyAjyty?= =?us-ascii?Q?FkyQlYXJViZ+TllbTZgNitqNmRPtTc2gaH72VKdLVkCjnpfW/fLyr88aUhxL?= =?us-ascii?Q?YWsZ8x40CEbyhTsnY3DR6Cir39Mw4T5fz3n/uQ+O9bwOYT53Uo1LXF8k709O?= =?us-ascii?Q?6un+FiQ6I/tSRELVcQd6UBNMtr7lDZsgVUq+0qHMSl2ZdI+eUBbKDNH81waR?= =?us-ascii?Q?WofjipL8vpUTiV4P5BZYUVs4HF7M7lTzaAGALmruagIhnXblvlsEDs7iR0G2?= =?us-ascii?Q?CIwUeqyKO8f37c3hsXuiHxy1p4/y3kLFLjUe5eDFAGu8KpPBxg4zniTprkOT?= =?us-ascii?Q?RPMMjeBKNqD+nWUOdwevrvBRKEY1Z60oIM5Zm/BNVImPjb4LoRwsdkTpzQ/k?= =?us-ascii?Q?STB3W2gR0g=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5605.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c31703dc-7bde-40a1-c078-08da5272ae83 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jun 2022 04:09:33.3498 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iMkU7MEFncITR69I/eBkH3EpN0ZwSQ68DaPwVwEPpoTsArKl8PMgonQhvhF25nEzwXLKtyOBwXn8btDW/CD2yg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6550 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > From: Richardson, Bruce > Sent: Friday, June 17, 2022 4:48 PM > To: dev@dpdk.org > Cc: Laatz, Kevin ; Pai G, Sunil > ; Richardson, Bruce > Subject: [PATCH] dma/idxd: fix missing default for workqueue options >=20 > When no --wq-option flag is passed to dpdk_idxd_cfg.py script, the defaul= t > value used by argparse is None. This leads to later errors which are > expecting an array value: >=20 > TypeError: 'NoneType' object is not iterable >=20 > This is fixed by specifying that the empty array should be the default if > no flags are passed. >=20 > Fixes: 94b0f04dc0e3 ("dma/idxd: add generic option for queue config") >=20 > Signed-off-by: Bruce Richardson > --- LGTM Acked-by: Sunil Pai G