From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1DDD7A0C4D; Wed, 13 Oct 2021 10:16:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6D1E54118C; Wed, 13 Oct 2021 10:16:01 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id DA68041162 for ; Wed, 13 Oct 2021 10:15:57 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10135"; a="214321419" X-IronPort-AV: E=Sophos;i="5.85,370,1624345200"; d="scan'208";a="214321419" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2021 01:15:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,370,1624345200"; d="scan'208";a="626248693" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga001.fm.intel.com with ESMTP; 13 Oct 2021 01:15:56 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 13 Oct 2021 01:15:55 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 13 Oct 2021 01:15:55 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 13 Oct 2021 01:15:55 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.175) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 13 Oct 2021 01:15:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=afbSjX8Bsu3/ushmQ0+E5pOwV63SdKePb9Q92n9vS0hCagubemDSFEzK7H26ZN6oX1A1NEHODmutlBuh1FpquWCJNk91FEJg4G0zTL/+zUNTAAGBnBl6AWH+D6KWDSpiCyYu7fwqEoWjabpy2ZsxeDoFTj97vtL7esH9Ri83jQPt2gAIYH1fWBOb+XpUIVXpwDJP0rDWIG0MVdnYg85FQ8uSbe/ixQ6HoUxbiYxIQXMM/8K/IZaTtrILae63aGuZbWdDbMGmv8qs/Hz6m9oVDhedDhv9KESf6vOJOrkoWnk4NF7lIjUNCL1RssZX4c5Uncv0WjouTUiFek56f6ew8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ieonB7bO6N7lz2Pu0tIgYcxDkPK3BpmYcFtwDsKQT3s=; b=ZGY+wnVp8r2bYa2SZN3uwLHBg+VGVPtXbKOotm2Y8rEDIr+lYcTAozRWPzxOwFPRmmfkGKeyuv75wfFA24OiBaqejE2yCw2laT1lFYgMkOU1RqrUns5PcvU4Q+iQzOIXV3jXFyC6dvnDfuOSBkEdbg1YshJGE2Q3gJqsAHC2g7UaqiSIKo2zAIBn2yEC24qx69Agt+PzThUmYBI4jKdCwsWO0UlGVSU+3OA0MYKDuRbo0wWbEfhubmg1LcISVfqTij9aNi5ispOTTPSwSwaR3NLkB/629tzIaHE9IRISK0U+hqVIapNNq5hlYrwth+f5rKdxHVor1/9QrJjV2g5yfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ieonB7bO6N7lz2Pu0tIgYcxDkPK3BpmYcFtwDsKQT3s=; b=NPj/dFCMX0xJeT3xRe7ALt7rspR91QUlLzwdBYGc87j3qTzhCldclLbrzugYklg6iSGoZcy53A8uWEeRWdfFua+O/Q4eKNEA2S8xQfwYmfHf7OqwrodilL8hgDLV547BCNwLRX0JCMgbZz0aeSz4ed1KioNc6225a69wev1/t/Q= Received: from DM8PR11MB5639.namprd11.prod.outlook.com (2603:10b6:8:24::15) by DM4PR11MB5567.namprd11.prod.outlook.com (2603:10b6:5:39a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Wed, 13 Oct 2021 08:15:54 +0000 Received: from DM8PR11MB5639.namprd11.prod.outlook.com ([fe80::102c:6b2f:161b:479e]) by DM8PR11MB5639.namprd11.prod.outlook.com ([fe80::102c:6b2f:161b:479e%3]) with mapi id 15.20.4587.027; Wed, 13 Oct 2021 08:15:54 +0000 From: "Wang, Jie1X" To: Ori Kam , "dev@dpdk.org" CC: "Yigit, Ferruh" , NBU-Contact-Thomas Monjalon , "andrew.rybchenko@oktetlabs.ru" , "Li, Xiaoyun" , "Yang, SteveX" , "Wu, Jingjing" , "Xing, Beilei" , "Wu, Wenjun1" Thread-Topic: [dpdk-dev] [PATCH v2 2/3] app/testpmd: support PPPoL2TPv2oUDP RSS Hash Thread-Index: AQHXv1N+v/b3XTh2/UGc8uP60m4VXqvPfemAgAEWjbA= Date: Wed, 13 Oct 2021 08:15:53 +0000 Message-ID: References: <20210924151705.287571-1-jie1x.wang@intel.com> <20211012102508.275790-1-jie1x.wang@intel.com> <20211012102508.275790-3-jie1x.wang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.200.16 dlp-reaction: no-action authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 45d687d5-9cd5-4b2e-a4a2-08d98e21ad2b x-ms-traffictypediagnostic: DM4PR11MB5567: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: W02qGyXCOfqQVPGGRFy7XxH8TXLZVIKiNc1LP6eYwqcqA/dXilL+mR3Hm02ni3cA1pn058NZ1iShnHG/i2OZjj4HFu7bpuH59KyensIsBpUnrJ17Yjqh/hoWO1Sdl6Q3i0VXSCgaLavpI9Wk7fSAy0ng+klT6aQkb8ix2rHiOP2w3k5JjgCB+VGF1aqW+AyWOIqWqw4MfebuhGGp4QFSTVYwniwKxolQft+qABFnPBICLAPb/I+LhQKnAAXttVO409fNglGkHViz3GetPZXyWyoNJhDTratccQ25VaMa3hq6bryWM6P/W7v9VejrUnet/wXKLQ1+i8PCnQzt/nX9YDGZfqseoLxhyDRPnQFDFmDuDFmqL9LI5A08jLU49jmMNw1sxUOvtbC8DGx4FbU/zN0TzE0ixSogo3GI+JAClQHgaYNA89SQc27MgVSXHXsgrH6TPpiq0ep8kAbOoJR/oLDJVLA8ccD1eUmZVyYPT29K7RDElaTk8FHJpVGElHKKoz4HfcjnmIVgYUg94Jfcrd+sZzKn2vTdKQmoIaE5xdSv7jPP67NeV1nvCJQAa+o2NFY1QlqtJhhq/oKkHcIv2pU/+PxbOHjtnrpOyayA5OUQPPcZb0cSJA3DDNf8v3V0YfPrrEVJqe63RnLRTPPp7duYCzhdgoYyLBhVRZPS1fwsXMnxRdqlJcUU5iLIUoumAr+460K85GmHDICC9/tp2g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5639.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(66946007)(8676002)(38100700002)(82960400001)(316002)(26005)(122000001)(110136005)(6506007)(66446008)(64756008)(5660300002)(71200400001)(53546011)(54906003)(508600001)(66556008)(7696005)(66476007)(33656002)(52536014)(4326008)(76116006)(8936002)(38070700005)(9686003)(186003)(55016002)(86362001)(107886003)(2906002)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?plNnsDV/Vqy5lT6TVS9KFZ9RGa/BKpNv06cBT1kBtaL8xids+RROgCsjF/pE?= =?us-ascii?Q?arMObAy26+0Jzo7Tnd3XmlUTWjJaErKEwZbz0fyMqO9Wb+tJE9BupLtTbouy?= =?us-ascii?Q?OUjlwPuBN/9eW9dmXkI/1M1E8rDLLOAdS4HndJ8mmZkvTOpDVJlFuqdfDP6t?= =?us-ascii?Q?ge1jqOHLOWqZcNondJ0Aq32cqtv5W5hH7ugyomAHx627HfMnARhO5P9kuTNn?= =?us-ascii?Q?X13MNRCky2gjpsvqGrvkKnabfheQddi0bPGCKIrTQcuswiJiv7rRbClvs/Nj?= =?us-ascii?Q?291eR/wyktEgk0lIyqueJ5KY+1dod+usobxxpY0fwdWas9KcENFXbiZnZ+mS?= =?us-ascii?Q?gHrwDy7mI2hLER6tPa55rZXjVXmBBWyGVbeqa+yNfxrahorVE07bNQoVJF4c?= =?us-ascii?Q?KAFiB2hizy3duC1HR7T5NFIVpL6ABXYvTd1tzh9PxX3qseH3qKSlOoY79nKx?= =?us-ascii?Q?lqzdtNoM81rzZjWGDSwu2H3c3POxWTw6YBZvuxEpnZ1NkQc+zzOLO03t1VgJ?= =?us-ascii?Q?e5xp1gHFR4UA/sNEv0PqjiIN39UjOVK7i2f/GHaS2tz49LU+YjF8cw/BklYl?= =?us-ascii?Q?kMiKbj/JOHPYAlT0JH/SxFErzzlDo+hpRUZ90yDxj82J8CKnFPpznynJVDWq?= =?us-ascii?Q?UKuVpTLOX2gCIo79JbxYejElTHV6aF7K1+RdLQglGkQL7QcylQ7PunX4Q5CO?= =?us-ascii?Q?6e56pHjlc/cpZZ86EwFy3yXtpC62GsY8JNqiI0GLmKcwd14L/Lakl9LEFj84?= =?us-ascii?Q?nDe2NGqNcQ3qQW4ICK6exbapbeRMdq/YDDXmz97eDxu7pBmsHxhsLCOiSUAY?= =?us-ascii?Q?K1IJ6+YfbMXs4ZOqNl5evF0Pj+vrFJ35IQMyCr/j2L0Isa1TiNm+1WodifFF?= =?us-ascii?Q?mdZP3x50TjcZmBnAMcw+S0pRhFBYN89TCnVuMwbnRrrwMik3MfoFThYfu/Ux?= =?us-ascii?Q?GNFUbkCWzexLLMI1hfcnPWSOTyB0/bVhf6Dp8Zmlzlu/B4oE2x8pDYEudoEh?= =?us-ascii?Q?5Iq+7UXEmM7ICfXV+UvUsKtYQAiHRvk/5T0JSZ2iTiTAoRVNYX+RwPAus3kz?= =?us-ascii?Q?znlrTtRnI/X7/iul5IqXV9Fjsu62pQ+t0LD00NfjIsN1MD1/vsgyjm4b9H1F?= =?us-ascii?Q?O0lhJdehXWoLnpVilZaRMcSHuncmScNYF0FomE4MnElq46g2MaR16N/c5Qf0?= =?us-ascii?Q?JlKqgk7vhbYvnBiiErUAqBfUgtfTMOoDXIWzpLtY8knNlirgBZqyUwulxxcP?= =?us-ascii?Q?p01Jsc+pqoY/dxOhnnkXkkaPHukPUjH6JMIDc/dhN5H3Y/Z2P2Ie187vLGCz?= =?us-ascii?Q?Sks=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5639.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 45d687d5-9cd5-4b2e-a4a2-08d98e21ad2b X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2021 08:15:53.9650 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XW/r4smNFyOpRatEAJuPICf9W4s+X2p8+FzTOatiSlpHr/ji00ZpCLHUfjJlK677Mr0h3F8FHQgjxvdOjH8DJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5567 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 2/3] app/testpmd: support PPPoL2TPv2oUDP RSS Hash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Ori Kam > Sent: Tuesday, October 12, 2021 11:32 PM > To: Wang, Jie1X ; dev@dpdk.org > Cc: Yigit, Ferruh ; NBU-Contact-Thomas Monjalon > ; andrew.rybchenko@oktetlabs.ru; Li, Xiaoyun > ; Yang, SteveX ; Wu, Jingjin= g > ; Xing, Beilei ; Wu, Wenjun= 1 > > Subject: RE: [dpdk-dev] [PATCH v2 2/3] app/testpmd: support PPPoL2TPv2oUD= P > RSS Hash >=20 > Hi Jie, >=20 > > -----Original Message----- > > From: dev On Behalf Of Jie Wang > > Sent: Tuesday, October 12, 2021 1:25 PM > > Subject: [dpdk-dev] [PATCH v2 2/3] app/testpmd: support PPPoL2TPv2oUDP > > RSS Hash > > > > Add support for test-pmd to parse protocol pattern L2TPv2 and PPP. > > > > Signed-off-by: Wenjun Wu > > Signed-off-by: Jie Wang > > --- > > app/test-pmd/cmdline_flow.c | 34 ++++++++++++++++++++++++++++++++++ > > 1 file changed, 34 insertions(+) > > > > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > > index > > bb22294dd3..3c9bcabd97 100644 > > --- a/app/test-pmd/cmdline_flow.c > > +++ b/app/test-pmd/cmdline_flow.c > > @@ -299,6 +299,8 @@ enum index { > > ITEM_GENEVE_OPT_TYPE, > > ITEM_GENEVE_OPT_LENGTH, > > ITEM_GENEVE_OPT_DATA, > > + ITEM_PPP, > > + ITEM_L2TPV2, > > ITEM_INTEGRITY, > > ITEM_INTEGRITY_LEVEL, > > ITEM_INTEGRITY_VALUE, > > @@ -997,6 +999,8 @@ static const enum index next_item[] =3D { > > ITEM_AH, > > ITEM_PFCP, > > ITEM_ECPRI, > > + ITEM_PPP, > > + ITEM_L2TPV2, >=20 > Why in the middle? >=20 Ok, I will update it. > > ITEM_GENEVE_OPT, > > ITEM_INTEGRITY, > > ITEM_CONNTRACK, > > @@ -1368,6 +1372,16 @@ static const enum index item_integrity_lv[] =3D = { > > ZERO, > > }; > > > > +static const enum index item_ppp[] =3D { > > + ITEM_NEXT, > > + ZERO, > > +}; > > + > > +static const enum index item_l2tpv2[] =3D { > > + ITEM_NEXT, > > + ZERO, > > +}; > > + > > static const enum index next_action[] =3D { > > ACTION_END, > > ACTION_VOID, > > @@ -3579,6 +3593,20 @@ static const struct token token_list[] =3D { > > (sizeof(struct rte_flow_item_geneve_opt), > > ITEM_GENEVE_OPT_DATA_SIZE)), > > }, > > + [ITEM_PPP] =3D { > > + .name =3D "ppp", > > + .help =3D "match ppp header", > > + .priv =3D PRIV_ITEM(PPP, sizeof(struct rte_flow_item_ppp)), > > + .next =3D NEXT(item_ppp), > > + .call =3D parse_vc, > > + }, > > + [ITEM_L2TPV2] =3D { > > + .name =3D "l2tpv2", > > + .help =3D "match l2tpv2 header", > > + .priv =3D PRIV_ITEM(L2TPV2, sizeof(struct rte_flow_item_l2tpv2)), > > + .next =3D NEXT(item_l2tpv2), > > + .call =3D parse_vc, > > + }, > > [ITEM_INTEGRITY] =3D { > > .name =3D "integrity", > > .help =3D "match packet integrity", > > @@ -8343,6 +8371,12 @@ flow_item_default_mask(const struct > rte_flow_item *item) > > case RTE_FLOW_ITEM_TYPE_PFCP: > > mask =3D &rte_flow_item_pfcp_mask; > > break; > > + case RTE_FLOW_ITEM_TYPE_L2TPV2: > > + mask =3D &rte_flow_item_l2tpv2_mask; > > + break; > > + case RTE_FLOW_ITEM_TYPE_PPP: > > + mask =3D &rte_flow_item_ppp_mask; > > + break; > > default: > > break; > > } > > -- > > 2.25.1 >=20 > Maybe I'm missing something but I don't see that you added the ability to= match > on any of the header fields value. > You also didn't update the code of encap (from my understanding this is a= tunnel > header) >=20 > Best, > Ori Hi Ori, This feature is only support for iavf enable PPPoL2TPv2oUDP rss. So it does= n't need to add the ability to match on any of the header fields value and = the code of encap. I'm not sure if it is necessary to add these.