RE: [PATCH v4 6/6] net/iavf: support L2TPv2 for AVF FDIR

["Wang, Jie1X" <jie1x.wang@intel.com>]

> -----Original Message-----
> From: Xing, Beilei <beilei.xing@intel.com>
> Sent: Wednesday, February 9, 2022 3:31 PM
> To: Wang, Jie1X <jie1x.wang@intel.com>; dev@dpdk.org
> Cc: Yang, SteveX <stevex.yang@intel.com>; orika@nvidia.com; Singh, Aman
> Deep <aman.deep.singh@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>;
> thomas@monjalon.net; andrew.rybchenko@oktetlabs.ru; Wu, Jingjing
> <jingjing.wu@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> olivier.matz@6wind.com
> Subject: RE: [PATCH v4 6/6] net/iavf: support L2TPv2 for AVF FDIR
> 
> 
> 
> > -----Original Message-----
> > From: Wang, Jie1X <jie1x.wang@intel.com>
> > Sent: Tuesday, February 8, 2022 4:39 PM
> > To: dev@dpdk.org
> > Cc: Yang, SteveX <stevex.yang@intel.com>; orika@nvidia.com; Singh,
> > Aman Deep <aman.deep.singh@intel.com>; Yigit, Ferruh
> > <ferruh.yigit@intel.com>; thomas@monjalon.net;
> > andrew.rybchenko@oktetlabs.ru; Wu, Jingjing <jingjing.wu@intel.com>;
> > Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z
> > <qi.z.zhang@intel.com>; olivier.matz@6wind.com; Wang, Jie1X
> > <jie1x.wang@intel.com>
> > Subject: [PATCH v4 6/6] net/iavf: support L2TPv2 for AVF FDIR
> >
> > Add support for L2TPv2(include PPP over L2TPv2) protocols FDIR based
> > on outer MAC src address and L2TPv2 session ID.
> >
> > Add support for PPPoL2TPv2oUDP protocols FDIR based on inner IP
> > src/dst address and UDP/TCP src/dst port.
> >
> > Patterns are listed below:
> > eth/ipv4(6)/udp/l2tpv2
> > eth/ipv4(6)/udp/l2tpv2/ppp
> >
> > eth/ipv4(6)/udp/l2tpv2/ppp/ipv4(6)
> > eth/ipv4(6)/udp/l2tpv2/ppp/ipv4(6)/udp
> > eth/ipv4(6)/udp/l2tpv2/ppp/ipv4(6)/tcp
> >
> > Signed-off-by: Jie Wang <jie1x.wang@intel.com>
> > ---
> >  doc/guides/rel_notes/release_22_03.rst |   8 +-
> >  drivers/net/iavf/iavf_fdir.c           | 174 +++++++++++++++++++++----
> >  drivers/net/iavf/iavf_generic_flow.h   |   4 +
> >  3 files changed, 156 insertions(+), 30 deletions(-)
> >
> > diff --git a/doc/guides/rel_notes/release_22_03.rst
> > b/doc/guides/rel_notes/release_22_03.rst
> > index 0d1e4a0b61..5a73ccc14e 100644
> > --- a/doc/guides/rel_notes/release_22_03.rst
> > +++ b/doc/guides/rel_notes/release_22_03.rst
> > @@ -66,8 +66,12 @@ New Features
> >
> >  * **Updated Intel iavf driver.**
> >
> > -  Added L2TPv2(include PPP over L2TPv2) RSS hash distribute packets
> > -  based on outer MAC src address and L2TPv2 session ID.
> > +  * Added L2TPv2(include PPP over L2TPv2) RSS hash distribute packets
> > +    based on outer MAC src address and L2TPv2 session ID.
> 
> Should fix in the patch 5/6.
> 
> > +  * Added L2TPv2(include PPP over L2TPv2) FDIR distribute packets
> > +    based on outer MAC src address and L2TPv2 session ID.
> > +  * Added PPPoL2TPv2oUDP FDIR distribute packets based on inner IP
> > +    src/dst address and UDP/TCP src/dst port.
> >
> >
> >  Removed Items
> > diff --git a/drivers/net/iavf/iavf_fdir.c
> > b/drivers/net/iavf/iavf_fdir.c index b63aaca91d..2583b899aa 100644
> > --- a/drivers/net/iavf/iavf_fdir.c
> > +++ b/drivers/net/iavf/iavf_fdir.c
> > @@ -168,6 +168,31 @@
> >  	IAVF_FDIR_INSET_GRE_IPV6 | IAVF_INSET_TUN_UDP_SRC_PORT | \
> >  	IAVF_INSET_TUN_UDP_DST_PORT)
> >
> > +#define IAVF_FDIR_INSET_L2TPV2 (\
> > +	IAVF_INSET_SMAC | IAVF_INSET_L2TPV2)
> 
> The same comment for FDIR: should we limit with source MAC?
> 

It is same as the RSS hash input set.

> > +
> > +#define IAVF_FDIR_INSET_L2TPV2_PPP_IPV4 (\
> > +	IAVF_INSET_TUN_IPV4_SRC | IAVF_INSET_TUN_IPV4_DST)
> > +
> 
> <...>
> 
> BR,
> Beilei