From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70959A04A8; Tue, 25 Jan 2022 02:54:44 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E78C142803; Tue, 25 Jan 2022 02:54:43 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 3393441186 for ; Tue, 25 Jan 2022 02:54:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643075682; x=1674611682; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=+YMTovzq6Sz0o+D/IrkSV6PCiBgy0KR429omKO+2g1o=; b=IZRif2O9EQkqwgFOb5eI2xfN2fuPOKFpWvTXCUUTxU7PSwmBrGeF/2ls E+6E9qxVA62zE9q3rjPlJHwC/4IrUMDLJieFT4AXfsL8Mzbt7s1hiUm2k wo2GB9XQQTzG5oCFSUhnPshwhxmScph5Q4ilztotSiYJEbSNGzWPp2uLz kOJV+EWtbzpNYMBO9IMWuxQ1pi5x7KGrdDP2q2x4XS1j14ZhPGBKNC/5T MH1VVeWXDbVqT+YgtqQs5ybGic63mjk9XjiqkonBgGlsrC60V6oSxqKvV IrN3PjXR+3I+X6gKIBwR4K7AhUr1TmFepvAkgGPeYGG2faE9bNgsUdtgI Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10237"; a="309514889" X-IronPort-AV: E=Sophos;i="5.88,313,1635231600"; d="scan'208";a="309514889" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2022 17:54:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,313,1635231600"; d="scan'208";a="617454724" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by FMSMGA003.fm.intel.com with ESMTP; 24 Jan 2022 17:54:40 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 24 Jan 2022 17:54:39 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 24 Jan 2022 17:54:39 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 24 Jan 2022 17:54:39 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.41) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 24 Jan 2022 17:54:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gLbKVXtecfKpXrLQbvut2woCAc+pogT0WrsvBBWwgQCNddrwGaqYJHe82DPpFKL/3dxT1XFLhjjubAAVlHUv/PvxchTCuyfCVVDetPNmnblXONyjReWkWEVzjexUMnWE2uWD53g27DCPDckx9e8KxbhYF4HyoEVZyUpJUS+N1SaDYfVAfH/ALCB4htpIbCnp3yfkVfn9DVLLmV2Qn7MaO1HmX2+cuyI9Pq1DBgUvSkRgC0RxHchpqIKYkrxirNUHR2RiJ9To5bylCWIomkz5amczju/MnR6ZUx7rbSuWtoqRzpEYHMF2I/9gER4GsyWzsXYkaevauRIzy9bnPhC5nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TboCWb85jMhH59zmm9pMIAcWHAmrModcxwla0YIdJvA=; b=ejoJ28ItKbbfUOFBhpOtDU3Pl2eonpwGFYMLj24ZBAs+TB5+gUDdAu6W3A7SpEBChbI1exXbd8kbChKp8eImMgrcC4unM0S4fknltmVsCopbYSJC0e0JvU3IID90d17Iq2daaLsNs9WIjCggWjQmJP9POUVsjaRl0RPUXhtfYzItDJLpevJeSx1CgIObyW4xEXQQL+NfDvAF+NIZVsABincUs9eHOKS2LspEqddUuy+SQ21JXHt884HLpVifFHr0fU051MCdlb0KzUm0EchF7i/W2GTNttWVE/kO5P6SvwXwl3oWdIO88eiVdev+2c+3HuaNMTxRJJuoLy/x/LxXTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DM8PR11MB5639.namprd11.prod.outlook.com (2603:10b6:8:24::15) by SA2PR11MB5066.namprd11.prod.outlook.com (2603:10b6:806:110::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.8; Tue, 25 Jan 2022 01:54:36 +0000 Received: from DM8PR11MB5639.namprd11.prod.outlook.com ([fe80::51b8:4654:6393:61c8]) by DM8PR11MB5639.namprd11.prod.outlook.com ([fe80::51b8:4654:6393:61c8%9]) with mapi id 15.20.4909.017; Tue, 25 Jan 2022 01:54:36 +0000 From: "Wang, Jie1X" To: Ori Kam , "dev@dpdk.org" CC: "Yang, SteveX" , "Singh, Aman Deep" , "Yigit, Ferruh" , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , "andrew.rybchenko@oktetlabs.ru" , "Wu, Jingjing" , "Xing, Beilei" , "Zhang, Qi Z" Subject: RE: [PATCH 1/6] ethdev: add L2TPv2 RSS offload type Thread-Topic: [PATCH 1/6] ethdev: add L2TPv2 RSS offload type Thread-Index: AQHYEO+a31zSHXZXqkWu9E1G8II+s6xyXtSAgACaeCA= Date: Tue, 25 Jan 2022 01:54:36 +0000 Message-ID: References: <20220124065613.2197436-1-jie1x.wang@intel.com> <20220124065613.2197436-2-jie1x.wang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.200.16 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c671ad14-1f15-41f6-8508-08d9dfa5a449 x-ms-traffictypediagnostic: SA2PR11MB5066:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2582; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4ZIH7yiMErPrg3W5KSnb4W5FBzyMVpmAtBQN26FUu67e/prJiMqMD9ZG0GGv8f48XJv0pHsaZTSAw336dj1dkMm34kRQnhaSpYo+PyJg86Snr1SrWBIzlJyJTbhUPjjj8tgr9D7fBY+9AwpOimJ5Km2hn09Y8ckM8U/Vdg4vBwH6IgdM2a0iPmSZ8mVZmquEpiLHxUcI8c4raTLAOlIsiVBKAbdAtvpUuuCXezAPvR7XdgNR+6LJiA7tYHv2j7BGc8e7c2xlbGm3mZSWQeC9OmcAseefjM6dzCMU/ko4lQxvsnY6zixnLMA04AU4cNk/+vOQPW3gfgNzjVF90/SjW3h821MolPGo2pbLa+dCnqX2u+sIiZB1Eh1IruFpTburLozAPBV6dGoCazzVGoD1BOpPywk+cOPFXKHJFmz2IrA4P7wFweW9ykVc8fg9Y5QfCfTr0ZMmh5jRgwDyJWLd1iw0HbRnaC6tfI02/oCH9517E2BwdhLyxD22kq8Z9vcV9nHamzTPuxDCj9i4NtzVokdacnbv0EjKXPPQOaG87MAJsRqREZgZFMq8Rmavg4uyNq2sbqvXFk9VWAW1JNWPow9nakCvgkFsCk06mhKTLeXP1Z2XZeYLX8BcauAcJUzjyXa9xRjRgmHZsJUc6qQyAo+VHg87IYOayRHACYO9ueiIJ05aEVQ3hCffaaHwFMsC+SOzX6wIyc1r5n6p9s8dEw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5639.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(186003)(508600001)(54906003)(66446008)(2906002)(4326008)(316002)(26005)(66476007)(53546011)(6506007)(38070700005)(107886003)(55016003)(8676002)(76116006)(66946007)(122000001)(33656002)(38100700002)(9686003)(8936002)(86362001)(71200400001)(83380400001)(64756008)(52536014)(110136005)(5660300002)(7696005)(66556008)(82960400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yoxLpytZYDUMg5xXNYCGSFEU8Q+IwtKDB5TgjU7GQO+TvzvP+ABADWav0ABv?= =?us-ascii?Q?o9Wa1vuxOEI/BLxIzLjDX1UJJ60Lf4jc29zbR/o/5f8kdt0hl4SSl4sPVqux?= =?us-ascii?Q?WUqkSJWxM838BktRRHt1gWDTgvha+cS8nbRTTOKp7RMuJn1SAGGJhiTzxebD?= =?us-ascii?Q?RvE0cN81gxh/h4k8WxpnoRlBC7WnUngBF5gDoU7tUPGdXbwXhDHYAwGKHpx3?= =?us-ascii?Q?LuNnsL5UlTolCrVF8V4uGjM+rXetL/6m/KIosf/jhyOLdgRwsKMGDbCyY6z5?= =?us-ascii?Q?GALVzemNo1dVnzvMJ1GkC/zY4iix5aX7jCqhEX1fJ/p+4daBP/YaEWns0Lqi?= =?us-ascii?Q?ivZ4NB9BFycVEH+QIJnUDw1zy+I3ia55Fh8AvOM5x0GKGPprLt1njLllvT/L?= =?us-ascii?Q?jzGJawE6auWiWXL9NqWhCcSlopFwkG3jM+3S+sUJRW5IpyHSACO/xalJKn3D?= =?us-ascii?Q?kY1OuNNWkA2RnonmC3DNwHtZaLwl5yCn22E04cIbmE2OYFm70JYaoqlkxVan?= =?us-ascii?Q?1RUdetOiGv/pHbH0Ukgvad7HDGJv9UYhL1So4e0xJWDDbdbdDBR47Nc+oBqn?= =?us-ascii?Q?23fcR9i+hyLEc9HK1wIjZV12uqpL35nGDX9KH20rIFNtMGqyl86CTlyDRoKa?= =?us-ascii?Q?4mG+7oiZ3g+NZpOixH05smly2kJW0ZlYM3rbwfBm09/OU52GpH08rfzJnHVp?= =?us-ascii?Q?VhfnF5f8mhPuTiEdLJpVKlCHJCDVUUB7aYj5M6afc2iox+Oz+3j7Lhe79jih?= =?us-ascii?Q?NjPtqf4pOTvcgerTstdP8sg4CxRrzpSMMW1Sn4Nuj9+ttcs4btiARv/jJGIj?= =?us-ascii?Q?sc27xHyjlu6kGomnNd2zC0L459fg4j1M4cymbKGDH08NlCwWl6gyFq3iKapx?= =?us-ascii?Q?AMKG41KeLYqOp8M00A/4e4f4WQHoFPdgfR0bv6FHUxUpjk12/HigWx6hYHZr?= =?us-ascii?Q?826G04r2MEv1cWm9nrlT5vXYfYWjDhW2xb4LvPoa+SR2Jzt8WaFScva3unWU?= =?us-ascii?Q?idzYdVWVXlH/E4hg0/HaJEGKMw8sj/d6iOFyv6ozMq2uONBDwo/VqmEzrxPw?= =?us-ascii?Q?JoFtWThphYGSEThZ25HTq8LIKf4leBo6s7yXBTlAt8MmpF1lDTEec5VPNZqD?= =?us-ascii?Q?dp+gyVpZsxvVK/ZsDiF5MIDl3S9kDnEJX0mMH+/dmOQ3gfkQwuc9Par7qu7+?= =?us-ascii?Q?epu2j/CNMHIPB9rFTOSfyLtRJGpzRt230Duaz7qP4hgnsBSMrY5HCDSgJ1Ut?= =?us-ascii?Q?W3iC65eaQ1zVPPq1V4IZSWv6z8up2aoCvMrbTgPzJiOQCAw32MyCViwBgYgF?= =?us-ascii?Q?qTZbeArt5eJlcKVb0pk59cATa5lxdOiROvUTQkO817pB9mfnU2X3k5xHg2pT?= =?us-ascii?Q?leo2zLfSGJ8gnENHwOTJOoAlyzi7RQTxGMYxQ1borTQwj52dJiuGpu2AlROe?= =?us-ascii?Q?83CPru0r5jxfIFyZcmFw/FOn5wztambQ9CKOuNpu6lpCmp2dAyfe7ImGCcEF?= =?us-ascii?Q?fl8R/YLS7wrCnRW9pBxv3FxaQoonYKsmugknwusbjFj8jkTV9hFFp1fkUk+6?= =?us-ascii?Q?IaxPrjzeYX88QclN/3NEGX5gpNCYemWHh9X7n89H1Xiq6iQtaJ6I38IIj3uo?= =?us-ascii?Q?djcAQqX99f5sWq/wDjTcP4I=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5639.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c671ad14-1f15-41f6-8508-08d9dfa5a449 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2022 01:54:36.6796 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3bMMZsY6gKefOPSSuIHMGm2YfFJDjbkw19LFZsbjBuN56/O3ZaMzZHPy0d9fF5xl2f8PJhP4aXAE0d/1tbZz+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5066 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Ori, > -----Original Message----- > From: Ori Kam > Sent: Tuesday, January 25, 2022 12:35 AM > To: Wang, Jie1X ; dev@dpdk.org > Cc: Yang, SteveX ; Singh, Aman Deep > ; Yigit, Ferruh ; NBU- > Contact-Thomas Monjalon (EXTERNAL) ; > andrew.rybchenko@oktetlabs.ru; Wu, Jingjing ; Xing= , > Beilei ; Zhang, Qi Z > Subject: RE: [PATCH 1/6] ethdev: add L2TPv2 RSS offload type >=20 > Hi Jie >=20 > > -----Original Message----- > > From: Jie Wang > > Sent: Monday, January 24, 2022 8:56 AM > > Subject: [PATCH 1/6] ethdev: add L2TPv2 RSS offload type > > > > This patch defines new RSS offload type for L2TPv2, which are required > > when users want to distribute packets based on the L2TPv2 field. > > > > Signed-off-by: Jie Wang > > --- > > app/test-pmd/cmdline.c | 10 ++++++---- > > app/test-pmd/config.c | 3 ++- > > doc/guides/rel_notes/release_22_03.rst | 5 +++++ > > lib/ethdev/rte_ethdev.h | 3 +++ > > 4 files changed, 16 insertions(+), 5 deletions(-) > > > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > > 6e10afeedd..3914fb9a75 100644 > > --- a/app/test-pmd/cmdline.c > > +++ b/app/test-pmd/cmdline.c > > @@ -2178,7 +2178,7 @@ cmd_config_rss_parsed(void *parsed_result, > > RTE_ETH_RSS_TCP | RTE_ETH_RSS_UDP | > RTE_ETH_RSS_SCTP | > > RTE_ETH_RSS_L2_PAYLOAD | RTE_ETH_RSS_L2TPV3 | > RTE_ETH_RSS_ESP | > > RTE_ETH_RSS_AH | RTE_ETH_RSS_PFCP | > RTE_ETH_RSS_GTPU | > > - RTE_ETH_RSS_ECPRI; > > + RTE_ETH_RSS_ECPRI | RTE_ETH_RSS_L2TPV2; > > else if (!strcmp(res->value, "eth")) > > rss_conf.rss_hf =3D RTE_ETH_RSS_ETH; > > else if (!strcmp(res->value, "vlan")) @@ -2256,6 +2256,8 @@ > > cmd_config_rss_parsed(void *parsed_result, > > rss_conf.rss_hf =3D (rss_hf | RTE_ETH_RSS_LEVEL_INNERMOST); > > } else if (!strcmp(res->value, "default")) > > use_default =3D 1; > > + else if (!strcmp(res->value, "l2tpv2")) > > + rss_conf.rss_hf =3D RTE_ETH_RSS_L2TPV2; > > else if (isdigit(res->value[0]) && atoi(res->value) > 0 && > > atoi(res->value) < 64) > > rss_conf.rss_hf =3D 1ULL << atoi(res->value); @@ -2314,7 > +2316,7 @@ > > cmdline_parse_inst_t cmd_config_rss =3D { > > .help_str =3D "port config all rss " > > > "all|default|eth|vlan|ip|tcp|udp|sctp|ether|port|vxlan|geneve|" > > "nvgre|vxlan-gpe|l2tpv3|esp|ah|pfcp|ecpri|mpls|none|level- > default|" > > - "level-outer|level-inner|ipv4-chksum|", > > + "level-outer|level-inner|ipv4-chksum|l2tpv2|", > > .tokens =3D { > > (void *)&cmd_config_rss_port, > > (void *)&cmd_config_rss_keyword, > > @@ -2429,7 +2431,7 @@ cmdline_parse_token_string_t > cmd_config_rss_hash_key_rss_type =3D > > "ipv6-tcp-ex#ipv6-udp-ex#" > > "l3-src-only#l3-dst-only#l4-src-only#l4-dst- > only#" > > "l2-src-only#l2-dst-only#s-vlan#c-vlan#" > > - > "l2tpv3#esp#ah#pfcp#pppoe#gtpu#ecpri#mpls"); > > + > "l2tpv3#esp#ah#pfcp#pppoe#gtpu#ecpri#mpls#l2tpv2"); > > cmdline_parse_token_string_t cmd_config_rss_hash_key_value =3D > > TOKEN_STRING_INITIALIZER(struct cmd_config_rss_hash_key, key, > NULL); > > > > @@ -2442,7 +2444,7 @@ cmdline_parse_inst_t cmd_config_rss_hash_key =3D = { > > "l2-payload|ipv6-ex|ipv6-tcp-ex|ipv6-udp-ex|" > > "l3-src-only|l3-dst-only|l4-src-only|l4-dst-only|" > > "l2-src-only|l2-dst-only|s-vlan|c-vlan|" > > - "l2tpv3|esp|ah|pfcp|pppoe|gtpu|ecpri|mpls " > > + "l2tpv3|esp|ah|pfcp|pppoe|gtpu|ecpri|mpls|l2tpv2 " > > "", > > .tokens =3D { > > (void *)&cmd_config_rss_hash_key_port, diff --git > > a/app/test-pmd/config.c b/app/test-pmd/config.c index > > 1722d6c8f8..ec922bd304 100644 > > --- a/app/test-pmd/config.c > > +++ b/app/test-pmd/config.c > > @@ -90,7 +90,7 @@ const struct rss_type_info rss_type_table[] =3D { > > { "all", RTE_ETH_RSS_ETH | RTE_ETH_RSS_VLAN | RTE_ETH_RSS_IP | > RTE_ETH_RSS_TCP | > > RTE_ETH_RSS_UDP | RTE_ETH_RSS_SCTP | > RTE_ETH_RSS_L2_PAYLOAD | > > RTE_ETH_RSS_L2TPV3 | RTE_ETH_RSS_ESP | RTE_ETH_RSS_AH > | > > RTE_ETH_RSS_PFCP > > | > > - RTE_ETH_RSS_GTPU | RTE_ETH_RSS_ECPRI | > RTE_ETH_RSS_MPLS}, > > + RTE_ETH_RSS_GTPU | RTE_ETH_RSS_ECPRI | > RTE_ETH_RSS_MPLS | > > RTE_ETH_RSS_L2TPV2}, > > { "none", 0 }, > > { "eth", RTE_ETH_RSS_ETH }, > > { "l2-src-only", RTE_ETH_RSS_L2_SRC_ONLY }, @@ -143,6 +143,7 @@ > > const struct rss_type_info rss_type_table[] =3D { > > { "mpls", RTE_ETH_RSS_MPLS }, > > { "ipv4-chksum", RTE_ETH_RSS_IPV4_CHKSUM }, > > { "l4-chksum", RTE_ETH_RSS_L4_CHKSUM }, > > + { "l2tpv2", RTE_ETH_RSS_L2TPV2 }, > > { NULL, 0 }, > > }; > > > > diff --git a/doc/guides/rel_notes/release_22_03.rst > > b/doc/guides/rel_notes/release_22_03.rst > > index 6d99d1eaa9..30695f11b7 100644 > > --- a/doc/guides/rel_notes/release_22_03.rst > > +++ b/doc/guides/rel_notes/release_22_03.rst > > @@ -55,6 +55,11 @@ New Features > > Also, make sure to start the actual text at the margin. > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D > > > > +* **Added new RSS offload types for L2TPv2 in RSS flow.** > > + > > + Added macros RTE_ETH_RSS_L2TPV2, now L2TPv2 field can be used as > > + input set for RSS. > > + >=20 > Which fields exactly? I assume it is tunnel id but can it be something el= se? >=20 It's session ID, I'll update it in v2. > > > > Removed Items > > ------------- > > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h index > > fa299c8ad7..43f582c90c 100644 > > --- a/lib/ethdev/rte_ethdev.h > > +++ b/lib/ethdev/rte_ethdev.h > > @@ -645,6 +645,9 @@ struct rte_eth_rss_conf { > > #define RTE_ETH_RSS_L4_CHKSUM RTE_BIT64(35) > > #define ETH_RSS_L4_CHKSUM RTE_ETH_RSS_L4_CHKSUM > > > > +#define RTE_ETH_RSS_L2TPV2 RTE_BIT64(36) > > +#define ETH_RSS_L2TPV2 RTE_ETH_RSS_L2TPV2 > > + >=20 > I know it was not done until now, but I think it is important to explain = exactly on > what fields this hash is being done. >=20 Yes, I'll add some comments to explain it in v2. >=20 > > /* > > * We use the following macros to combine with above RTE_ETH_RSS_* for > > * more specific input set selection. These bits are defined starting > > -- > > 2.25.1 >=20 > Best, > Ori