From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5AA9A0C41; Thu, 4 Nov 2021 15:24:37 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 97FBF42766; Thu, 4 Nov 2021 15:24:37 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 564FD4276E for ; Thu, 4 Nov 2021 15:24:34 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10157"; a="231961487" X-IronPort-AV: E=Sophos;i="5.87,209,1631602800"; d="scan'208";a="231961487" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2021 07:24:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,209,1631602800"; d="scan'208";a="730074158" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga005.fm.intel.com with ESMTP; 04 Nov 2021 07:24:29 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 4 Nov 2021 07:24:28 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 4 Nov 2021 07:24:28 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 4 Nov 2021 07:24:28 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 4 Nov 2021 07:24:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BZFtjNtGG660UVvvWAN36xcyw76+D+XG+VvtJJAS9GbuQ+bSTx2DieMutfC12SdPzHwgzNFAZla0rls2nY8h524ceNuDuHVsCj71TXk4HpjcJGL2EWH6rE6QE77sLeUS8CXLCBlMjaXfPtVJrjetZP2Chzu3EPSZUxbtO60Y/BXrlx79NGb5vdsDMoPEkJUPMzPaKfrhlYr8i32fWZdp3hjaV8S3DCWLIedrHGQlRbqplYsgMKJK75NF+NZgWdAKotjW1hgcLkKEumOGFYzpazx8OsnKZeTjNm6shrHBwHuyiw2JDv7WVM93+NsnA9x/MXNWcR3kSjWU4KkDkcFE+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E3WNeC++WaacU0vfChPEy5R0XomkH9HQJ4ivqzS0krY=; b=E6xHshPx2CSE7aOxMCbrd5oQM4FiPn0srNnns2n4m6q7D8OMWaWLQHaJKUmBsh/c7c1RZYim7bimCqqk+3gRlc8Qx2D0lZCHnz2jCGL6mItikIblOuuzzZ3ePjEB9c5tF8Hg0xOpFt/AlWs+jQQr+nmYB2iuExBdePdDbCIa3TrZCpGIUkRKtQwizAsRGNXGzos/3qQQNySFAL0Sv7uW8TkNZOaTf97uVK5yIL7DH7xlGpd9t2C3qjZLVM4iHRC6yF4OMFtPY1FIgbjEwLNOoF+gTRdhubO68TGlnnLSmDx5g5paLpY4azo864KQEMdET4CqeNm36/amd/QJdEh5ww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E3WNeC++WaacU0vfChPEy5R0XomkH9HQJ4ivqzS0krY=; b=xcPa8fWKdlX29xwtQ7SKvpR04NILjKw8Sr+ZzHU5yRLqaZx71Ezr9oVPHIkwCwFOp8J9Mi5qm5iGvVzCBEnjIlFqCWsRmYAmrYTXTetvrjCie7VerUHMwnka+kVXHWq8IMySMY5YiDf7DwCS72iqUgJgT7mALUBxBGvtvbsX2jM= Received: from DM8PR11MB5670.namprd11.prod.outlook.com (2603:10b6:8:37::12) by DM4PR11MB5565.namprd11.prod.outlook.com (2603:10b6:5:39a::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10; Thu, 4 Nov 2021 14:24:27 +0000 Received: from DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::c0f1:1135:ceb5:ac10]) by DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::c0f1:1135:ceb5:ac10%9]) with mapi id 15.20.4649.019; Thu, 4 Nov 2021 14:24:27 +0000 From: "Dumitrescu, Cristian" To: Thomas Monjalon , "Singh, Jasvinder" , "Liguzinski, WojciechX" CC: "dev@dpdk.org" , "Ajmera, Megha" , "Liguzinski, WojciechX" Thread-Topic: [dpdk-dev] [PATCH v23 1/3] sched: add PIE based congestion management Thread-Index: AQHX0WuzMh+s7majcEy+C9QokMlOsKvzZT2AgAAHGgA= Date: Thu, 4 Nov 2021 14:24:27 +0000 Message-ID: References: <20211104104918.490051-1-wojciechx.liguzinski@intel.com> <20211104110335.491723-1-wojciechx.liguzinski@intel.com> <20211104110335.491723-2-wojciechx.liguzinski@intel.com> <3424746.7aQOyVHj5L@thomas> In-Reply-To: <3424746.7aQOyVHj5L@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 272a0058-a64f-4f35-ae11-08d99f9ecef7 x-ms-traffictypediagnostic: DM4PR11MB5565: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ONPD5Yayq2DhvSUb/x9FKuOLTmgAcwXLZbb0ta0oIar66KGOu4H6UoFurBC19StwlRN1ofra3scRS3C9pL3+C9qYPGyflOX8S2Ml/aAiZ09uBMFxUXoFblxp//Xbg2Mbpc4gs1f7Mn4pddgooolmjoPBLI/QBk8SPNFLeM8gN+I8CucLdOlFb6LNDQjARvYG9yXMla0PW6E1Ago/GyhTbpzPDR2jQ/BOUwz/BWoLuVbWAe5WTHlBOtMRrgJdno7kLpfOF1QfhYYlGyjx8kwZn6pU6Ohu6UhALqZf9gvndeEIlR4FIAebkeJbXi86REnoxYN+Jz3yw+9fntYWO0gRUcWshKSSwXmMVY0ZZ73JrRCaj54Bv4bIXcm13Weo6og0cHVdQBptEuC8SFKoCqb0vuc0+mU03sMfym3LJAUF2KIjjqs3VEgX04Aulx18SJApDGECA73g2z9vdrkQxBregqam3Ku0j/ZDgljLw/x5VeabPmdx6ezbz1zEnc07TK3KyasqcDJnboN5ghp6Du0nN2TKz7hyD7BPh4IB92VjxqFuUroqDLSk0Oakd4p8RcCIjmcJtdRnzqO6T46HJAry86VZPuu8C1R5Y83QGsFNIl7pHBJIl22yC6sXrifUg9OYDqOI6rN0mC/JRGyE7X/3dXK5oyG8iuqlYT89ISlquboBsKkRNSxIdm2LdLGiyxACJHRpx50eN6hkNLu72hp6hQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5670.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(316002)(26005)(9686003)(83380400001)(6506007)(52536014)(186003)(5660300002)(53546011)(8936002)(71200400001)(2906002)(76116006)(7696005)(508600001)(38070700005)(82960400001)(66476007)(8676002)(66946007)(4326008)(66446008)(107886003)(66556008)(86362001)(64756008)(55016002)(110136005)(6636002)(122000001)(54906003)(38100700002)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?weaMjlEMsKiuFHG/jRQUrSaZ3kg6M8kppIlUyenhJizzjF/XwEKp6ASLcP2p?= =?us-ascii?Q?IxlcdKFefqH13KeURJmoMzEA4Pu+O+UNTYMPGrSE2g441iS+W9N5mlBl94Zw?= =?us-ascii?Q?G4N+TZc8SylbbQ5omM8fv9/n14ARP2mT7LkUdo8OrcnhmJ5+WOonX3fatBZb?= =?us-ascii?Q?D3mRZZcHWqSkVv0JKSrF7/IbzHizzB+S77CXCx3fqHMfpN1r27uY9Vxg5yR9?= =?us-ascii?Q?bssH1forb4jDYTUt3ndHH7eYEdOmjqWfZ9EsfxuVyWv3J+svxmQQZNGHmTtN?= =?us-ascii?Q?3P2W08j6RyvrDLNa0LngnAMiNOIvvycZpjS5EYPP00uQAMTEMZPJq5zpNr4i?= =?us-ascii?Q?jv9FxbbgKEEodtMb4u43L2ISzjkvm60FNzQny5cHagTctZkqgDt1PYQr9LZ7?= =?us-ascii?Q?Flu+aH8qaOZNPYgGSb86fJRq+JvzUs2jo6ix/SbEJUOBFAmGcgSSzQm/Cd5m?= =?us-ascii?Q?qyihxdiJXx2bjlD9Dae6+g0T8IIVVYkxDjO6DSbCFUrzQ8RSNM6FTmAQbyOB?= =?us-ascii?Q?V7tE5zTQhQBTShVQzBEVMcRH080TtoNtH2wG7qjEydldubR8Vxbc/QpdYUD7?= =?us-ascii?Q?DmInqSgVTWv+svviQgMvegqFH9imTvdVMxBS88hePpdQaw4jZLp1RZDILzZ9?= =?us-ascii?Q?c68H6ynkg98gQMlXWsZX2zOG/HsRqwOQkLJijYb3+khSdTg9sF6USLkiXdZt?= =?us-ascii?Q?fFNpmcIJhlc3cIqIfV2GCyiKZtvmzYCbAUdFHxlr/BXX9wA/+t8f1YCmIrF4?= =?us-ascii?Q?V0Y5phwFJKQxhavG7jEbzjpf7N7MAMD0d2+r3CpAxCmOv54fZ7ZPY7jP/5Nr?= =?us-ascii?Q?tyPfvzW7mY+Lb8fnFEi8atVPVix4FBLolMZGiLcj31siKU3DE1TSVB52jLQl?= =?us-ascii?Q?23ghxKrm92gJdvZFIg10gtaR6Gq9NiAGOeMkv2y0nBFPf2pqSig4niqN0SCx?= =?us-ascii?Q?4NAdMGX5Wr09XRurOjZThJhsOpybqZaT+Sf9qBOm4/rffEvYlM0fAxLWfUlC?= =?us-ascii?Q?8jgkPW12ydpwaNJJXz6H+cfm4BQN5eY5chYR46RxkpXC+yp2vbuqVU9btddu?= =?us-ascii?Q?RQBrcQhF4RPJ9Cotw5D0tTqnjtrrfoJFF3gIIVzWDz4dGzlpb/BgWYtlvT9P?= =?us-ascii?Q?b4Ee4PRNWnbGO07oIdRpHb5e3Xh3ncIlqH1uvcgRNfShSEnl7ydMKxKRFgQf?= =?us-ascii?Q?TD4RqtuuDCT4Bjl1L40qRgD590RVDATL+ZRrotMF+Z+HgqvMsmhqA1RNSIj2?= =?us-ascii?Q?nC8f2Hp0NA5V3Wm9T6OWwOt43BaqU6IDOpKswTBmvgyrXZrxRzTHEhovrWRE?= =?us-ascii?Q?s7LU7dJcMZWfmJGosAqu4A2R94BGYjuin+j9UHAdcLW7JR8Y2u6hUB1CKF0I?= =?us-ascii?Q?WkYIV04NDqGpLoHx9L6qHm8uZXZ5e8znAmkU4IlpFG89sSnRkmXj/NKRnax5?= =?us-ascii?Q?n34WZHDtcylfXqmQKEpJ5FDvOkRhipIlUQfIZ8MqoT2cWdPmmSNaSwHF05ud?= =?us-ascii?Q?bFfEzNlfYNSupcpRgRXMIq0e9iuD6NNOIw/aO8OiNT2uhreBwibcucydmvCJ?= =?us-ascii?Q?jgUBq7y7sSur8ILGLeU+JsmFuEZIiDTjEzu2oDAPF6GQCnVLHk0pQ4O1cEYZ?= =?us-ascii?Q?alnhnSOhY8BWxMf1HUB8JN1RhUa9e7dH3DxL4J6CvxJkDdv+tjVJRJzhniH6?= =?us-ascii?Q?gP2n6Q=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5670.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 272a0058-a64f-4f35-ae11-08d99f9ecef7 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Nov 2021 14:24:27.4349 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 653iknhD3AvycIgzYTxZMGIlh1knzrVSYlJc7KrlpbsIpUg03hxyfwMNShEjDpkFY1+/clDoFRdwsBYUKx3F2LBGGem0Rr2e2T2R5iSJviI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5565 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v23 1/3] sched: add PIE based congestion management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Thursday, November 4, 2021 1:58 PM > To: Singh, Jasvinder ; Dumitrescu, Cristian > ; Liguzinski, WojciechX > > Cc: dev@dpdk.org; Ajmera, Megha ; Liguzinski, > WojciechX > Subject: Re: [dpdk-dev] [PATCH v23 1/3] sched: add PIE based congestion > management >=20 > 04/11/2021 12:03, Liguzinski, WojciechX: > > From: Wojciech Liguzinski > > > > Implement PIE based congestion management based on rfc8033. > > > > The Proportional Integral Controller Enhanced (PIE) algorithm works > > by proactively dropping packets randomly. > > PIE is implemented as more advanced queue management is required to > > address the bufferbloat problem and provide desirable quality of > > service to users. > > > > Tests for PIE code added to test application. > > Added PIE related information to documentation. > > > > Signed-off-by: Wojciech Liguzinski > > Acked-by: Cristian Dumitrescu > > Acked-by: Jasvinder Singh > > > > -- >=20 > It should be 3 dashes to make the below hidden in git. >=20 > > Changes in V23: > > - Coding style fixed > > > > Changes in V22: > > - Coding style fixed > > > > Changes in V21: > > - Coding style fixed > > - Patches reorganized according to comments > > > > Changes in V20: > > - Removed API conditional compilation > > - Added flag to indicate cman enabled/disabled > > - Fixed submitter data in patches > > > > Changes in V19: > > - ACKs included in patches > > > > Changes in V18: > > - Resolved merge conflict in lib/sched/meson.build after rebasing ontop= of > main > > - Reverted whitespace change in app_thread.c - comment from Stephen > Hemminger > > > > Changes in V17: > > - Corrected paragraph link naming in qos_framework.rst to fix CI builds > > > > Changes in V16: > > - Fixed 'title underline too short' error in qos_framework.rst > > - Applied __rte_unused macro to parameters in > rte_sched_port_pie_dequeue() > > > > --- > > app/test/meson.build | 4 + > > app/test/test_pie.c | 1065 ++++++++++++++++++ > > doc/guides/prog_guide/glossary.rst | 3 + > > doc/guides/prog_guide/qos_framework.rst | 64 +- > > doc/guides/prog_guide/traffic_management.rst | 13 +- > > drivers/net/softnic/rte_eth_softnic_tm.c | 6 +- > > lib/sched/meson.build | 3 +- > > lib/sched/rte_pie.c | 86 ++ > > lib/sched/rte_pie.h | 398 +++++++ > > lib/sched/rte_sched.c | 254 +++-- > > lib/sched/rte_sched.h | 64 +- > > lib/sched/version.map | 4 + > > 12 files changed, 1860 insertions(+), 104 deletions(-) > > create mode 100644 app/test/test_pie.c > > create mode 100644 lib/sched/rte_pie.c > > create mode 100644 lib/sched/rte_pie.h >=20 > Adding this change to include the new test in sched library maintainershi= p: >=20 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1428,6 +1428,7 @@ M: Cristian Dumitrescu > > M: Jasvinder Singh > F: lib/sched/ > F: doc/guides/prog_guide/qos_framework.rst > +F: app/test/test_pie.c > F: app/test/test_red.c > F: app/test/test_sched.c > F: examples/qos_sched/ >=20 > Cristian, Jasvinder, I didn't see a lot of comments from you on this patc= h, > so I assume you are OK with this change. >=20 Hi Thomas, Yes, I am. Regards, Cristian