From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC921A0547; Fri, 29 Oct 2021 16:07:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9FA4D411E6; Fri, 29 Oct 2021 16:07:29 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 4EB71410E1 for ; Fri, 29 Oct 2021 16:07:28 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10151"; a="230529661" X-IronPort-AV: E=Sophos;i="5.87,193,1631602800"; d="scan'208";a="230529661" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Oct 2021 07:07:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,193,1631602800"; d="scan'208";a="448376642" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga003.jf.intel.com with ESMTP; 29 Oct 2021 07:07:00 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 29 Oct 2021 07:06:59 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 29 Oct 2021 07:06:59 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 29 Oct 2021 07:06:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ym57g9JfbEQ1dWhmqoWGb0AjEc4x3VN24q4qyVasvNYxn5QOlCAZbg2DfNcXs41AD2ksHdQBCYNL3/ZHi9KpiUJ0GiQEbuaHFZtiMY5x2v+OZL1cNjfBhXvOVvS49LiqlA4abYEl6rYrkqyWOqhpA7hS6tZPoxGr8BfuVaraVljP4k0e0V0snQg6U4COBKxpJ00wjtLqxq2oewlv9hBGuEVvuHvHoQ6yjT6J+urfzLS4BqOwaiFdKzQH2RAepMVzoJ82J74N30xkBv56rytZfHrwmH1KCg3Z1ReIVmANIavs2TuhvOHXWRG17Wo+wN6GY45YCq1ILV7ihHn2PylosQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=03LOmKfO7RfReBh7neCzz04rGbrhWozs6q+YlEjHpyE=; b=WytRJuBgpvlJ+PshOc2h1hIQBhZYZ2nZ9YjXIENgUVIEIcB8WVbeW26dqbmdwIgWX2oEdgfm0QTcpG4iOiiGgQkaGvJnOKsu0YPYja1OjjnGrbk7xqeGY+wmAWmdeWwyOi5tgCvagTgHQvHC7XWlEoupj7lkBXvxVmFOg0hiJVk6BSR5SVcgwciNO3MGbQvW2ZzWdB3Z/22c6fpZwsxNXve0GfXKhKtlgg8iq7sAuIsWWSbcL6GQhI01qNivezbspuPAYrKdejKbixzavb/G32lOCJRdEefQd4on95OYz98kiKjPgK/wLucP64VELjJnagATFf8vArB3kLmJzOuRyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=03LOmKfO7RfReBh7neCzz04rGbrhWozs6q+YlEjHpyE=; b=oo5XDyu5u5iQzE6u84yIw+iN5Scc2Ax4FCqEn8zVuZiXOJJRpAicI/HyOESv8EvoKKAbHCCJlm0+kVQwYTSoonXxMPFBsSQhfOwC4e+hb+iGqbWY19hnAcdW9Y1nnKaVPYHZE5B90+sOi0xEqJPZP5rGyoHx6jwKfDaOoOEyQRE= Received: from DM8PR11MB5670.namprd11.prod.outlook.com (2603:10b6:8:37::12) by DM4PR11MB5566.namprd11.prod.outlook.com (2603:10b6:5:39c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Fri, 29 Oct 2021 14:06:58 +0000 Received: from DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::c0f1:1135:ceb5:ac10]) by DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::c0f1:1135:ceb5:ac10%9]) with mapi id 15.20.4649.015; Fri, 29 Oct 2021 14:06:58 +0000 From: "Dumitrescu, Cristian" To: Thomas Monjalon CC: "dev@dpdk.org" , "Singh, Jasvinder" , "Ajmera, Megha" , "Liguzinski, WojciechX" , "david.marchand@redhat.com" , "Mcnamara, John" Thread-Topic: [dpdk-dev] [PATCH v19 1/5] sched: add PIE based congestion management Thread-Index: AQHXy+Ukl73Yw60iw0uYKPLiJeQVGqvqAimAgAACMqA= Date: Fri, 29 Oct 2021 14:06:58 +0000 Message-ID: References: <20211025113208.3910951-1-wojciechx.liguzinski@intel.com> <20211028101802.4127295-1-wojciechx.liguzinski@intel.com> <20211028101802.4127295-2-wojciechx.liguzinski@intel.com> <1856407.E66k3sLkBB@thomas> In-Reply-To: <1856407.E66k3sLkBB@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: caefbecc-b435-4945-0e4d-08d99ae55f11 x-ms-traffictypediagnostic: DM4PR11MB5566: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vZ+bBzGP2586Vk9bBhD1zcxIDou39RC+qsv1AdP/HVciJ+LweIZYvKNQGiqt22stgUMs9QpdEesymI3y0S9TqPR1h8XLz5HWFgYXWBRIifvI59mBxctutPTStH83Pa7QKYfh4tuwTnYkhxRuPOZb/lkl2lnh4NvBT9aOAwO0Wo8wwRY9fJLH1BZWTfG8XKvai6bNFrj+wmUoBQUG2wO8Sh2Upr6SBLlHakg8ybF7ApoCJI2rsOhTHCEMgbI+XrdG1bLzOVXB4cJlEidduS/xZiHlMIvD+fJrl4EezmPnfp4idmCbL1gcBuETkNYqmgzn4pZIt+h2YIhuaHcxyoDNTJVVNDKGjJ3F+Nj5FRiHEh/6EeyWLXvhSF9L9aON+W9fycBXMA3vkgxwex45fYrSHeTgxhFwpDEHGXdPOI39CVNiidye1ucB/++jIsXgQ61VsWnB2SebLFo/dlkt3mo5t3OpuDbIVGg7rBFeW0x9TdxODvIjsyS5+6bnTaMLqUZjVd9lh9VXcZgTucZ9WJF91isdBRv/vHqc3JeVs4oX1WcZTxDJhS3yzr/V4sl/czmRz/q3GGpTnINrxngPPJQLFrGVSnTfD26/iN60vziawkUPv8UkkpnNJNF1S+VD0usmYW6CWW4shhk80v7yhtC2Zqthsrg70P04Xe5s+9LEQgs14hXsOy9vmCKjLrd1U4aPw4hzuCWqponK2fhPynl5WQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5670.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(86362001)(55016002)(186003)(5660300002)(71200400001)(66946007)(9686003)(54906003)(7696005)(82960400001)(107886003)(316002)(4744005)(508600001)(4326008)(38070700005)(26005)(66556008)(6916009)(38100700002)(8936002)(6506007)(8676002)(33656002)(53546011)(83380400001)(66446008)(52536014)(2906002)(64756008)(122000001)(76116006)(66476007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?G68PBxwZiJ24NG3Ws8S4iXI1AiPQ54aXaQUNv7oL34vYhHQyILTdhPXKNKhW?= =?us-ascii?Q?+apRR2GWsgGZ7R1CGBg597mgC98uP6+H0Gfej/8pUHCTU+ErmCfOeXc92OpA?= =?us-ascii?Q?DR58LweFl1dejP4YlvgdT04X9aV6ho0K8Gqd+7Ui4o8XGduskl8lrtSvSpwy?= =?us-ascii?Q?pBbYLvXVh8KboKPUcFLcaWpP6vwnOKUBQJ4xdTUS+j/h35BIgWoHLe0G22KE?= =?us-ascii?Q?c2h9dcEbWPEpHmOE47IqaAiaigJFMEOo1biu6hsINCIzDsVI3EBA9T4EgvdE?= =?us-ascii?Q?tDolWmEieruFAGilK1a1mLm8UmNUhmw+830d63c1n4QV1usCGPSPnjW+9rsz?= =?us-ascii?Q?Z3uwhNxHNU3335jLEd53UAIYTLbEIBkczCMcc85a6ZtEmGcdpiMQ/hPV6uF7?= =?us-ascii?Q?H6tH3IZ5L22oK9hcBzXugSIsHBzZmtY8lVKhkWsrITGIBbSTDAnV+74QHQkn?= =?us-ascii?Q?t1E+5AXEj7YJbOLMReRrdOXzBA/UQEM60ZteA8XVOMFiUKhLdhrVl++JjaHb?= =?us-ascii?Q?2nQSiEd+5fw8y/CnJGMP8zVzDpeMCK3L7OOjMA24CXGdR2SdgGYDk4SjbqKZ?= =?us-ascii?Q?FE7eW92NV0bDylQMV7rL2agN9qhJsIMMaUVwXoZaUk3Zj9HPUCOEln7lKy4U?= =?us-ascii?Q?eTajR6RHnq57lowJpvkKiv+RSHTrQF6+5TFMB7cBdg0+FUWdYZFYo+DeTEIh?= =?us-ascii?Q?pmzcP7NMDNO8IQcTJtn9AI3Q8vnonUpCx16arPtFjRlVGTe+UuywEzwZSOT9?= =?us-ascii?Q?p6sdzodQKaXP0VXYp4RAvI+8kdcjDWtNfiz65JNkXpor7GtNq6nNXv0SmMHm?= =?us-ascii?Q?KEpxCNjkMJRYdvcZ4KYB8+wyN6Opoj+L+fYQwwCZx4CW9XZ9b6+2KZkS/SNY?= =?us-ascii?Q?KHCtrYrySa7K8ph/PztlhcsFy5CjMQg+RXKBpW8cIUyjFzcmbnGcTpvBEdLz?= =?us-ascii?Q?qRlnDHG4aR/OKd+B0nGvbYO90ggDHjiI6XcdyED5ylvfgg0Wps5AUYokQGKI?= =?us-ascii?Q?tl6hpENdeR43HAr2TH4NNx6zUYjMB9THivSc3KuCdsBFB+lA04EZa86tik+H?= =?us-ascii?Q?JnPXolC44tHCj/+YpgyasDzB3ES3JH7PQ2mVZxZUR0YQ5Mpsb4E7WV4Lq9cI?= =?us-ascii?Q?bmiVKteiLJL26pHfGZRae+HqNg2fOI6TYG94G6P6biY57szVhLWmbVuzfNEQ?= =?us-ascii?Q?3ZuLH/hygACu8T0ZxgAN2G3QL4SaBnYAZUJVgMMYffM3Ty6hfATgz/nPnxck?= =?us-ascii?Q?T2NfdPPLu+QOB21jfJLUDyhvuoSEMy1gCxzgdxvWqymnjgWSu1/5nSAfUknH?= =?us-ascii?Q?oskwPRWoVJvjgI6+40Po+O1JQGAYKogg7K2nCvsWjfdEf+20W85Nb9O9FRnS?= =?us-ascii?Q?EbpP9GfVDQJsLv5/dn+bRgTTd3XIA0vXFu1CiHWayVTCruESEUFfFkZm7UEJ?= =?us-ascii?Q?KgofoNbr5QkhPD+TD7tiQKYRgEEVrKyiX8iihSo7HiqAFVdej8ysu9a/HfCM?= =?us-ascii?Q?xIrz/s+2SOxwQ+Kio17v3OejtrGraGsySn9x27/lBO8dtFtxTq2I5/7BFiSX?= =?us-ascii?Q?bKjiCu4BwtyqEieuMaMLApcvo533HUw53ih1FT30N1XuDeTntPSAhOSGfouA?= =?us-ascii?Q?TCRsYJoPmU1WOpC4G2BuJZohsd4ao0mYXWyrZeMxybSHa7/ZF8+ePzSVVw5I?= =?us-ascii?Q?Rq0uRA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5670.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: caefbecc-b435-4945-0e4d-08d99ae55f11 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2021 14:06:58.1463 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: b7TSqUS2rH80TF3RCZ8VdXlINClKbScWPFp9+9YsXN/ko+WcgicZgmeFvT0MHx+exzhcs+7yzxBLV6t8J/GkEdtjjIA3AfjIBXqv1DjRFM4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5566 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v19 1/5] sched: add PIE based congestion management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Friday, October 29, 2021 2:58 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; Singh, Jasvinder ; Ajmera, > Megha ; Liguzinski, WojciechX > ; david.marchand@redhat.com; Mcnamara, > John > Subject: Re: [dpdk-dev] [PATCH v19 1/5] sched: add PIE based congestion > management >=20 > 28/10/2021 12:17, Liguzinski, WojciechX: > > Implement PIE based congestion management based on rfc8033 >=20 > An explanation is missing about why RED code is removed. > I don't know whether it deserves a separate commit, > but at least it should be removed consisently in lib and example code > in the same patch. >=20 > Cristian, please make efforts to help this patchset be properly organized= . > A blind ack is not enough. >=20 The RED code is not removed. It is simply the macro renamed to CMAN (Conges= tion Management) to include both RED and PIE.