DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: "Ajmera, Megha" <megha.ajmera@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Singh, Jasvinder" <jasvinder.singh@intel.com>,
	"thomas@monjalon.net" <thomas@monjalon.net>,
	"david.marchand@redhat.com" <david.marchand@redhat.com>
Subject: RE: [PATCH v2 0/4] sched: HQoS Library cleanup
Date: Fri, 18 Feb 2022 10:58:22 +0000	[thread overview]
Message-ID: <DM8PR11MB56701E1F1C1CC515EF0AB887EB379@DM8PR11MB5670.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220218093650.2549927-1-megha.ajmera@intel.com>



> -----Original Message-----
> From: Ajmera, Megha <megha.ajmera@intel.com>
> Sent: Friday, February 18, 2022 9:37 AM
> To: dev@dpdk.org; Singh, Jasvinder <jasvinder.singh@intel.com>;
> Dumitrescu, Cristian <cristian.dumitrescu@intel.com>;
> thomas@monjalon.net; david.marchand@redhat.com
> Subject: [PATCH v2 0/4] sched: HQoS Library cleanup
> 
> v2:
> * Rebased with latest main branch code resolved conflicts.
> 
> v1:
> This patchset involves the cleanup of HQoS Library:
> 
> * Removed unused HQoS #defines from rte_config.
>   RTE_SCHED_CMAN, RTE_SCHED_COLLECT_STATS,
> RTE_SCHED_SUBPORT_TC_OV, RTE_SCHED_VECTOR
> 
> * RTE_SCHED_COLLECT_STATS flag is removed from the code.
>   Stats collection is now always enabled.
> 
> * RTE_SCHED_SUBPORT_TC_OV flag is removed.
>   TC subscription for best effort queues is always enabled in HQoS library.
> 
> * RTE_SCHED_VECTOR flag is removed from HQoS library as the code under
> this
>   flag is no longer useful.
> 
> 
> Megha Ajmera (4):
>   sched: Cleanup qos scheduler defines from rte_config
>   sched: Always enable stats in HQoS library.
>   sched: Always enable best effort TC oversubscription in HQoS library.
>   sched: Removed code defined under VECTOR Defines.
> 
>  config/rte_config.h                        |   8 +-
>  doc/guides/sample_app_ug/qos_scheduler.rst |   3 +-
>  lib/sched/rte_sched.c                      | 156 +--------------------
>  3 files changed, 5 insertions(+), 162 deletions(-)
> 
> --
> 2.25.1

Do people feel the need to have a cover letter for this patchset? IMO it does not add any useful info, so my vote is to discard the cover letter.

  parent reply	other threads:[~2022-02-18 10:58 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-18  9:36 Megha Ajmera
2022-02-18  9:36 ` [PATCH v2 1/4] sched: Cleanup qos scheduler defines from rte_config Megha Ajmera
2022-02-18 10:52   ` Thomas Monjalon
2022-02-18 11:14     ` Dumitrescu, Cristian
2022-02-18 11:17     ` Dumitrescu, Cristian
2022-02-18 11:04   ` Dumitrescu, Cristian
2022-02-18  9:36 ` [PATCH v2 2/4] sched: Always enable stats in HQoS library Megha Ajmera
2022-02-18 11:01   ` Dumitrescu, Cristian
2022-02-18  9:36 ` [PATCH v2 3/4] sched: Always enable best effort TC oversubscription " Megha Ajmera
2022-02-18 11:02   ` Dumitrescu, Cristian
2022-02-18  9:36 ` [PATCH v2 4/4] sched: Removed code defined under VECTOR Defines Megha Ajmera
2022-02-18 11:03   ` Dumitrescu, Cristian
2022-02-18 10:58 ` Dumitrescu, Cristian [this message]
2022-02-18 11:49   ` [PATCH v2 0/4] sched: HQoS Library cleanup Thomas Monjalon
2022-02-22 12:57 ` [PATCH v3 0/4] sched: cleanup of sched library Megha Ajmera
2022-02-22 12:57   ` [PATCH v3 1/4] sched: remove code no longer needed Megha Ajmera
2022-02-22 12:57   ` [PATCH v3 2/4] sched: move grinder configuration flag Megha Ajmera
2022-02-22 12:57   ` [PATCH v3 3/4] sched: enable statistics unconditionally Megha Ajmera
2022-02-22 12:57   ` [PATCH v3 4/4] sched: enable traffic class oversubscription unconditionally Megha Ajmera
2022-02-22 15:27   ` [PATCH v3 0/4] sched: cleanup of sched library Dumitrescu, Cristian
2022-02-24 22:44     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM8PR11MB56701E1F1C1CC515EF0AB887EB379@DM8PR11MB5670.namprd11.prod.outlook.com \
    --to=cristian.dumitrescu@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=jasvinder.singh@intel.com \
    --cc=megha.ajmera@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).