From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57F64A0C50; Fri, 16 Jul 2021 14:47:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CA8B84067B; Fri, 16 Jul 2021 14:46:59 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id D6CCE40151 for ; Fri, 16 Jul 2021 14:46:57 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10046"; a="197912273" X-IronPort-AV: E=Sophos;i="5.84,244,1620716400"; d="scan'208";a="197912273" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jul 2021 05:46:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,244,1620716400"; d="scan'208";a="490485704" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga004.fm.intel.com with ESMTP; 16 Jul 2021 05:46:55 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Fri, 16 Jul 2021 05:46:54 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Fri, 16 Jul 2021 05:46:54 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Fri, 16 Jul 2021 05:46:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PQlxTUu5FjoxaYGsv/IGQEMx4wPGbMFVjDOHXR6LeZVqcXNAmd+0EnTlgFzcN2AIvG53vSZEPP8fqpLdmoYCOt1++3ElK0ma5pVo8EcGpC+gx2/GHK7VMd5iFufaxrlq36dl4JrzEHh4x/hs72iF47Izhx0T9AkaalyeFxlea8jhC9oM+oLOl5trtnn9ldEQGBUO/dmh27SsWGHQSTJUVtWJUCiUsqi5hzS52cp9+F1myiFC5dRg02i+wBjXk0M3vqV7EVvRYe4fhoot7+B+lGx1vxSECRk2jbTY9l4y4qK4poBVOxlje5PGaSjnVFqmoKdeG0UI0BurOyt9XzLdDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nqWGiMJKyFq0JOlL7KXjLC2hhMhQRbdzizkRKTKytF8=; b=bA8GcpdD21AOxw9ngJBvPauNTDWemoeZk50vdIdD+VLJk4PWi/leFNKJNaIymL3RrZv55WE2fgKBjYghgwH/UYhB7Z2TTwPvjgESil6S8Dfx68oZ30XJa1/G1cYoFv2W5FOX7YX43IwKxfsD9QntZvUtzig5UUU37Q/HZS2V6299LQGsgP6IJZd3VAodpTXqolC13mnFP9K3YbQYrAjas3qhGynaWPY+a21FtmzC4Ykg0rY8mXmsZUfin0ATrm+JZDsY3fCVxSntXLYv54vy5XUM+ZfHcYLSEypIbuuKapJbsC3goV7SqpkDRwaAsKzPCATspzbO3awulNYnTtCO+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nqWGiMJKyFq0JOlL7KXjLC2hhMhQRbdzizkRKTKytF8=; b=E0RixcqMTiR6KTDVtyDe7j1Xi4t2hHMpuOmAFzicG7pfi+5ZBoNOqoDe5iroHVJ/vUrfs8zsBUbwZKGkvu1fN5pPjllrydLBVq9ytl/e9F5r/m2BXKmk6lzumvnuW0zdKutwF/rF2AmTH8GsZwodJ7zf2kaCmBMsKeS+qmxR26Q= Received: from DM8PR11MB5670.namprd11.prod.outlook.com (2603:10b6:8:37::12) by DM8PR11MB5672.namprd11.prod.outlook.com (2603:10b6:8:26::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.24; Fri, 16 Jul 2021 12:46:52 +0000 Received: from DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::4e4:c86b:b091:bc26]) by DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::4e4:c86b:b091:bc26%3]) with mapi id 15.20.4331.026; Fri, 16 Jul 2021 12:46:52 +0000 From: "Dumitrescu, Cristian" To: "Liguzinski, WojciechX" , "dev@dpdk.org" , "Singh, Jasvinder" CC: "Dharmappa, Savinay" , "Ajmera, Megha" Thread-Topic: [RFC PATCH v4 0/3] Add PIE support for HQoS library Thread-Index: AQHXcXSGCjUxYJl1R06OBW4VLbmfaatFnOlg Date: Fri, 16 Jul 2021 12:46:52 +0000 Message-ID: References: <20210621073506.96017-1-wojciechx.liguzinski@intel.com> <20210705080421.18736-1-wojciechx.liguzinski@intel.com> In-Reply-To: <20210705080421.18736-1-wojciechx.liguzinski@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c2717be9-7cbe-4f34-87e5-08d94857c96f x-ms-traffictypediagnostic: DM8PR11MB5672: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tc/AZ++feRcpZKyApiKrSIgyHLjy7GFhASLUWeN1o5GxdQxNWBEJyI681Zpsz0udZCWO/cc2/xYIX1anj8xtC695W+fAFvmrQEZt+6hSUch0Sr9IMv3wLhmVyhXVeU2ZJADHbBTKG5XPIT53j3E86WYpruC3Gv26WGml0cV+k4klFnR33bQP0u9gtmmwT8lnLo5WP5IV83TlCNA0FZfTmlt84DFincPGB5/mwOHOXCGh67PUOAtr/qR0Ao8SAibHI1iDAGlVI/1FaSykmCfQOZ0ALm/zHqEkCm+8L0LRfTIHBFrYFYeP6uN1Ue8f4GEOPixTxVT5JUfSXw2/y3t0NUrGXFJfdeUVcLthm0/l1oVlyq9FNejYMrKz5kBpG6lwt06Ar8LG+G4E5LAu6U+JOKCbTrLQUf5UWCes1ug0lzd17jpoUKWhBgQkoMsvL/S2R+nqzOkAd/n14lAD7WW8TDjvqvqTYi+3b0u23SM0MRDhS2SZ922CIEyof8RqJhEBMNLfpv+7K13aFxdDN9ZMqgxfXO2/53d98urABLw0qawhFRaA5PZ+MO6Ps+xHIdn/+rFy7UXVuGIbdcl2Jp+LdElkqCgdml4MWuAGs+d1bdbrqn7dWI0uoy52/N8DUzgrFQUDBy1xPUN7hzHjMall7Z4077tg4j6Iq/xQCROH2pEg/VfsA17rU4XiVG0pl6/X7FT+zzcKVvI9SBRB5hYlJQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5670.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(376002)(366004)(136003)(39860400002)(346002)(52536014)(122000001)(66946007)(76116006)(38100700002)(6506007)(66556008)(6636002)(66476007)(66446008)(64756008)(8936002)(2906002)(4326008)(53546011)(107886003)(8676002)(86362001)(71200400001)(110136005)(54906003)(316002)(55016002)(83380400001)(478600001)(7696005)(26005)(9686003)(33656002)(186003)(5660300002)(38070700004); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RefAKeUI+btOU7xb4a/pixtFkp4T5GT1bpcpMeN4MMIynI7vaPDzPwoKC45g?= =?us-ascii?Q?U0jru75S2n8gb4HdpkF9wIjiq4DKNw0+dmC5R8QsEV2POqIPkbS6ELsFQaLt?= =?us-ascii?Q?jE4jkUV2dgaemNuFsQHGvd9zPFFAnRVx8+sM3hsfR6m39pvOpyHZd9qhWYwg?= =?us-ascii?Q?Kgo1aOXAmeQV96ru7VlIcKb3qfWlCtaYTcG5Dcne5K0ulrsvOLr8XX0AnFJn?= =?us-ascii?Q?d1HovYXdAZqLBHwaLveGs3ZzUIc1wQrMcCVtUGNOq6pypHaC8+dZckjGpqX6?= =?us-ascii?Q?itSijDDLfIY6yfZvkQ+Jvu5PzRjU9jlZQrJtqAX4DYuHvyilGWTJbuCS0AX2?= =?us-ascii?Q?ZzVxITZlgEr4i8sRcsHNz36Rb4M7qKtQUTnhGPUNzD/7f1cPxp47JmtBPLf8?= =?us-ascii?Q?Ut/GHkjgwwzSuExhZER98Gn1XHFgK7eD/rtXutLYMSSxxm5Qhwv82LuPrQza?= =?us-ascii?Q?uSqS5Wb951yPcvJ9zI2z+Bijiodp4O0e3XrMLzRP6Mtack+n35GjrPBdl/Dq?= =?us-ascii?Q?Iyh8JHzroXUAMadBSp6kNSiWycNNgLNHi6moKeZCyDlCe5m+ldJZFcIg7pn9?= =?us-ascii?Q?/2Ex3M6Y2jCDnEDrUjlv2awz4QLjWDHy9ScNVkauKTRQ+LluACIoozhUEe3a?= =?us-ascii?Q?vtBsXCZBEOb3UI1+vexw6B78lxwuB2Q4FreZYCEESL9L6k236z6lQFgOVlZW?= =?us-ascii?Q?MESIbIAwArYX3phulP8OX2LA5cjypPkOnvJWsRrXi6pgarY5z8BUXgAFqk7N?= =?us-ascii?Q?uz+tcNpBuuedmjWLDiK1wMKmOV9GmFPsR+av6hijJHcI5FiRSytyMRFDGJAv?= =?us-ascii?Q?G1fsRElbcxGU0cqilssA480C11Ho1KkyRwegvCmIlOIHJlduduBuH5/YQNlD?= =?us-ascii?Q?1w+UtxIgMS6bMXc1CuubgNoQcPWjcMwHGsLNit1A5R5XS0W6TfBGR4VqfdrW?= =?us-ascii?Q?0kzoU1+dtfAegGH8yDytml+CYsM0FRWIQyKSoEiyiUGHm++WCvjC4vYXGTYg?= =?us-ascii?Q?uCqun61LqbcODsWjCR/l1QzinE9SXgY/igqfPMvybElnwLfDUOpxrJvPAsmo?= =?us-ascii?Q?LK/7xpDklVDxRxxIKtXDy2Xhl2LoQ26zpgZqErCNIKhIsZhOIHmv8VXpkO1z?= =?us-ascii?Q?l/rAWafOJYQ03jUlFwoBb7WgHn7WMqg9MnFFWR4SLimoaJmgAHlVMr8YSxkW?= =?us-ascii?Q?jIiQSZ1pamc7wK12rndPDFZgqe2+IfhcCgmcERfo2esiyOVFUcRgXpdVcj8S?= =?us-ascii?Q?uvSbvLr8Q0YXigNh5FqTKeyar6W1tu0o8eFIsfTzqNPtbLPYohNQw9FsscJr?= =?us-ascii?Q?/UoJDxbeaTA8SPNzU3FeMJBA?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5670.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c2717be9-7cbe-4f34-87e5-08d94857c96f X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jul 2021 12:46:52.6917 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nqGywk5I/gnOPPVE0ZPv+El6JFU6agNze/a6GT0V6GrjGPpc8s/3p2IE7SeDDd6kOf3iMbyCDAQWx1/XEZOrqFV01VJBtyagpi4LGZI5TR0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5672 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [RFC PATCH v4 0/3] Add PIE support for HQoS library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Wojciech, Thank you for doing this work! > -----Original Message----- > From: Liguzinski, WojciechX > Sent: Monday, July 5, 2021 9:04 AM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Dharmappa, Savinay ; Ajmera, Megha > > Subject: [RFC PATCH v4 0/3] Add PIE support for HQoS library >=20 > DPDK sched library is equipped with mechanism that secures it from the > bufferbloat problem > which is a situation when excess buffers in the network cause high latenc= y > and latency > variation. Currently, it supports RED for active queue management (which = is > designed > to control the queue length but it does not control latency directly and = is now > being > obsoleted). However, more advanced queue management is required to > address this problem > and provide desirable quality of service to users. As already mentioned by other reviewers, I don't think RED/WRED is getting = obsoleted. This entire paragraph is a bit fuzzy and not really adding much = value IMO, I propose to remove it. >=20 > This solution (RFC) proposes usage of new algorithm called "PIE" > (Proportional Integral > controller Enhanced) that can effectively and directly control queuing la= tency > to address > the bufferbloat problem. Please add a link to the public RFC for PIE in this cover letter. >=20 > The implementation of mentioned functionality includes modification of > existing and > adding a new set of data structures to the library, adding PIE related AP= Is. > This affects structures in public API/ABI. That is why deprecation notice= is > going > to be prepared and sent. I think you are stating the obvious here, how about removing this paragraph= as well? >=20 > Liguzinski, WojciechX (3): > sched: add PIE based congestion management > example/qos_sched: add PIE support > example/ip_pipeline: add PIE support >=20 > config/rte_config.h | 1 - > drivers/net/softnic/rte_eth_softnic_tm.c | 6 +- > examples/ip_pipeline/tmgr.c | 6 +- > examples/qos_sched/app_thread.c | 1 - > examples/qos_sched/cfg_file.c | 82 ++++- > examples/qos_sched/init.c | 7 +- > examples/qos_sched/profile.cfg | 196 +++++++---- > lib/sched/meson.build | 10 +- > lib/sched/rte_pie.c | 82 +++++ > lib/sched/rte_pie.h | 393 +++++++++++++++++++++++ > lib/sched/rte_sched.c | 229 +++++++++---- > lib/sched/rte_sched.h | 53 ++- > lib/sched/version.map | 3 + > 13 files changed, 888 insertions(+), 181 deletions(-) > create mode 100644 lib/sched/rte_pie.c > create mode 100644 lib/sched/rte_pie.h >=20 > -- > 2.17.1 Regards, Cristian