From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 148FDA0032; Fri, 18 Feb 2022 12:01:13 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0458B40150; Fri, 18 Feb 2022 12:01:13 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id B00C040141 for ; Fri, 18 Feb 2022 12:01:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645182070; x=1676718070; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=B17EGI+B4ZPYG99HcAG7DdzEEefIf444eocCJzZovYo=; b=Oy8Sy+LMChMC2qNkWObbQiekdJF6t8DzHQfIRFzgN2JBm41MKxYO052g pc2iJANqtn7IuZfADUYRiSoDEMLwF1irzy2zhu4HrjcqsQiICti1EPw0r kqvHUs4tb9GX+ZE1/eFlQV5XBNxJYe/CQ6a7kKEMo0C4FbYtEIwOjzvBG DVWYJdGfiZeUfLLwwx5Qwu+K32seMHa0u0SGiM6SOvzoe34Lagt58/agk 1rtaS8YPOdFFYCW+WvFDlH6Q6luFz8Ul84m60j+LaLh/OcU5Uk/bt2rkc Z07Y7En7bj/t7cb3MPiiGobacQUO+7b3VWAWl5unlDSLGLCX0ZOLTWxo3 A==; X-IronPort-AV: E=McAfee;i="6200,9189,10261"; a="249938987" X-IronPort-AV: E=Sophos;i="5.88,378,1635231600"; d="scan'208";a="249938987" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2022 03:01:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,378,1635231600"; d="scan'208";a="637708310" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga004.jf.intel.com with ESMTP; 18 Feb 2022 03:01:09 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 18 Feb 2022 03:01:08 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 18 Feb 2022 03:01:08 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.173) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 18 Feb 2022 03:01:08 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KR0H8eXhn1u9wE/sRE9yD33ETQtOpuL8ApkCcuVCqPekCLisxknJt7ZuExDSjuVajzxKw6V/HUgxUBJzuUDx7S7EItNBaGBjIMVx0hUlsPFDhddCm/OF3//mJ7wtviAaJM7Es/dJuD7rsjl8XqBRPkBuAvImCErLabwCJ8+Ym0rWB6/nWiZRBgohrL9MFdJd9P+D8HoGCM8FGTN4Y5DC1tNkovAQ4l4NPRxscxQhaVghvJj3C6o0DXNq/syhrMDjPTiBfMQVB1j2Fk+unQbAxU01fQRD5bTBx4L5e58aXVEtGyVSPO3H158ReqWDKnDSjxh0r5mivRbzeBPbPliHqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nbDR2etcaKr+fb4dbXAI7OrDD92GxmY4Gy1pAWpshiU=; b=J5UAliQxGo+n9osbGGMlxHHMMWyg4dsvM+wnZJ3lc7DqigFE8a5HwIbdRLsyvWKZU8JbISFkiDJb8QqN6kY3r+oz6n1UsMeIYg0XxRrWHtLYShiFI4PaATwP7kT/qV3C5o0MyaX7hsYm0bJYsmTIrEDAxcaoivyfc01uAzKYdc10B2ohVQoHKc+BG79Za75dO1aymRvKlNyVumeyae00s8XvFrNAc8e2IJdqpIRWS1pE3pGk9LHe8JDcWgPJjM4U249gEubtXb2ieeflIwtcsrOANeLsrYsET7XjV+KreX+swFo5iuPlEs+tcQXWWxGNw44QUwnCkMUBlbEh62haXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5670.namprd11.prod.outlook.com (2603:10b6:8:37::12) by BL0PR11MB2913.namprd11.prod.outlook.com (2603:10b6:208:79::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Fri, 18 Feb 2022 11:01:07 +0000 Received: from DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::e9b0:843e:2b39:6680]) by DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::e9b0:843e:2b39:6680%4]) with mapi id 15.20.4995.024; Fri, 18 Feb 2022 11:01:06 +0000 From: "Dumitrescu, Cristian" To: "Ajmera, Megha" , "dev@dpdk.org" , "Singh, Jasvinder" , "thomas@monjalon.net" , "david.marchand@redhat.com" Subject: RE: [PATCH v2 2/4] sched: Always enable stats in HQoS library. Thread-Topic: [PATCH v2 2/4] sched: Always enable stats in HQoS library. Thread-Index: AQHYJKsY8yY+26sPc0KxjBefAQhpn6yZI55w Date: Fri, 18 Feb 2022 11:01:06 +0000 Message-ID: References: <20220218093650.2549927-1-megha.ajmera@intel.com> <20220218093650.2549927-3-megha.ajmera@intel.com> In-Reply-To: <20220218093650.2549927-3-megha.ajmera@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 68ee24f8-526c-4011-dde1-08d9f2cdf68b x-ms-traffictypediagnostic: BL0PR11MB2913:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Cj1Q0c1O4uiUd8wjOUD+PIAWUNFIQ/XVcwUH0GEugoEFiTOlKAaW8IHy8/gTyLbAgc/h0G5WO3/aZvlXhd0nHuaDzIutStVyXl6RnhIaNHMzbiYQqGdsQn2fAYaaC1+JAumzl99nz6JlVBQrCz9iy94zBCMjJSRDAFV68JDmTYP9sdtzcr95o1c4bSQd4ahyVwGPksKA7xM1ZSCFf3vKk+wDUj4zwxOVmc3Q84kmw3LtALZcuNJA9eKxRnniA+W9d6GdkZ5j7600ZYtN4T7upkX8j86wFw/3AtTkNqbvCws3pwg5Vp8X8hDiTFFAmiWqEHkDrTew13zmREkgQR2Ekt4UpmbUyMSRLeGB6j3u8OjZGssbHs8HyIN+ybT8i/28zDriSSSr9YcSfflhPWJyNaVPPxrS7bV4I3HM3sRet9YdddTMZeK4HNEqLfToaPSkqG7sLxL8dPREZLnIeo55ZWoNYESMRjs3wr+a5GmygnJ8jY4PuuzSJGZSEMyGvYihQg7Edl4XKC5+FWP2uJqPGhScUmNjE3qlN8d/PfvACT+oBvlyyvy/BhpCBtT4VWIES7TfMx2xDHWXHOaVfZ480znKPcltX3jtZOxLcCmhnSTeHWj94NThrZsL5fALIYHTw8BmJb61/T6/bkI9u6uXAUcud25/NyIat8T9aBf5soovhNKqgt7S40xn2vNllOwoemkvvT3wHVpxruPT99jTYg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5670.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(33656002)(64756008)(38070700005)(53546011)(8676002)(38100700002)(55016003)(66446008)(7696005)(110136005)(316002)(2906002)(6506007)(71200400001)(9686003)(76116006)(66556008)(5660300002)(66946007)(66476007)(86362001)(508600001)(122000001)(82960400001)(83380400001)(8936002)(26005)(52536014)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JsOUg5M9lo0CYy7T7225i3nMKIOARy26pKlssHniFS0Kvg8FI6Czxtc5kWLR?= =?us-ascii?Q?pD2gM7K+ex4d9G+znC0F2Kkeae4f9y9yxID2ZzPqR1VbtkKYkb5MoR4gYFD3?= =?us-ascii?Q?C7ZIMLJaOQ54uWrwCo7Qfg3riTu8MN6zSLfrOq8lrE8k9+7liMvoe7yTYgMc?= =?us-ascii?Q?2SXsUEaEX3Z9GcxCm++s8UP+A7rUGwD/zymRjJSogI4cPmiGkcevy01oOkw2?= =?us-ascii?Q?uVqTg/mko1tixuOw5NiUgD/FCZ6yf/LGJt6mrmC8pMZITRZzJNtaAhibYrhT?= =?us-ascii?Q?KwAzlN0tpPeRI/nDoPxYHm22ZEuJ13xvyvj4kMDxs9kssBHAMJ5948bHmGWc?= =?us-ascii?Q?7tTBBGrJIbVxwlOqyFVfRJv+0aDy5dPENry3ysaiXOIfTD7hidVwuNxjFIu3?= =?us-ascii?Q?cN/xamO0fbEYpOgD197JViGUamreWLIE8e2ODz0B68SQ6/ae919gbS1LZjbL?= =?us-ascii?Q?XQCAmFF9lCXiFr5Ox1EB4X4fs5wvT+g+eVEpqeouV3RltBsj+jxZNDLsvGPn?= =?us-ascii?Q?DYJqA6smh5GzJewp23dTFdFAa5fDje3FXTa58FGTJ6kL7RFgQ2AOl3I4AVtS?= =?us-ascii?Q?llp2VQAEyziB1hHorQAsq/Ow7j+J+EZIGBZ91wa2iB23fIJwtxTKTRLY/MA1?= =?us-ascii?Q?NNlKLczJbuPx7G05HywoZQNsDZ4J2HkKvBO62qTkR+SADcWWoAf43jCmj68d?= =?us-ascii?Q?vebFyW/WKdiJps4Tt/ggYPwUbRs7douCB4SLW72noVT4POGLSSrdGgHAQ6pU?= =?us-ascii?Q?0qgPVmw2oC8xz8v6he7zmgq5hwJvzTdkAPw5BOGUE497KXxW5ma6fon15EHw?= =?us-ascii?Q?kiROzjRXYbCO9HKSH4OkQ5akd3RFu9XNWBpvkYb8iNH/hPEcbIrVKDUGINiE?= =?us-ascii?Q?T54vp2UlrylKCNoiwxrrVSOXLwOhp3aOryJTftm3kZeuyA2ZZoxWobp3X51/?= =?us-ascii?Q?YTuMgMAGSU8EQfdedkcfOsl+WauIaGe4irvlSH9aYgtCWWWI4T/p7elL3+uo?= =?us-ascii?Q?uWDz0QXtUDidtzgpHrKNy1Rbh7CFsiKpf3LYOqhU8e12C3Lgx94RDOtYO/Y1?= =?us-ascii?Q?A1w41ogG1NkzUuh61dp3QKDiV4WlflvoflNJiLWbORLZ3yXiiYgNOjhsRBhA?= =?us-ascii?Q?aog/di0R/+6DNFsB3zTdqtaX8KwAxSUZSVQCer/cImVsXMrCpRgaloa/f5PG?= =?us-ascii?Q?ECBPVEMVoNaQ49xYsBtNezjl8XinGZC6w5XtsMmB0Wkrphhpl4SFJ8XcwfD4?= =?us-ascii?Q?E6puW7NZoU9vXGRJatGyzpRbpdO3rsU5/pz6Efq+bEPx+rMIvw8FSJ+g8KaZ?= =?us-ascii?Q?giVWa3w//XwbCLmD/vdJWIl+YrSA0N8r1rJJfW7QVZ8U/e/ZOmBh9mBQfHM9?= =?us-ascii?Q?Wi9WzzgM1+QvCXI/hJFS6RB6Oa5qp7jBo73a8/7wYu2ym35cLO83LM1fwliS?= =?us-ascii?Q?H+HwhUws357Ar4T0T2Byo29K8uEtKr2PUdPKF0OiBp30q6MK4NMvLOumobei?= =?us-ascii?Q?Y389ChuXcGM/UK2TAO6bmvMkpG/pHWsipXTTr6BSHz0Fi5WqsGpc7Rh+xaqf?= =?us-ascii?Q?WZ7iUF3RRlH6YZk/xGw2iHIUyo/swqVXaQBQ0+wSAmx4CfQwr7nL8eF7LJF/?= =?us-ascii?Q?uvjz7/aoHYsUphTWHGMw/clPDlrTjpEW3Zdg/SyLuEJNl+QB0CHxHptBv8gF?= =?us-ascii?Q?8GLa1Q=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5670.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 68ee24f8-526c-4011-dde1-08d9f2cdf68b X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 11:01:06.7745 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HG90tqoTvMk1Z4hX4RnZ1M313yNMljFgerjNF0+RHgTrVH+uz4ePU1WaBW13rjOlShmjsi9zp+vt2icxgpQxlDGaSDGOqwa0ZviC3p7zh8M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB2913 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Ajmera, Megha > Sent: Friday, February 18, 2022 9:37 AM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian ; > thomas@monjalon.net; david.marchand@redhat.com > Subject: [PATCH v2 2/4] sched: Always enable stats in HQoS library. >=20 > Removed "RTE_SCHED_COLLECT_STATS" flag from HQoS. >=20 > Signed-off-by: Megha Ajmera > --- > lib/sched/rte_sched.c | 12 ------------ > 1 file changed, 12 deletions(-) >=20 > diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c > index 6c3e3bb0bf..6f2d85edc0 100644 > --- a/lib/sched/rte_sched.c > +++ b/lib/sched/rte_sched.c > @@ -1790,8 +1790,6 @@ rte_sched_port_queue_is_empty(struct > rte_sched_subport *subport, >=20 > #endif /* RTE_SCHED_DEBUG */ >=20 > -#ifdef RTE_SCHED_COLLECT_STATS > - > static inline void > rte_sched_port_update_subport_stats(struct rte_sched_port *port, > struct rte_sched_subport *subport, > @@ -1849,8 +1847,6 @@ > rte_sched_port_update_queue_stats_on_drop(struct rte_sched_subport > *subport, > #endif > } >=20 > -#endif /* RTE_SCHED_COLLECT_STATS */ > - > #ifdef RTE_SCHED_CMAN >=20 > static inline int > @@ -1989,18 +1985,14 @@ > rte_sched_port_enqueue_qptrs_prefetch0(struct rte_sched_subport > *subport, > struct rte_mbuf *pkt, uint32_t subport_qmask) > { > struct rte_sched_queue *q; > -#ifdef RTE_SCHED_COLLECT_STATS > struct rte_sched_queue_extra *qe; > -#endif > uint32_t qindex =3D rte_mbuf_sched_queue_get(pkt); > uint32_t subport_queue_id =3D subport_qmask & qindex; >=20 > q =3D subport->queue + subport_queue_id; > rte_prefetch0(q); > -#ifdef RTE_SCHED_COLLECT_STATS > qe =3D subport->queue_extra + subport_queue_id; > rte_prefetch0(qe); > -#endif >=20 > return subport_queue_id; > } > @@ -2042,12 +2034,10 @@ rte_sched_port_enqueue_qwa(struct > rte_sched_port *port, > if (unlikely(rte_sched_port_cman_drop(port, subport, pkt, qindex, > qlen) || > (qlen >=3D qsize))) { > rte_pktmbuf_free(pkt); > -#ifdef RTE_SCHED_COLLECT_STATS > rte_sched_port_update_subport_stats_on_drop(port, > subport, > qindex, pkt, qlen < qsize); > rte_sched_port_update_queue_stats_on_drop(subport, > qindex, pkt, > qlen < qsize); > -#endif > return 0; > } >=20 > @@ -2059,10 +2049,8 @@ rte_sched_port_enqueue_qwa(struct > rte_sched_port *port, > rte_bitmap_set(subport->bmp, qindex); >=20 > /* Statistics */ > -#ifdef RTE_SCHED_COLLECT_STATS > rte_sched_port_update_subport_stats(port, subport, qindex, pkt); > rte_sched_port_update_queue_stats(subport, qindex, pkt); > -#endif >=20 > return 1; > } > -- > 2.25.1 Please adjust the patch title to meet the requirements: -start with a verb -do not start with an upper letter And also please do not mention HQoS anywhere (title, body, ...), the name o= f the library is sched, not HQoS. Title proposal: sched: enable statistics unconditionally