From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: "Danilewicz, MarcinX" <marcinx.danilewicz@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Singh, Jasvinder" <jasvinder.singh@intel.com>
Cc: "Ajmera, Megha" <megha.ajmera@intel.com>,
"Thakur, Sham Singh" <sham.singh.thakur@intel.com>,
"Mcnamara, John" <john.mcnamara@intel.com>,
"Devlin, Michelle" <michelle.devlin@intel.com>
Subject: RE: [PATCH v4] sched: enable traffic class oversubscription conditionally
Date: Tue, 24 May 2022 14:30:29 +0000 [thread overview]
Message-ID: <DM8PR11MB56702C425F806CBE7077B5DDEBD79@DM8PR11MB5670.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220524134332.644318-1-marcinx.danilewicz@intel.com>
> -----Original Message-----
> From: Danilewicz, MarcinX <marcinx.danilewicz@intel.com>
> Sent: Tuesday, May 24, 2022 2:44 PM
> To: dev@dpdk.org; Singh, Jasvinder <jasvinder.singh@intel.com>;
> Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Cc: Ajmera, Megha <megha.ajmera@intel.com>
> Subject: [PATCH v4] sched: enable traffic class oversubscription conditionally
>
> Added new API to enable or disable TC over subscription for best
> effort traffic class at subport level.
> Added changes after review and increased throughput.
>
> By default TC OV is disabled.
> History:
> - v1 - TC OV disabled by default
> - v2 - throughput improvements
> - v3, v4 - changes from comments
>
> Signed-off-by: Marcin Danilewicz <marcinx.danilewicz@intel.com>
> ---
> lib/sched/rte_sched.c | 189 +++++++++++++++++++++++++++++++++++------
Marcin,
I don't see any of my comments on the previous V3 version addressed. You mention in the change log that you addressed comments, but I see that all my comments were silently disregarded. Jasvinder also noted the same for his comments in a previous version. Please address the comments and do not keep sending the same code over and over.
This change was supposed to be straightforward, but for some reason the progress is extremely slow on your side. I think at this point we are at risk of missing the RC1 deadline for this feature.
Regards,
Cristian
next prev parent reply other threads:[~2022-05-24 14:30 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 14:51 [dpdk][PATCH 1/2] sched: enable/disable TC OV at runtime Marcin Danilewicz
2022-04-07 14:51 ` [dpdk][PATCH 2/2] sched: fix to manage " Marcin Danilewicz
2022-04-14 9:53 ` Thomas Monjalon
2022-04-27 9:23 ` [PATCH v3] sched: enable/disable " Marcin Danilewicz
2022-04-27 15:48 ` Singh, Jasvinder
2022-05-09 20:05 ` Dumitrescu, Cristian
2022-05-10 6:40 ` Ajmera, Megha
2022-05-10 9:09 ` Dumitrescu, Cristian
2022-05-24 13:33 ` Marcin Danilewicz
2022-05-24 14:52 ` Stephen Hemminger
2022-05-26 23:12 ` Danilewicz, MarcinX
2022-05-24 13:38 ` [PATCH v4] sched: enable traffic class oversubscription conditionally Marcin Danilewicz
2022-05-24 13:43 ` Marcin Danilewicz
2022-05-24 14:30 ` Dumitrescu, Cristian [this message]
2022-05-25 14:18 ` Danilewicz, MarcinX
2022-05-27 0:09 ` Danilewicz, MarcinX
2022-05-27 0:09 ` [PATCH v5] " Marcin Danilewicz
2022-05-30 8:45 ` [PATCH v6] " Marcin Danilewicz
2022-05-30 10:35 ` Dumitrescu, Cristian
2022-05-30 11:59 ` Danilewicz, MarcinX
2022-05-30 10:54 ` Dumitrescu, Cristian
2022-05-30 12:02 ` Danilewicz, MarcinX
2022-05-30 10:58 ` Dumitrescu, Cristian
2022-05-30 12:04 ` Danilewicz, MarcinX
2022-05-30 11:55 ` [PATCH v7] " Marcin Danilewicz
2022-05-30 12:14 ` Dumitrescu, Cristian
2022-05-30 13:34 ` Danilewicz, MarcinX
2022-05-30 13:55 ` Dumitrescu, Cristian
2022-05-30 14:05 ` Danilewicz, MarcinX
2022-05-30 13:38 ` [PATCH v8] " Marcin Danilewicz
2022-05-30 18:47 ` [PATCH v9] " Marcin Danilewicz
2022-05-30 21:13 ` Dumitrescu, Cristian
2022-05-31 9:49 ` [PATCH v10] " Marcin Danilewicz
2022-05-31 13:09 ` Dumitrescu, Cristian
2022-05-31 16:42 ` Thomas Monjalon
2022-05-31 18:45 ` Danilewicz, MarcinX
2022-04-08 12:50 ` [dpdk][PATCH 1/2] sched: enable/disable TC OV at runtime Singh, Jasvinder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8PR11MB56702C425F806CBE7077B5DDEBD79@DM8PR11MB5670.namprd11.prod.outlook.com \
--to=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=john.mcnamara@intel.com \
--cc=marcinx.danilewicz@intel.com \
--cc=megha.ajmera@intel.com \
--cc=michelle.devlin@intel.com \
--cc=sham.singh.thakur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).