From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 135D2A0032; Fri, 18 Feb 2022 12:02:18 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ECA3040150; Fri, 18 Feb 2022 12:02:17 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 59D2C40141 for ; Fri, 18 Feb 2022 12:02:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645182136; x=1676718136; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=TYTYbrb6B10Cr5fTq3nWFlU93idUrQUbdOuQpk0OknM=; b=HWRKK/34YC4zDGfBrnc8AHM5jGgw8S4og0pphcC7smzW1nOP70RfVFNd yuwhpVzREFQjtD3gUN0Dn02KsjsY4bQ7+MwYAVUaqgGn/e4SNJRRiRMX+ UMX1grgq9AfaeLb19+H8le9QZOfpBDXZzbdriwaIyejrpcD/q/kyZFwk3 gJl9ES6rnOlIuSYkejulupQQE+a5zX8dpy/gOb9WjA0BSgUTswoPtwsiz HC4tCaJinh7DuQIloS98CtNqeYAmhTZssrML61r8S1a4SErdLK/7UGOjR ZT3BdUPiFUG8Fgv/tNg1/JOgJe9PsvDvH0E/LfNMxJuJDPfCTay3mn0sw Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10261"; a="231087813" X-IronPort-AV: E=Sophos;i="5.88,378,1635231600"; d="scan'208";a="231087813" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2022 03:02:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,378,1635231600"; d="scan'208";a="489364993" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga003.jf.intel.com with ESMTP; 18 Feb 2022 03:02:15 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 18 Feb 2022 03:02:14 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 18 Feb 2022 03:02:14 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 18 Feb 2022 03:02:14 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.42) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 18 Feb 2022 03:02:14 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nfeqgB67bAGh9d5jOKrUJ3kUyJuz7znVNvmtLJbDEKq1lmzGRSvmLs3SpcqHAAkDsA0exE919Vcfg3SZc4VMmBQY/syjxHOm1ly3k8ZpZpHWA5yjFfO/Uj80rnA00nZXCTDpqqYKAv32VES0FAk6qKjht/rxR4PsiiOfIsV1ptDvFRDcy/G7444ntu4VybwEmJa7jONGkq2stK4E1FkzwONIatGAP1Vse9lQhrvQo3t3WeOGgxkTx/KJnd1Tt1EVYOl2Kc0vW2gibECTYk9Kc34gNLgWRUFrOGeSJhWIIqXuW8gJbgn0MgjL+ihKqM/5RXu+mfKq/RMBpBttVvWhJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IAuXbKGghQX68Gl65sbIb8OdH+5jSaiif24OCL/f5v0=; b=K6FAuUMG89dHmU877DEpSvxFX0yvzPBrKoC6//I5NKi6uqgSWoYAcPJ+JySlTBQ0tYXkGIe2aHQaRDFYTZPWYwGJmjT3L53N8+ejlptfg1w2187F+1e9jh0VDWBlVUfvwfN0uzkDPof0Xkccl4ZS333Vu2f1BiWWNBkp1+8Iu4AdfBH4xVdqeivWWtnsa98+nueQtSJffzuvT4d6kkIJsYaigIPRjSyHb+nQurvF/VP34RAjx1RdJoliFAalVJFhC083bOTBKCgLgYpdx83xZhimGj+ha5gAZfGbbTHhHASGemeAqibBZdCxVxUN4AmN/lwE6xWpYVEHvvRiSa5mVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5670.namprd11.prod.outlook.com (2603:10b6:8:37::12) by BL0PR11MB2913.namprd11.prod.outlook.com (2603:10b6:208:79::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Fri, 18 Feb 2022 11:02:12 +0000 Received: from DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::e9b0:843e:2b39:6680]) by DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::e9b0:843e:2b39:6680%4]) with mapi id 15.20.4995.024; Fri, 18 Feb 2022 11:02:12 +0000 From: "Dumitrescu, Cristian" To: "Ajmera, Megha" , "dev@dpdk.org" , "Singh, Jasvinder" , "thomas@monjalon.net" , "david.marchand@redhat.com" Subject: RE: [PATCH v2 3/4] sched: Always enable best effort TC oversubscription in HQoS library. Thread-Topic: [PATCH v2 3/4] sched: Always enable best effort TC oversubscription in HQoS library. Thread-Index: AQHYJKsaihy9/4en9U2Y310AxmV7NKyZJF5w Date: Fri, 18 Feb 2022 11:02:12 +0000 Message-ID: References: <20220218093650.2549927-1-megha.ajmera@intel.com> <20220218093650.2549927-4-megha.ajmera@intel.com> In-Reply-To: <20220218093650.2549927-4-megha.ajmera@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 05bc8a06-5131-4cf6-d7a6-08d9f2ce1d99 x-ms-traffictypediagnostic: BL0PR11MB2913:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:182; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: caMTHgq0e4VKp3tzLTMOPa5Q/4DCE+NamkTB8XnpiyOWhZj0S9cBxmO3W62uX+gsdeO09rBhd9koyogn9/IXnyJcdnqB5WYPmN54vX2f8fW7uR0nwrjjYvwriq+TZ9DBoAYLW06K2c1VUoZLIg9RGz3UrP42poVArhln7+3Vz0UwHWhYA3V2CcnyH1EJORyd1DTsrnPW3EnhxeKs9ma5ND12NLWj5mlctxxMKjzaC3f6y59bI14RZ8vo+0xnHC0WdjRK/1hWdHb3ujMQR9GYdkqcXXIUcA8YfIl509xl5F0MSJfQ5lFLVwHnxPNnDM0rieh09qa2WyRuAhSNl+xklI9DiLrh4g93QTwvdzikzAEHLruYvpJoae53wIXoxgAF8pni7Ct0DC6NmfxRQ+dalmoz1hMricmiTXtYn+5euhq9Dr13RbIWrG2deaZoz6ULooEIyf6uxB1AlhyP/U6Li7XnST4UslXND7hadZLpqkUiFBUdD46U7w7y7zX6EQ7+5sWAXGdSI3nyWvMNfRG+aCGd8Njqp8w80Se+dOAjTkLlc2A0+mjrmTrfhGM8jRoT36nQuSlZT6uHlJK5V49+/bDme++su4GpcegNzRps9mYKUeaZLtpClinD85/OHlRfOl5+ivmMwgWIIJWXjMb4+yhBVpBD92ULg3o2RP9Tw0Ep7LzOklRL5Xjq/OSOufGAyCJ81NcpQtuS+ZEkHZ+ocw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5670.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(33656002)(64756008)(38070700005)(53546011)(8676002)(38100700002)(55016003)(66446008)(7696005)(110136005)(316002)(2906002)(6506007)(71200400001)(9686003)(76116006)(66556008)(5660300002)(66946007)(66476007)(86362001)(508600001)(122000001)(82960400001)(83380400001)(8936002)(26005)(52536014)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?74q6ihNBofjHMAAyX6waznqryYfNmfsHcMxq51K9BVEuZQTISVH1UvKl2c42?= =?us-ascii?Q?HxTiudaTBwRbnEur+g9cLBURAr9Bzg37BUrdtb+Ea4CythcqRerSpP6x7K/I?= =?us-ascii?Q?GjAQ2a3FXw4qyxhjTIlIpVwaJueRsVIJoo5x13WMaoQsgZ+HDproyKcLjiZS?= =?us-ascii?Q?45jWbtWCeB8HCqIk+tuCaScN4R+SltO92FGYqxtMurM8lFFZnH8BDFzbFfH2?= =?us-ascii?Q?kb+USN/cAeEAvrGg5Jtv5U4jueb8//lSwF+D2ZlMrL71UyPRKaB3xvm+idgq?= =?us-ascii?Q?beIEiZQsvDhvO06ap2P0MIU5GHuZzifjiEgwLNW7PNTED5SnDOihZFYP9ROM?= =?us-ascii?Q?GKxuQMwuurLMYYw8hfZ6K9A7JTDCujt+hfln6u4MT42SQe1qRI/gaclgKkjy?= =?us-ascii?Q?PQ208yRumXV15ForIVpY5KdsPoRgyelsBsBxR0pLNK9jvrg9VKZqHmQX3KNi?= =?us-ascii?Q?GAclqX+KPA10VVr9UDUGL3AmRkAOtvuytxuPoGkPSQR5zPbSv581b2eiYbx7?= =?us-ascii?Q?Lb4ApUH9cZCaYeJciUova1wJtCYX4a9WgmRTEt8tF7XuRY2qt/3pddC+QSQz?= =?us-ascii?Q?qHkGh4EZbaQ9s7ZK3KYQyY4lW+L2UQxQIYcpZRohQbbFD8fpsMTvix7cAAXd?= =?us-ascii?Q?h3bX+egp26sGFlPfvO7C3mE0e13N+wZVtEEm/Qqup38EJAIjh331f69J5Sri?= =?us-ascii?Q?oFsxRjZYT8Rqo6LaD5DASiD19Zp+gREpG1SvD61MDfApEsrmCgRT81QJ+p9Q?= =?us-ascii?Q?jwv8D3gGQA+0mRomfG4Vlv4FcG7LFn+xjVU9IAyB7PO73CnUIrJ3tIzmQhrq?= =?us-ascii?Q?stpA3RBkl5nrJaG7K/L3+Cu301qw6XXGmhaBX0pqlELmVYSkZAppLHshgAWb?= =?us-ascii?Q?u+rWaXVflqE/WZrt1Gl+C21f2hpWQeLlVDdNcp56JKxec+sBJSI8gYp101lI?= =?us-ascii?Q?caAOr6gNFdqnw8tx/qzx1Gwi6Hm53RsavllwjWBZfa8Yocc7BCjFLfaZvcLq?= =?us-ascii?Q?A/Hv02LaZjo54/HGo7wSdxLFogdx0NjqglnS5D9737LwtI1i0zNYJExNBYIF?= =?us-ascii?Q?dsAy+d+KB4mIu/t9MSziWTxUpMuXi2IEx9bqDtUyx0JUFn/yClBQEYazDgI1?= =?us-ascii?Q?nVW64R/PNK/4cBlFkRhXnfEPNJKyF+B/wLAqIuBz1bTiE6wZkKOU+CSZ1Urh?= =?us-ascii?Q?RPJhMzu4p1z2WCsQH/ahmmOtjMybIbpAirby2MCA3g+q0m3vAik5acLs8fWv?= =?us-ascii?Q?YlxRI2Ily/jR+wJAxhh3v6+FCpe9XVqJMAR13bxX955Tx1IIAMXU3jRzbQBQ?= =?us-ascii?Q?pmIlq9l6BeSB8sTsvwR6wFKryAnX2EAvSS4fubIUWHXh24ETD+F0MomhxGkg?= =?us-ascii?Q?gPKZWr7vRyWPW6MUZ5fi0d7msPt5T74xS0e9M1xBpDVSp+bwRgplHr2R+zAM?= =?us-ascii?Q?kJF7W/89OPKAJ7tGIe91Jr0WJJwbGXKs3CcIF1qYDgs+e6d0bUM9RrgaI7qf?= =?us-ascii?Q?oWDwiuvm+U9CwfWv7OWsVAUTYwpLEhNDPK8wg9tVi/fo71MbMd2dPiOEmxM6?= =?us-ascii?Q?RAibqtzeodtyhwuAa7q9socIHHo31onERLFXBpImFnVzvb1HDLsOxRUTR93R?= =?us-ascii?Q?h+2gf+v/uZrebMGWvoT1+d56Ywy6zSNPwS7ZLJ7whu9O4odw9/MRbTLhpKlL?= =?us-ascii?Q?j/Ia9Q=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5670.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 05bc8a06-5131-4cf6-d7a6-08d9f2ce1d99 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 11:02:12.2817 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: g2QEUcQuN8ty3T5GLB5a2xWcuUI3JUFj6nP0AlS1BKm9fOmamMioaiX8rtuIHHCwAGfH+KtqUcAVLHmK3USZFsaZ2MVFKsvAYufHk9uDfGs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB2913 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Ajmera, Megha > Sent: Friday, February 18, 2022 9:37 AM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian ; > thomas@monjalon.net; david.marchand@redhat.com > Subject: [PATCH v2 3/4] sched: Always enable best effort TC oversubscript= ion > in HQoS library. >=20 > Removed "RTE_SCHED_SUBPORT_TC_OV" flag from HQoS. >=20 > Signed-off-by: Megha Ajmera > --- > lib/sched/rte_sched.c | 91 ------------------------------------------- > 1 file changed, 91 deletions(-) >=20 > diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c > index 6f2d85edc0..807134b48d 100644 > --- a/lib/sched/rte_sched.c > +++ b/lib/sched/rte_sched.c > @@ -1329,14 +1329,12 @@ rte_sched_subport_config(struct > rte_sched_port *port, > for (i =3D 0; i < RTE_SCHED_PORT_N_GRINDERS; i++) > s->grinder_base_bmp_pos[i] =3D > RTE_SCHED_PIPE_INVALID; >=20 > -#ifdef RTE_SCHED_SUBPORT_TC_OV > /* TC oversubscription */ > s->tc_ov_wm_min =3D port->mtu; > s->tc_ov_period_id =3D 0; > s->tc_ov =3D 0; > s->tc_ov_n =3D 0; > s->tc_ov_rate =3D 0; > -#endif > } >=20 > { > @@ -1356,11 +1354,9 @@ rte_sched_subport_config(struct rte_sched_port > *port, > else > profile->tc_credits_per_period[i] =3D 0; >=20 > -#ifdef RTE_SCHED_SUBPORT_TC_OV > s->tc_ov_wm_max =3D rte_sched_time_ms_to_bytes(profile- > >tc_period, > s- > >pipe_tc_be_rate_max); > s->tc_ov_wm =3D s->tc_ov_wm_max; > -#endif > s->profile =3D subport_profile_id; >=20 > } > @@ -2267,50 +2263,6 @@ rte_sched_port_enqueue(struct rte_sched_port > *port, struct rte_mbuf **pkts, > return result; > } >=20 > -#ifndef RTE_SCHED_SUBPORT_TC_OV > - > -static inline void > -grinder_credits_update(struct rte_sched_port *port, > - struct rte_sched_subport *subport, uint32_t pos) > -{ > - struct rte_sched_grinder *grinder =3D subport->grinder + pos; > - struct rte_sched_pipe *pipe =3D grinder->pipe; > - struct rte_sched_pipe_profile *params =3D grinder->pipe_params; > - struct rte_sched_subport_profile *sp =3D grinder->subport_params; > - uint64_t n_periods; > - uint32_t i; > - > - /* Subport TB */ > - n_periods =3D (port->time - subport->tb_time) / sp->tb_period; > - subport->tb_credits +=3D n_periods * sp->tb_credits_per_period; > - subport->tb_credits =3D RTE_MIN(subport->tb_credits, sp->tb_size); > - subport->tb_time +=3D n_periods * sp->tb_period; > - > - /* Pipe TB */ > - n_periods =3D (port->time - pipe->tb_time) / params->tb_period; > - pipe->tb_credits +=3D n_periods * params->tb_credits_per_period; > - pipe->tb_credits =3D RTE_MIN(pipe->tb_credits, params->tb_size); > - pipe->tb_time +=3D n_periods * params->tb_period; > - > - /* Subport TCs */ > - if (unlikely(port->time >=3D subport->tc_time)) { > - for (i =3D 0; i < RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE; i++) > - subport->tc_credits[i] =3D sp- > >tc_credits_per_period[i]; > - > - subport->tc_time =3D port->time + sp->tc_period; > - } > - > - /* Pipe TCs */ > - if (unlikely(port->time >=3D pipe->tc_time)) { > - for (i =3D 0; i < RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE; i++) > - pipe->tc_credits[i] =3D params- > >tc_credits_per_period[i]; > - > - pipe->tc_time =3D port->time + params->tc_period; > - } > -} > - > -#else > - > static inline uint64_t > grinder_tc_ov_credits_update(struct rte_sched_port *port, > struct rte_sched_subport *subport, uint32_t pos) > @@ -2405,46 +2357,6 @@ grinder_credits_update(struct rte_sched_port > *port, > } > } >=20 > -#endif /* RTE_SCHED_TS_CREDITS_UPDATE, RTE_SCHED_SUBPORT_TC_OV > */ > - > - > -#ifndef RTE_SCHED_SUBPORT_TC_OV > - > -static inline int > -grinder_credits_check(struct rte_sched_port *port, > - struct rte_sched_subport *subport, uint32_t pos) > -{ > - struct rte_sched_grinder *grinder =3D subport->grinder + pos; > - struct rte_sched_pipe *pipe =3D grinder->pipe; > - struct rte_mbuf *pkt =3D grinder->pkt; > - uint32_t tc_index =3D grinder->tc_index; > - uint64_t pkt_len =3D pkt->pkt_len + port->frame_overhead; > - uint64_t subport_tb_credits =3D subport->tb_credits; > - uint64_t subport_tc_credits =3D subport->tc_credits[tc_index]; > - uint64_t pipe_tb_credits =3D pipe->tb_credits; > - uint64_t pipe_tc_credits =3D pipe->tc_credits[tc_index]; > - int enough_credits; > - > - /* Check queue credits */ > - enough_credits =3D (pkt_len <=3D subport_tb_credits) && > - (pkt_len <=3D subport_tc_credits) && > - (pkt_len <=3D pipe_tb_credits) && > - (pkt_len <=3D pipe_tc_credits); > - > - if (!enough_credits) > - return 0; > - > - /* Update port credits */ > - subport->tb_credits -=3D pkt_len; > - subport->tc_credits[tc_index] -=3D pkt_len; > - pipe->tb_credits -=3D pkt_len; > - pipe->tc_credits[tc_index] -=3D pkt_len; > - > - return 1; > -} > - > -#else > - > static inline int > grinder_credits_check(struct rte_sched_port *port, > struct rte_sched_subport *subport, uint32_t pos) > @@ -2491,9 +2403,6 @@ grinder_credits_check(struct rte_sched_port > *port, > return 1; > } >=20 > -#endif /* RTE_SCHED_SUBPORT_TC_OV */ > - > - > static inline int > grinder_schedule(struct rte_sched_port *port, > struct rte_sched_subport *subport, uint32_t pos) > -- > 2.25.1 Same comments on the title: sched: enable traffic class oversubscription unconditionally