DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] test: enable bitmap in fast tests
@ 2021-10-27 14:05 David Marchand
  2021-10-27 14:55 ` Dumitrescu, Cristian
  0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2021-10-27 14:05 UTC (permalink / raw)
  To: dev; +Cc: aconole, Cristian Dumitrescu, Nithin Dabilpuram

This test was never added to the list of tests to run in CI.
Its name does not follow the implicit convention of ending with
_autotest.
Let's fix this.

Fixes: 5e9647fd5a1a ("test/bitmap: test scan after half cacheline is cleared")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 app/test/meson.build   | 1 +
 app/test/test_bitmap.c | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/app/test/meson.build b/app/test/meson.build
index 71fce2efda..510584010a 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -198,6 +198,7 @@ test_deps = [
 fast_tests = [
         ['acl_autotest', true],
         ['atomic_autotest', false],
+        ['bitmap_autotest', true],
         ['bpf_autotest', true],
         ['bpf_convert_autotest', true],
         ['bitops_autotest', true],
diff --git a/app/test/test_bitmap.c b/app/test/test_bitmap.c
index 70d8fffb5a..e9c61590ae 100644
--- a/app/test/test_bitmap.c
+++ b/app/test/test_bitmap.c
@@ -269,4 +269,4 @@ test_bitmap(void)
 	return test_bitmap_all_set();
 }
 
-REGISTER_TEST_COMMAND(bitmap_test, test_bitmap);
+REGISTER_TEST_COMMAND(bitmap_autotest, test_bitmap);
-- 
2.23.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] test: enable bitmap in fast tests
  2021-10-27 14:05 [dpdk-dev] [PATCH] test: enable bitmap in fast tests David Marchand
@ 2021-10-27 14:55 ` Dumitrescu, Cristian
  2021-11-10 10:45   ` David Marchand
  0 siblings, 1 reply; 3+ messages in thread
From: Dumitrescu, Cristian @ 2021-10-27 14:55 UTC (permalink / raw)
  To: David Marchand, dev; +Cc: aconole, Nithin Dabilpuram



> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Wednesday, October 27, 2021 3:06 PM
> To: dev@dpdk.org
> Cc: aconole@redhat.com; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>; Nithin Dabilpuram
> <ndabilpuram@marvell.com>
> Subject: [PATCH] test: enable bitmap in fast tests
> 
> This test was never added to the list of tests to run in CI.
> Its name does not follow the implicit convention of ending with
> _autotest.
> Let's fix this.
> 
> Fixes: 5e9647fd5a1a ("test/bitmap: test scan after half cacheline is cleared")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  app/test/meson.build   | 1 +
>  app/test/test_bitmap.c | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/app/test/meson.build b/app/test/meson.build
> index 71fce2efda..510584010a 100644
> --- a/app/test/meson.build
> +++ b/app/test/meson.build
> @@ -198,6 +198,7 @@ test_deps = [
>  fast_tests = [
>          ['acl_autotest', true],
>          ['atomic_autotest', false],
> +        ['bitmap_autotest', true],
>          ['bpf_autotest', true],
>          ['bpf_convert_autotest', true],
>          ['bitops_autotest', true],
> diff --git a/app/test/test_bitmap.c b/app/test/test_bitmap.c
> index 70d8fffb5a..e9c61590ae 100644
> --- a/app/test/test_bitmap.c
> +++ b/app/test/test_bitmap.c
> @@ -269,4 +269,4 @@ test_bitmap(void)
>  	return test_bitmap_all_set();
>  }
> 
> -REGISTER_TEST_COMMAND(bitmap_test, test_bitmap);
> +REGISTER_TEST_COMMAND(bitmap_autotest, test_bitmap);
> --
> 2.23.0

Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] test: enable bitmap in fast tests
  2021-10-27 14:55 ` Dumitrescu, Cristian
@ 2021-11-10 10:45   ` David Marchand
  0 siblings, 0 replies; 3+ messages in thread
From: David Marchand @ 2021-11-10 10:45 UTC (permalink / raw)
  To: Dumitrescu, Cristian; +Cc: dev, aconole, Nithin Dabilpuram

On Wed, Oct 27, 2021 at 4:55 PM Dumitrescu, Cristian
<cristian.dumitrescu@intel.com> wrote:
> > This test was never added to the list of tests to run in CI.
> > Its name does not follow the implicit convention of ending with
> > _autotest.
> > Let's fix this.
> >
> > Fixes: 5e9647fd5a1a ("test/bitmap: test scan after half cacheline is cleared")
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Applied, thanks.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-11-10 10:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-27 14:05 [dpdk-dev] [PATCH] test: enable bitmap in fast tests David Marchand
2021-10-27 14:55 ` Dumitrescu, Cristian
2021-11-10 10:45   ` David Marchand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).