From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 51068A0C4D; Tue, 19 Oct 2021 14:19:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CF6EB410FA; Tue, 19 Oct 2021 14:19:02 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 7B624410F4 for ; Tue, 19 Oct 2021 14:19:01 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10141"; a="227261362" X-IronPort-AV: E=Sophos;i="5.85,384,1624345200"; d="scan'208";a="227261362" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2021 05:19:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,384,1624345200"; d="scan'208";a="718254090" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga006.fm.intel.com with ESMTP; 19 Oct 2021 05:19:00 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 19 Oct 2021 05:18:59 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 19 Oct 2021 05:18:59 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.171) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 19 Oct 2021 05:18:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gwKRsw5gMnudBPQelS6IKSNgJi9Bf3I64LIK55FhMINiZ0Jg5TyTdhCaZVWJ8tnv4rLSDxtyFcFQQHMw120UTx76mT6aYJCV90LY0imeuU0R5zRn7+y975zzn2LOw17AKTbWqk5idoHj4NZJyJ706+AuqfV/lQsP5mjMFfnCn6yfw7xjkP89TMQNNV7v++OrypGWCJ/vQXbTjrhl0sn9Teq+2/Aa9lCD7DtsNlfcZEUyHmVfJXixGnxb+FMpmXywSgZ6BjKC+pksOiJFd2JoHI/4QP574ympZ4EQW5NLGrl42rtCSJVyWaMj0zybmYaQ/DU5lJQsFYbmYSxpvbqPnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8JQlxP2i3zrwgdugVUzKBEbA6EnAF9W2YOpzT/8FjaQ=; b=X+Zljz4J8g2CazTwAzT6JN7AB716yiEBVdYNRHm3Ox5WnK5O9Z7VbfK5RUX3c/pgENK/2QykJ+jhWaDyC6loo0iMaJk+QLhQ/D36NCkhnpnqLZ/N8koebgdrL1XTtjXNpVAbUWqLyIsi1ol/hOoOxCnsRC9W925raEXND1l0caUUq6sZxPNFLFlQv3dUvnR7WYFg3Clg7hG3oUfIavXqTWqLyEqLW7d1P1mLJkfP/iCi8YU4htnYEi6KFq0DZunVH9o8Va2T5cPEniG4EmfdIm3eB1GWlQfRL3MTUUL6KdBPl+97GcjQZn5FlB1b5CiMDZvqQobgTGEZNo0QjYkIvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8JQlxP2i3zrwgdugVUzKBEbA6EnAF9W2YOpzT/8FjaQ=; b=mKFYTkUOvNX7DRU7O/j/4YGICMZXz5fBSzcvI9Rv6fHHIaFGMkoTko1OQFOOg9j+2PG/zcQGAYWbUA5N9ZLPOSKDYdYXSE5UuBIjkm+RSwauQBtLT2xIZmXzkuPVNQAknLgi2VaCT0IJDd/CjLSyCXqUNkb4knuE4LvsK7OLSSw= Received: from DM8PR11MB5670.namprd11.prod.outlook.com (2603:10b6:8:37::12) by DM8PR11MB5606.namprd11.prod.outlook.com (2603:10b6:8:3c::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14; Tue, 19 Oct 2021 12:18:58 +0000 Received: from DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::c0f1:1135:ceb5:ac10]) by DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::c0f1:1135:ceb5:ac10%9]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021 12:18:58 +0000 From: "Dumitrescu, Cristian" To: "Liguzinski, WojciechX" , "dev@dpdk.org" , "Singh, Jasvinder" CC: "Ajmera, Megha" Thread-Topic: [PATCH v15 0/5] Add PIE support for HQoS library Thread-Index: AQHXxMH/MWdQAts15UGpy1XtVdjXJKvaPU2w Date: Tue, 19 Oct 2021 12:18:58 +0000 Message-ID: References: <20211015081620.2873739-1-wojciechx.liguzinski@intel.com> <20211019081902.3514841-1-wojciechx.liguzinski@intel.com> In-Reply-To: <20211019081902.3514841-1-wojciechx.liguzinski@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 85dd7967-c707-494f-27a8-08d992faa0ec x-ms-traffictypediagnostic: DM8PR11MB5606: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3bfuAv6ObD8Mjo8eeHxyKxD39sFLdetb82fOTAmnFyFwX8RFRIt/xmfpPZU7iu0+wlMXxgu+UCXugXWPXi7pOUat13D3wpxqlfyifAscHMA3C/0bgOQ9vUBggaIDZC7nWrrqDhLgvqN+UOgSPhcOQA0TGeVZ+kbGO3inkje7lTFOlTlgNZXFq9/ZEkmf7i2sivEl7P1P5NykUSb+AIU2A8xa0N2Si+gI5TU+MFH/dE0xyZqTTEhsA2yRmHTsixfrwzCChB8jtj9iZmzmVFx0j6/uHx6kzjXHQIWEY2v7NMC8JKsPLHm1GEai/b9Ugj8CCvb+kIowPi8qe/nw0xUTobpM/Zb14wyEkwhrwTLgr/nJHa3qozT8hs8Izji91KFTvtQTvb+6+nOsz5V4AEgR9MspFO7G/L7X4LpibKuLCb8pNr3wOpI6/IbS+SnKkQvbQUq5KfICofy9KzMPstq6qbhMSOViVZXbMWpNhwCtAXYDbwqjp2R3VVZw3exVzkc9+6RedA+CQieeBTiDBaDEYpckow7hzFF5QrVOY1o3ZxvJYB3SwhBA3BrjeNCcRIE0ouXvEeGuygmt3ZehSTVSVHceRogS9RsfQlc+Trr163p3VIWcPdMnoL4nNRVEOPPGjyNo+QB+T0kD4i4HXAy07X9VDs9OxUySzfuIAObkmFZmlRirNOE6TD4ODpaZho1vuF4meyP9EX1Y8+HTEQ+Usg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5670.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(7696005)(76116006)(82960400001)(33656002)(6506007)(83380400001)(52536014)(71200400001)(66556008)(508600001)(55016002)(66946007)(53546011)(8676002)(122000001)(66476007)(4326008)(316002)(107886003)(9686003)(38100700002)(26005)(110136005)(5660300002)(2906002)(6636002)(8936002)(38070700005)(66446008)(186003)(86362001)(64756008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qTHUkfUVOC/F5iKkIFMtUN9+vWQkLqOzg7PRBy4M939QIX2lJkGfP4c4WqIh?= =?us-ascii?Q?sXNFEWZsVGk4GwojuuK0pvZizkeQEvmhBkqCf+6xyDvMbQFCOMXMPAc8cT8q?= =?us-ascii?Q?FSFQNLMuRu2u5c45XS3HkHXTX03rd0UYjPbmKcI8iPuftmCmFS/6vfk41VNe?= =?us-ascii?Q?v5rt9ylQ+thqwOJDkg/L5k0r2mYbYxXfQZ8xsshQeLsLedqXzdp6+bRftn19?= =?us-ascii?Q?n0Br50jknO25KxYXWAftFq4gmOCg3+TgG0ieKkMzLNcPOgqhWiSr2B2p/kPW?= =?us-ascii?Q?Cpr4k5nJZxQT5/vifM7ss/p7tWZg+kFXxIKGSAsZY40WggA9qD8hnl6Q1bfP?= =?us-ascii?Q?LNCFhe+xguKYdcLd1SIUoUs0wfOn/8aHdtlPBGsvei6KV3zKnwnUM5a1YQsd?= =?us-ascii?Q?CRjwkzFEDzHYnO5TinT1hLSBXIFBOmiy7wjv449ylKjTWkCsCDF2Mawdi5BT?= =?us-ascii?Q?YAaF8PKljsSwHdWxLxoFIxmHlnJTKeBN7ybfOzCWVzcgnlrqQH4OCHcPD8Ma?= =?us-ascii?Q?S+DeYC5jNoN02iulfNLR/f8lxMUxRjQhZtf6Go4LiC6h9dWLL5AbHWjLaT/Y?= =?us-ascii?Q?drtzTA3ABGqq+mHta7Rqm5oytL4UQ9IL8mZLK1GLVdoWkwDT1Jfg38YO7qBn?= =?us-ascii?Q?MGXtKDsk2VS3yNEaJ+KaX6y5dSOQgPs5mNySsg5+DaAWrxs+9Lo+i/j4EGgA?= =?us-ascii?Q?j4AJAr96iUUyw1YFFo139Sz5f+r/K/YSlrhzemg5G2kcoJoO3jT8tRqjbS2T?= =?us-ascii?Q?dD9WXDm69L5iy+oHTTig8NqoRtjbRc4SsoSSFxdUiC5p4OMQqd1aENaOo0OM?= =?us-ascii?Q?7+a8bJC+1H3Sk+VuHbodqhJLOaqxIofW+soAfyrPBeJ/3HkdKyiJt3sHDcKt?= =?us-ascii?Q?KeQsvKvPdW2MLikTRP5AlFPWpWeVSIcAQjyO1K+P1wWwUnE9oLfMqWmurppb?= =?us-ascii?Q?fGVUJlFheotPyt78jO0pM/hbHwlH1Efd2hqMj0ABKKlZM0tNfC26fQlccv0w?= =?us-ascii?Q?8Z1WWUeyAuJP5ah0chl8vesCAd+MjlJUw9tjMgH4bLlSM61c8AfuHp8eCqcf?= =?us-ascii?Q?2VHUWNyhoO2pqRkWXvndyo9tVLkUzu7+gcc5XWzthDOLLJCC0FhTr2KVkpkj?= =?us-ascii?Q?TRFykGMww7AJ4IOu8kZlZFn0cv+fCQgJkHiwENMWPnPBzhrdVBtYDHIiWZeO?= =?us-ascii?Q?pNflfuDySuL6NMV8OCE0oMKc6W5k72J141RmHN1KT/rPXRCHWNNEp2X/6lTy?= =?us-ascii?Q?dSTwnJyNyLrM3bezhQlii4WIOat1I0hY7XScOFHnCaxCHm7qhYnsxbZ6t4vy?= =?us-ascii?Q?nl94EAKCa0Hsvf39wONFBwNg?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5670.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 85dd7967-c707-494f-27a8-08d992faa0ec X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2021 12:18:58.7940 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HIoVfy5ooulTGab84GsbUZ/di8sZKf1i/owTDfJXdoyHHrpdgG/eUZF7ppdx1QJsfSrNvnKaC+niBsKvJzQAqZ9A0sKaC62KM094YVB2igY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5606 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v15 0/5] Add PIE support for HQoS library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Liguzinski, WojciechX > Sent: Tuesday, October 19, 2021 9:19 AM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Ajmera, Megha > Subject: [PATCH v15 0/5] Add PIE support for HQoS library >=20 > DPDK sched library is equipped with mechanism that secures it from the > bufferbloat problem > which is a situation when excess buffers in the network cause high latenc= y > and latency > variation. Currently, it supports RED for active queue management. > However, more > advanced queue management is required to address this problem and > provide desirable > quality of service to users. >=20 > This solution (RFC) proposes usage of new algorithm called "PIE" > (Proportional Integral > controller Enhanced) that can effectively and directly control queuing la= tency > to address > the bufferbloat problem. >=20 > The implementation of mentioned functionality includes modification of > existing and > adding a new set of data structures to the library, adding PIE related AP= Is. > This affects structures in public API/ABI. That is why deprecation notice= is > going > to be prepared and sent. >=20 > Liguzinski, WojciechX (5): > sched: add PIE based congestion management > example/qos_sched: add PIE support > example/ip_pipeline: add PIE support > doc/guides/prog_guide: added PIE > app/test: add tests for PIE >=20 > app/test/meson.build | 4 + > app/test/test_pie.c | 1065 ++++++++++++++++++ > config/rte_config.h | 1 - > doc/guides/prog_guide/glossary.rst | 3 + > doc/guides/prog_guide/qos_framework.rst | 60 +- > doc/guides/prog_guide/traffic_management.rst | 13 +- > drivers/net/softnic/rte_eth_softnic_tm.c | 6 +- > examples/ip_pipeline/tmgr.c | 142 +-- > examples/qos_sched/app_thread.c | 1 - > examples/qos_sched/cfg_file.c | 127 ++- > examples/qos_sched/cfg_file.h | 5 + > examples/qos_sched/init.c | 27 +- > examples/qos_sched/main.h | 3 + > examples/qos_sched/profile.cfg | 196 ++-- > lib/sched/meson.build | 10 +- > lib/sched/rte_pie.c | 86 ++ > lib/sched/rte_pie.h | 398 +++++++ > lib/sched/rte_sched.c | 241 ++-- > lib/sched/rte_sched.h | 63 +- > lib/sched/version.map | 4 + > 20 files changed, 2171 insertions(+), 284 deletions(-) > create mode 100644 app/test/test_pie.c > create mode 100644 lib/sched/rte_pie.c > create mode 100644 lib/sched/rte_pie.h >=20 > -- > 2.25.1 Series-acked-by: Cristian Dumitrescu