RE: [PATCH v7] sched: enable traffic class oversubscription conditionally

["Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>]

Hi Marcin,

Comments inline below.

> -----Original Message-----
> From: Danilewicz, MarcinX <marcinx.danilewicz@intel.com>
> Sent: Monday, May 30, 2022 12:55 PM
> To: dev@dpdk.org; Singh, Jasvinder <jasvinder.singh@intel.com>;
> Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Cc: Ajmera, Megha <megha.ajmera@intel.com>
> Subject: [PATCH v7] sched: enable traffic class oversubscription conditionally
> 
> Added new flag to enable or disable TC oversubscription for best
> effort traffic class at subport level.
> 
> By default TC OV is disabled.
> 
> Signed-off-by: Marcin Danilewicz <marcinx.danilewicz@intel.com>
> 
> History:
> - v1 - TC OV disabled by default
> - v2 - throughput improvements
> - v3, v4, v5 - changes from comments
> - v6 - removed rte_sched_subport_tc_ov_config declaration and map
> - v7 - changes from comments on v6

I see you moved the history a bit below, but still this is not the proper place for it.

> ---

This is the place for the history log. Please note the "---" line above.

>  lib/sched/rte_sched.c | 93
> +++++++++++++++++++++++++++++++++++++++++--
>  1 file changed, 90 insertions(+), 3 deletions(-)
> 

Still only changes in rte_sched.c and no change in rte_sched.h for the API to configure this feature?

<snip>

Regards,
Cristian