From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: "Ajmera, Megha" <megha.ajmera@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Singh, Jasvinder" <jasvinder.singh@intel.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"david.marchand@redhat.com" <david.marchand@redhat.com>
Subject: RE: [PATCH v2 4/4] sched: Removed code defined under VECTOR Defines.
Date: Fri, 18 Feb 2022 11:03:11 +0000 [thread overview]
Message-ID: <DM8PR11MB567070F469F6D3A8166457D1EB379@DM8PR11MB5670.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220218093650.2549927-5-megha.ajmera@intel.com>
> -----Original Message-----
> From: Ajmera, Megha <megha.ajmera@intel.com>
> Sent: Friday, February 18, 2022 9:37 AM
> To: dev@dpdk.org; Singh, Jasvinder <jasvinder.singh@intel.com>;
> Dumitrescu, Cristian <cristian.dumitrescu@intel.com>;
> thomas@monjalon.net; david.marchand@redhat.com
> Subject: [PATCH v2 4/4] sched: Removed code defined under VECTOR
> Defines.
>
> Removed "RTE_SCHED_VECTOR" flag from HQoS.
>
> Signed-off-by: Megha Ajmera <megha.ajmera@intel.com>
> ---
> lib/sched/rte_sched.c | 53 -------------------------------------------
> 1 file changed, 53 deletions(-)
>
> diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c
> index 807134b48d..8ad5ca7e05 100644
> --- a/lib/sched/rte_sched.c
> +++ b/lib/sched/rte_sched.c
> @@ -24,16 +24,6 @@
> #pragma warning(disable:2259) /* conversion may lose significant bits */
> #endif
>
> -#ifdef RTE_SCHED_VECTOR
> -#include <rte_vect.h>
> -
> -#ifdef RTE_ARCH_X86
> -#define SCHED_VECTOR_SSE4
> -#elif defined(__ARM_NEON)
> -#define SCHED_VECTOR_NEON
> -#endif
> -
> -#endif
>
> #ifndef RTE_SCHED_PORT_N_GRINDERS
> #define RTE_SCHED_PORT_N_GRINDERS 8
> @@ -2446,47 +2436,6 @@ grinder_schedule(struct rte_sched_port *port,
> return 1;
> }
>
> -#ifdef SCHED_VECTOR_SSE4
> -
> -static inline int
> -grinder_pipe_exists(struct rte_sched_subport *subport, uint32_t
> base_pipe)
> -{
> - __m128i index = _mm_set1_epi32(base_pipe);
> - __m128i pipes = _mm_load_si128((__m128i *)subport-
> >grinder_base_bmp_pos);
> - __m128i res = _mm_cmpeq_epi32(pipes, index);
> -
> - pipes = _mm_load_si128((__m128i *)(subport-
> >grinder_base_bmp_pos + 4));
> - pipes = _mm_cmpeq_epi32(pipes, index);
> - res = _mm_or_si128(res, pipes);
> -
> - if (_mm_testz_si128(res, res))
> - return 0;
> -
> - return 1;
> -}
> -
> -#elif defined(SCHED_VECTOR_NEON)
> -
> -static inline int
> -grinder_pipe_exists(struct rte_sched_subport *subport, uint32_t
> base_pipe)
> -{
> - uint32x4_t index, pipes;
> - uint32_t *pos = (uint32_t *)subport->grinder_base_bmp_pos;
> -
> - index = vmovq_n_u32(base_pipe);
> - pipes = vld1q_u32(pos);
> - if (!vminvq_u32(veorq_u32(pipes, index)))
> - return 1;
> -
> - pipes = vld1q_u32(pos + 4);
> - if (!vminvq_u32(veorq_u32(pipes, index)))
> - return 1;
> -
> - return 0;
> -}
> -
> -#else
> -
> static inline int
> grinder_pipe_exists(struct rte_sched_subport *subport, uint32_t
> base_pipe)
> {
> @@ -2500,8 +2449,6 @@ grinder_pipe_exists(struct rte_sched_subport
> *subport, uint32_t base_pipe)
> return 0;
> }
>
> -#endif /* RTE_SCHED_OPTIMIZATIONS */
> -
> static inline void
> grinder_pcache_populate(struct rte_sched_subport *subport,
> uint32_t pos, uint32_t bmp_pos, uint64_t bmp_slab)
> --
> 2.25.1
Same title comments:
sched: remove code no longer needed
next prev parent reply other threads:[~2022-02-18 11:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 9:36 [PATCH v2 0/4] sched: HQoS Library cleanup Megha Ajmera
2022-02-18 9:36 ` [PATCH v2 1/4] sched: Cleanup qos scheduler defines from rte_config Megha Ajmera
2022-02-18 10:52 ` Thomas Monjalon
2022-02-18 11:14 ` Dumitrescu, Cristian
2022-02-18 11:17 ` Dumitrescu, Cristian
2022-02-18 11:04 ` Dumitrescu, Cristian
2022-02-18 9:36 ` [PATCH v2 2/4] sched: Always enable stats in HQoS library Megha Ajmera
2022-02-18 11:01 ` Dumitrescu, Cristian
2022-02-18 9:36 ` [PATCH v2 3/4] sched: Always enable best effort TC oversubscription " Megha Ajmera
2022-02-18 11:02 ` Dumitrescu, Cristian
2022-02-18 9:36 ` [PATCH v2 4/4] sched: Removed code defined under VECTOR Defines Megha Ajmera
2022-02-18 11:03 ` Dumitrescu, Cristian [this message]
2022-02-18 10:58 ` [PATCH v2 0/4] sched: HQoS Library cleanup Dumitrescu, Cristian
2022-02-18 11:49 ` Thomas Monjalon
2022-02-22 12:57 ` [PATCH v3 0/4] sched: cleanup of sched library Megha Ajmera
2022-02-22 12:57 ` [PATCH v3 1/4] sched: remove code no longer needed Megha Ajmera
2022-02-22 12:57 ` [PATCH v3 2/4] sched: move grinder configuration flag Megha Ajmera
2022-02-22 12:57 ` [PATCH v3 3/4] sched: enable statistics unconditionally Megha Ajmera
2022-02-22 12:57 ` [PATCH v3 4/4] sched: enable traffic class oversubscription unconditionally Megha Ajmera
2022-02-22 15:27 ` [PATCH v3 0/4] sched: cleanup of sched library Dumitrescu, Cristian
2022-02-24 22:44 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8PR11MB567070F469F6D3A8166457D1EB379@DM8PR11MB5670.namprd11.prod.outlook.com \
--to=cristian.dumitrescu@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=megha.ajmera@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).