From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17F50A0032; Fri, 18 Feb 2022 12:03:16 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 01F4440150; Fri, 18 Feb 2022 12:03:16 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 49EE840141 for ; Fri, 18 Feb 2022 12:03:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645182194; x=1676718194; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=tlWt9r5Gk5W8ca5ZbsTsxdDGq+1/0I9DAAPq30K86xE=; b=RPAzNtN0KY1M7Dn4OQ7+Kax4b6zKdEQ/o6D8bFbojPdxwrsPuUAdGmZt 8xq6ZT2InlFwuByIDAhVbuQoM1jnYgNQspxPJdOGss5HpyaTlnd9E6ubX WJIdNtYLWJuHg0fjjYTepmUfNEvutiZuRUImSGV4xMUdS7QnB/mEvouAP sJmHr9mTHC2x56Bh7yo7sE5NA5CtdU4po8/Yimva00Lt5O7LDchEHJim6 lJjqoNKdgALEHEluIKK8Oj0q8Keu3dqLBNh5DGzAmaUFYcuN81FSnxkFz TQp8ewCrZ5sFAyI+gOuAp+v0jpq94l0G6IV3jQEvDPZiKOQUsZ4cpCllS A==; X-IronPort-AV: E=McAfee;i="6200,9189,10261"; a="238510222" X-IronPort-AV: E=Sophos;i="5.88,378,1635231600"; d="scan'208";a="238510222" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2022 03:03:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,378,1635231600"; d="scan'208";a="505466565" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga006.jf.intel.com with ESMTP; 18 Feb 2022 03:03:13 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 18 Feb 2022 03:03:13 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 18 Feb 2022 03:03:13 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.49) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 18 Feb 2022 03:03:12 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ul4esQ0o4yvCL0GLuyT6wxLbpq9BLIPv3EeuPeJruAMDinGG6VKhK8bc15clnsd2KqgQ4ZkUxyEhRXt1Zy2ocB6/E8YhHd6YqICpOAJAyxlCmqz/IUii1mBHM8yyD+sUo8WeMHQEmZia4RMIJIflYVdn6IbdR2iWu4i49ByUz8wRcvFDhgUliKiJm08gwqHcwrKogDlzsWy6RAX1ddtNb+GO4kR3Wu6NHIX+Wx5h7inWEDCjViGWdTLJTZATIarZXMqscG8JgavJAThBe4UexiMI+DD/uS3J+b05MbuIkN8pA8wFlGS2GZNu0kCcG6q37qqWvF/en/EyZOCK/T0x9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U1TemY9JRSrmCXg2hN8L+LC3pepEHH52GP5fq2Yq/XA=; b=V7HYQSqhiwexdGalmcgqUV/FPwSRKnR4pQHfxMTF/Mrxt//9QK1ZbxPG7tD3x8sEX5P4TnjRVynzHsrWiU0XhpEQez38+S8v2cK440lW1E1ztr3rz6kv6iKX3Lx+euA9iDS1r7bUL/y1iPG4Xsb4b2fAa90Xb8IPhG6dqIJNrQa0fbjDpGUc1t9IOsx4kw96uxR9hB6gjsaDTRTBepsgOq5tHDyLhcMWCBew0M/beVfxrIrfC50C/awUKLcGfxPbMYuo9+Uy3hTU+unzFBj4ey62tsyu9Y5GYJTlgSszLTSkHlup3HRkwOGsVaiKsUigJZ3OrH0i4BlhdJIsrzjN/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5670.namprd11.prod.outlook.com (2603:10b6:8:37::12) by BL0PR11MB2913.namprd11.prod.outlook.com (2603:10b6:208:79::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Fri, 18 Feb 2022 11:03:11 +0000 Received: from DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::e9b0:843e:2b39:6680]) by DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::e9b0:843e:2b39:6680%4]) with mapi id 15.20.4995.024; Fri, 18 Feb 2022 11:03:11 +0000 From: "Dumitrescu, Cristian" To: "Ajmera, Megha" , "dev@dpdk.org" , "Singh, Jasvinder" , "thomas@monjalon.net" , "david.marchand@redhat.com" Subject: RE: [PATCH v2 4/4] sched: Removed code defined under VECTOR Defines. Thread-Topic: [PATCH v2 4/4] sched: Removed code defined under VECTOR Defines. Thread-Index: AQHYJKscwDFvit3hUUu1hqnACBVJp6yZJKQw Date: Fri, 18 Feb 2022 11:03:11 +0000 Message-ID: References: <20220218093650.2549927-1-megha.ajmera@intel.com> <20220218093650.2549927-5-megha.ajmera@intel.com> In-Reply-To: <20220218093650.2549927-5-megha.ajmera@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 75edb509-f7fe-4618-e065-08d9f2ce40c1 x-ms-traffictypediagnostic: BL0PR11MB2913:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:185; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5QkdoZWa+6Nj7zJD4Y+ywrXWk4nn1WbqYlzo+WvCzI6aHecW9N1EjNiBH02/oMX95Xd3VL0COj3oq6BybRVcWJiSKUhcaNa5ZcOTtU5QBnG33YUk6EVtp6kPC3AOE+tTvhBAESevYvwuPtF5CsKlTMIojKxeAAdT2snF8hzbOlHlgYk/yQvbVxZIgvfW1xLsskX10n1ilBti6937JThH3znlgHsx4q3TTk8e6FdHR8Pjz3UAiu/yfm7+ctRjb2F2DwUBLFZldI/D38wnJporTpWarhK5/LnymPz+cB24zZZB7v0EYxKsPwMy+yi4hZdJ5Jrwtv8LBwZwufhHQrJUsUyKxlb/yFkzW09K1GE3sRmcpW2AuLVErFcGMjI5Xy795pEtz9B4ndGeFdOA8gWFfaFlWgxIuwtXeOZhUxRjQcANUruFl8PKptaG6Se7uZW3pbMyQFwEQqM1QbOfqt578DkIl9NL5hLIr6eaZ0NU/2n63CdnjzHMP96up6cmFfonEixtt9IDqhgDpclMHgkN20VlymHNHrEvSzCSg1Yz7negGpVhfoDjhDKSUdHBwYOCgMSQZTx1AqpZKke8GFUlX2uEy377xEjfA7RJwnk41vyNWpQRC2gbsFz/Rg1vJiD5OlnsPo5eU1Px0OF0R7qkkqQ0CCjLILR57mRGBmEd/bA73oPolOh+m7GM/CAEmysi8o1mm19D8UQvXffGgLkk+w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5670.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(33656002)(64756008)(38070700005)(53546011)(8676002)(38100700002)(55016003)(66446008)(7696005)(110136005)(316002)(2906002)(6506007)(71200400001)(9686003)(76116006)(66556008)(5660300002)(66946007)(66476007)(86362001)(508600001)(122000001)(82960400001)(83380400001)(8936002)(26005)(52536014)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?nayiyKM1l/QRYpJxGYnorsjwj6wwqIDl6CykHtVRqogx/Zk3Sww/9cyCDVYB?= =?us-ascii?Q?3NeO9wfK8BLRhlZcxXraRS+edxRYFgzp3XMgeyJ7jBNocGGoh072m+OGOOdk?= =?us-ascii?Q?u5hJ2/zYytrBff2Y1nT2tXPkPUoGLr76XlNFP4MSFiGQPZ72Ff2e5wSVEMkH?= =?us-ascii?Q?1f1VQ4zlqis3HCcdNu6hE2r+QvQL1eHftZ3XOKogIfRHmqzBsjDBrzCs5nl2?= =?us-ascii?Q?7XCdlMhZ+MZiP9CkymMd7m614fJan1COZt0wIfFNwDyzzJZXvjUx96T1K+4A?= =?us-ascii?Q?wrIbfZhAOn6sDhV3ZYL/j4Fg44mY5wotEYqMrVmWMyleZaHravPTf6HiYe8H?= =?us-ascii?Q?OkBDnXqd9yJr2Z9XdSwGloA1rpbRgRqhm3oeV/e6HxjXD3Ei7Wkb9tS6kJJk?= =?us-ascii?Q?NtGIL5oaeTHcsNsuxnjgZt5Dnez7GnHrsaSWuDf9Z4r+0Ud5cxVbfRTjVBMA?= =?us-ascii?Q?pAR8EcHCyy4AONTOWIM06EnswFESBEnET0O41snoheuwwwo+RouoCjNn3H//?= =?us-ascii?Q?NxhJWKThi0SVNk29mPxYU6G/h9tkvFsDHE4U2xhIB5kf7sCgIXO8g+URbQzY?= =?us-ascii?Q?YBS5rg5J0jgshYZBwvu5RFdClT2CQhvTr3GlxAN0BeyV8g8pM7sgzfIX+w8D?= =?us-ascii?Q?huzzc8UABSmzWlOGU57ODrFWD7NIXjM6sfg9xirnwzsbgNQC8sKC+bFkiXdz?= =?us-ascii?Q?QrJ5tzFHeZapneZ9NFR26AjTaVNOzeF3hQAh+ByZJAJqnXXr2bhUDPyYCD9f?= =?us-ascii?Q?nxqfiYJ8uCFCIOwbCjxwfxHgk7SzDawxgrFlctZnuJ+r397yFKL3YfUwzIYB?= =?us-ascii?Q?egxUeBhfdYRkxpCzSBUM1ZEl+3sLqa4OZZxycMUlrkYF1RPUIah67Azt29Jc?= =?us-ascii?Q?vTumB5rBTS/0fklE1FM2CmQ2jvsUTzr51xqkx5ea8dChyT61AKvooJZ97GVD?= =?us-ascii?Q?YUoMHM2jYFW8mpzPclFKo7GFhimJsL8dj/vR8WQq23mVCbLp9NvUil/P/nXW?= =?us-ascii?Q?0F1qmBbFfeHG/52WtwgAvNAjDUPefMAVX6IULz/jrqkxjMwmAxSc3/KpK5tH?= =?us-ascii?Q?k5mxZbDtcBa8zUnSeP+8mkk+g3+ZWTtSo5FjjL2MJWGBXRnxSJrVPdrlA8i0?= =?us-ascii?Q?DMECqoQnXv1y1CgPeDQD7rG3lWJHyQKan2wS3SLQn8A5m64EIA0FBUj+XUI4?= =?us-ascii?Q?XW2IodgEktoRbLWN5WysMAkJIt3PVMtWJV2SK6E0NtwUKBbtAV8NzWzK1y1U?= =?us-ascii?Q?1Q+ovSyk2ROp5+1QOdFB3TNaVfzhlsFhAUZn/OaXOGNbC82iftn96Rk6EFM7?= =?us-ascii?Q?iqwA5w5gtVtYyX2SL2nyFbitkIlFqztBTiw2Fl5EYAp/emsEmhaChWURGLub?= =?us-ascii?Q?eH1xi8ywwgkiDa6zMOmDYk80ClfpwM3TpGHGZDjqaYzBJf+FTr41yToU7ZIB?= =?us-ascii?Q?mKGqXgf09ZFR6bKQdIY5rgEg3HCPK7IzPa55yqdVCrzUABTKV3JhFx4kNaH9?= =?us-ascii?Q?fPUlgr9HEMTw19iBeMr+eyry7QO+GXmWnI8TTcEQu4vzQgGWAFGeSt64KydF?= =?us-ascii?Q?tY4GiBTPxzNNqyCo60V21s1mxg8gtheNzfhJSOQa4zZMNC8l8uBOs/gkUDkR?= =?us-ascii?Q?Ry+pGInd03irMpf1iq2P17g/Q7/W15u45Aldk9wvZ20DxEDr5zPD92DWYjKg?= =?us-ascii?Q?u8bG7Q=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5670.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 75edb509-f7fe-4618-e065-08d9f2ce40c1 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 11:03:11.2643 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EMAOO+XbXwnDctfa0I36ftlkK+GisBLPFkpUDFS+G05n+2p1hHyCzxpMqPn/2un3jbzo54yTDMlpUAZ10TVln9XRzC8XwXEU7KBT8l4gCf8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB2913 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Ajmera, Megha > Sent: Friday, February 18, 2022 9:37 AM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian ; > thomas@monjalon.net; david.marchand@redhat.com > Subject: [PATCH v2 4/4] sched: Removed code defined under VECTOR > Defines. >=20 > Removed "RTE_SCHED_VECTOR" flag from HQoS. >=20 > Signed-off-by: Megha Ajmera > --- > lib/sched/rte_sched.c | 53 ------------------------------------------- > 1 file changed, 53 deletions(-) >=20 > diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c > index 807134b48d..8ad5ca7e05 100644 > --- a/lib/sched/rte_sched.c > +++ b/lib/sched/rte_sched.c > @@ -24,16 +24,6 @@ > #pragma warning(disable:2259) /* conversion may lose significant bits */ > #endif >=20 > -#ifdef RTE_SCHED_VECTOR > -#include > - > -#ifdef RTE_ARCH_X86 > -#define SCHED_VECTOR_SSE4 > -#elif defined(__ARM_NEON) > -#define SCHED_VECTOR_NEON > -#endif > - > -#endif >=20 > #ifndef RTE_SCHED_PORT_N_GRINDERS > #define RTE_SCHED_PORT_N_GRINDERS 8 > @@ -2446,47 +2436,6 @@ grinder_schedule(struct rte_sched_port *port, > return 1; > } >=20 > -#ifdef SCHED_VECTOR_SSE4 > - > -static inline int > -grinder_pipe_exists(struct rte_sched_subport *subport, uint32_t > base_pipe) > -{ > - __m128i index =3D _mm_set1_epi32(base_pipe); > - __m128i pipes =3D _mm_load_si128((__m128i *)subport- > >grinder_base_bmp_pos); > - __m128i res =3D _mm_cmpeq_epi32(pipes, index); > - > - pipes =3D _mm_load_si128((__m128i *)(subport- > >grinder_base_bmp_pos + 4)); > - pipes =3D _mm_cmpeq_epi32(pipes, index); > - res =3D _mm_or_si128(res, pipes); > - > - if (_mm_testz_si128(res, res)) > - return 0; > - > - return 1; > -} > - > -#elif defined(SCHED_VECTOR_NEON) > - > -static inline int > -grinder_pipe_exists(struct rte_sched_subport *subport, uint32_t > base_pipe) > -{ > - uint32x4_t index, pipes; > - uint32_t *pos =3D (uint32_t *)subport->grinder_base_bmp_pos; > - > - index =3D vmovq_n_u32(base_pipe); > - pipes =3D vld1q_u32(pos); > - if (!vminvq_u32(veorq_u32(pipes, index))) > - return 1; > - > - pipes =3D vld1q_u32(pos + 4); > - if (!vminvq_u32(veorq_u32(pipes, index))) > - return 1; > - > - return 0; > -} > - > -#else > - > static inline int > grinder_pipe_exists(struct rte_sched_subport *subport, uint32_t > base_pipe) > { > @@ -2500,8 +2449,6 @@ grinder_pipe_exists(struct rte_sched_subport > *subport, uint32_t base_pipe) > return 0; > } >=20 > -#endif /* RTE_SCHED_OPTIMIZATIONS */ > - > static inline void > grinder_pcache_populate(struct rte_sched_subport *subport, > uint32_t pos, uint32_t bmp_pos, uint64_t bmp_slab) > -- > 2.25.1 Same title comments: sched: remove code no longer needed