From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DD645A0503; Thu, 19 May 2022 16:49:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8092540222; Thu, 19 May 2022 16:49:15 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 3169740156 for ; Thu, 19 May 2022 16:49:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652971753; x=1684507753; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=4/y/7qj3CU5nGaHYEtgpLWS8JfBWExjH0nDYbIYlLxE=; b=GNaeeyX59TsYxcmm5YrM/cXk6R8vwASu9mPk8QLbkMEk+a1Gv21A25xg 31pmPNMRwN0MfIzbgbs9+vzEzK6xTdCbleZOke/xMRYkdPHPDV+RLzO03 HJwyspBo5yjm1qE0Pn8RgpYoKTRolY0WS5aV/yjPd+O3XAxW4fTK1nKO8 Agr/RCYB0qHLT7+Oj4a6ETxgRiD+QJH5+ED8OjlwMwqzzKphd9Tfw2UxS YjtkJrmuNiAOuXJf2p20KWAacZU4ZUEsBpwlFusgqIQSwvYFgVp1yON8b ZxMWKqAAF2T23mDSkb4MN28tgVXwoy9HL+3lUnkbJKibBcRHb2oaxbiRt A==; X-IronPort-AV: E=McAfee;i="6400,9594,10352"; a="272358425" X-IronPort-AV: E=Sophos;i="5.91,237,1647327600"; d="scan'208";a="272358425" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2022 07:49:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,237,1647327600"; d="scan'208";a="570251183" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga007.jf.intel.com with ESMTP; 19 May 2022 07:49:09 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 19 May 2022 07:49:09 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 19 May 2022 07:49:08 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 19 May 2022 07:49:08 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.105) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 19 May 2022 07:49:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DbO9FqQqhpXhtNd4mAKo/9mnds7D84kDtDEBTmmNKcyPf+R1XtLmHnkh7EndisaChXmdh7EM+ffW8P23edAvji9fUpDDq/6TGoh5bdkQ1xPiCrzR4c0ZInU8/6QtW50PEppGZNhaD66ZxaEQ/7S2Lb41HqzRUMUQR5Dg8JvY35rH8IfYAJtehG9hT+XVlQXtC7Rqz1JEjVfrpWmdbOlAGdKctW5GA3MM79kahKzoyWkzfaQuF6+n7wwcdYBnR6NwA0LkEe6mtiYLoVYIqoPUBMXjJITvM8iZGfXN/jnA5TG65lZid6TX0as1Advu0UVfN/eZ8s5qTSPcK4bbEvsBfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2fn3zATbM+d6T0RQxgQIXsgYfkAu+dHcRZELiw1ZtPk=; b=dUpZfcOgZ1q9sBUvLRqV5YpddQvPpQnTfye69wjMCeGJTqu6n7hTAoHTJnLiBgWjI+Yv6t+kff53Ow+o5jrSR9rlOSpeIHZbr4+b3BAQKgK++gRhGSH1Pm2qquMkfYwT3HFX67uodXX8BWOoAl4Wt00JXBlJpcnh534Ktrsoi5+EYR6tUJ4h4UxwSOUV6JGkRedrdCQ6nc4ssqL9SKW4ztKt6oUzW6g+dfcCj5SyQj4EItZTIhDbbNtpuiMfLTKyPSm4srBaroZBXVu2frWGP/wr0ekcod4uwaC9luhmKIPHfR2jvQrso2dFigCXGHFyjMlznRrjKx7TVPvJ3QgTDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5670.namprd11.prod.outlook.com (2603:10b6:8:37::12) by MN2PR11MB4509.namprd11.prod.outlook.com (2603:10b6:208:192::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Thu, 19 May 2022 14:49:05 +0000 Received: from DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::89de:bffb:b66b:516b]) by DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::89de:bffb:b66b:516b%6]) with mapi id 15.20.5273.017; Thu, 19 May 2022 14:49:05 +0000 From: "Dumitrescu, Cristian" To: Alexander Kozyrev , "dev@dpdk.org" CC: "jerinjacobk@gmail.com" , "orika@nvidia.com" , "thomas@monjalon.net" , "ivan.malov@oktetlabs.ru" , "andrew.rybchenko@oktetlabs.ru" , "ferruh.yigit@xilinx.com" , "Awal, Mohammad Abdul" , "Zhang, Qi Z" , "jerinj@marvell.com" , "ajit.khaparde@broadcom.com" , "Richardson, Bruce" Subject: RE: [PATCH 2/4] ethdev: allow meter color marker modification Thread-Topic: [PATCH 2/4] ethdev: allow meter color marker modification Thread-Index: AQHYanDPTIvIKFb2kEO2gv7vvAcT+a0mSRfQ Date: Thu, 19 May 2022 14:49:05 +0000 Message-ID: References: <20220502200439.4100965-1-akozyrev@nvidia.com> <20220518043459.1281590-1-akozyrev@nvidia.com> <20220518043459.1281590-3-akozyrev@nvidia.com> In-Reply-To: <20220518043459.1281590-3-akozyrev@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.401.20 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f6542cc0-4953-4e97-8b07-08da39a6b8e6 x-ms-traffictypediagnostic: MN2PR11MB4509:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gMxgNRqiDCAm2unkh2UrjTwJczrvcSsD8ZgqFmDMhT2w1jQuQ2K8PvE7nX1TlHB8S3k/JvJ8SQ/y7DNTKzZssfwtJWLx3SJkdEmgB8v4PcWYCLnh9BVLs006cDMY2X8dZtqUw6TS/XKHJZBEQ8v7i4aMG7DVPCgSQ5daksqjMAxI2jHrkxPl6uBB9ai890EdIF93eR/k5WpFjCZWC/HTrDLYfnIYpqxRaNTSBkWdBiqEJepah9pOsHERfQQrgbHgUrfUAbGaZB4wHMbDMz5p+/TuOpoBw8oWArtg8SyrYfkah2O19Od2LbSXt3MTfUtkvPGqH231enaKfUe25UpmSqOk2kFQLtOHVmTTMR5LwOTG9bxMc73J4Dso4FuIslRCSkfkQzZ5/13ESyT1R2A9M+Vm2ezFGh32IcQmUQCSQWbhnrlCk0LZpEO7/mLLp1yWgf/3iqx7ixHwebd34QvCb+cOND4wnUGaV72hC603tf9eGDiC9wkhbJYAQX6ytoacvbApGQJkS0daAg+bx7VQrL8ZcHDRHiE9T+OqHGEPdYIy4CZqHAIH0n9l9UFwD8pLGIMcYhm2uoqxxnDkIUi6rm4Bt1kUeUgEhym7v3/rpKXqrf2Wxnwnk9t42OFCWsN5uGEdlkyShVIy2ZDR8xN/Rl6H+2iKdA0n/bJBW/a0hNoO5N+yavMkGIAwX/Pvo45+Pe/ueeBBJjijGoHvIP6eTw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5670.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(107886003)(316002)(71200400001)(38070700005)(54906003)(122000001)(9686003)(8936002)(86362001)(7416002)(55016003)(52536014)(508600001)(110136005)(26005)(82960400001)(5660300002)(38100700002)(64756008)(33656002)(53546011)(4326008)(66556008)(66476007)(66446008)(8676002)(2906002)(83380400001)(7696005)(186003)(6506007)(66946007)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+BrW6tYhNA2pVmOUUxHv4lTQJ0o2k654Ay9zJ2gBezO3OE30nvyzolsGKvie?= =?us-ascii?Q?uWET0i4MeWGWeDesKocXQPyR75lJHADU7OaFhH/Yk0DSS9TtmFB3xDFvOMYb?= =?us-ascii?Q?FB4681i73sWhPHM/c5qphEYZ/2mcq89Gkogc+R2gBV4Cyllkqbk67Bpf/jry?= =?us-ascii?Q?35b7bX7Lh2GwTKSFzamyALZmDqXcMvPXacNN8E+uiaPt02So5eBB1VD7rsEk?= =?us-ascii?Q?swsOcJFxVclG6M/mUMMUeOnNhD9O02+tvwVhwD5dcT79KPKZIhUxZSpugadD?= =?us-ascii?Q?d0QelIxhAGLEAb/ZeMD4QO/hifd2gyQvWQSoEvGRi1oZw7hj93QD5M8CuE/y?= =?us-ascii?Q?FuYaj4YHtMRN7pFkG/VH+NugiPP1tSaIWNmkDLl3TKFkUXhIl5cjcPVDHKGB?= =?us-ascii?Q?RQVWwAGBJwcs4mEFTaTcN3QscUK9XTLbJDoaRYuBNBdoQ4cXrf93kveHTvbB?= =?us-ascii?Q?soYduATiwHV0mDgFO5inMfehINoscvvkIcvB7aECETd4rlUBzEOW8FgfIAIH?= =?us-ascii?Q?/6VriJb4ZkgtJCDmvKJmFTeB9mOuOjka2zvwedKWlsGCtVXvfkPjFgQz0u86?= =?us-ascii?Q?tClAKFfjyAUZEUP0eAK3hIvGaZKVXL0nInLK+k922LKuhB1lRDABMX6aKaDY?= =?us-ascii?Q?Ds+jqlBlCerLLzOTbbDLE+75zaF146xtTvZd28AuCFuukMTfzpt68kP/9kxH?= =?us-ascii?Q?MrTqb6BEmnqjtvKUzXwhywm5jS8HfZ/GTPTg9Otvdc1uPFc4n4dO4clOZvPH?= =?us-ascii?Q?oTW/eubg/JkGpVIkt8conKqvMJ39UyRNDiW7jDB5zzPv+wTyy4g1ss8O+7wh?= =?us-ascii?Q?VKJ6lXLUoxe8KL9N/f2SBfrHEaCZMjRW6VSs1Q5pZyOJT2e0IFgIlijBQ7Q4?= =?us-ascii?Q?OIk9pclv4datuJcJTZgkIm23kgw+o/AIr5j+j93J/3Ugx+fjZ/Mn4AMcc9aa?= =?us-ascii?Q?RrsC+q4y9YGQPol5IheXoSOVjLK+t8w/7NUomGoFQD9OlF/3SLshFk4uNLyN?= =?us-ascii?Q?0a8+mQPjTt0RzrcUjqxhW+AuThNLjKq+XFouZxQQ4jN8GmXvVqwtW+E/S7bv?= =?us-ascii?Q?uo+GccEuhfwuHkmEEGKvSfvOouWMZvnA/Q38BB0PdcqoGak8SeYB35STgp6i?= =?us-ascii?Q?JLkbLJIfzNv9gPwnYb3f8HB37hZfuzfB1RNhJQ9fHIj5961oeY0ZsIFQpSff?= =?us-ascii?Q?NJv7S2kfRQ/Xr4NbfDHwsz8RTyDO/oeb6AiZr9OXX0zZA28Q5cy8Fer8m2jy?= =?us-ascii?Q?fRHKcumXftaNCDEoLdK26Dq2Ih4Ul7GRqPXZKuqJ5WJV4Nc/fHRsDQaQv7Rg?= =?us-ascii?Q?RXUr+MsatoHYaUHCUQYTnUW3oQFx3xecQGAMTyMYEfR0mqS2gXhvZZduJr+D?= =?us-ascii?Q?QEQfJfT5oVnU35NPwlZm/tz4apklRYJX2Uuu7EDxqfj+NJT9qH8p1WiwA/wU?= =?us-ascii?Q?+ZyPOyhPdk0FruymVSoWqdZvGjq61wMeqdvXVAu6egZ1QQhmDMa+3enRp9lZ?= =?us-ascii?Q?K7GmDRQZlXRYtNOgK5XLFYcNuvnxnga6ZMKZfgeiDdFoC60xjcxpcwZokFBs?= =?us-ascii?Q?UjwNLAQqoGQmuGRKluqCifUbucPzY6CyrcRwUjtE2l5Z1aLNJUE6uGPwTWDH?= =?us-ascii?Q?ypok43hlVLTgmyV6Dg+3ha5hzQqczS6dzDSkjPdFtUGTdkRiwHwoozoocmqz?= =?us-ascii?Q?93VqkHCUsWsTZORjP4lVKQY1Yc/GergoLt+oHnpWoWy8BPqpdYRCXnFh0uZg?= =?us-ascii?Q?GmMmwLsCsDKMgljpiEsx5TbtPgfunLU=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5670.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f6542cc0-4953-4e97-8b07-08da39a6b8e6 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2022 14:49:05.5505 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nrsEebEKlmvPxnVk2OBEHTf8hrNTvK293Q8LEpqioC9nDn274+aTbBI5gne2oTETH2m/UT0KDA7yEx2iuy6qll87tstdn/sNMA2A/1ni6eU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4509 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Alexander Kozyrev > Sent: Wednesday, May 18, 2022 5:35 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; > jerinjacobk@gmail.com; orika@nvidia.com; thomas@monjalon.net; > ivan.malov@oktetlabs.ru; andrew.rybchenko@oktetlabs.ru; > ferruh.yigit@xilinx.com; Awal, Mohammad Abdul > ; Zhang, Qi Z ; > jerinj@marvell.com; ajit.khaparde@broadcom.com; Richardson, Bruce > > Subject: [PATCH 2/4] ethdev: allow meter color marker modification >=20 > Extend modify_field Flow API with support of Meter Color Marker > modifications. It allows setting the DS field of a packet to any > color marker: green, yellow or red. User is able to specify > an initial packet color for Meter API or create simple Metering > and Marking flow rules based on his own coloring alghorithm. >=20 > Signed-off-by: Alexander Kozyrev > --- > doc/guides/rel_notes/release_22_07.rst | 1 + > lib/ethdev/rte_flow.h | 1 + > 2 files changed, 2 insertions(+) >=20 > diff --git a/doc/guides/rel_notes/release_22_07.rst > b/doc/guides/rel_notes/release_22_07.rst > index a61a4d77dc..ec83178d98 100644 > --- a/doc/guides/rel_notes/release_22_07.rst > +++ b/doc/guides/rel_notes/release_22_07.rst > @@ -63,6 +63,7 @@ New Features > * **Extended Metering and Marking support in the Flow API.** >=20 > * Added METER_COLOR item to match Color Marker set by a Meter. > + * Added ability to set Color Marker via modify_field Flow API. >=20 > * **Updated Intel iavf driver.** >=20 > diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h > index e3f0e86eb6..817df34ed0 100644 > --- a/lib/ethdev/rte_flow.h > +++ b/lib/ethdev/rte_flow.h > @@ -3714,6 +3714,7 @@ enum rte_flow_field_id { > RTE_FLOW_FIELD_META, /**< Metadata value. */ > RTE_FLOW_FIELD_POINTER, /**< Memory pointer. */ > RTE_FLOW_FIELD_VALUE, /**< Immediate value. */ > + RTE_FLOW_FIELD_METER_COLOR, /**< Meter Color Marker. */ > }; >=20 > /** > -- > 2.18.2 This is not really correct. The packet color is a sort if meta-data field t= hat does not get sent out directly. Yes, it can translate to a header field, but there are many possibilities: = outer/inner VLAN PCP&DEI, IPv4/IPv6 DSCP, MPLS QoS, etc. We need to specify= exactly which field from the packet needs to be modified. We had the same problem for the input color mechanism, I suggest you take a= look at Jerin's patch.