From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91971A0503; Thu, 19 May 2022 16:44:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3ABD740222; Thu, 19 May 2022 16:44:47 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 5AB1540156 for ; Thu, 19 May 2022 16:44:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652971486; x=1684507486; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=q3g4BUvxAL/Kk2K5+yWOI2TPzPX7epROBD6aCIVc3xY=; b=dfsZFAZaJv0UEEMCBVvIlqm2iiJLj8pvarvgHZZAYtVyQ/bHu8IeNpst QjI77uao9RswiNGZOtpLw3+o5WQ23bWGxoSZmfQqxRdOY3uq2ij4mBBU/ erKpUY7l/J68VNUNwUjSc+akQKZ/7ETVEdSGv9pzW2aTf7RM+0PdgoG7c epe425Gdnu8Dm68JjmcX9kTYyk/pXhueN/ZI4yh2U08lB3LNpVAdCgDsN cQxfFbXiexoGS8DrPV8ACBXJZrg/zs/jzmVaBrp0W2a2gAJJnIy3SR/hC NyPPMU8leKN9wCmlpmPPNocsJGs2mIWlP3H0oCxSJ6Wu6bffxGPM9vacs g==; X-IronPort-AV: E=McAfee;i="6400,9594,10352"; a="332853708" X-IronPort-AV: E=Sophos;i="5.91,237,1647327600"; d="scan'208";a="332853708" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2022 07:44:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,237,1647327600"; d="scan'208";a="570247900" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga007.jf.intel.com with ESMTP; 19 May 2022 07:44:44 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 19 May 2022 07:44:44 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 19 May 2022 07:44:43 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 19 May 2022 07:44:43 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.170) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 19 May 2022 07:44:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G54OxoN6wpoGgxtGJl0pGh6iMdP2J8UiuozLpB10cePcXotgZ0RFeiNPYk1iQBMGLQU1j5WPPOxfiJi5BVUO9ViXWxABEqfiku0TmSiiDjzlYMU3b70tbCLRYTLiHS4lPNFJBGR7AX97ijfmnf+E/4pXLo9J0XpqreM6XO/oSwaCaMvkriJvDT99kRucyz/daMOHCD1SgZEJGKwxWgRptFzXfdWgitgUOJuhTXH/Qr+lAKX28VWkFW6TxiHYxL77ABTkZqX8IuIQj3uYJu9adeAodODprd0gWecvKw+FHo4GqFfqGavFeUDTlJqA3780QuUYBq7S6nHw5OVpJpgmdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wb0v7cIlJDAZAOi/hACNiudmVekTISupV9/1tOzGuxc=; b=OvjkcRa0EsDnB6KAWpNNMvWzSMv4U/Kq0448j8DoPGrpGouVIRfIu8mWQMA5Cq2yvsVdG472pyDt/92zQCweHMXRH5l3SnA6KyNeD9sPlqN/4Z1TO8AjKKQ8w6b83Sj07tt/AYmszaSWGpl7NSpi/jxbictnUYCuQZNj0yT1B69jUgRDJSoDhOyXjfUWZl1acTkmN6KVN9D0kOMJzg3oJObDyHD9VbQbIiZaz91njk/Eqod7QmmOgB5NHj36j/CD++KGpVzhn4+YzyfHGXxHmx/sjK/VNRTTVfCeXvK33X86IkdbPplLjZaJB1xde1p3YzpyqslDGxJY39+WwoHUPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5670.namprd11.prod.outlook.com (2603:10b6:8:37::12) by SA0PR11MB4703.namprd11.prod.outlook.com (2603:10b6:806:9f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Thu, 19 May 2022 14:44:42 +0000 Received: from DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::89de:bffb:b66b:516b]) by DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::89de:bffb:b66b:516b%6]) with mapi id 15.20.5273.017; Thu, 19 May 2022 14:44:42 +0000 From: "Dumitrescu, Cristian" To: Alexander Kozyrev , "dev@dpdk.org" CC: "jerinjacobk@gmail.com" , "orika@nvidia.com" , "thomas@monjalon.net" , "ivan.malov@oktetlabs.ru" , "andrew.rybchenko@oktetlabs.ru" , "ferruh.yigit@xilinx.com" , "Awal, Mohammad Abdul" , "Zhang, Qi Z" , "jerinj@marvell.com" , "ajit.khaparde@broadcom.com" , "Richardson, Bruce" Subject: RE: [PATCH 1/4] ethdev: add meter color flow matching item Thread-Topic: [PATCH 1/4] ethdev: add meter color flow matching item Thread-Index: AQHYanC44XSsqa0Z5EGurQJ6ytJxyq0mSMpg Date: Thu, 19 May 2022 14:44:41 +0000 Message-ID: References: <20220502200439.4100965-1-akozyrev@nvidia.com> <20220518043459.1281590-1-akozyrev@nvidia.com> <20220518043459.1281590-2-akozyrev@nvidia.com> In-Reply-To: <20220518043459.1281590-2-akozyrev@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.401.20 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 72b74c2b-a716-4312-8dae-08da39a61bce x-ms-traffictypediagnostic: SA0PR11MB4703:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lb5QZXrhg1td7gKi3Nv2HOMJUl8GS+XPMuEanwwKANa3S3KWd0wy+bsrahEzkCugZM/wjBPlCB6I6H8Uhq581WT7ca+k8MvCFWi0//pQVxHj1DztLE7sWWm1qVkIT0r6kVFf9bjlqK8hDUXbdRlGEHXI0geLBFyUeHwz/ugjRyp1RLTSCqQxiYf1vVz1PnpxneyqiUF2D+E1NDSfBFS0lVrghOhLCkkCSxZYw7jKQYr+42WXWnXLx+PsfYnkIQxTOxiedHj+YVmbRMgdPc9+K9Y4Kk1cosx7hf63D4Tx8vwA3TN1E0HKL4Thgow3wb5S9DHD5kKuzl8rZved3omPkiX76TLBmC3Q4iGiK6bMorTjyoK3HaJNCtuFqw4JYzcjE2/80K5KCYS9UwcpTjzNaem2Lm9ljJc481KlQ6shVBNO4GLN3KRXAV8YQv3/Nse4voVmEIa3Go2ghsAlKebh89FfNQUu+D8ErrteR5FdnTBGmAuQ+Aj5nI2otqr6UpwQZD9AlmdZi+pwxT4GOR1EOvOQ2gdkwsfVxprkEdP6ThVKUpLKW14L5n/Gi4zN06wl/8RZe5MpAvMH+drCW5DFKpFh+2yBz/0Bv7uz++4LZw0ipmPU1tIp27F4IBrE8xsA4eoq5daWNxCe76wW2VkioGyRK/SNpVWZ5eJ7AEVGB0U6uucc2ViuuosmGK9ygrdDB5HlXxE86BHRLq2r0dmeGA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5670.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(66476007)(66446008)(8676002)(64756008)(52536014)(66946007)(66556008)(8936002)(110136005)(76116006)(54906003)(86362001)(107886003)(316002)(4326008)(82960400001)(122000001)(9686003)(26005)(7696005)(6506007)(71200400001)(508600001)(38100700002)(33656002)(2906002)(186003)(7416002)(38070700005)(55016003)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rQaCpgtk0K3WVl5F+O9pnESktdaXAaEh2Ovhos8L+1bUXbr2Ds4lYn+dVRtK?= =?us-ascii?Q?nUBsYCHsZlc8+KwqqWjdnuJxoS64JB1wSgSpXauGyNJlAklhdWKBOhRXoXn3?= =?us-ascii?Q?9P8+fa8p7bRvDpbvr0qYjoeKTwLjKr/JpWVkx8X1OS4iRI1ichKa+LkRjRSa?= =?us-ascii?Q?xMJBNcvymDmgiRCqYMSk7NS1CFhMA/NgEI81gGY2zJhlC7J5fIuJtCZObATA?= =?us-ascii?Q?xcr+DS8Vwhr97TD7J2sM0EMb41mQz3DMuI0ljU+aS8EqI758cyQa4KqZaeBI?= =?us-ascii?Q?A8bvAZSoA6r0Y9Ir/1Mf1OYevp5zjDlMmYNpVEsWv0HVAbghyx0Zdl7o0NjQ?= =?us-ascii?Q?L0HU0TrGhN3Nwz/KGShJpNWersjd5eSqXa8YipynjQLFsaMCFGMuI7TlPrNG?= =?us-ascii?Q?IicUkEe/fAeweyxizsk9VT304KfVcmxK/GGWthb9SKS3RYblP5L7NYOMSEvQ?= =?us-ascii?Q?IVyOU3gd915sRwXPBboVh6zGJKQbawaLS6W9UVl3jrGva9PPb/cXOVKK2tpL?= =?us-ascii?Q?EO1zJmwp77RSFdLSik6PKjdwJ0Cq5PcFyt+PhzTkF+26NYBUdC7EU/SMaVuo?= =?us-ascii?Q?u/eekjPzn9Xb24aW41Q8r5VVS5sjdhQV3uf4U83wqLp1jncrZZ53TBqrwf3i?= =?us-ascii?Q?JrummCowCdzKDBRGXXuyrFWSuEGKO0B5V44jBRw85y1T7lveIM+o4ueHCz4J?= =?us-ascii?Q?Dtyc4Y7ZJtWNx9vqJyEidjnHVtJJYJ0vzkkb0pHawMoaaAx+O2g1fU3EYsap?= =?us-ascii?Q?XymnfJH31qAgiol5JGgViwI4F35JLKkGNKeZ9mklaI//7aK4KxAlMFONSFF7?= =?us-ascii?Q?BoAHHWg6ymQ9hdVKKzNlXaSLBQbIuWzZd3ikpySydmg67hsC8caQqoiBmoSO?= =?us-ascii?Q?oD81WDHl3RcKIPOwPz5qVyU/O0NlpnOcSm+QaWCTxN+ltCKJssP2ip+WbNMl?= =?us-ascii?Q?jphlK7hnmBPez28NjhhZFvVkU+iQzCQjKVCPXLIihjoNjfYMk33QaU6DcczR?= =?us-ascii?Q?n6b7OD4TKgmuQJXpjkfvN2flgdb+dVWkcJm+ZWUZfyikvuP73Y4WTQ63pyud?= =?us-ascii?Q?q378Z9uOG7AUIE0DV3iNurpaoXWlAbQVjANLegK67wtb3T3oMm7YkIqx7y9R?= =?us-ascii?Q?omnZFP5yAQu4DneY6uMDG0OQ7vejP7xBDeQ3y1tQpsp/z/K985lOdQEzikaZ?= =?us-ascii?Q?YtM6zInZOjJ6mgT13GmsL/YEIiNisod8GrrhObH5g/HOB2Wt8B4rKE7LG5DZ?= =?us-ascii?Q?ZAzIAcyfv6E6LGwtQ1tdloSL5Q8I1/syVjaHGM7DzrY8eZsSD7+qVc0uY9bF?= =?us-ascii?Q?7MqdFzJsHK5YVgCXb3g0l9Uuugy9GFiEbXQeliHU87q995ohqvJQq+xh/Zi9?= =?us-ascii?Q?4vdToWRY1UqqdBg+mHK5FCuJ4L25IXMLrDnLiPdxDcn5hv3KsvK+YVcsIWsD?= =?us-ascii?Q?c7qTNU4ARJtJQIhduUeVQSHrygkjI6Jvmf00gpbDBTd9+OpBMNE5wHcP51ib?= =?us-ascii?Q?oW7RJddLbOoKW+lAC5oueNsqgQr+zzQ++dp7AeYAz73cVH441jEWrGEIa3oe?= =?us-ascii?Q?6r+spr82+ALpDXyTH5u18cU5aMFp2Rwyzy8RJEOikk0vF4Z+7OJGQKdQXNbr?= =?us-ascii?Q?QMTv+pRw9jAGuciQ3Ui8nLwFxralojd0ytUm9wjA9DNp98uP4ruqCRqwxFRO?= =?us-ascii?Q?kLml58/EW/sduOKQxeXMqVBn/oHPwFMSQeHmq+OSczoMwxbEDb1GRZ+r+48f?= =?us-ascii?Q?XxnpnEcnkb7vSHHpswnBnXL3///bNzA=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5670.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 72b74c2b-a716-4312-8dae-08da39a61bce X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2022 14:44:41.9910 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bSWPKiijQkSRzrm3+AJ0ntyb8LMChIeg9nzqsMK3RM8PmVZFeMgNCE7KJgiSyzu7moXblgcesnK1INLZpewHKyat91VVXhN+j84Gs/Z6GUQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4703 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h > index d8827dd184..e3f0e86eb6 100644 > --- a/lib/ethdev/rte_flow.h > +++ b/lib/ethdev/rte_flow.h > @@ -671,6 +671,14 @@ enum rte_flow_item_type { > * See struct rte_flow_item_gre_opt. > */ > RTE_FLOW_ITEM_TYPE_GRE_OPTION, > + > + /** > + * Matches Meter Color Marker. > + * > + * See struct rte_flow_item_meter_color. > + */ > + > + RTE_FLOW_ITEM_TYPE_METER_COLOR, > }; >=20 > /** > @@ -2201,6 +2209,22 @@ struct rte_flow_item_flex_conf { > uint32_t nb_outputs; > }; >=20 > +/** > + * RTE_FLOW_ITEM_TYPE_METER_COLOR. > + * > + * Matches Color Marker set by a Meter in the DS field of a packet. > + */ > +struct rte_flow_item_meter_color { > + enum rte_color color; /**< Meter color marker. */ > +}; > + > +/** Default mask for RTE_FLOW_ITEM_TYPE_METER_COLOR. */ > +#ifndef __cplusplus > +static const struct rte_flow_item_meter_color > rte_flow_item_meter_color_mask =3D { > + .color =3D RTE_COLORS, > +}; > +#endif Adding color as one of the match items makes sense to me as well.