From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99E6FA0C47; Tue, 26 Oct 2021 12:02:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5389E410D5; Tue, 26 Oct 2021 12:02:35 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 69B0C407FF for ; Tue, 26 Oct 2021 12:02:33 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10148"; a="216778744" X-IronPort-AV: E=Sophos;i="5.87,182,1631602800"; d="scan'208";a="216778744" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2021 03:02:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,182,1631602800"; d="scan'208";a="486115195" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga007.jf.intel.com with ESMTP; 26 Oct 2021 03:02:32 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 26 Oct 2021 03:02:32 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 26 Oct 2021 03:02:32 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 26 Oct 2021 03:02:31 -0700 Received: from DM8PR11MB5670.namprd11.prod.outlook.com (2603:10b6:8:37::12) by DM8PR11MB5671.namprd11.prod.outlook.com (2603:10b6:8:3c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Tue, 26 Oct 2021 10:02:24 +0000 Received: from DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::c0f1:1135:ceb5:ac10]) by DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::c0f1:1135:ceb5:ac10%9]) with mapi id 15.20.4628.020; Tue, 26 Oct 2021 10:02:24 +0000 From: "Dumitrescu, Cristian" To: Thomas Monjalon , "Liguzinski, WojciechX" , "Singh, Jasvinder" , "Liu, Yu Y" , "Singh, Jasvinder" CC: "dev@dpdk.org" , "Ajmera, Megha" , "Liu, Yu Y" , "david.marchand@redhat.com" Thread-Topic: [dpdk-dev] [PATCH v18 0/5] Add PIE support for HQoS library Thread-Index: AQHXyZQHMC7+q1m5P0+IVHzc0VWOzKvk8rWAgAACWgCAABgE4A== Date: Tue, 26 Oct 2021 10:02:24 +0000 Message-ID: References: <20211020075002.3871469-1-wojciechx.liguzinski@intel.com> <20211025113208.3910951-1-wojciechx.liguzinski@intel.com> <11202335.JZDmDKIj46@thomas> In-Reply-To: <11202335.JZDmDKIj46@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a142b6ca-770a-4311-5274-08d99867b595 x-ms-traffictypediagnostic: DM8PR11MB5671: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3qm2Y+5KYu9SoPz9AXjl8DZWCx1X67jGvPsA54jXE05ijpFKrwVIZIRE2VptG5Lji/lh1NO9eAULG6SXHetYF/UR/snRX6F+WM27/sGiyMq5kM+75DPic5R/ro/MzG47OGtLAfXBpPkzY67ybiv3LeGi2Do5tjgyGKCkhwsG/eWwJImvBt5g4r5p4dPF/lrzJFkQdb5qS7WYhY14i7ZtPPVCwa8NZjmHMpqltzKjHOFHwjj71c0qjG/s3W4h836LHua6svXTl5Z97Jjf79DvX0qVoPY++AyKrjmVFTOTj47we01M2yqayWPyHF5lWXhjka+kAcCtr8UITmsTQ/MTqumcURtYLLrEbwsFj7mu3i7QvWWJxUESZF93LKb58/3XPQJ+Df6L6IwYWDt/Z+PvebaM7vHMfkLnv/dOiGR071Smm0iqoP3cfWhmnz7uEMssG2u5cNLVABc+HdpPe02nm9FCRWipq5b4DI9K0vM8YiHBKiBKVtrDMoqV5gxvUbEUCRrPyyis6ArbOo8RB4OeKvrxySMudwKEkxSrpOpmOesoiyvf1x6JeBEAY7rbzEDyr01zBw78baLsmbf/IZV+gI0dZ4eypCMj8iLCifpTfyQAMxUDxoMnVeHzfBFw0wvAnCVpM4QKBj4uoWWMtSavXDsXmnJO1/5weQ3ofdHeOv+H/4dXoVpA7A9vFe1sHDzOX9K6vWel3cR3c3Z7M21RqGlesJfgywAZlsBTGFGe3zC5NLmsr5F71BBEuFhhvHsViYlYbwTQT3cujlEZsyjMOM66yT8XlxM+tURhI3CX2Io= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5670.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(5660300002)(76116006)(66476007)(4326008)(6506007)(71200400001)(33656002)(66446008)(54906003)(6636002)(2906002)(26005)(186003)(66946007)(55016002)(53546011)(8936002)(8676002)(82960400001)(9686003)(7696005)(110136005)(122000001)(52536014)(83380400001)(66556008)(38100700002)(966005)(316002)(38070700005)(64756008)(508600001)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?K+QTBh2HUcJujCFzkrSvt2MHF6qS85XrwJlQVVXyB4Z22vleAuipZMO3qwCj?= =?us-ascii?Q?C0foLvEuJ0SPuLGSFTij5o4WNQDQWoErHp9dbfifyGFKPuNOqByqmAajLzyI?= =?us-ascii?Q?Mxn54zisj/KUpJexdew8TLuLyp9MfRtyO+N0BvtzewehK8ZP9tD3GZwKU2aX?= =?us-ascii?Q?2WyVsrtJ1oi9Fj73DcQmCK0TeURxwgIItb1QCrLPGdlZVXwjQHB4rDI4lba0?= =?us-ascii?Q?7lrEPZNo1fzw1TW/DYq88yNe/lWJYlwT0J1NfyfqkWodLF3DgOMiabG9cSnb?= =?us-ascii?Q?7IIXsZv8uABrNURx12cS7swoeiLuZ0A+DE8XWtafs1eqRq/s79AeDgGZaWhp?= =?us-ascii?Q?JbRxi+6mqkgqKVBqV0wvQdB1nGqGHkrpT0Qlr9I0QsneAaB4LRbEKiT2o0I2?= =?us-ascii?Q?4zaTNv1N37otTwa3tmSzos2VlS+8KDzEIsaBdfIDHFxHiPhaD3+X5vbtbjVa?= =?us-ascii?Q?2py4BRJ4yDEcIErLIFPXIQ0sDMs7e2JKPlYrtzWiCXHKEgKlin9b9GPPFsFQ?= =?us-ascii?Q?viL0oY2H9jz9yPYLaTLjoMIMkqyq66uD9jFxGGzy1uNPKSrZxBofHxvab1US?= =?us-ascii?Q?oZKJJUhOS8b51PZUzplg9g+MGzOlRlMswUooUYFSgqlITeQ92d/3SCKpbal+?= =?us-ascii?Q?WXOpcPhK6Ask2QzKx9xcVkGO5JPIUD27cWcwJmlSwL6vVbkU34bJkVNsN5Gr?= =?us-ascii?Q?MwTh+kCPBSn4Da14kbyUxhnZ3D/BFJkIgpFffeDtQDEtnM1SQ/8pMoYkgRCO?= =?us-ascii?Q?qXf89o9cOMDla/+6mzugRbmRuK3qN4dSyZbM0LmbNH31NtK2xP7Mv0JI3Z2U?= =?us-ascii?Q?gLGf+tzfEhsQkxNBbKzLAfXak5wwgPGty9UkHucY1JaefSfRTPvBauujt1eH?= =?us-ascii?Q?SSuywXa+APTgDd2oygerTZlVhqaDzZDhzCJfHClzW7WDJ+Ec89iy0kkggeeJ?= =?us-ascii?Q?I0/V9UbF+uN+l7sITRdLxwoQrwP4P30orTrdoLhaMc5KCV2AKaFZr9UnDkVk?= =?us-ascii?Q?6unxHiGHAutEz/tHSYXZUPrMYl/esJNoQNazyF/WVpDDBsoZO/2NjNPc/ZKH?= =?us-ascii?Q?ng8zbKHytLuUVQj2IhUtpamLYnpgLgHebu+vJMy3bLcn4gV4Mrm6VB8+oICR?= =?us-ascii?Q?hKmI1M9de3ENFm+jIamGJSZm1lmZh39FhqZjEogX+td89Zm6LWpLKld8z2uR?= =?us-ascii?Q?wfRRlUe0IMNUiRH4coyHPSe7b6QwIj58QaC3i2yv13re7P8LtKbbDymzcskE?= =?us-ascii?Q?8KPKMnS4kSL9hHx5pcLYthLtYOAF9fAEV9ucCQy/8QCMZ8vo3/9KjaRHxY2U?= =?us-ascii?Q?HfGoi6CRD4PRD6sgNskTcnvYAgubCeD2f802xAk41mOa1vNNB+ad0snxxZRQ?= =?us-ascii?Q?LUAiivqaDuTb9PKfB3Le2WPy6fdZrA+1FZPyZ3zxC/yepQboQ7xWFTMFMvD0?= =?us-ascii?Q?wAOXUGhvUHIuIG+6FEJEptEpvxkAwvqFJtKIIv87W9zwfeLn6Iptmo7p9DVC?= =?us-ascii?Q?OVYPOJSh6xqw1CWZbzYVyMxuh43znuYI870W9K59xsn9Ieu4jBG2HDsGEwK/?= =?us-ascii?Q?VVULx8g/xLRlC5VlX5HqEmqvSKBZkJYQ6D9IMRv3+oc8LLdm1HA9/1rP5GmL?= =?us-ascii?Q?9PGO/eZfjXfylTNzZNwKZrv2v0xU9PSPfpyQtAdOo/4aOmz/Pm27wm4gppQM?= =?us-ascii?Q?3FdnYA=3D=3D?= arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BbkmKkDYmRAi4QcT7ZAm68WnxZNA09SzIubPsWsi8si73WqG6mAHCrYEOQMbXHaMh46vH+ffH6XB2laJxnDn9sH/Jj9t619iV0Y0PmLe3EYVZxAqDzyDE2z4KNZr+ivC6BgK1319gFZqt+yWKdSDae+22qQEy24irrWAj+ZzyYqHh8P6/nocK8YmB4+Ql4f/EXid/1oeXTjneRzNidp/Yc5auEstb007t0PtTo7/7B44anECEaXQEACGglu9PZU5jOqssjqS8iG7ZaxNJjp27sSK2P/ivc4Ww7hRGjl+SiFLFnD51hkf7FG+6+9HmrmAhv2O/YdNCK0JU0wePjQkMQ== arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/1pCTbwCeDibd0QDit03p+qARWMW9lIm3mT3ULBNyKM=; b=PZEnLSHdssTH4oxNoiXFD1eDoipWVcNn4nIKEEz++wt1hFELEESNfgnikW4ZPcp8maLDmRFRf9BALe9cuRWlIK8SDVaOf1h/2yrUwSbJ8BgoPR+Em8xnO/A39GDePSg538oOLv9WMetBg6ks49YjJTsTmo7layHA9LS/570N+aVNwbs3opRLjtbjNfT1T9ab32tceubLYXBBp1TV1ovzi86MJk59RONWKxFKD4oSbyW+aw5Ry8UZSmRbpozxkUIv4nbA4wEcZynWtXEqG331IdfftANF4ee6y58b3Mi2XENtajF9565VuD47iOjgEXmFxKJIF20eQ2MkebKtPuFDTw== arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/1pCTbwCeDibd0QDit03p+qARWMW9lIm3mT3ULBNyKM=; b=dI2ddA0iB8fb+sNVyJrc6O8T/Tf19z+AMvIwhyMVqBLJXqupcC6cWQWt+tQvT9VP9b+kMyMNMyGfMGRcHkSJBos8PBtii2uL/adbkEjdBwQEONrKD7O52KhumBgo54tQh/y12MN8L0l7AbE5n8/8c19CFb7sTbDYekBXDFXiIlo= x-ms-exchange-crosstenant-authas: Internal x-ms-exchange-crosstenant-authsource: DM8PR11MB5670.namprd11.prod.outlook.com x-ms-exchange-crosstenant-network-message-id: a142b6ca-770a-4311-5274-08d99867b595 x-ms-exchange-crosstenant-originalarrivaltime: 26 Oct 2021 10:02:24.3976 (UTC) x-ms-exchange-crosstenant-fromentityheader: Hosted x-ms-exchange-crosstenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d x-ms-exchange-crosstenant-mailboxtype: HOSTED x-ms-exchange-crosstenant-userprincipalname: kQeZ8jp9L4LUvnSccftHCT5aUAuXS1dHcoC7tRKf/Jlfx87WjRbS6Sp0CfRuSA26xCU/TEe5Q9FAo3eWTllKG7lUvyno4j1JZRtNwRIMgHY= x-ms-exchange-transport-crosstenantheadersstamped: DM8PR11MB5671 x-originatororg: intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v18 0/5] Add PIE support for HQoS library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, October 26, 2021 9:33 AM > To: Liguzinski, WojciechX ; Singh, Jasvin= der > ; Dumitrescu, Cristian > ; Liu, Yu Y > Cc: dev@dpdk.org; Ajmera, Megha ; Liu, Yu Y > ; david.marchand@redhat.com > Subject: Re: [dpdk-dev] [PATCH v18 0/5] Add PIE support for HQoS library > > 26/10/2021 10:24, Liu, Yu Y: > > Hi Thomas, > > > > Would you merge this patch as the series is acked by Cristian as below? > > > https://patchwork.dpdk.org/project/dpdk/cover/20211019081902.3514841- > 1-wojciechx.liguzinski@intel.com/ > > I didn't see any email from Cristian. > It seems you just added this ack silently at the bottom of the cover lett= er. > > 1/ an email from Cristian is far better > 2/ when integrating ack, it must be done in patches, not cover letter > Hi Thomas, I did ack this set in a previous version (V15) by replying with "Series-ack= ed-by" on the cover letter email, which does not show in patchwork. Is ther= e a better way to do this? It would be good to have Jasvinder's ack as well on this series, as he is l= ooking into some other aspects of the sched library. Regards, Cristian > > > > > Thanks & Regards, > > Yu Liu > > > > -----Original Message----- > > From: dev On Behalf Of Liguzinski, WojciechX > > Sent: Monday, October 25, 2021 7:32 PM > > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > > Cc: Ajmera, Megha > > Subject: [dpdk-dev] [PATCH v18 0/5] Add PIE support for HQoS library > > > > DPDK sched library is equipped with mechanism that secures it from the > bufferbloat problem which is a situation when excess buffers in the netwo= rk > cause high latency and latency variation. Currently, it supports RED for = active > queue management. However, more advanced queue management is > required to address this problem and provide desirable quality of service= to > users. > > > > This solution (RFC) proposes usage of new algorithm called "PIE" > (Proportional Integral controller Enhanced) that can effectively and dire= ctly > control queuing latency to address the bufferbloat problem. > > > > The implementation of mentioned functionality includes modification of > existing and adding a new set of data structures to the library, adding P= IE > related APIs. > > This affects structures in public API/ABI. That is why deprecation noti= ce is > going to be prepared and sent. > > > > Liguzinski, WojciechX (5): > > sched: add PIE based congestion management > > example/qos_sched: add PIE support > > example/ip_pipeline: add PIE support > > doc/guides/prog_guide: added PIE > > app/test: add tests for PIE > > > > app/test/meson.build | 4 + > > app/test/test_pie.c | 1065 ++++++++++++++++++ > > config/rte_config.h | 1 - > > doc/guides/prog_guide/glossary.rst | 3 + > > doc/guides/prog_guide/qos_framework.rst | 64 +- > > doc/guides/prog_guide/traffic_management.rst | 13 +- > > drivers/net/softnic/rte_eth_softnic_tm.c | 6 +- > > examples/ip_pipeline/tmgr.c | 142 +-- > > examples/qos_sched/cfg_file.c | 127 ++- > > examples/qos_sched/cfg_file.h | 5 + > > examples/qos_sched/init.c | 27 +- > > examples/qos_sched/main.h | 3 + > > examples/qos_sched/profile.cfg | 196 ++-- > > lib/sched/meson.build | 3 +- > > lib/sched/rte_pie.c | 86 ++ > > lib/sched/rte_pie.h | 398 +++++++ > > lib/sched/rte_sched.c | 241 ++-- > > lib/sched/rte_sched.h | 63 +- > > lib/sched/version.map | 4 + > > 19 files changed, 2172 insertions(+), 279 deletions(-) create mode 10= 0644 > app/test/test_pie.c create mode 100644 lib/sched/rte_pie.c create mode > 100644 lib/sched/rte_pie.h > > > > -- > > 2.25.1 > > > > Series-acked-by: Cristian Dumitrescu > > > > > >