From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7599A0503; Thu, 19 May 2022 16:55:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B56E040222; Thu, 19 May 2022 16:55:13 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 2961A40156 for ; Thu, 19 May 2022 16:55:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652972112; x=1684508112; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=5zhXXneXnlLOhPN3g8O5P0vbvD4zdHeloAKCeqTl590=; b=IRUrk46PFkBv1KVOJoYp4Xk86kzm2s56OAI306co6n3MMkHTfTVjFRvN aK1bUZIJvhUHe0cHnkZZ43a/zDzRqjfs+PPjxnONM2KoyTOUoEBNoF6eV 61T37jSOpMCBPmiBFPWHca3tYDtGiS1DcPwr1MNCWuFVk2mlyq8Np90C3 QJv3cqODB71vS3MNgyDgaEevntSyZmLzxlnxNSG2vT/Q815U5+FMo3qRr wZ0nHCryQ1KEMkQsJ5XRqriAYUKs/43bwzZGOPbmpq+Bi/mTPENAUnSFa 6sFfcGh7pIqisj0azQg9JeW98isvJwJuQIoFvPsDrRbYxVQATe6fEKUxf A==; X-IronPort-AV: E=McAfee;i="6400,9594,10352"; a="271053769" X-IronPort-AV: E=Sophos;i="5.91,237,1647327600"; d="scan'208";a="271053769" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2022 07:55:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,237,1647327600"; d="scan'208";a="570255695" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga007.jf.intel.com with ESMTP; 19 May 2022 07:55:10 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 19 May 2022 07:55:10 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 19 May 2022 07:55:10 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.48) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 19 May 2022 07:55:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=At/WccnxyvlowsfTzqs1785Nyba+iHla0An/knhfxHi/YT1RQwiE74R5H9Ppr0E1xbOk1M2jOK0g0ZPsdIjqFMhalrxWQfJm4Fm9G6fsz5Mq8A2UhOmDEewYoszTXaWXk9xc2JU7EEWxwarnlHzn7fNefg80y/9viPKHqqCCFTeKk3CMSM5UQilsZX+xiVjDpYNUEVbPqueHJyRBTq9leIteKvy1FSR1fF8BOyzFElVFFjEKyH9ac/r2E456TxSTT1kpXTDzWi10XSvC2HL2qWO0OQOH2M7Hc20qdDwisNI1zmKBjqNyIsQP8kq2T/w7BWXqrSEokEwfvDcj4n+E/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=le37038DNAUtATCCX/EyJyoA+nrHycSVdXyCm5p+kW8=; b=Pw/Sfm4MRJE9dva8dNlyD4bUWSXrF1MVQIkGaosSA1l0DwcGSZWCeokS04Sj86w0qUpzlo885bh1Th0Ikwm4oGQxUXlG27a7Q2ql88p5IZ2SNdNsYDE6xm5iy8rMCKulHCPeAMRsd8iMid01/D/dDJMMEJ6vegFiMCnXLX8UYqp4uW66FSXxnRTd7lBjHYj3PukDZHfA5A8yv8P3pX88yuTPqXjO2ddGy5o0RLttfp1aP+n13/q8w4SWEtiE0jkXbSAncrV8VjFlOdF1oh7Pa4OoW+rP8V+duA0D53At0wPjxj2jgjZhrbZpgLteXCPhhQ2rKfgaMZ9QTXqv9uw+9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5670.namprd11.prod.outlook.com (2603:10b6:8:37::12) by DM6PR11MB3291.namprd11.prod.outlook.com (2603:10b6:5:d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Thu, 19 May 2022 14:55:03 +0000 Received: from DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::89de:bffb:b66b:516b]) by DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::89de:bffb:b66b:516b%6]) with mapi id 15.20.5273.017; Thu, 19 May 2022 14:55:03 +0000 From: "Dumitrescu, Cristian" To: Alexander Kozyrev , "dev@dpdk.org" CC: "jerinjacobk@gmail.com" , "orika@nvidia.com" , "thomas@monjalon.net" , "ivan.malov@oktetlabs.ru" , "andrew.rybchenko@oktetlabs.ru" , "ferruh.yigit@xilinx.com" , "Awal, Mohammad Abdul" , "Zhang, Qi Z" , "jerinj@marvell.com" , "ajit.khaparde@broadcom.com" , "Richardson, Bruce" Subject: RE: [PATCH 3/4] ethdev: add meter profile config calculation Thread-Topic: [PATCH 3/4] ethdev: add meter profile config calculation Thread-Index: AQHYanC6Iv2mUGP/NUCDUtBlrUesia0mSoRA Date: Thu, 19 May 2022 14:55:03 +0000 Message-ID: References: <20220502200439.4100965-1-akozyrev@nvidia.com> <20220518043459.1281590-1-akozyrev@nvidia.com> <20220518043459.1281590-4-akozyrev@nvidia.com> In-Reply-To: <20220518043459.1281590-4-akozyrev@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.401.20 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6f7b13d8-dfb4-4455-1c61-08da39a78e28 x-ms-traffictypediagnostic: DM6PR11MB3291:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +b/dn2NAfh24egmyYoo7A/pnpkD3xytLHSPUTbB/BuBLKLPmFw9X2sihChqQ0ZM3cW/QCeNPFTSK1wacUBVa0RXD1W/WeOeAEbfqdxmd7XHO/g8rDPe4ewSKJgCBZ9m7Qs6n8s6uPXM+NFstXCDFn+2g+mmSkq9I0gagrdkEd+CVSHLVg3x5hpwQbFN+RV8zf/oHmHH1xwUa7GSr9afiJZ33/kQdmlSpx/NZYiqR1UNkFbu48FY1xXBXogMrrAdhSN0IbbnJqgkTMzELuVN8zO5GXSalIMVcKFB0ohg5RjkT2wH+fxfLOooK6XJqSQVVkJkkAAokUoAJ4hjM4ITM9WAZdnVc8wp82pQuxVvQQ9BJ32hX+fLByEtY99cCF89KgZNEl1Ctm9aa3qu6nPO/WQUWRXTn3T3gvrFr5cYBDjznvfRcjBZJnalKRcE9tHcazO7QfDCyXGCh7BaqILW0toWi8QOiyUaLqLY8V88b0zZsOl0ZFNaGdPSM+NTXTbw+F5bwosriTg+UxKEyyqnJw8s8Q3jy8q9pfqQBNS2IZlEWqeZLf7XkSEuuIoFZZEuUmk2ADPQmlS95LniX0db+Q9xIc5rUtfCUn4r8OqAmwHwKduQqQ9GYXtkoxWitI6J/wGlFzt1UUftRZBTzP7wYROJggj0gzF5Nd9M3xVJurrEmk7LIXV4sNW8lkaSN3z0LvXBg1+Vg6TyjP6iqYSn/yQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5670.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(8676002)(52536014)(5660300002)(83380400001)(82960400001)(76116006)(33656002)(66556008)(38100700002)(38070700005)(7416002)(122000001)(66446008)(508600001)(64756008)(66946007)(8936002)(4326008)(55016003)(2906002)(71200400001)(54906003)(186003)(316002)(6506007)(66476007)(7696005)(9686003)(26005)(107886003)(110136005)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0KB+GK3ovQclu1EY3jG8GH35DMPdE/TFn+CCsX2b+1uDXXXFibWZfiGgJlvv?= =?us-ascii?Q?Nrm1FDVjGAEYg81qBQKiiZUlH9k5j41l/iBl9cuyDCIE0uhWAtxgZ2f09uLJ?= =?us-ascii?Q?U9p3GK9mmNhWmXYr7bUnYJ527+Uhb/Sd2cuIOytA3sG8JlTVbIoToOibyqfV?= =?us-ascii?Q?MQc6TuDP+1UkOydCyuCG8S9Qlf/OaqmyFROKIqBNKjUE9A2rt5P9xzLzucKU?= =?us-ascii?Q?/sS7mKv3gfmAw4+sXFWT4f+zeAqwxuyDifp8TnsIawJw0QmKkw1bkFFKsCCX?= =?us-ascii?Q?NxO+gX6a6AEFKZXjz8NrSmAUGUl5J550nYcs/G2MfFZecapQSQbGFFIhtBh8?= =?us-ascii?Q?sq/sOWDTVX/QW4q2Hyo3bDj/Une+y0rkRG8dzzdPL207NZaLzxZJKo19V1lt?= =?us-ascii?Q?yfbxJFvAnCzzlqJLzgirHYPFzzn2VTbq/LnDC/Ypw+iPncUMFcSLWx+3C1WB?= =?us-ascii?Q?og1a8RzwGkjMQbyneLQkNRHXjvkvP58w4bDOjkSVfHaVcqjlOELoMhGdfqAG?= =?us-ascii?Q?xisB18xo8GAKZf0Il3AbXZ6GjEYR90rG9anO2vUuULHDG8Fl1l0ISOPosOaC?= =?us-ascii?Q?DZWzwd0tiLwPEXxmKGB4C9IUJi+1LWU96n+KY5BqBBhqMf6W755gmTiT4Vaa?= =?us-ascii?Q?CXUNyeqJvXMcmWs7iys/D3aatg8XIfhXzZ5g8+R7TFkFnRdU+InMM0T9/CST?= =?us-ascii?Q?BEC2vhzS/uvo6aQRfCPAMPPJthIvD5RS2faC4ccq2H5HVkMnaoJ5KvHrrl+B?= =?us-ascii?Q?YwfEw+oP3weYxe5KhuO42bulhf5aZWBu6kjptNe4eMEjMkoEsaVXsaImYggJ?= =?us-ascii?Q?8cgbCZAQ8HXjg6Kho1eYx/UP0QNu2vwZKAKNLrM69B5ACtzXToC9DygqikSZ?= =?us-ascii?Q?WsHa8Nc0nrR1jmIQEInybnPzK3ujsexTBwRKeJHsOF19ZBDTLwePWFtJXtTP?= =?us-ascii?Q?ma1+t69zghjE90Ir0fFlDfcZ6SQ0gz87Rg4s/RQWg7JCUGmMzzGQmja2I6JX?= =?us-ascii?Q?nKHl9qKtZx/CkEmC1WkMiHW1JnE4yXHD8H9HzzYzzDNfTewG7dLIBxVQkyvH?= =?us-ascii?Q?6ftcKjFIZiLZWDaCj5S7cdl7F5toZzKw+icmO9YwinuEeh8fX7YG5UTzRlXe?= =?us-ascii?Q?QMXZ2ifxXtl6ghh+Q2Hh3VZEOMdPkHIBbC3BOk/7WNc7FCFSOmFh4Yx00kRS?= =?us-ascii?Q?Rt9m0ix56wYsxI/V/kUU7fmwkPbWebYElmaDnd48p44bdlcjA0cA9kjtoc40?= =?us-ascii?Q?I0cxFFezegr8NtBOqIG0uR3Y7P0CnA2LWUNOX5TaQa3qA02yQBeL/4F1iuWz?= =?us-ascii?Q?h1/ihSdm7rRX4JmdtUiftxf5e1oKpQqMYN3ZRozwyHqMUZiqBfIXb5fbBsou?= =?us-ascii?Q?lsLVQ8Zxhb2qJbCYlUeVmxRvuhens9Vc+bGh7LnxYXeI4UeoGT2RY0+QhWQz?= =?us-ascii?Q?uit34eNDdEzMTuMQ5GIPcQs3Bzel1ByxYoAK+d4buJpAp2W8bPVji+SVt4xZ?= =?us-ascii?Q?LhQmNm2NrXcp28l1sR7z1qRorp9QkUEVmtPh67G1H/z1jeYJjBBe2UsBIeFj?= =?us-ascii?Q?A50QCRcrY/O2NL18FZesGJ7Mu0FNHI7JlIZoPupkqwNoRu28Z0VuMhH44KpY?= =?us-ascii?Q?SodLtTkaTrslKxEs37XTO9Z//FAqlWjbOl6Y8DxqmpNSlyrAg1KOe5W3ftbn?= =?us-ascii?Q?j6OSknVIBbRby1sxGJx/5sohklK0uscazdoNanAm5rw0CtxB1NiC8z7BBlVM?= =?us-ascii?Q?H1sm6TINmPuuPg/dGXJ43gjBqzESVYw=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5670.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6f7b13d8-dfb4-4455-1c61-08da39a78e28 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2022 14:55:03.3505 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 40yl+xcRAqNdDlFgGV6V5X85X6eDN9Zx9ev/2DPTgJrkUgxYE1bkLV2wFGqeBw9gHVrG1Zv2ynAa5aYakS9gtl8RmTlrCc64kqoIEyppI6Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3291 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > diff --git a/lib/ethdev/rte_mtr.h b/lib/ethdev/rte_mtr.h > index 40df0888c8..d7b916b168 100644 > --- a/lib/ethdev/rte_mtr.h > +++ b/lib/ethdev/rte_mtr.h > @@ -524,6 +524,30 @@ rte_mtr_meter_profile_delete(uint16_t port_id, > uint32_t meter_profile_id, > struct rte_mtr_error *error); >=20 > +/** > + * Meter profile calculate > + * > + * Calculate CIR, CBS and EBS values for a given meter profile ID. > + * Convert user-provided values to PMD-specific configuration. > + * > + * @param[in] port_id > + * The port identifier of the Ethernet device. > + * @param[in] meter_profile_id > + * Meter profile ID. Needs to be the valid. > + * @param[out] meter_profile_cfg > + * Meter profile configuration filled by PMD. > + * @param[out] error > + * Error details. Filled in only on error, when not NULL. > + * @return > + * 0 on success, non-zero error code otherwise. > + */ > +__rte_experimental > +int > +rte_mtr_meter_profile_calculate(uint16_t port_id, > + uint32_t meter_profile_id, > + void *meter_profile_cfg, > + struct rte_mtr_error *error); > + > /** > * Check whether a meter policy can be created on a given port. > * I don't understand the purpose of this proposed API function, can you pleas= e explain? It looks to me that you want to have an alternative way to create a meter p= rofile, so why not use the existing API function rte_mtr_meter_profile_add(= ) ? It does the same thing. Also, who allocates this opaque array meter_profile_cfg? Assuming it is the= user that needs to allocate it, how does the user know its size?