From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 68CE9A0547; Mon, 21 Jun 2021 18:56:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D4D7741158; Mon, 21 Jun 2021 18:56:09 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 79B7C40040; Mon, 21 Jun 2021 18:56:08 +0200 (CEST) IronPort-SDR: dXDj2PDWtHob7ZqPLdgKjYawJtBtLVOcjTfOWjD9eNlxWByzXfhD70YQJEdmT6nJgh4ihhUHKv TbEhNIELbozw== X-IronPort-AV: E=McAfee;i="6200,9189,10022"; a="194023789" X-IronPort-AV: E=Sophos;i="5.83,289,1616482800"; d="scan'208";a="194023789" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2021 09:56:07 -0700 IronPort-SDR: 5whpARK5DakilkMUUwY5vD4UL2akTJxytU1uEQZFEP+2xWAx6IGl7DtWCg9XxTcf6xmAy1SuUm /zisQemomNAw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,289,1616482800"; d="scan'208";a="406020093" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga003.jf.intel.com with ESMTP; 21 Jun 2021 09:56:07 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Mon, 21 Jun 2021 09:56:06 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Mon, 21 Jun 2021 09:56:06 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Mon, 21 Jun 2021 09:56:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CE380vLLbhARLMLfLo4y36rX1+k5xVc+IukETJKD4yDL2EDsoifg1g2cOGC8Aob1OhIiWAazYU/pOIp2dF0cTaS4lQxiW67GUYAFjHbNWSqRtkhIasx/9vnVSkMeghi/xCw5ymGcXWB9L1bU1z1r8+NNpq62+DKaWYJVMYB/ibR079BXJxJFeTjMgb3sgsiZBxvZjs/9WNcftC8HwuJu6jbeL5IGnuy7mRUi+QJ86sQa6eAxZ1c8DLESRREdmxw+Yvwf/wWlLg8di9nB/X1/oqlxM86Y1QkQcsPmsf6bavIcx6uX5mqK5vicT1P2fk/wp+kghoAZrIsSTjJ4qSWcsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s5ETRpT/vn38cGlvUQCL6n83koBwQwdtcV5AzZAA6hs=; b=Loe624t19I56roGUyWo8vG9LuAOM7NWVyMrraw6PcoA9w9NbWWRyrqAmKjSghtSzGLEWSBg+Mr8OVcjYR++ADB/zXYVIp4m1eEXMWhvOlvcx/iUsVJUxgmm9BO5F8HgzQws+kR7n/nH/9FE5GrjCJbEuR5LdP9nNbFTXMPOg724pNFisGrhGP2iJwvPnoJX7M6BbL4Iy2bEv+IlblavlWGUxHlIqF2w8+3yg77JqdnJUyp73k+B74gZx+5U093UJKuArDlzxF0dH1KmWjQmbiFi5PqcwMXFBNdxKNCEPN/TXZ8PgeNkoD1tGB5v0//kv8YLsDPNW3xQoI4NjKv3zAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s5ETRpT/vn38cGlvUQCL6n83koBwQwdtcV5AzZAA6hs=; b=rnt5lOY+TZR57H7xZ7JZ7g6CtMZMp3d9+hSsP0sBr2g43EPDkRelMDpC+D8RV/3/TZ5YRjkfqB5TaJ15Peg3MJAKq4U6N00N5zKrSDPE8bujzfib7NvxN1YIp11A3zwISpqUZYH9cdGRhRMzmCN+0wi0NjRBRLbwqoDhDVuIKak= Received: from DM8PR11MB5670.namprd11.prod.outlook.com (2603:10b6:8:37::12) by DM8PR11MB5639.namprd11.prod.outlook.com (2603:10b6:8:24::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.21; Mon, 21 Jun 2021 16:56:05 +0000 Received: from DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::e0f9:356e:4e86:85b9]) by DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::e0f9:356e:4e86:85b9%3]) with mapi id 15.20.4242.023; Mon, 21 Jun 2021 16:56:05 +0000 From: "Dumitrescu, Cristian" To: Thomas Monjalon , Thierry Herbelot CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-stable] [PATCH v2] table: fix typo Thread-Index: AQHXUI/9ZE9ZEBe9tkWB87H3KQvEVaryfwcggCVs6ICAAAMEAIAGamIwgABw84CAAAWtAIAACz0g Date: Mon, 21 Jun 2021 16:56:05 +0000 Message-ID: References: <20210524085341.15184-1-thierry.herbelot@6wind.com> <786a1730-37eb-8f22-7812-74a8a7096dd9@6wind.com> <3815134.CEuO83SSsj@thomas> In-Reply-To: <3815134.CEuO83SSsj@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [64.43.147.100] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8f078879-4199-4c5c-b730-08d934d5759f x-ms-traffictypediagnostic: DM8PR11MB5639: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NbFsMSQl3QJxRxYiCsXXW7YBYm79YHd9nizJ75Jm/W7oJdRlKsr2W9SbwKrxDiXwX8KjbhGRqvX2cyfGhndCr1Jxz7kJo5fd5kegHdHg/nnKggDMJrotmjvYVXdQeSjuf6MIWERLJaUzkw2NPuEX6aNZdgj/nl6mhcZMUn6pOuhtO8ot5cXUHuTj6WG+u8L3bFJjMAphAjRtn4jWTs2DxSSYdpUyXWnt/dPzXAm9kBo9WXqEGv3iPgk9rc8uYAMJ4gEEq1cVOHoa/q9ovfWVsY/anhvol34i0/+LloDRoPyWZAIHy9fr3AsePLupUMTeBbYbwFqjBupEcHdGDUxQIg+UQ3S77jUElZt4w3ow9W4JhHHvrYitHKkAIzt8bu3e46GfsndeHh7n1h785+hAt09KPlac6v1gBuTenFuLKh1PcLVfJ4UlxbYYvzxF/uzrG/RMUSHOv54yOFq99haQxaPGqn7PdOFWeqrlyv7VwsJaUTCsyJuKewEk2ZQ42VnGo1D02jITuEzaX3B2b3MkT0yPTwiIz47S8ewjpEGgiuZSbyFocvPo9NIHe+mNUIRT6+66opK1MeG8HoogbGYkQuv0+x6g0eA4RrbvMklFVxQ= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5670.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(4326008)(2906002)(76116006)(64756008)(8676002)(66446008)(6506007)(33656002)(7696005)(86362001)(8936002)(66946007)(66556008)(66476007)(53546011)(186003)(55016002)(26005)(54906003)(38100700002)(498600001)(122000001)(9686003)(71200400001)(110136005)(52536014)(83380400001)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bGfdp344RFDleCxQaU2GtKIKBIQTMQi7WzANl2ItRz9rYcNXsyV8lgDog6Gy?= =?us-ascii?Q?DTGMqnZsbNPmRr6tSz8gNpf/w4ihYNoqie2qO3puLbimrh9gWBfi46r7fYii?= =?us-ascii?Q?aw6ExbhYKqnYce/LtMt3467oa24mZfY5rlUcJyV3gRQiB+8O+PPZK+kOiNUZ?= =?us-ascii?Q?VRzJuPjlNOWHQWiR7Q6POhFmlsw1c0VB/2C2nVzsExdyjdcOLaniHzy1y7fq?= =?us-ascii?Q?7J4Yn5RIFL4aEHMCGiY88LPcC9Cir6JYqPG35Z3qrqBwhffnVYQlTUBYGT+O?= =?us-ascii?Q?YEPQe4DW8Qbf5bfMZtd/BpYRgLuNuEUc6Fn69whkZ1avK/y1/SLRx44JCRPW?= =?us-ascii?Q?3tzgsb3Qq4cvMaOzdR+X52LkFWlj0lHLUExq4nSqNSXwyQNumbT9IX67ctN8?= =?us-ascii?Q?RlCcbqh1xOUHCB3hANJC0isljMmu+6AXR263aei+/fzEIWvNMuhkvk3kcaw+?= =?us-ascii?Q?jZ76WDtmoemxIY8rkOyoqxvssuZprczA40eB9UOsZ1FtNPyX+cnXDkmEKY/P?= =?us-ascii?Q?5zEvYdvdYUKeggoId5MtpLqt0V9Gh9liDFoBiybJlVZbIkI2dwWzEGAI+Oqs?= =?us-ascii?Q?B26zH1rngsJxczjf7XOnZnCDaHmjcEQbS32HMxVZkjmjjsuVpiVf1nHF6Bfj?= =?us-ascii?Q?xzZUCt/e/pulG1xb+91CLcCAeWv9j7j1lU2jLiSSPwMCVuGedQt5X7eOsmMw?= =?us-ascii?Q?44USullONdglWp2GpvhSV+YPpG/O6ZaQCtHiiJM7t2jSTxzSR33aEThN6pya?= =?us-ascii?Q?gDWM74Zz4ML39p/sHmOITxzpTxuGPhL5UnJ3LgV1pccvBionuYVEOsZq9C+H?= =?us-ascii?Q?HwrZdBDpuu2CzAo3CK2MGEXukzxsnrq7Yh6lEbVSJdEgqHrSFwbrV9XrYjh/?= =?us-ascii?Q?iqW6qA1gRQlxD/w7UqxCwmEwA+QTDQKro0QJ3o1HpvmW7JGguL0nDqIErTsh?= =?us-ascii?Q?HzNPVMW/U6ghU0i4oA417HyQ2iPdq8k/jKyKnvXj7X9NtISS0aKwpQf97HvF?= =?us-ascii?Q?t72jumF8GxWFSWpT7kWEcQMzikJFehwL5ED+qiBDUsoplFS6CONpu2fXgguW?= =?us-ascii?Q?824U8RncxTaSuZm5jdpvKRq9KCAP7PwehWjoR8CgbMGajz1PsXkTsTWtTxPv?= =?us-ascii?Q?nsiLhAYl1csCnLClS90YAGn9MZ4K9HQ+Xpjg+daJ7YfFA2ITvgAB6w9D4+b9?= =?us-ascii?Q?FgOFUIURmQ1+9IHUCqCDp0iRD50t7mJyKq1/1P69SKaAMyfnB/NSUZAtJO8z?= =?us-ascii?Q?cVapD5q3y3mRJYYTRGl8zKAC6ZWUEP8kxaUHHyw3UIAd3kBQXSu2s/gprSEZ?= =?us-ascii?Q?6GghgXZtg9HGq1fOJelBuGJx?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5670.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f078879-4199-4c5c-b730-08d934d5759f X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2021 16:56:05.4869 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JR8KQajgP8ayXkFR0xF84sp84DTEPj1MNfkF/yXiqqdx5Be19apW0hzOz/+HILAVFVPhtu03o8SNhX/+F6Npyj0HpR/2iAAR0CULh574lHs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5639 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] table: fix typo X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Monday, June 21, 2021 5:15 PM > To: Dumitrescu, Cristian ; Thierry Herbelo= t > > Cc: dev@dpdk.org; stable@dpdk.org > Subject: Re: [dpdk-stable] [PATCH v2] table: fix typo >=20 > 21/06/2021 17:54, Thierry Herbelot: > > On 6/21/21 5:44 PM, Dumitrescu, Cristian wrote: > > > From: Thierry Herbelot > > >> On 6/17/21 9:01 AM, Thomas Monjalon wrote: > > >>>>> Check Bucket key for all possible indices. > > >>>>> > > >>>>> Fixes: d0a00966618ba ("table: add exact match SWX table") > > >>>>> Cc: stable@dpdk.org > > >>>>> Cc: Cristian Dumitrescu > > >>>>> > > >>>>> Signed-off-by: Thierry Herbelot > > >>> [...] > > >>>>> - return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt- > >sig[2]) > > >>>>> + return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt- > >sig[3]) > > >>>> > > >>>> Acked-by: Cristian Dumitrescu > > >>>> > > >>>> Thierry, thanks again, you could have actually added my ack from V= 1 > :) > > >>> > > >>> The root cause looks to be a typo indeed, > > >>> but the impact or the scope of the issue > > >>> should stated in few words in the title please. > > >>> No need to send a v3, please suggest a title and I will apply. > > >> > > >> table: check a bucket is empty for all bucket keys > > >> > > >> Thierry > > >> > > > > > > Hi Thierry, > > > > > > I think Thomas is asking for you to send a new version of this patch = with > the title updated. Is this OK with you? >=20 > No need to send a v3. > > OK, so you're going to fix the title while applying? Thanks, Thomas. > > Hello Cristian > > > > Sure ! > > > > What do you think of this title: > > > > "table: check a bucket is empty for all bucket keys" >=20 > This title suggests it was not the intent before. > It should say that it fixes this check, > or better, name the area of the API which is fixed. >=20