From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65684A0032; Fri, 18 Feb 2022 12:04:48 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 411D140150; Fri, 18 Feb 2022 12:04:48 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 4A78440141 for ; Fri, 18 Feb 2022 12:04:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645182286; x=1676718286; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=guKZ4esD+VLfOLINaLMILg9sjJL26Ph+O3WJgVLnXk0=; b=LwUPjn2Do8fvYYC6yo1c1Kw1fj6e1Z/99qX5bdzC5XGOd55QU5iJiwWP 2watYdjnWSFjYebVOinXrdn32fpRvc1fR7NZ1VvuHjf5pLFY8Nr4FlRza V6qAlgGLkygMA36TPuz4jPYl2XLS2O6JLPvmrUoQL1RUAPI8uDxr9zpyR yPBcc/yZ/fPGl08N2QUkxo+kyOxESl4SWJfcui0YccBs9xyHQCZdp2nwN Hh7Kl0eg3oCxcSq8L7DQ6ODh1gvVwGhuMmBTwNHpC8scRsYHxsksZqYdC 7eObVYeWQa66p3KC7ii2xjAO34BEZgbbivJ3aU9bARpOwuyIA0O7x/hNq Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10261"; a="238510381" X-IronPort-AV: E=Sophos;i="5.88,378,1635231600"; d="scan'208";a="238510381" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2022 03:04:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,378,1635231600"; d="scan'208";a="777976731" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga005.fm.intel.com with ESMTP; 18 Feb 2022 03:04:45 -0800 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 18 Feb 2022 03:04:44 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 18 Feb 2022 03:04:44 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.41) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 18 Feb 2022 03:04:44 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mAPiXnanwLWi2djssqp2PEmGsASx/oX+FYLL9XwfBNXDqmVGN/KoDMrENrS7NVlKCw0aD9lLezr1YCP0TzKL5KHUulcXbsDmRkX6/y7zMlbKOLYvWlWi7rAGYUK+e+PECm5f8LdDVeqDwU2VnjBvL4sqlCBCnFSPI199OwdVTr6xKCeh/PUAjgsB//fZHLjRKr1gSXzowMFnVwg1eOsuBo43GknevcQs0ipwEIvHJbHurC8PPh4lU+Dsvt0iCJtnFgc1oEdUlo3IjzJncApb1I8phQVb9Zz17hlJ+LNSKpl8TVkDJ2zPLojp6qeOLJ6WdNszByy0n/tqZut83aysVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QenLdp91ieCsMZt0E0WTSQi9N1MGebdkDEXskPHasa0=; b=GTK0qIvFdc7DndWV5D4nEGrdQNOcV1s1cBMhfFUf8H8FsSEj6wCZC3uTrFPtCB1hoOJiS9SIzrS0aF7ZG1cdmKuhavpCStqzJ+cwCiuMptzJ55JrGiVgV0OYj/Bb6q0eX0/wnoKNZrdkpXQQ4EnorLBIn2sZsuj0wMKPcBKOfqcV5RJWvRi2fvMFFLq988GxDqjeniMplVmGQWBuqYAafPdsxCkudhOBTOJL/lqh2j9mavR3heHNvN6Aqs+JzxoMIbOSL5Vawgmi50XVTt6l9Cjg6NoIz8FISNI6E7OC6Cmma7utsS1ne1yGEogXbAkgFRv8WGi7PWZpvWv4SB/nAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5670.namprd11.prod.outlook.com (2603:10b6:8:37::12) by BL0PR11MB2913.namprd11.prod.outlook.com (2603:10b6:208:79::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Fri, 18 Feb 2022 11:04:37 +0000 Received: from DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::e9b0:843e:2b39:6680]) by DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::e9b0:843e:2b39:6680%4]) with mapi id 15.20.4995.024; Fri, 18 Feb 2022 11:04:37 +0000 From: "Dumitrescu, Cristian" To: "Ajmera, Megha" , "dev@dpdk.org" , "Singh, Jasvinder" , "thomas@monjalon.net" , "david.marchand@redhat.com" Subject: RE: [PATCH v2 1/4] sched: Cleanup qos scheduler defines from rte_config Thread-Topic: [PATCH v2 1/4] sched: Cleanup qos scheduler defines from rte_config Thread-Index: AQHYJKsc1jK9fVn6rE+YuE7cQLMGvayZJO0w Date: Fri, 18 Feb 2022 11:04:37 +0000 Message-ID: References: <20220218093650.2549927-1-megha.ajmera@intel.com> <20220218093650.2549927-2-megha.ajmera@intel.com> In-Reply-To: <20220218093650.2549927-2-megha.ajmera@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4f4b70c3-16cf-4904-c2f7-08d9f2ce745c x-ms-traffictypediagnostic: BL0PR11MB2913:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fe78brXwAxgk2QF74ZjNSM1m4ifU/+n3kU2Kubv1IEE1qSlPt1c6XgP+Kmc7W4SNbUb523jID0UITMAfQSaZo9OvJUViRhzs8rV/AHEOSqAkSDEth09Pi1wK5os2GVAZGpEK0hxmvZgyFOl+MfAtjiHNHNoPGeg8K3wsaGdYav6ElOrfMPBnH8luK+c909tynf3bPrY8dgcjRIZBVWwVVAuPGU31Sb5CpVGNtEni/R8j1w5sGf9tJzbhqceuLtyOOf9oIySmeCS2oAfcezzHmZjHjrwb9cuVD5GIcllE+fn/wCUqg5WcQMnOV7iT/ssf+prOdip6utcP96tuwwP1mWp7exEoEKRFs1cZoPLYddTaxd+1IjPk+V9aQkDsHcJaeZDuv5HwS89rpzZicyK0yYx/Bvr1rwO2E6cg2ZuDSIsZf6oMhfkQTeVXgmI3mlXDJYG6l7IefJ5dvroCHr6tEmga3QuwFbYqSm7JfzPxeRg1X+m0p3Paow2sFcDZ3EdRjFTIZ3an6YQcU8hw+LFq/xa5rBwA3AbFqoFRKIizpArc4rWTtj3KnYhiTjHR5XjYyMOSXXoinihBqR2HKnb9er/MfKfsXioGQu7PWNtha3l9Ay/C4BRBiaJrgxdquPZkXAEldGmwOJ9hhsNloAhtSAJJYEqle7VWxWAIJBIWbJoH1/kSkj6QhH0rxIiT/h0+ydTSA1iZVpXJtyf5sJ2hYw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5670.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(86362001)(508600001)(122000001)(66476007)(5660300002)(66946007)(82960400001)(26005)(52536014)(186003)(83380400001)(8936002)(53546011)(38100700002)(8676002)(33656002)(64756008)(38070700005)(71200400001)(9686003)(6506007)(66556008)(76116006)(66446008)(55016003)(2906002)(7696005)(110136005)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lxxlv04aMa0FbimimtFc9cjjVJyc5cdSGNyxPTgxMaPC8jlo13Q/ie1Fl3JJ?= =?us-ascii?Q?XPH0aIISfvisXHvWpWe5FTFN/56/6ed6/pDD6+x/YP7i3BPythz9uGO0Y/JB?= =?us-ascii?Q?Icpeo4Z/3ONl3T7xalWi3LEL0UB7AU1F9aBJCmq4EmFlqcjvshwVLSiv4677?= =?us-ascii?Q?L/mbWHmGHFh4U6uAfEiyGe36ZDlV2oRzs1Ht7AOxu1mrtt962jo6L+4ObKmK?= =?us-ascii?Q?AiV3/GX5YlqLKfvNlDsFD5Mc30ZeY/LOUaKAHfRwbCyxqeQuFwfV4iS5VSw0?= =?us-ascii?Q?Cz7Hjln64SvxCtrrNB1bWkCAi0m13mOReRpTKem0jzyGJOzXQjorGkvtEgea?= =?us-ascii?Q?lwPLBRz9+1jopRqeuZYihmyHQtQN2AsFyYBw0PwJBsRVER5GbcJUwf8Snqn2?= =?us-ascii?Q?S1xx6ldY6DD1rsWqR8yHeRgzHbc2NmY/Owbwa9SSAUv7RlHzIi0NUyIS5WVl?= =?us-ascii?Q?gK6nVHH044POR19LfaC+QjmLJYJTJXJMlMocD/CrD9Jk7VFDoJ0vmmtyQ7X8?= =?us-ascii?Q?F8kbRBWeYoYWjdZO8ec3uOnUn84jm4KO5LEu0rr6J2aKhBAGmZprHzLe5vub?= =?us-ascii?Q?evzOo7cVbyWthYGkcSh+M5rZa/gTxeorjwWcz1Ft7saeaKZPA4VIrasRmy0n?= =?us-ascii?Q?BH4IYko63pyzVB9LOJmXSwx5LaO/igIsJYbrO9uTPLhSxeHe8gkeIViMb5ws?= =?us-ascii?Q?4mrF+PDxqJEV3tYzR0ya4q5r5/XytAYtcqCzWuPUgGB0hDWv0vGJQrcn3slc?= =?us-ascii?Q?zruV29u/nJb3i4aZ3QYEd9wYJPMQlkUxzJBBUQ6JokQdWC2csT1XXu1mTDgv?= =?us-ascii?Q?BaYbTcm7zcsVvp5WSgq6MLD24BhliVGXTLHW8RoLQPaeyjh06gEghn3uXI3E?= =?us-ascii?Q?dWmLSDNsKBloCzKfq7LRJojGq0ZeG1j5557gYu+XDqPJh8OCu8Et+msDLMn3?= =?us-ascii?Q?nr8jLxZbeuLlSXqmwYQM6B4M8OEvRJ/D36HkgtjNeCUsUtSSiXjxU1iuFw0Z?= =?us-ascii?Q?ArOH7I6KlSIZKsAzT/W8BUnSZ/1cPsqtkwJuE4FEEPIrCYc3GqyMJNMU1nVT?= =?us-ascii?Q?HGv4CwsPl3lv+7d/xmatFNtqpzg2LIykV5IKBdJBMNassUcxLHS4pM80flvi?= =?us-ascii?Q?VqAHWh9YzPLeT0Fb06/IR+f9YyTMqf/m3R8wd3u4WW9jSpUHiLtbi/Mh55Yc?= =?us-ascii?Q?+nr98IYd5mgLedprvrXpnh4zfwiJyPbDtW7O0usmnUc01HmUS5QwiNe7QKDn?= =?us-ascii?Q?BKNYET2aSqB06NeoHQiE13O8UY//ruQx4+w9tZbNQG8IcqsIlusd80+yG2yZ?= =?us-ascii?Q?MrfrJPCinBjavkYX4kSIwudkYu4hB+03IjMQDEsp4FW82/R0qq9aTxaH7EgP?= =?us-ascii?Q?URlm1386eSJOncGouGE2dFzllWYcA4TlzFdtfHZlOwpwo+si6iYXuiBJ7fYz?= =?us-ascii?Q?RNS9KMTOBKtSBjYd8Q23t4kLL8hcO2MbGEO2vDROrStQDno1cpT+fnj9+0FO?= =?us-ascii?Q?Pk2hQlkAdqlXRz8tbJKXyGM3JQ/Y6wjIX/1piTPQshu74V9LWrJ2VSD55aN2?= =?us-ascii?Q?xXG3ulROzh7WFFZvdrdTcrPEkABfQxDqt4xUtLOP+eFHTZjLVqpaAXzA9LXu?= =?us-ascii?Q?kclUQqBQWaZw22mJlVbDeejdaGEQycfS03esoNPZczcJvs/ibERO1r99FjpC?= =?us-ascii?Q?+1teDQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5670.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4f4b70c3-16cf-4904-c2f7-08d9f2ce745c X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 11:04:37.8418 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Uxkz6PXgnrBtn5+jnU2XoKM9wQoIZv/S/91fxki9gYnPJNjEQEUuDijHdzRn6PI72MotmEb/ppgSXGFhyR6CP8z1RHc43sO6glb4IGaQqCU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB2913 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Ajmera, Megha > Sent: Friday, February 18, 2022 9:37 AM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian ; > thomas@monjalon.net; david.marchand@redhat.com > Subject: [PATCH v2 1/4] sched: Cleanup qos scheduler defines from > rte_config >=20 > Cleanup of sched config options those are by-default not defined. >=20 > Signed-off-by: Megha Ajmera > Acked-by: Cristian Dumitrescu > --- > config/rte_config.h | 8 ++------ > doc/guides/sample_app_ug/qos_scheduler.rst | 3 +-- > lib/sched/rte_sched.c | 4 ++++ > 3 files changed, 7 insertions(+), 8 deletions(-) >=20 > diff --git a/config/rte_config.h b/config/rte_config.h > index 91d96eeecb..917097630e 100644 > --- a/config/rte_config.h > +++ b/config/rte_config.h > @@ -88,12 +88,8 @@ > /* rte_power defines */ > #define RTE_MAX_LCORE_FREQS 64 >=20 > -/* rte_sched defines */ > -#undef RTE_SCHED_CMAN > -#undef RTE_SCHED_COLLECT_STATS > -#undef RTE_SCHED_SUBPORT_TC_OV > -#define RTE_SCHED_PORT_N_GRINDERS 8 > -#undef RTE_SCHED_VECTOR > +/* KNI defines */ > +#define RTE_KNI_PREEMPT_DEFAULT 1 >=20 > /* rte_graph defines */ > #define RTE_GRAPH_BURST_SIZE 256 > diff --git a/doc/guides/sample_app_ug/qos_scheduler.rst > b/doc/guides/sample_app_ug/qos_scheduler.rst > index 49c14a00da..7016ca4078 100644 > --- a/doc/guides/sample_app_ug/qos_scheduler.rst > +++ b/doc/guides/sample_app_ug/qos_scheduler.rst > @@ -42,8 +42,7 @@ The application is located in the ``qos_sched`` sub- > directory. > .. note:: >=20 > To get statistics on the sample app using the command line interface= as > described in the next section, > - DPDK must be compiled defining *RTE_SCHED_COLLECT_STATS*, which > can be done by changing the relevant > - entry in the ``config/rte_config.h`` file. > + DPDK must be compiled after defining *RTE_SCHED_COLLECT_STATS* in > the ``config/rte_config.h`` file. >=20 > Running the Application > ----------------------- > diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c > index 62b3d2e315..6c3e3bb0bf 100644 > --- a/lib/sched/rte_sched.c > +++ b/lib/sched/rte_sched.c > @@ -35,6 +35,10 @@ >=20 > #endif >=20 > +#ifndef RTE_SCHED_PORT_N_GRINDERS > +#define RTE_SCHED_PORT_N_GRINDERS 8 > +#endif > + > #define RTE_SCHED_TB_RATE_CONFIG_ERR (1e-7) > #define RTE_SCHED_WRR_SHIFT 3 > #define RTE_SCHED_MAX_QUEUES_PER_TC > RTE_SCHED_BE_QUEUES_PER_PIPE > -- > 2.25.1 I agree with Thomas's suggestion melt this patch into the other patches. You would need to have an additional patch for RTE_SCHED_PORT_N_GRINDERS.