From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 69D74A0545; Tue, 21 Jun 2022 15:27:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E463B4069C; Tue, 21 Jun 2022 15:27:39 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 5AA9A40151 for ; Tue, 21 Jun 2022 15:27:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655818058; x=1687354058; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=sQ2oR9jSdE/xrRh3yxLeEK7oM7bGhqhAIGkshT8+j9E=; b=Xt+1IHRvxK0A+suq2S1SRmcdCqprQimHQWmvlPQkwHn3U1gnxyhvmqel a52v0lUShvxNMo0pUL2X8xE1VMQnK3ueqeJBriGkNRa+8qpUFNDUtwaur qekHlOyRGejF2ajlUfxBq4gFQ29bvHKH951RNiIS4KApUld9Tjw/DqEIM 19n1ixOHPUW32OwY7e9xxQiETiz98v1zyYnC/WInW8jN+9XTGksFFo1FB uELu99gzz5he5l5Rj/+pvaRt+FgF6uOyL5gwNGjz5xPwn6gLEkvizepdP M7sDPr8oJiz+9s8bibVueq1leDyA0aqN16r/T86He1jtI7eRNRy7A+yzK g==; X-IronPort-AV: E=McAfee;i="6400,9594,10384"; a="263150349" X-IronPort-AV: E=Sophos;i="5.92,209,1650956400"; d="scan'208";a="263150349" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2022 06:27:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,209,1650956400"; d="scan'208";a="591650777" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga007.fm.intel.com with ESMTP; 21 Jun 2022 06:27:35 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 21 Jun 2022 06:27:35 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 21 Jun 2022 06:27:34 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 21 Jun 2022 06:27:34 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 21 Jun 2022 06:27:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vnuuy+mT6mCobMsU61y3D1wDI5D5nMQgMuMZbUkf3BBu9xR9xWIP01ztVQ0fffzQAAIKpdLd8sNBnbjdNngBAnWmKt9K/zCr+bWiz2Goqhfzchup1MMEZWV2bN/pAPTb0zwJ0mSC95Xbap/VGJ8zagkssHV852qYWenQIJ94DQAzMgt8/V/oBzokTbvrtIvg6xMxrFx+/PLYvxm8EMTAC+p9pB1eT3+v6qAz9HShHYfbFYmptXm08yUI/nMITLxVttn0+hbQ8mkSIvp1yYshCJn2QT+Pjq3iVhY+3ardZmuRCS49+zU2C3r3Va5xQTYvB3bTFMtlw2vDJ/N0Bdq3jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7N6UIV7E/OYH0q/YStR/rowzYZTHHZtGJipPa0SDiTA=; b=IrYsZLQmadedsvFOgdgV5khfOez7ClKj4znwNHKOedshYUWdsdp8dOsNcdp/bFtpZb21NW8Xt3bVvQVwwGM83volqsbXSxGKfVaBE1NL1LDLcgAmjs4HrFgIhOjbZRiQNMnXXzVwnBVOI67MghPfRwV99fBi6pwpAnOwZp6tSHYXC8sZEZAcEdONlUKoTbI/5dncDfdtcPLSWDj5xFJuxm3afmWu7OSYDU+oFGs+tedJkUm1qD1xfwr6S6LzZTVaelwVZVz3B8hg1MgMAbqo4KVpGf9fYDoWPwq86nXtUqeS1PhUYhRXZeIz+yBNt4A54PjURtegCLjQ20QSvqSVkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5670.namprd11.prod.outlook.com (2603:10b6:8:37::12) by CY5PR11MB6281.namprd11.prod.outlook.com (2603:10b6:930:23::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.14; Tue, 21 Jun 2022 13:27:33 +0000 Received: from DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::89de:bffb:b66b:516b]) by DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::89de:bffb:b66b:516b%8]) with mapi id 15.20.5353.022; Tue, 21 Jun 2022 13:27:32 +0000 From: "Dumitrescu, Cristian" To: "Danilewicz, MarcinX" , "dev@dpdk.org" , "Singh, Jasvinder" CC: "Ajmera, Megha" , "Liu, Yu Y" Subject: RE: [PATCH v6] sched: enable CMAN at runtime Thread-Topic: [PATCH v6] sched: enable CMAN at runtime Thread-Index: AQHYhUczIf+zfkEXq0GJKwMsGYbyta1Z0XfQ Date: Tue, 21 Jun 2022 13:27:32 +0000 Message-ID: References: <20220620135630.975370-1-marcinx.danilewicz@intel.com> <20220621081607.993440-1-marcinx.danilewicz@intel.com> In-Reply-To: <20220621081607.993440-1-marcinx.danilewicz@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9b3b94b9-260f-46b4-ebef-08da5389cc40 x-ms-traffictypediagnostic: CY5PR11MB6281:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bK1WhH8b6b/U3wj1RmYxVaQ0zoGP7Cl1886ZIBWWAX6VxFl9ZUIEInhqNtEwytV6+uqSUm+aYQENvuUFUAhvhppwnQtDRW0BbaXSt+9ia+Fg4eBcKjANd5XQ42wjkwNn+Pb8lOGKk8wcTA4NdhCb/Aa4MxfzIxYyDXuUt95fvZVBegFZ8HVoMQrgqs8CMKF0sp+sJ6AMppEatwuWFnpwlPljpqiyg97fivUf0ujbiTNi54x70xuH1zE8WZ8yk48Qv948eXIwU0w3tnG6UeBeonSrhR8kJLR8lgU6pG9jC9u7OXHnrhstO2NT9Hk5hd0VDbhP2VCzJKpgMmLou5b9sJSangVlc1bdA9Cuy9mVyRPnCTbR4uYp75BxyizSsvQkNxZ7+8qyTVSKhw2w6U54fwcHNSm4lXMyMe9JXqhHG0eP+uhNk+kXrDgqL7sR/Rzd7KZToGdF+CCDWvA+Mve0L2pthxhhwmsmkKMiUiVXMD+/SHCSXaYvu06NcdmITRreq7H37Eg5XQaamjtNyUazIj/UGzMYXoU8glum4xjmd7lYnILBqZyL1tap0vyjB0MwhW4dqAxFui1G3HnoNGo/HJKPK8dyPaAJ80BLEXzM80JbV9EGiZ3ipLXEDnhjYYu3XOo4XeG13Zc8/1GjdXZcRHMG0PspjXTUjZBoHMJ+mw4YTo9z+4Omk0gax31txZoSl04OJYoJn+8ouZiVCWobVg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5670.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(39860400002)(136003)(366004)(396003)(346002)(376002)(55016003)(66946007)(41300700001)(82960400001)(66476007)(86362001)(8936002)(5660300002)(33656002)(7696005)(2906002)(6506007)(107886003)(64756008)(52536014)(71200400001)(38100700002)(76116006)(66446008)(54906003)(316002)(6636002)(478600001)(8676002)(9686003)(110136005)(26005)(83380400001)(122000001)(186003)(4326008)(66556008)(38070700005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LiVukqV85IZxytxe6XL/sOZMpjB6eb5pYzKtQAdKaLMD+A6oPXbR25VU0xmy?= =?us-ascii?Q?yn4rmE0LLOFlcCBvKuR/1S4Mdi/Mtw6YTMxp86D9UVs5UE3FGkQU3t2oIAKc?= =?us-ascii?Q?affWDw7PiBeWP4SVBbQSjQ73zDSNK9PyLKluhEGH3xdTqFWIzVVBT1pEzke4?= =?us-ascii?Q?3ERKHJng7Byo0tynnxd9P+lKdofGsGEt8VN657jI+gPT4tE1fxfrzw9vP968?= =?us-ascii?Q?xrsU8Hvdw15hDrGbzjYgSvJONGWrlkSbf9qzBkL4AomQi+lUpIBPcd9iK2kC?= =?us-ascii?Q?grdeasT7xFEV+KTVBYaSjrh9FcIykoL3a/WDqgI0wpLEyiUKgz6iMmg2Nvjd?= =?us-ascii?Q?fWwf7RE3J1mNlbt1e8ePiGUMbgzITHJrOhlyusF1gnCScxt9Wbil9FmsZo6K?= =?us-ascii?Q?Jnis5Gho1Ng6KVaR9CUJql9ReooI7NkfBDY3Ed+g8sIH6rveCZV0mP9nQo0k?= =?us-ascii?Q?/h/7nBITYo/6vPBIGn4Cu2SVW/GYbpLa+lHO3Amq82b8Wk0i0R1UNx/Jh+/S?= =?us-ascii?Q?zeOl2Km7Dl1C94x7XkGPoZ7uGHa3bFwhxvWjfJWI155j11a6AaeK2L2vNjBJ?= =?us-ascii?Q?ml65giDeH5aQSMCardWCyzz5yayh+u70Te2GkBjquWXWo5M9CP+SB9/+7kCf?= =?us-ascii?Q?q6MS+ZaWXuHIUxy0WboxEfs0WbYt8VaNHtmDgwU/haawfO1uzAB4ig5LUUSh?= =?us-ascii?Q?53B56HW6y+K1wleX/HbU2jUYQuOzWhAtLALoajMoFw3hnmULf+CGe8qQa+e3?= =?us-ascii?Q?hpc5XVUSFEbkirrgugJZkBPAi4/X74LOj30J1jy/hlEEoTTI2SrypjxOBLUq?= =?us-ascii?Q?90lOWyivu8fo860tpfs6UBCxom4RSzpO67pmvCOw8Y/XNi09WHQKQdUJK2Vx?= =?us-ascii?Q?6+P5jiZPWBNk1u/WjiFTVcOAXIw+Dy75HKExY2c0ng7ARUs5GFLnO3sdU3cA?= =?us-ascii?Q?XJjzic7VKob7By4/xBEqLkfPdewkvjwjCoO6PUqYIlRwYJG+lGOm4o4hIu9d?= =?us-ascii?Q?9RJCReEg9lJ0ZeCuPGEcKOA4w6/GFFJNvC2p+6SksPk6W30DCqKWb/q9ltht?= =?us-ascii?Q?3MuqQ606L5R7KRRj0VZABbpeHhezuIF/qKuzr9MIexuEp0g2MylfZItCSjYx?= =?us-ascii?Q?2PHGzWC1F3hGM20ZbMLi1ZzbskpAcbd6Xt3KW6xL3vM1N8VwHr0yQftaS6pJ?= =?us-ascii?Q?BRRrEgds+zhI+0uilWKtOTRoZQX8QVIlph6NfImxjmnhplWZYgrxCWs8FNPt?= =?us-ascii?Q?YPKsA0Fxwp3Y7Q+4ta8o7yMeDpuQPefeX/dWPHSrwLXlp2KsqeNRR9EkSf80?= =?us-ascii?Q?eF0z7u8+pUdBhWRiLP9tnKO3WoNcV+PvCviBXDR7JdA/Ceu12N5fAT4zfQqH?= =?us-ascii?Q?5XcU54psJCD+Pnk3Xaweza7jWe7AA1Tu0vTBgYN3ZCQB+/wxEIjeoGtL7GHu?= =?us-ascii?Q?9MHFB+JrLQxVxAkg3OOKyT+6RT3fwBuclvnXeWcEywQeUkDvu+EWGKnuFjWp?= =?us-ascii?Q?a2RxdtCP5KD4BokW96B9GNp2ImmKDdq2W3SURZ9LR0BsVENHZ5LeSQjeGq6O?= =?us-ascii?Q?W9JsqKCueSeUddkaqpNcAukr3yqOJt94ErUgTvjD3smdCQ2KNhb4pAntXZxP?= =?us-ascii?Q?O0/DMspWcGFnFlv3VRkqOurqS3DaqDq7xhjA+mY1CkEQYOgZ/AndtidLQAAh?= =?us-ascii?Q?f75dHDoDSb8K68IfD+fxCMgFab0exkjypVtlHD9hA7fIIS+uU2UdGziNRqDN?= =?us-ascii?Q?DiwNRtzr+y38nkdjMmMXwBIC4bn175M=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5670.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9b3b94b9-260f-46b4-ebef-08da5389cc40 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2022 13:27:32.8153 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tF4W1AawValxZ0LQv0+Hy8Za7UflLESmrrYH0RnmsLGHYilcWCzDXzwweSc2bavRdaMQAArUb4j7ZLsjCtadKftEVP46HMZ19kdzDxd9QPI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6281 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Marcin, The code changes in the library (rte-sched.c) look good to me, but I do hav= e some questions for the qos_sched app and the Soft NIC driver on how CMAN= gets enabled/disabled. How do we control whether congestion management (CMAN) should be disabled o= n enabled (WRED/PIE)? It looks to me like you are always enabling WRED by d= efault, which is incorrect: we should have CMAN disabled by default (in ini= t.c). My preferred way to configure CMAN is: a) CMAN should be disabled by default b) If the CMAN parameters get configured in the profile.cfg, then and only = then CMAN should be enabled according to the configuration. In init.c, we can safely set the subport CMAN parameters to NULL as the bui= lt-in default when the profile.cfg is not provided, so we can safely remove= the WRED params from there. In cfg_file.c, we need to have a good way to disable/enable CMAN. In profile.cfg, please remove the WRED lines as opposed to commenting them = out. Is this OK with you? Also, have you tested the qos_sched app and the Soft NIC driver with all 3 = configuration files? Thanks, Cristian