From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5277A00BE; Thu, 10 Feb 2022 16:01:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 937CA42704; Thu, 10 Feb 2022 16:01:46 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id AF95F42704 for ; Thu, 10 Feb 2022 16:01:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644505305; x=1676041305; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=mGFe/B7SHzXcRE4TCSD6WTQjYcY07NY0CC8ZLjMcos4=; b=aO4v42WIBfnncIgadJDdPDuOSLSBjIQkviA7TgxWarpmWpluhGrZS3eD my8QZqYwD5tNK24p8bYEuitnDxf95nT9QCHkcMYmBdtIzjyZdJkDj3RMb hlyIM9Lyn23bCtN3luj2CPlWqQEYx0VI5NIgsSNZTW58+E4WDoT8cjDWU OXaAGqQ+pKDBARmziQcT1uRgsp8KmJxjBKGjbSGCuiLDge/zCfNIeJDnx cpGEDqKl4CvnNZ2Rw7epcxVf7nT7wSpJhY6CornOvjzRnb+RXn6075XDs AH/PTgT6+oP5fXS7Cm7Z/wrBx8bNNeBah05hLSR2mz7H7nSsliv4EQcI1 A==; X-IronPort-AV: E=McAfee;i="6200,9189,10254"; a="312792130" X-IronPort-AV: E=Sophos;i="5.88,359,1635231600"; d="scan'208";a="312792130" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2022 07:01:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,359,1635231600"; d="scan'208";a="773898793" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga005.fm.intel.com with ESMTP; 10 Feb 2022 07:01:26 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 10 Feb 2022 07:01:25 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 10 Feb 2022 07:01:25 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 10 Feb 2022 07:01:25 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nEnqELqYk9GfSIW9TgDyipTIqD1nhDpqHFdZzMFBkjyaIQHAz2WUe/RO3IPFni6B3//0WvwmLBof9MwGQHMk7LMw1amcu2l876uG8OOB/rH27534lhHtc5PYennPrVrMSEejN5bJqK6jPYMSrY2hoqtgaXKnTkOnGdf9IHiHfsyDRRRW/Xd556Ti8ULzYlVeJWFgTwmF16TvRVeLhOgEHMJaMa15v07mLQiIhWjZf9mU3AHgZcl9tepyBA4s+/URAgICHDwqc9eU/iQdSsrb/Yp/yuzroHwq0zXkLCJWMnNLsm8zLy9IshPFVXtNEahHlTGXwk944iROq1U8hoxMnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lquJgEBIvaxcmKKyyiQuE6toM4XAvFumFXaTmguwuuw=; b=E5qo7A4OL73QVLIE/pl/P86h18/wxMh9nsWd/xr8oaUPgcU978m2JVt7tbk2wGQx05zElCAJCXJWdnWyPqkMMGl8rQjWaSw/dm3Rm9MMmS565rKpIJKB5KedWWiRA2Ng5NmL6wZfgxCylyYf7hUQRgL3F+8ESGt2SfZGaDFsKe9FlV8+qXsHxM/SpKdtV5TeaPOFLP2AQpvyN/saH1a49aeZ13bOmZnUDyOubfD7KBLpM2O2ZqjXh0NraB5AVb+E1pbD0ErmqzYYCwGwJBhAuTTzK3Ig/LDnHTqssK0OnwQc5NkzDpGIClUQsGqjn50RofNRIvhF82g6To09JRWyxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DM8PR11MB5670.namprd11.prod.outlook.com (2603:10b6:8:37::12) by SN6PR11MB2720.namprd11.prod.outlook.com (2603:10b6:805:56::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 10 Feb 2022 15:01:23 +0000 Received: from DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::e9b0:843e:2b39:6680]) by DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::e9b0:843e:2b39:6680%6]) with mapi id 15.20.4951.019; Thu, 10 Feb 2022 15:01:23 +0000 From: "Dumitrescu, Cristian" To: "thomas@monjalon.net" CC: "Ajmera, Megha" , "Singh, Jasvinder" , "Yigit, Ferruh" , "Mcnamara, John" , "dev@dpdk.org" Subject: RE: [PATCH] sched: Cleanup qos scheduler defines from rte_config Thread-Topic: [PATCH] sched: Cleanup qos scheduler defines from rte_config Thread-Index: AQHYDvLbUC41mkJFIUSG7XFAijOSnayM/I+w Date: Thu, 10 Feb 2022 15:01:23 +0000 Message-ID: References: <20220121181459.1599739-1-megha.ajmera@intel.com> In-Reply-To: <20220121181459.1599739-1-megha.ajmera@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c2879669-e07e-4ad9-d057-08d9eca6343c x-ms-traffictypediagnostic: SN6PR11MB2720:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3BzK4WamGMe0Uv4vXkWn+zWqbXlFjlOP+72feXTdndmTFM7P/DCb8lXR5QQawwJsA9TpGxV8wTyWErlilZRSZWvmQFORbAEx23kF5ykKcNGIR7LwYbX6iZ4LXmw4x4yaeUIfEP88HB7z13+LLQq7Ohaig/xGIA+GThANdNfM4XjJF1AvTOvEDx92uX/2DbhHDgc0+ShMPUMQHf4RK1YdW5PKREYPLugPnVcIRb/Csv+/6P4bx2PwBcExos1V4eaEgSSAszZMKFwJ9i3VWydTkYXnjilYKHaC0Uy8+jiqWzx0CoOwAEHiwt2WbKOYeM/3oBFIQufAc9kG7beTC5/cHVKbPAXZtBC/hITQU92cDC4tjkB5QD03jyYxb9nCeMFkUZARPOwc3ESeWOf962UxSG8iHNTeTqW0ab8tUJeo44p8GH7kyXJL/tQal7oL+wbXDrnKgULAUuljjydhVCTeiP3bZWkg6h6nFGhwZybmSwrLejdbSiPUcwpuaoGhjfoDSOd/gz7gIrSka2VoCaPCkCGTiP6EuSNDLr2UDyaCymN0RAnqBYckuan3d1FYdRnEbfqRxZiONy+vdNxicCfG182SA1CFMnR/ajrij9ybQWnHe7C08n0BV+V+pvRj9+itDMeiklQsKvQ5uq/fayq+RzjUhdh5ObbqJuefszmnytrTTsYKM+nPml0/PVNpupKfZpIDSavUbRVEK8J4l8Cvug== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5670.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(4326008)(508600001)(5660300002)(33656002)(66556008)(8936002)(76116006)(71200400001)(64756008)(9686003)(66946007)(54906003)(6916009)(66476007)(186003)(66446008)(38070700005)(26005)(83380400001)(55016003)(8676002)(53546011)(316002)(6506007)(7696005)(52536014)(38100700002)(2906002)(86362001)(122000001)(82960400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IFgY/1abzvRhlPPGGv9BGKkrNMz01tPYvnN2HwS/4DRA/Zt/V5NqPsVe2QHY?= =?us-ascii?Q?t47Ig2mqQWnNxeq1H/89nlmIC4mILiYmPGY9UYJduaJ5w4fYfCnqYtgp+N2E?= =?us-ascii?Q?fzSZq4AQj01MfUSdd1PkHh7L5Ic4X1t4kdsg8076DBEsm6Fct9Bkxfyx3eGD?= =?us-ascii?Q?cDDS8HLf7pWhGjWJEFjWVGoeCgtkD1xVpx+zVvoQBcvmQChG8u327t0x9NHN?= =?us-ascii?Q?NUgrQanNtYOaBAnZMgZL3ztXdGhTcze9h51faX0KKbLM6PiIJXHDGCIuAgS9?= =?us-ascii?Q?x7wPgXInLCwQ1Eo+ojvhSjOBZUy8BXdm3C8Ms/XY0mvHr7czLELn91ieGbMA?= =?us-ascii?Q?7yCGuZz+fh3WZ+XUW54Fj7tBtCmljx4IwGvFCQqBEmQ9d/DbxzCXkk7azXG2?= =?us-ascii?Q?LS1iXn14EgFLEZcrobaVxDBlagykUjq2UnJwvLJQmnIWVfF/w7cFYtaeGRHg?= =?us-ascii?Q?J/layHqFDOW2A8uoh7/ozcBkhRIMATheLEa64j/h4fO387RWCHmX7hXiBIth?= =?us-ascii?Q?62Rnu73RgigbB5/X+LQMqQ9jgUs2QeWRo+Aoz9ajLrmHOUKR2gV6CNVyy+Gu?= =?us-ascii?Q?9zlJ1iYPVxSk5ygLvak8kKvLRzzaxYvJccOY+d+o5t0RUya4sCbEhX5Ow62x?= =?us-ascii?Q?90oAF46tqnp63a0LL24RCmkVjov6lguE/kM6Fgc2DpJk8IkPA5sB+brBsR5T?= =?us-ascii?Q?+DWluTyKOmT18a6sxW6r4hCEtLoUNWYdErqq/T3E4hotl50yh7YEo4G3jSth?= =?us-ascii?Q?bqia5y5Hw5Zv0l6bsXyVdOezj6vWEXuDcH3K4g6y2e7iVaX71FPSBXhAZLh7?= =?us-ascii?Q?rj/g4cWaQhNoe7kpBipIYwXRCj1Y78fFCTJZ/4U9XCRYFS/hICdhCy1j3uIL?= =?us-ascii?Q?apzISyaN3wHN0J0Khj50ZhonoYEavKCeYjGKtmzLGiLs/ypGtESFYpQdnRyJ?= =?us-ascii?Q?7dhKO9Sn3ihs3HmGm2++XpaCB7EBoxgsNsecdXHQfsw4+fB5eiL4wroBvg8U?= =?us-ascii?Q?RgxYy/c8OQyXYqZcaLZ3zIGp1s3HtUzTDaDW69Sl/oHD+eM7mi7DZuqm2m+e?= =?us-ascii?Q?0zTPBIIuTbsmiTo+Vnxdx58q6g8+KYYj/xuxIcFm0UcUJbvFbgsUaC/IBEvb?= =?us-ascii?Q?/FS9ZiDvmpyTXv7y3SfK9FTQVm0QWaQrBYE+neRqUWmSBZDe2aCdga61VTsw?= =?us-ascii?Q?PL64EomohcXKDBkcDgjcn6shWWSsOvJKRzWb7Wojetzfe/bD2dp4jlILGKx+?= =?us-ascii?Q?29tJlwPQJJxeRBhUlk9z6HmReRsGPjHiSpK4N0BVQzCdJ+ak3nIf6xv5TYVf?= =?us-ascii?Q?b7ZE1QWYvyIQmf8bM0bKDDCoYEyJxR4Omu2NTsxgyXj5E9h8XXh8CXgUEhI5?= =?us-ascii?Q?dKV4YV4rScDfrYKIrN1RBlVgFNej3NVFikCuDnHn3eUWcD0Al92lxBEVkc91?= =?us-ascii?Q?GXV3Osg0EyE0Prq2TZX7Btf5aNvEP388nXNdo5evnU7dsf4HUW6Li2qGzTqU?= =?us-ascii?Q?QElEwjFoIxK0TXGpjJvRAxVo+KS+I2O83rjo5hU45fYY4aH7fR5lBmoX2n8t?= =?us-ascii?Q?VnxVBYfkz6K3xWWDItNbDZfs4vYhnr8Bqt6rSDT/pXTXNoEUTo9fB7aQIZU7?= =?us-ascii?Q?Dr+TAZA0+QDZ+XkVxjpBubJ7iljMa19CznboTWkngJCAjY6YNMrScCtHcR6+?= =?us-ascii?Q?DMDeTQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5670.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c2879669-e07e-4ad9-d057-08d9eca6343c X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2022 15:01:23.3513 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Efes4mL0eefXfUf7kLou9FmEN2t1WLxsx0GXwNoT/vt84bwSU6HNhp274AjLrRotz0Z50Yt5YNgUoNUCmvdwtzcvTEdBaIjZV4Q/m7JHgvo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2720 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Ajmera, Megha > Sent: Friday, January 21, 2022 6:15 PM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian ; > thomas@monjalon.net > Subject: [PATCH] sched: Cleanup qos scheduler defines from rte_config >=20 > Cleanup of sched config options those are by-default not defined. >=20 > Signed-off-by: Megha Ajmera > Acked-by: Cristian Dumitrescu > --- > config/rte_config.h | 7 ------- > lib/sched/rte_sched.c | 4 ++++ > 2 files changed, 4 insertions(+), 7 deletions(-) >=20 > diff --git a/config/rte_config.h b/config/rte_config.h > index cab4390a97..917097630e 100644 > --- a/config/rte_config.h > +++ b/config/rte_config.h > @@ -88,13 +88,6 @@ > /* rte_power defines */ > #define RTE_MAX_LCORE_FREQS 64 >=20 > -/* rte_sched defines */ > -#undef RTE_SCHED_CMAN > -#undef RTE_SCHED_COLLECT_STATS > -#undef RTE_SCHED_SUBPORT_TC_OV > -#define RTE_SCHED_PORT_N_GRINDERS 8 > -#undef RTE_SCHED_VECTOR > - > /* KNI defines */ > #define RTE_KNI_PREEMPT_DEFAULT 1 >=20 > diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c > index 62b3d2e315..6c3e3bb0bf 100644 > --- a/lib/sched/rte_sched.c > +++ b/lib/sched/rte_sched.c > @@ -35,6 +35,10 @@ >=20 > #endif >=20 > +#ifndef RTE_SCHED_PORT_N_GRINDERS > +#define RTE_SCHED_PORT_N_GRINDERS 8 > +#endif > + > #define RTE_SCHED_TB_RATE_CONFIG_ERR (1e-7) > #define RTE_SCHED_WRR_SHIFT 3 > #define RTE_SCHED_MAX_QUEUES_PER_TC > RTE_SCHED_BE_QUEUES_PER_PIPE > -- > 2.25.1 Hi Thomas, Any issues with merging this patch? What this patch is fixing is removing these flags from rte_config.h, which = I understand from your previous email is the "most problematic" issue from = your perspective, hence my recommendation to have this patch merged. But th= is is definitely not the final step. Here are some next steps to make these options run-time configurable as opp= osed to build time options: 1. RTE_SCHED_COLLECT_STATS: Always turn on the stats, ignore the modest per= formance impact, enable the code path with this flag defined and remove thi= s flag completely 2. RTE_SCHED_TC_OV: Always enable the oversubscription feature, enable the = code path with RTE_SCHED_TC_OV defined and remove this flag completely. 3. RTE_SCHED_VECTOR: Keep the code path with RTE_SCHED_VECTOR disabled and = remove code path with the RTE_SCHED_VECTOR enabled and also remove this kno= b completely. The code currently under this flag is no longer useful. 4. RTE_SCHED_PORT_N_GRINDERS: Keep the RTE_SCHED_PORT_N_GRINDERS defined in= rte_sched.c (as introduced by this new patch), this is not a configuration= knob for the user. 5. RTE_SCHED_CMAN: Check the latest performance impact of having the conges= tion management code enabled at build-time when not actually used at run-ti= me; in the absence of no significant impact, simply remove this knob and ha= ve the congestion management always enabled at build-time with run-time opt= ions to enable/disable it. Does it sound like a good plan? Thanks for your help! Regards, Cristian