From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9CCEBA00C4; Mon, 30 May 2022 13:50:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5067B40694; Mon, 30 May 2022 13:50:26 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id E3616400D6 for ; Mon, 30 May 2022 13:50:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653911425; x=1685447425; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=CpHvt1P+BC9K1JHfz8X2aAlxFTiRNX8QKlmgruOsnJs=; b=bo7c9iMArm0HJ07Hj/pASc9/D2pC1vMx0r1q9R6+TPeeJ50/P5w2wlq8 959wgRtjzE/mS5jH51t6PqFhdio+R//KWOjpCmVQL3DFp/97Ns1wiNFI4 tdBC9xKKHLgf+3dwSsapkb4CiFM3zZSjhWGMX6EzIC4NaDHf0V+uUGeku QvCAb9eYNhmFi+DQ6KKKU1Z7LWL+wC2TZQOqvvJMl1bBDYj7ty8Xj75Ac uk+EyNO5ird5ekFZTtTHw+Qfptlbl1nPMDXWfnNkOvm2rcxW+YMGnxYXa YpGPAsBl4Vl0aVzR0qW8y0wz9lTUXrCZ15485Ky6IPQzA4ZVNOuiytPCZ g==; X-IronPort-AV: E=McAfee;i="6400,9594,10362"; a="273792967" X-IronPort-AV: E=Sophos;i="5.91,262,1647327600"; d="scan'208";a="273792967" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2022 04:50:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,262,1647327600"; d="scan'208";a="632587104" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga008.fm.intel.com with ESMTP; 30 May 2022 04:50:23 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 30 May 2022 04:50:23 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 30 May 2022 04:50:22 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 30 May 2022 04:50:22 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.173) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 30 May 2022 04:50:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SgZ3eaYgUFJbMCImMSOAK65FfcwbNbzOgg/4Em5k9rhgQv4ytE6mjsroQMyeD6PmvDX/x2T9HQsylOR5OZHazmF7ujscqkxnNrYPEBB/udlcfsnbijSUxrjG6QDGVINTby3USX5lJPSRXrZhRGyuZDkm38ijxHK3AczqJiVaf6T8kWsZvQ0lQU4R0IFpYr55t8v/t3PavzCx60sP8Tx5GbnOCIoq/U4caVsK4PVZrMUPjgVF2SVK7QtA8J/FQXCNMXVYZXMwnoTrOZS2QTi0hnWCYYnYjZCwIUh6FHHza4fd7+2dDnl3B3NyV4Z2NzsXB6wupNAAJAKIWQg37EcEYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B6xQFB0owJGdSFT/CYQL5vTCnQxbos62XSBsT3hPYUw=; b=dxv5z6dZad3ROBibGIrVlHpTRC70SRAmnH2mW8l0rJPOsqMmIjncp/lg1Le3m6sEOXDLn6J462ONtWaqULd/tsXudvEhFypWYh5EsVY4IwHXXz/Hg49l9jpz8K7Y3zgwihX+GV+15lgXclTzFiYFBDM3sPzPSr9/Wpr4x90dQB4GMeHIBFnk0nqL1WXiOWiKR/UKIi2tN3pkSFYaKxsBe/9k0qqb7KcDjsAnx8C4iPwD2PDmdGum+1sFaCRHqMNNJ0oOJQ9QDwjr4L6h7956fOxouSjt/TpfMUO3rTLYlB8azZ2UKgXQCGbAaOzSAnnJzc2fX/1rxG8RZLIqYJpOKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5670.namprd11.prod.outlook.com (2603:10b6:8:37::12) by DM5PR11MB1499.namprd11.prod.outlook.com (2603:10b6:4:8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Mon, 30 May 2022 11:50:02 +0000 Received: from DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::89de:bffb:b66b:516b]) by DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::89de:bffb:b66b:516b%7]) with mapi id 15.20.5293.019; Mon, 30 May 2022 11:50:02 +0000 From: "Dumitrescu, Cristian" To: Stephen Hemminger , "dev@dpdk.org" CC: "Singh, Jasvinder" , Wojciech Liguzinski Subject: RE: [PATCH v5 2/3] rte_pie: remove unnecessary floating point Thread-Topic: [PATCH v5 2/3] rte_pie: remove unnecessary floating point Thread-Index: AQHYcT7591x7GddR+kqxVYykv9V4mq03U6wA Date: Mon, 30 May 2022 11:50:02 +0000 Message-ID: References: <20220524184623.480646-1-stephen@networkplumber.org> <20220526202653.99796-1-stephen@networkplumber.org> <20220526202653.99796-3-stephen@networkplumber.org> In-Reply-To: <20220526202653.99796-3-stephen@networkplumber.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b11b197c-5ea8-410f-fcf5-08da4232881e x-ms-traffictypediagnostic: DM5PR11MB1499:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KMm4mDf5Zexw7KJxEyxNc0aLVsB33qFSu4wxRoUa7ZHAQdaNUtEKlSDGoY6GH9Kdr94WGD53OrsGzXOK20FeloqRh2SheWZXVdeZX1x87+8W3Nm5eVGMYs7zl1OJGABOjlXlzVQ0NJIIDvaVdGxEF5aUkRx3tkPDkAbozBZwU5kvOVQn3vWEtw0oRwLI/YFMDDjtAc+Y/Z/m4tqrUAYjePZt1MitjmxU530eMaM4eFBX2ZEUD9QRjTUeEJWeUTJ2iw6wgMCMlzdyAxrGNq/8Yxlt/Z1d4QlSM0yVB2uyP1JNNJstFB/QA3qHB/5pOGFRqDJObJMChj8jG1N44aUx0j0q5eQN+9PwzbU81DRogfJQ3sakKQcy3o6VDG4dOgjY+jIOIWB3RpvZKnjQFs/zFzIdSmEf9r1MJL9oWWfyTY+wsxHLcqDHtXIwwVnu9XRBb4+lljRa0MLM+S+gfvlgBpK0wfGZewRZwGPiIbUu1mv+OCubq3dAa6B+LxbpFDrB+hPTKS5VrXTehcP6fMmGe4nBwOvk1KGVOVaZyvs8gIqPWgBzg19ZsTuzTUDNZesLUBRf3BGepEEFCqO/pyhLTA2EAws6eiMJ3glUAHbW3NvuipxQ7ttIOElq/LutOPQ39gYj1M1Sk79JkYwNXYs53TUwwwnn3esedieQ8G2nZDHyeLadI0P6uit8ShijQcRnqdA3GWKxHDQvicSQTCqqqQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5670.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(316002)(82960400001)(110136005)(55016003)(54906003)(83380400001)(66556008)(66476007)(66446008)(64756008)(71200400001)(8676002)(6506007)(66946007)(76116006)(4326008)(53546011)(508600001)(52536014)(107886003)(186003)(86362001)(8936002)(5660300002)(9686003)(38070700005)(26005)(2906002)(122000001)(33656002)(38100700002)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bsCubUs/o8BG93E3b87/1TmftDJpemDpClhhlGa4d/VE7CnYfk4NFzPdWlq9?= =?us-ascii?Q?QkwrFqNZldi3qaGf29jAs29oo7/odAuqINZgUUTVRfEZ2nrJ5NmCJX2L5SI/?= =?us-ascii?Q?n0IRKn4vZNsgpOllpZkV/Od0vQ2EJ7zOAR7F30oZRoPjYU/mklscPm4ABiKD?= =?us-ascii?Q?FDWSY0CGzuMvgaxbF1YUqVCeQ+/DB4ihx/AvZgjV6RbgfPXgEQzjpHloGo3q?= =?us-ascii?Q?KcYd+EqzvIpJ9t4yBZ9o1hk4Ch7SrWRrMziLbq7jysV3En1u5rgfz9JZWEvK?= =?us-ascii?Q?hbiuBuekxPB9hjHciju2EpUFJEjJE82HdO754tXc2UD3cNWk08PX582WS+aa?= =?us-ascii?Q?Kbyahcz2wjNd86b60+a/q5jDumj8E9HOZd9XMxs/eK5CpbMUa9y1tULTIVMb?= =?us-ascii?Q?1uhoDjNaOeO0pc1PLvaoq9s6xW4RYDog4KFLcJGDSFdZ7AW5L+x3RhO9VRLg?= =?us-ascii?Q?KYTpIxUPgv7OSj4vIZIMeTRkdxagbs8eiLaxbgiL9GHz92q4VS0s2SCH6hos?= =?us-ascii?Q?OlHSk+VZ2kyWK5VWNDNwhCiSrBNSbxbvzegtDQaaiGR1dgxAF9VMz7jqVcb2?= =?us-ascii?Q?pu32HAUR/aYKFBmZALatu1Qq2p4O/wqjz31ZPrRO0Jfw1x4BwzxxfUaBW21n?= =?us-ascii?Q?TcueMwe3Mst0DIDwJATxrNqGkukf7Qevx+eqyjEQB4TS1vXKAWbRlC7lxK/9?= =?us-ascii?Q?/44SJTwe3bkEdC5BOD1vGkHndI9tMvJwKoHMj5idtUpAc0QSu2nnSASfB5XC?= =?us-ascii?Q?rWU5BXiX2jrPa3C4n4eGSVGJtLSFGJUZuwx733n1jnFM0Zalr5sO4hNM5Q1h?= =?us-ascii?Q?eD5au171TwvQOlyJagWwCabDA/xCZkeLqBvxCJHPDb5WIWRBhc26WT0Z2df0?= =?us-ascii?Q?AY1sLzztuc7FDLbeiHq6fSiVSJhN2z3so9kGLGHSWR6xHJ6ipA/KSlIB7Vk9?= =?us-ascii?Q?dyWuQvdpyGdnChsgmMyVFVTvFsH7k8O9eu65wt5Vwl/heIG4fb6dZ7x6wgAt?= =?us-ascii?Q?O/Mf3GW61R6ZifaoB56u7eG7zHCHLc7tKKSrfBdmgTPX8cbfMGwIRf2DVURI?= =?us-ascii?Q?+dQT/3+ZU7DIpESbh27srZ+y9CxniOjqCQ15VCPNpUUBvfTETcZvc6FxBW7L?= =?us-ascii?Q?CD8xKHRC//Cy1RVTeioC7DxocrXkQlytfsrEHmjYy4eE93A4xszxfuld3Tfg?= =?us-ascii?Q?aJYmEkoon72N3fcWrnfHqLd3lXuYYnlsyKlGwYZZpi/QHD6JLHcJJP4dcXj3?= =?us-ascii?Q?3pB/LXBiOT34Scs/HOa3LpEj88XC8fU9tEZTYIzmYqLfXLx20ByMJGTW57Bp?= =?us-ascii?Q?QhDAWpdpaDVw87r6efoQp8MO6bb5toh6fD7jCjJL2dxD2HWe6G+S/TFeZpaY?= =?us-ascii?Q?G5y9N/ACHFh3rMjKWNa3r/SclHMRDxSsk48Q17WZHfvYjc2ZmTsNt43GKHj9?= =?us-ascii?Q?lkR+gApaP7gNeOAs5oa4kQhjJsJGM4e7SJHf+jRiJSrXPXtRfJ3lPsuomlVf?= =?us-ascii?Q?GVi45RGOGR16rofOMSazcifpHdWv83SF8dylr0btbm5B9+vAitxV+k4J+Vno?= =?us-ascii?Q?UGQZ2q/ZHvYXw9n6wdslalBaXT6C5UnLScuHsiUhh0zc+H2zFjtiwXoTmgNy?= =?us-ascii?Q?7Jdn2UB1xHtrThtqbYLX66rJcskB/6HfNmtPkIYaGkIN1uVAOMB7aYjK4XaW?= =?us-ascii?Q?eT1lEJdgStJVCV8jebGNUbX3oMGhXpAHh87b8xekMSTOqihETNn5iPAjPPev?= =?us-ascii?Q?O5EcuHckmDH4rGgU7C1MiiMSjLWAxGQ=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5670.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b11b197c-5ea8-410f-fcf5-08da4232881e X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2022 11:50:02.5720 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /CK5MfaYj8IXGHihgDdQ4aibXtNoGg0ovMlQKAWC3q8J5+kKsWI1lBDUu6qmUKhXBuxaB9/73EXoXhLD14rX2WGnFfz5scpQAY5HZJYvbtk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1499 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Stephen Hemminger > Sent: Thursday, May 26, 2022 9:27 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Dumitrescu, > Cristian ; Singh, Jasvinder > ; Wojciech Liguzinski > > Subject: [PATCH v5 2/3] rte_pie: remove unnecessary floating point >=20 > The qdelay variable is derived from and compared to 64 bit > value so it doesn't have to be floating point. >=20 > Fixes: 44c730b0e379 ("sched: add PIE based congestion management") > Signed-off-by: Stephen Hemminger > --- > lib/sched/rte_pie.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/sched/rte_pie.h b/lib/sched/rte_pie.h > index 02a987f54ad1..3e2c1ef46721 100644 > --- a/lib/sched/rte_pie.h > +++ b/lib/sched/rte_pie.h > @@ -218,7 +218,7 @@ _rte_pie_drop(const struct rte_pie_config *pie_cfg, > struct rte_pie *pie) > { > uint64_t rand_value; > - double qdelay =3D pie_cfg->qdelay_ref * 0.5; > + uint64_t qdelay =3D pie_cfg->qdelay_ref / 2; >=20 > /* PIE is active but the queue is not congested: return 0 */ > if (((pie->qdelay_old < qdelay) && (pie->drop_prob < 0.2)) || > -- > 2.35.1 Hi Stephen, Thanks for your proposed fix. It looks good to me, but since Jasvinder hand= led the PIE integration, I am going to defer this for his review once he co= mes back from vacation, just to make sure I am not missing anything here. Regards, Cristian