From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B492DA0C43; Mon, 18 Oct 2021 14:22:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 36BA540141; Mon, 18 Oct 2021 14:22:16 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id B25434003C; Mon, 18 Oct 2021 14:22:14 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10140"; a="251693347" X-IronPort-AV: E=Sophos;i="5.85,382,1624345200"; d="scan'208";a="251693347" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2021 05:21:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,382,1624345200"; d="scan'208";a="526229299" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga001.jf.intel.com with ESMTP; 18 Oct 2021 05:21:55 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 18 Oct 2021 05:21:55 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 18 Oct 2021 05:21:55 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 18 Oct 2021 05:21:55 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 18 Oct 2021 05:21:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I6i7AinpREDgYGVtkWXgh5M1mNcto30dUR2lC8O/tZ2gpmRCchBNNzdyugHKvAMeqpfYF/pfkaH1R9iuPpBdhgblDLAC++Szq+EogTlDjKesmDVy6lt3AyMEbJS97E+aATAvjdI6YvOj9BD2bhNoH2/cWFpZjccFILsARajhjnJO0QFEGPIpbDAUsIQbrdCz6FS+lUXk3QNHHEkUPgLkiOPeZHFlszXlOyJ97+PwwfgSa9b8kFFyFsmcGYVqTyUGbWYnRYQAL6kzGC+8SajOu56Uec0J2CA7MZxXmvDw+s90vlvoiTLxElPefVJxj7bvEKYJZbUXEtD3d4o5U+wJcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MjiGsRVmYm0XH9VNVGMu4Jzuukt2ziIbwt3KygtFDEs=; b=MOTUzlLyRR8SkCap3c10aIsex2G3zoX+JOqeC3/XkuWuo3iInD4oqs7T33sCcK8Hqxjsd0JcabP20+IubmrRolp0YD17L7JWaBSIMPw2v4xDiH6CHPHGb2xxjAPHlFatIfrJfvwcRDgZ4OxWgMGuTlURCJ/7K6Cn2yTeTRsJY+pdmo45fiueWJNx0k6sx/rCW2jcYXheHuP03KM+6AVjjLSsuo5iefooaB6pUrvcnWxKriQGTe6xwWaRwcRl1T2u0MdHIOy4A8eAWWzg0xXqgith7muf6Ng+wR9dO5DOB/9VYzaivmTyaJs2Bm9ss+5YuDUT4VaZaBy0bs5EyRNlbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MjiGsRVmYm0XH9VNVGMu4Jzuukt2ziIbwt3KygtFDEs=; b=Dr5I5OGqE9CXnxwQ+nIEcNCrCtrX6Os3uMA1CK/aR7mDXCv/7RLyZcPw9KTZz5Oeq1T6fovqXRnaxm45bT5olD1QhUJUpdlC4CTMLCpPwF5Xnf4Bcqc6uB6XQgpdyzn/undxMXV/WuH5V/tWFxIK4K22RRrTCZyOAtOM+xsX564= Received: from DM8PR11MB5670.namprd11.prod.outlook.com (2603:10b6:8:37::12) by DM8PR11MB5622.namprd11.prod.outlook.com (2603:10b6:8:36::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Mon, 18 Oct 2021 12:21:53 +0000 Received: from DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::c0f1:1135:ceb5:ac10]) by DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::c0f1:1135:ceb5:ac10%9]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021 12:21:53 +0000 From: "Dumitrescu, Cristian" To: "Peng, ZhihongX" , "david.marchand@redhat.com" , "Burakov, Anatoly" , "Ananyev, Konstantin" , "stephen@networkplumber.org" , "Mcnamara, John" CC: "dev@dpdk.org" , "Lin, Xueqin" , "stable@dpdk.org" Thread-Topic: [PATCH v10 3/4] pipeline: Fix compilation error with gcc ASan Thread-Index: AQHXwdb4fgusEoCIykul3Qb0NwXkI6vYsRKg Date: Mon, 18 Oct 2021 12:21:53 +0000 Message-ID: References: <20211012094318.1154727-3-zhihongx.peng@intel.com> <20211015151110.1876850-1-zhihongx.peng@intel.com> <20211015151110.1876850-3-zhihongx.peng@intel.com> In-Reply-To: <20211015151110.1876850-3-zhihongx.peng@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 29fa6b49-ebc9-42b2-84c3-08d99231dead x-ms-traffictypediagnostic: DM8PR11MB5622: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2958; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hlmKt9l8wnfIMl3raBh7EBkZR+/a51+ssflE0Bcl67JYMz17s/OzdqPZBcCPs4LhByYIvbp274eJO+MgrI+t8iVTjZ19qBHFC1hpPPqgs8bfX1/SCOKbFAQhHd0hRF/xQaQtm/a8JY4Rgm4wQPeQJdyeq3GBb2m46TocJwWZZwIQ0qwCNOozAFfCMLx2kpPc8Hu4paUT4VsBtVt20xu8PFC/vzmeDbqM25nI6WEK5KZbkncqNefAF3WlpArsFw/Tm3l9JbIDgyQ/4cO0QVIWidXqg/4xFwkDhmTJqhKpkwN8sn9IIoLy0MKTTMfJUyCCS7jOyG+IPAwjQ14qNDoqRhnMvWC3eul4khXsxROBRg5oFqVTYf/KEd76kxcf1xZWiNKOlctoZp9mND/Mkmf8SfbR8OGPA2nJouexHDeOnWeq4B3OTO7/5R+X3i18q49aA3og38575I2o5w7nNPaKaBYaytTEtxETTnn+WdGWROKgvr0FPleVigvg/PjuxOx0B4464zEILt5haofdZcToVl8W0w0OAIMitIu92iz3w83oeNVJdD6Qxbep0DNZx/epFoeMzKoNtMNhtqCsotGEyhCXz/xAQwKXrZTy894A58OMFR1glXgaX1a2B0LnecIJhVQU6dpJ7Nc6hz2jRw2rQeXmJ/sJlfCOhBi29u9gigawuC4lS9nHyaedj2aph4bAFg/UMR88OA6XN4+xlJgNyg8Jf/ATGz/pJhEMNBj9RaE= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5670.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(66946007)(66556008)(54906003)(8936002)(66446008)(66476007)(82960400001)(64756008)(86362001)(5660300002)(6506007)(6636002)(76116006)(38100700002)(2906002)(110136005)(71200400001)(508600001)(122000001)(9686003)(55016002)(316002)(186003)(38070700005)(8676002)(4326008)(7696005)(53546011)(52536014)(83380400001)(33656002)(921005)(26005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gfiSd+TCGP5ZJJhxRdIAnI7fkWODeJ9VaVNZw9BYpUZxXdUqE/zVOu3BFU1j?= =?us-ascii?Q?1BJ+xHXGkYa/S9sBrY3tnpW6GtTDxMQOWw8lh10Y73IFvj4srbMawEXbtcyE?= =?us-ascii?Q?r7LkyNtNcHNSlUcBM7Lwz8ymeA5jtXDS5fKSYlJCKFOpsx6t1/jW6x84KqBA?= =?us-ascii?Q?H+9BJDnr0h9rWwOTEeyGx01p4S7cRd39wejNCpRwYtfKfm6fPEJr/+elCAeC?= =?us-ascii?Q?DZBDe2GSsf31JbSWz2HQzWPuseay3ZrdXwGcyNkhwNUfHaZtZ7MCy6+OAXKO?= =?us-ascii?Q?cfxoq5Q9+rgrqkOdRBky+1E4bsOEylVmygEs9KmYadsB6lSQM/zzHyxYG976?= =?us-ascii?Q?1ed+gWf6lJ4EXUzZmR2fVlNMX7t6eoXJXat9zfZTTrJmhFNzOPo2t7rGakJd?= =?us-ascii?Q?+hvIC0N/fhUHqFJVMRsHkdk2up2CjkdX2F6M8NfJD7iRxEtDIf/htBI1YcTP?= =?us-ascii?Q?+HxkmNNzhinSYnMvN1Ous9f5TszCPPjyOijfwTIoGiOiNGxQ8SvKt1HyjLoK?= =?us-ascii?Q?IrmWyk6hoRVKfsDoF/PbaN28+lOESMH9WIzKY9eR26odmfBKN/Xot9xlJFdC?= =?us-ascii?Q?qy62+19VUCmcuo4PlkqXwrm3TUzxBIfC2YSQQxoUeoVMZbhAM+Ky6jiJBe9t?= =?us-ascii?Q?skLCrx6dhKAkOAzjTrxTNY9cJhMorQE8zlvD1vzpSiAYxWmp8FQiCMn9kUmD?= =?us-ascii?Q?uGGKbaf2ZPgRU99mUgfsA75usTIY6GqPRjdOdiROFmXsu1UVkCpZZE+fPlMV?= =?us-ascii?Q?NL/wFjy7B2iZkcAM3y+ntimqxWdp15VJhk6Z/qnLtGOTgQuyN+Ski2x9nHvH?= =?us-ascii?Q?5KHN/Li6e8pZX+xnJAnwkY3C25RB6eVUGlWD7Mi+w5c7bNaD2JU60CNu+1nv?= =?us-ascii?Q?io2MXVSWkp/V+GgNL3B7t93PX+bPjGzwEOjkpo38K3cTt1cYv+mOgnfUh9qN?= =?us-ascii?Q?7WOwY5GMIc/wgVhACqfiGFBkI+Qu+UACdrukpht3uwZvR+BEkmx4X9ChvBcW?= =?us-ascii?Q?YSuJl5oX9idB6HfJKV6aOHDKJkt8xLyyFM4UmpQPAt+bEaBq2wEgM0ZMlGOv?= =?us-ascii?Q?W8caXwsj9hQbn4aauGAWZOZgSLkMpe6m4jKKFyJoDJgMheT0oH2wMdBUkkYH?= =?us-ascii?Q?6iaSoOmw74z4WssAU3DB1j/6OOmo99LkqgXcJTTQQRbsbOGrDYhj3+3aDyp2?= =?us-ascii?Q?5hCIC6WpUGyJdDs3q+XFWhhgud8X5NnZoDM6WJlFlgQR9/PhcIEERPozVNjn?= =?us-ascii?Q?Tm6i9JF2PpFman4cVTPhjX9SElqlzN57OaXcodSBPRsCJ4ztZb7T7zM5j12O?= =?us-ascii?Q?jbFvxjyx1y4bOJXUeQ/ljRFn?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5670.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 29fa6b49-ebc9-42b2-84c3-08d99231dead X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Oct 2021 12:21:53.5517 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GBmVXnI7v7FisU+l5BI1oyxhjFlf0qSM/bE/kiTOoIkSpbuglARSfOTw6TO4klfdkolLWLs9Oiav+mJ6uPSgC4Kuges4IUmxM+WgtVUne2M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5622 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v10 3/4] pipeline: Fix compilation error with gcc ASan X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Peng, ZhihongX > Sent: Friday, October 15, 2021 4:11 PM > To: david.marchand@redhat.com; Burakov, Anatoly > ; Ananyev, Konstantin > ; stephen@networkplumber.org; > Dumitrescu, Cristian ; Mcnamara, John > > Cc: dev@dpdk.org; Lin, Xueqin ; Peng, ZhihongX > ; stable@dpdk.org > Subject: [PATCH v10 3/4] pipeline: Fix compilation error with gcc ASan >=20 > From: Zhihong Peng >=20 > The gcc will check code more stricter when ASan enabled. > "Control reaches end of non-void function" error occurs here. >=20 > Fixes: f38913b7fb8e ("pipeline: add meter array to SWX") > Cc: stable@dpdk.org >=20 > Signed-off-by: Xueqin Lin > Signed-off-by: Zhihong Peng > --- > v7: no change > v8: no change > v9: Modify the submit log > v10:no change > --- > lib/pipeline/rte_swx_pipeline.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/lib/pipeline/rte_swx_pipeline.c b/lib/pipeline/rte_swx_pipel= ine.c > index 1cd09a4b44..0acd6c6752 100644 > --- a/lib/pipeline/rte_swx_pipeline.c > +++ b/lib/pipeline/rte_swx_pipeline.c > @@ -4642,7 +4642,7 @@ instr_meter_translate(struct rte_swx_pipeline *p, > return 0; > } >=20 > - CHECK(0, EINVAL); > + return -EINVAL; > } >=20 > static inline void > @@ -5937,7 +5937,7 @@ instr_translate(struct rte_swx_pipeline *p, > instr, > data); >=20 > - CHECK(0, EINVAL); > + return -EINVAL; > } >=20 > static struct instruction_data * > -- > 2.25.1 NACK. This is a false issue, no bug is here. CHECK(0, EINVAL) translates to an un= conditional return -EINVAL. Does this tool work correctly when macros are present? Maybe the tool shoul= d parse the preprocessed C code as opposed to initial C code? Regards, Cristian