From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC1A3A0A0C; Tue, 29 Jun 2021 15:51:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5F5D1411C5; Tue, 29 Jun 2021 15:51:14 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id D6E8C40E01; Tue, 29 Jun 2021 15:51:11 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10029"; a="208187529" X-IronPort-AV: E=Sophos;i="5.83,309,1616482800"; d="scan'208";a="208187529" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2021 06:51:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,309,1616482800"; d="scan'208";a="625638765" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP; 29 Jun 2021 06:51:10 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 29 Jun 2021 06:51:10 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 29 Jun 2021 06:51:09 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Tue, 29 Jun 2021 06:51:09 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Tue, 29 Jun 2021 06:51:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m/npEHWMnsq6741AtfpSN/6h1pU7cpT5dUsgWeEJ7op54pnXRr77wFDve2kknAYzST12dts/FTTXriecEcNkeTI7xPXamgjBZTLd+0KoePtsUc41zv2UWP7eiKecr9jdMOSYj2LEe6AN50pR655KwA1tIWW7hXEVAcLciYl/b97DET+dG1/u2eLFc+m0I/Kv66VE5INrl549HwzG5pMIDbQ2eul9sp9WOl0Nk45vVrkUFHXy6E6zocVYuz2MI+E2qLzzo3aZQsP2fSRQco7vpCTugyjEuGbMCJpqWY/xrGyLdIhKmQt6VHG8340l2IO1Y4vcVB/oYVdL6ecUvQRgBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yeSa9m1MAVuSGFFmbJs6hJQYUlnhYxEsFLeonQKfneA=; b=bPuw1hxaBOB/EPDFlkqSvKn8fUTfh63Xqd9gy1xDXdTq0QBiup8PCZwzHyZIzQ6U15Jr7rD5ftk5fCfd58wdsujeA69ASRpoJR6bSZy8hezFyuu/newOdaRFPZQ0ACx7PK+usZo12o7xlLP8ZOdp3i7tQjYnUlA4OeYmkvbLuKpkPasfJd51LExx+sXJgg0cd+ACc6pAxtugo2u4GFDyxAPAgzzr7t3uUkMHVmXtCTFyg5j+VTF3nfbXNVtsY/oMp+DDxWDUy+sBuXcBrzsBaHbXLH4/ctpkmZGN23shfUI4l/rOr0PV/FwuQw1EifOaGbrFACeG0ymDwEtk6VbN1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yeSa9m1MAVuSGFFmbJs6hJQYUlnhYxEsFLeonQKfneA=; b=yQyFt10SKTHca2dQuvq2v1uS8KSRJQJTS029Hm4k0o4gzO40LyviX0a/0NtYgtN5XwrDbR7nFAz1WSt/IGyHD+EXdKLzYOAeTG470jXaFrcmhoZRsLIRkwEbHk1Jt1rq5FLCrUAPhjIKgd6fOxRmhKaBqNE5tUeMEbdmJoTQI+k= Received: from DM8PR11MB5670.namprd11.prod.outlook.com (2603:10b6:8:37::12) by DM8PR11MB5622.namprd11.prod.outlook.com (2603:10b6:8:36::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18; Tue, 29 Jun 2021 13:51:08 +0000 Received: from DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::e0f9:356e:4e86:85b9]) by DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::e0f9:356e:4e86:85b9%3]) with mapi id 15.20.4264.026; Tue, 29 Jun 2021 13:51:08 +0000 From: "Dumitrescu, Cristian" To: Thomas Monjalon , Thierry Herbelot CC: "dev@dpdk.org" , "stable@dpdk.org" , "david.marchand@redhat.com" Thread-Topic: [dpdk-stable] [PATCH v2] table: fix typo Thread-Index: AQHXUI/9ZE9ZEBe9tkWB87H3KQvEVaryfwcggCVs6ICAAAMEAIAGamIwgABw84CAAAWtAIAACz0ggAw5FfCAACOAAIAAAPYA Date: Tue, 29 Jun 2021 13:51:08 +0000 Message-ID: References: <20210524085341.15184-1-thierry.herbelot@6wind.com> <1770440.SLloOXSvDy@thomas> In-Reply-To: <1770440.SLloOXSvDy@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [64.43.147.100] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 39c8190d-d3d0-46a2-2522-08d93b04f290 x-ms-traffictypediagnostic: DM8PR11MB5622: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bf4yIpbKgR3OrpuSvDJ4RdNVY7TMCCNYGblgQqGYKfznGaBegozFCh2xdOpq9P7Qal1bnDH2B5hIu4snd8jJixoAxVt5e8dLuKRvMBAo3wyIwB7CVdQ6Z0LsJfHttx4U+6E0TcUDqjNL/7OmrM6Jk8XMYbGm+C/T/AsVQntrds0jp0V1Fig3iZr6b3oOyrXWFFfZ+Pi4AR7O43YEEsJbpLKx9sSBWY/xRZ/LnSEKxL2j92bVyIGSusYKqA0CcwlTW/zEEGMPw4iv/itnJLNsGp9ZtoydWZC18yTG7NM/277ot4ecH4iQ7bDwmAbdTSiamG+Ks2qiHuq/YAwSozSnnlYguQq1bviu2dpljMxxSseQzwD47WYLTpNrgD9W1YTnngmRCcVoiJCO2JWwxG+Zo3jx4QiX0NBg+2nYOUTgCkm8gQkiiYKGBzACYletykmfhyB4AAscxldDkL8FIFGYvI6IK5zdIKFsNJ3dQtnKCwMA20gqOHcEQ9pGpmlByJ8yhxSVcet2owz4EFgNB5jfbnYIbkxMBsOI2M8xVB1JGtS7F+1AzHXsXSOMh9DsJkESmDNsWF+GcwLLC7i6MIjET37zviQyJTAzYovp7KgLEDiDNKwookEY9Qupf6VkDIIHCB6R0tf+IlaiwAZ6I+RxjQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5670.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(39860400002)(376002)(136003)(396003)(366004)(346002)(9686003)(33656002)(86362001)(186003)(4326008)(8936002)(55016002)(8676002)(71200400001)(26005)(83380400001)(76116006)(6506007)(66946007)(122000001)(64756008)(66446008)(38100700002)(66556008)(478600001)(5660300002)(2906002)(110136005)(316002)(52536014)(54906003)(7696005)(66476007)(53546011); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EMlg/OUrgcJFvee+vW6byKjLXPnHWyZXEJIOTXCbSy5MlWyM1rqD9n2jpKIK?= =?us-ascii?Q?xG9QZHsZYdjEHcYaS562QOBtHPiK/ToSdFBj0xFcNSQ1Lqmp7jaMnpWTBs4R?= =?us-ascii?Q?rL1p7SQr803YLwdAg3qFxPQFMWSR90kjbegRJoS89WZB/BwJIvjuBqG9h8+Q?= =?us-ascii?Q?WUL13dKEwbu/EVfqwgTZfUrlZBoK+8Nd82m0Tp69ZiTpXSLNRiDyUs2YSX4D?= =?us-ascii?Q?NRTPebp58gg6fvkAmfn67CTYqucY1kdEx29Znye18vY63xUGm84FGZcOcdH9?= =?us-ascii?Q?o4su8f01lH7aHB1c5iC6hcG7HGMZrWmj576wnQN1/M4ZM8RHFPqBgP3KO/o9?= =?us-ascii?Q?9k/TbnEIMroJYhiSDrPIwQZtTlujjNd65IFveO2EXUm6Rh+chrQoC1elPyZi?= =?us-ascii?Q?AMAx6q1w4yOZ4bKZiXbidotzvtLk2IP4Tztx//Tqr/5WCDZ8/Eq+5UWt/kfv?= =?us-ascii?Q?E/1mHdqWGWrJBbhrtLn7xfzPSA5BpYIT5/PotYb+INQcEPVs3CGK3aDfcw9b?= =?us-ascii?Q?pBwslsDOiZu2r17DzA9c7xXGS9cQNdBXANKBZTeCmPXCClAkGLAjHmveoFPh?= =?us-ascii?Q?evXnuNlDO9Fo9V3094Rmn2GduQmpqAUa6XRJt9VFEoyrOgaKv8NYbRVyjeNg?= =?us-ascii?Q?x4Q0D41+XcO/oKBQsrDJM5ljhrrOZ8RHND2Nx+Hu/wWj2knAkosLzf8I8Yts?= =?us-ascii?Q?H/rjWLr/2Vugc5+aveXKVb4TJbathIlDX3R7QlCVo7NFU6tQBTFnqFFtomuY?= =?us-ascii?Q?jPOU7UZ2c4Pu9ApxlLXXC1+LekwuLYr3Jn/8Ji4N5KbYlA+ogYPGzX02w0gy?= =?us-ascii?Q?1yrNHCw0/Z/tgdbO1coxvCfKw/BmsfJ7Ig7Gr8DAh7gGzUw5Ak0EQ8UEUM46?= =?us-ascii?Q?tK9wfpNLlSFqDhlG6BAYAPzoSdnkv9S+XiBY6RWqBfSEIgbUdAhIn6Px+1O2?= =?us-ascii?Q?EhAX50iroGVmHFEYtqL8Roq5GucssB4KSG+lY5G9MxyKgxsE6C9v2VHUgpNB?= =?us-ascii?Q?MyVS2axErd4veSsmmyci6bmao9F9+DYJRckjU01AZNpoRQ10e/w6rxXLWU5f?= =?us-ascii?Q?RFxCQG9jcLjyzkAXNWOoodlknQgMT2Q676foCcJnBXQO/qzyZFxzS4tHdNU0?= =?us-ascii?Q?MRLT++5pFDCF/IYp2k/jKem+xIA6p0UBgGq2VCu54LiwWNMY8R6fCnDDgF8b?= =?us-ascii?Q?7KdxSdSL3fc1h474be5pgRlevPlP5IVgr7b9fJx2pKzZRX2iMwxMp8ZMF8rt?= =?us-ascii?Q?oinuxgmhInczqSLFgpnR6fn8iOJNjf614bUoe/79r+Ks5OWZpE0zTefGWqBf?= =?us-ascii?Q?PxrX6e+6jgLYnVIsLp8OCEsP?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5670.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 39c8190d-d3d0-46a2-2522-08d93b04f290 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jun 2021 13:51:08.4578 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JLXZLyblW6BPt76QCfu+0RfILipo6UdN0n4/FUVr3SdECZb6i4oSKQetDBLZm4bNExWiLkFHbwJT73XbxCKmhRLugsq2RU9ZboCj0P89brM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5622 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] table: fix typo X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, June 29, 2021 2:41 PM > To: Dumitrescu, Cristian ; Thierry Herbelo= t > > Cc: dev@dpdk.org; stable@dpdk.org; david.marchand@redhat.com > Subject: Re: [dpdk-stable] [PATCH v2] table: fix typo >=20 > 29/06/2021 13:35, Dumitrescu, Cristian: > > From: dev On Behalf Of Dumitrescu, Cristian > > > From: Thomas Monjalon > > > > 21/06/2021 17:54, Thierry Herbelot: > > > > > On 6/21/21 5:44 PM, Dumitrescu, Cristian wrote: > > > > > > From: Thierry Herbelot > > > > > >> On 6/17/21 9:01 AM, Thomas Monjalon wrote: > > > > > >>>>> Check Bucket key for all possible indices. > > > > > >>>>> > > > > > >>>>> Fixes: d0a00966618ba ("table: add exact match SWX table") > > > > > >>>>> Cc: stable@dpdk.org > > > > > >>>>> Cc: Cristian Dumitrescu > > > > > >>>>> > > > > > >>>>> Signed-off-by: Thierry Herbelot > > > > > > >>> [...] > > > > > >>>>> - return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && != bkt- > > > > >sig[2]) > > > > > >>>>> + return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] > && !bkt- > > > > >sig[3]) > > > > > >>>> > > > > > >>>> Acked-by: Cristian Dumitrescu > > > > > >>>> > > > > > >>>> Thierry, thanks again, you could have actually added my ack > from V1 > > > > :) > > > > > >>> > > > > > >>> The root cause looks to be a typo indeed, > > > > > >>> but the impact or the scope of the issue > > > > > >>> should stated in few words in the title please. > > > > > >>> No need to send a v3, please suggest a title and I will apply= . > > > > > >> > > > > > >> table: check a bucket is empty for all bucket keys > > > > > >> > > > > > >> Thierry > > > > > >> > > > > > > > > > > > > Hi Thierry, > > > > > > > > > > > > I think Thomas is asking for you to send a new version of this = patch > with > > > > the title updated. Is this OK with you? > > > > > > > > No need to send a v3. > > > > > > OK, so you're going to fix the title while applying? Thanks, Thomas. > > > > Hi Thomas, > > > > I see this fix is not yet applied, is there any action required? >=20 > The proposed title is not fantastic. Last one is: > table: all keys must be checked to declare that a bucket is empty >=20 > I just need a title showing what is fixed. > What is the impact of the bug in bkt_is_empty()? >=20 Hi Thomas, How about this one: table: fix bucket empty logic Due to a typo, only 3 our of 4 keys in the bucket of the exact match table= were considered, which can result in valid keys being incorrectly dropped = from the table. Regards, Cristian