RE: [PATCH v3 0/4] sched: cleanup of sched library

["Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>]

> -----Original Message-----
> From: Ajmera, Megha <megha.ajmera@intel.com>
> Sent: Tuesday, February 22, 2022 12:58 PM
> To: dev@dpdk.org; Singh, Jasvinder <jasvinder.singh@intel.com>;
> Dumitrescu, Cristian <cristian.dumitrescu@intel.com>;
> thomas@monjalon.net; david.marchand@redhat.com; Thakur, Sham Singh
> <sham.singh.thakur@intel.com>
> Subject: [PATCH v3 0/4] sched: cleanup of sched library
> 
> v3:
> This patchset involves the cleanup of sched library:
> 
> * Addresses review comments on v2 patchset.
> 
> * RTE_SCHED_CMAN is left unmodified in rte_config.h.
>   Cleanup of this will be taken up later.
> 
> * Removed unused flag RTE_SCHED_VECTOR from arm/meson.build. Only
>   scalar version is now supported.
> 
> * Added grinder configuration in docs. The configuration is moved from
>   rte_config.h into sched library.  Default number of grinders is 8.
>   To override the default, specify RTE_SCHED_PORT_N_GRINDERS=N in
> CFLAGS
>   before compiling sched library.
> 
> * Sample app is updated to always collect statistics as this flag is
>   removed.
> 
> * Updated softnic library by enabling TC oversubscription.
>   This flag is now removed from sched.
> 
> v2:
> This patchset involves the cleanup of sched Library:
> 
> * Removed unused sched #defines from rte_config.
>   RTE_SCHED_CMAN, RTE_SCHED_COLLECT_STATS,
> RTE_SCHED_SUBPORT_TC_OV and
>   RTE_SCHED_VECTOR.
> 
> * RTE_SCHED_COLLECT_STATS flag is removed from the code.
>   Stats collection is now always enabled.
> 
> * RTE_SCHED_SUBPORT_TC_OV flag is removed.
>   TC over subscription for best effort queues is now always enabled.
> 
> * RTE_SCHED_VECTOR flag is removed from sched library as the code under
> this
>   flag is no longer useful. Only scalar version is supported.
> 
> * Rebased with latest main branch code.
> 
> Megha Ajmera (4):
>   sched: remove code no longer needed
>   sched: move grinder configuration flag
>   sched: enable statistics unconditionally
>   sched: enable traffic class oversubscription unconditionally
> 
>  config/arm/meson.build                     |   1 -
>  config/rte_config.h                        |   4 -
>  doc/guides/sample_app_ug/qos_scheduler.rst |   5 +-
>  drivers/net/softnic/rte_eth_softnic_tm.c   |  18 ---
>  examples/qos_sched/init.c                  |   2 -
>  lib/sched/rte_sched.c                      | 156 +--------------------
>  6 files changed, 4 insertions(+), 182 deletions(-)
> 
> --
> 2.25.1

Series-acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>