From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2CAFA0350; Tue, 22 Feb 2022 16:27:41 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 410A340DF6; Tue, 22 Feb 2022 16:27:41 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id D3CF440DF4 for ; Tue, 22 Feb 2022 16:27:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645543659; x=1677079659; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=SmStpXnwzUgt0zG1Z0biv0N6482Ub89aMbptm/Ai5Zc=; b=LGhqxYBznvjIa/zPsw4fep6YgYLLEWSaYUXF7C6aW0oa6NL6leoJ0/R6 o25i43/cPW2CKl6noaOAvNB8Bh8np+mOuX673j7TJW3hXzQbJK8W8O6r9 pEDUfe9qOvNtI/r6NJH4YfHTdzOteoB32Q3ceMb4JOrZ6I5bCz62+3xbW cQm8k21SEjKS3zDy4zslm7xZkWzKWXHkpdz76CZGu+e4ZcTaB2b+gDa5y AxQLJyAu6nnit4TapAx8iO9WJcw0IxK48qBdu0qsaXTa7CXIyLsDbMxO9 NBchtdYg5gYV/WQgivbrpijp/WDJZ/YohoLHqRdyu5s7P4uAKyAL23sE6 g==; X-IronPort-AV: E=McAfee;i="6200,9189,10265"; a="276333962" X-IronPort-AV: E=Sophos;i="5.88,387,1635231600"; d="scan'208";a="276333962" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2022 07:27:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,387,1635231600"; d="scan'208";a="490831526" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga003.jf.intel.com with ESMTP; 22 Feb 2022 07:27:36 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 22 Feb 2022 07:27:35 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 22 Feb 2022 07:27:35 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 22 Feb 2022 07:27:35 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m9CxhDPnkbEc4b6Dnq827Q+7lx9lHjbFpIY3WIueAMIlMXRQCHbxBV6INfVXca9FpuLjL8+x/Gz9zdGI8wVgE/CriFLn6wLzy1WyYxrQ9mGPyD9iKLrG/C4XA3qhIyn1V4Vr5zMLTf9KTiBgbCI4QEg5nO5lwyfavILu+HvQBh6bMok36Mgoh2+CyCVPiXLUlG+C1Fm+3uUPcjFtC8bf2AX7f5p/YJdwhn7v6Zy+SCmGOUaq6xi93yAI3QBNsGylA+ubCKYXyCmJcyupD19aVkuzmVPjOL31mhypZhRikWvJZ5nwel0LpbKSV+yTjO7NSxqjuij7LobUw6N8Bldong== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ON9TnW0AM0qR7QS0VD4R8kkqwNO90ShiEouWzSqNB8I=; b=KIn7u73Vhgs/AIIf07ooXyM6YlefA/ZiwPpkrnfyFO+SiOtM5tkdgwOWG4xiq/XmHb8y7u0ICjtmmmZ6b8dk0lQQd8OO/xDqI9/LD5EdMA/fKEmXSstP0m3n0uidKD3blVy9NgTlhOx+FcGLZLsmUuseB5NMQc5D1BZtsimkaZlhvwJ72EwjN2jRCWza+gW/DhQ1ZfM5YvcRtc61Q8QXetIz6/y9Ne6JxHFFdx/sWFJvQsxm+h2H6RjaOOT7T8aJnPhafsJXyC0kcYN/i2z9TsbKWT2xQy1g3dzPjiese4Eahn1D0gTS8HGx/yNEZ7/6NG4bF0GjS6ZiHodpKtNFTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5670.namprd11.prod.outlook.com (2603:10b6:8:37::12) by BYAPR11MB3413.namprd11.prod.outlook.com (2603:10b6:a03:8c::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.24; Tue, 22 Feb 2022 15:27:33 +0000 Received: from DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::e9b0:843e:2b39:6680]) by DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::e9b0:843e:2b39:6680%4]) with mapi id 15.20.4995.027; Tue, 22 Feb 2022 15:27:31 +0000 From: "Dumitrescu, Cristian" To: "Ajmera, Megha" , "dev@dpdk.org" , "Singh, Jasvinder" , "thomas@monjalon.net" , "david.marchand@redhat.com" , "Thakur, Sham Singh" Subject: RE: [PATCH v3 0/4] sched: cleanup of sched library Thread-Topic: [PATCH v3 0/4] sched: cleanup of sched library Thread-Index: AQHYJ+vQR0XqxDGf8UmapgFr1+Jns6yfsWZw Date: Tue, 22 Feb 2022 15:27:31 +0000 Message-ID: References: <20220218093650.2549927-1-megha.ajmera@intel.com> <20220222125745.2944462-1-megha.ajmera@intel.com> In-Reply-To: <20220222125745.2944462-1-megha.ajmera@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 80a2f317-77d4-4691-10cd-08d9f617d7dd x-ms-traffictypediagnostic: BYAPR11MB3413:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: E/cTaLMj4FgM7gXBG/VtbLWnJqGOuJ9c0TyP7O2sPa9/yekEr7SVCnCdO0CtWVgFIY2NULlSqikNiyoZTVhO3aHAuqNrLF9yndeI5YTeorsmmJcL/zG5FpomK3S3+EAaZEwS9UyhNT8zrRL5jB0JGDfGE4GyEd0I+XKHq8uvZjR+grT0wqLVojV9CEQhEZVuGiZXlULLuG0RsRUAF+dEJOZRlYhUQwDR0uqYF9l0oxJUgul56P/hYlXUzbbiZt1cWRmdpqXO7X0bRauORjEYq1d7FTv2YlqOVOV5C7S5lcEsGtaYeHjImV51efyCPtuUQiK4r44DwqUCwQTbnZogFwAJi8wV7yRTul9s9TSlK56WaICHBEbUGXdbJniQyCncGOnNFbLGuZH1zFndRGquXxcA9HNO+tlaBZzipzRdl483uO9DhDSj9IP3tel9pxuFkQn4+x0liGwfzScc2sGUCctbxcGBqj5HZbw/0Bjsz8+si/xnAEVI88TOOFhbTXehhcNHwUffH1Ub9k6itdkGYx5XYBr+fG3vNL/JDleBaLAPCohFxPgwnXsoov/T9CGYGyw/8JU3qI5iAcBgxWrvYjiiPuTkD+m9dwJSjoVsv+FWVlZumlOsZV7ORNYU6nGIhwinkKPqoa08ckgnVjOWxS+Jb6gUbzSzbG2fGCIul6Vvxbl0fPillNNWRLIEiq7ZxDQ2si4poU91u0z2qdQrDA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5670.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(66946007)(64756008)(33656002)(71200400001)(66556008)(6506007)(66476007)(8936002)(52536014)(9686003)(38070700005)(7696005)(66446008)(38100700002)(8676002)(110136005)(5660300002)(122000001)(2906002)(6636002)(83380400001)(508600001)(53546011)(186003)(55016003)(82960400001)(26005)(86362001)(316002)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?cSW2dYtqwbLwPFTbVwyGpSLWgSVCRIXJpCcBSg/bVl6fT2LOSWetk3rRZTO5?= =?us-ascii?Q?rOx8LN7dbbzXzrJa1B+43xtvrnaJ0CgoSB6C1sF+bHzgAHoX+4vzY89Z6gho?= =?us-ascii?Q?h63we0tMkXddP+jD4x3ydK3t75Kqku7xgbyrIB9JfDoj5DSQT9mvmhVnfXpp?= =?us-ascii?Q?B2OmWD0RSw4rXYgMxDoxAY8YwMaFS/ULf2cxo9nv2RXwE9hG66ZInrcP24b/?= =?us-ascii?Q?NmROs7NSC4f1LLY5MNomn50ZgvO6s3og0T8Axv2VWPzcmaQnnOaWB8+3gAfO?= =?us-ascii?Q?vz40Z5Ss8YC9ICT7tYU1JiUIx71CPpYEPPUE5GVlnbUw2wOZ4WWVdFDwWGSJ?= =?us-ascii?Q?JvuMLcvDjwN70fOph95l1dmMr9ugIJK/7iZCKFbGjCcNjm/rflsB7q+BQxep?= =?us-ascii?Q?Hohjhyb1b65wHR3pLY54HMsx6THzJEytyI6rN2bHrG8EOgEnV1q99Zk3f+uo?= =?us-ascii?Q?Kcm61Bj9y91Q4py+sP3GN5yQAvwO2E1J64mLBZonfoiZpo2Fu1cJtwzK7SUO?= =?us-ascii?Q?V2+QHKV7ZJnQh6B4/lT6ftgRH4Bf4y3E5ReL02sJkK2SrBpDvWlkN0q7Kc15?= =?us-ascii?Q?upn3mseix/ojjK1Xlhe5mz5ClhEKu7OsI0VSm6tCbyL8pTAwc2iKaFZYV0Ui?= =?us-ascii?Q?8yRusnCByKgPos7xUEeg8kqXDihgWeTsxPtUseqp7vaKbRqfLRIEt5kgQNTX?= =?us-ascii?Q?OPXhiUxjFAj87+DpgPyXEGsSsmLfdeGC3Ci0yaD7jIQUldrWD4Af4GIFWb7r?= =?us-ascii?Q?JGp/b2MHD+KupxEtJNmDVUmT7su9SZKmczJqBUh2tgk+NgWLODZPJeWLsntQ?= =?us-ascii?Q?9+0EuZj5gNsmAmbl/pTbpwZ4xhS0qTFHR3a+BpwtqhPRivGOAKXHYthgWJEd?= =?us-ascii?Q?qTVgRGj5YVdOGPe8/2UbMCQ7hhxvz0xuaidswmFAUl/04x5Ac4V+P7ZQgywK?= =?us-ascii?Q?7NzNfDR0ii5ctlMkwBx518SYJK6IIA+Ga+5qO2bwTMoW5q4hmyP+hd1pfiwN?= =?us-ascii?Q?00iRBkpZ+32W2lSwg5AgHpyr6fXi+UYyOpawhyNGsK5/BjH4KJXOO6zANLws?= =?us-ascii?Q?4zq1a+zsfBOh1gclfBPI3py1H5MsnQvGOC9LkUGaJDObDYySxMgK/tKtW1Cm?= =?us-ascii?Q?Qz195hpLdf3Hbk9maoXuLFfN6rlcwPVfzTMvf4oPfjuLxG98QcCvDOsqR0Re?= =?us-ascii?Q?GP367OBw272s3MoY0Dttnl2/S0ZvI+0z8TwNeOKqPEj2tPIvILzQ+YakmLxS?= =?us-ascii?Q?xKO7LBxAXsOVosDGDx7y7mxKj2e2pRR+tmV8Po+y0F+safcs2HZtkJRv3cpv?= =?us-ascii?Q?7k5vo8nGwTsNS6N6ouwEYDTrza7ipgFd6TDsGxYiyyFWM/hUwzILrKOE8KPp?= =?us-ascii?Q?mnVdCAhS03kLX9E6XckzLxi9nvv4Uwn59uTOWmN088Srgob9rO5D2rEEWno/?= =?us-ascii?Q?JAlkkwvB5Wc3Gno3aYM9K6UaWOJ7Ar0ADAogZBfhWxglHDp19Za/6Azydixd?= =?us-ascii?Q?CTg0SFB7Vmv1lFle5PACPEbm1IMiJZxvuxcSxXa+7/2+QLQd3sd+bhYi52VM?= =?us-ascii?Q?hc3RV/FTrxH0mheWna8fXOAYHmrs2bp6u5eYnxUZ6IIg6REgvHedvS9GooRf?= =?us-ascii?Q?YoRK0x8gsVck32QYbkQcQGOpqtq0BnK4AjQJsEk+wA6mYUbbm+Fd6Mk2q/GD?= =?us-ascii?Q?7hioJQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5670.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 80a2f317-77d4-4691-10cd-08d9f617d7dd X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2022 15:27:31.4812 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iHzcCHfiymiWLwhHqHCNp6k/uHecignxZhZ62Y8qklHYqpbGQ3+QSjpKXMpj9IbWXAT8w2sF574zcK7qa0IHs1PwTrEAUDdTHtarSc7/TCo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3413 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Ajmera, Megha > Sent: Tuesday, February 22, 2022 12:58 PM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian ; > thomas@monjalon.net; david.marchand@redhat.com; Thakur, Sham Singh > > Subject: [PATCH v3 0/4] sched: cleanup of sched library >=20 > v3: > This patchset involves the cleanup of sched library: >=20 > * Addresses review comments on v2 patchset. >=20 > * RTE_SCHED_CMAN is left unmodified in rte_config.h. > Cleanup of this will be taken up later. >=20 > * Removed unused flag RTE_SCHED_VECTOR from arm/meson.build. Only > scalar version is now supported. >=20 > * Added grinder configuration in docs. The configuration is moved from > rte_config.h into sched library. Default number of grinders is 8. > To override the default, specify RTE_SCHED_PORT_N_GRINDERS=3DN in > CFLAGS > before compiling sched library. >=20 > * Sample app is updated to always collect statistics as this flag is > removed. >=20 > * Updated softnic library by enabling TC oversubscription. > This flag is now removed from sched. >=20 > v2: > This patchset involves the cleanup of sched Library: >=20 > * Removed unused sched #defines from rte_config. > RTE_SCHED_CMAN, RTE_SCHED_COLLECT_STATS, > RTE_SCHED_SUBPORT_TC_OV and > RTE_SCHED_VECTOR. >=20 > * RTE_SCHED_COLLECT_STATS flag is removed from the code. > Stats collection is now always enabled. >=20 > * RTE_SCHED_SUBPORT_TC_OV flag is removed. > TC over subscription for best effort queues is now always enabled. >=20 > * RTE_SCHED_VECTOR flag is removed from sched library as the code under > this > flag is no longer useful. Only scalar version is supported. >=20 > * Rebased with latest main branch code. >=20 > Megha Ajmera (4): > sched: remove code no longer needed > sched: move grinder configuration flag > sched: enable statistics unconditionally > sched: enable traffic class oversubscription unconditionally >=20 > config/arm/meson.build | 1 - > config/rte_config.h | 4 - > doc/guides/sample_app_ug/qos_scheduler.rst | 5 +- > drivers/net/softnic/rte_eth_softnic_tm.c | 18 --- > examples/qos_sched/init.c | 2 - > lib/sched/rte_sched.c | 156 +-------------------- > 6 files changed, 4 insertions(+), 182 deletions(-) >=20 > -- > 2.25.1 Series-acked-by: Cristian Dumitrescu