From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D96F7A04A6; Wed, 9 Feb 2022 10:10:45 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AF44541101; Wed, 9 Feb 2022 10:10:45 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 2BE4B410FD for ; Wed, 9 Feb 2022 10:10:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644397844; x=1675933844; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=T1XtFe1TXZS+94f13UCiJmRDSKMtXMpb+GSsv83gw8I=; b=XAKuFCn41doybM5YhCuwPw141W/CnRHzRcvlAHJS7cQK+m/RE6PA8bqv 4Y20KSySsyzZXO7qhqwpUUNug5IDapPvBRMcsmchFSTtzKVnIUraCHTfl Po8zUlnGEY1iQ0jnJyUC6sVFRcphI1t10Cn+lOw/FfDMqJSE1SlgJb6to Q2D3ThR3LMyGF/VaS7WoJRgSC4ksLxQNALDHc3SspDtVwKkp95BNijV72 Gy2SFV7jv8M3h4jdik74mYopO0N/km/KKLleGym8yf2zgLb5RbRZMiEeQ khtquksWN4gWdP3oPm8gbSvtSrQvqSz6ppBYcRGPf76maHdNLBCfdwbZk w==; X-IronPort-AV: E=McAfee;i="6200,9189,10252"; a="229132533" X-IronPort-AV: E=Sophos;i="5.88,355,1635231600"; d="scan'208";a="229132533" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2022 01:10:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,355,1635231600"; d="scan'208";a="482269634" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga003.jf.intel.com with ESMTP; 09 Feb 2022 01:10:40 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 9 Feb 2022 01:10:40 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 9 Feb 2022 01:10:40 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 9 Feb 2022 01:10:40 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.42) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 9 Feb 2022 01:10:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EgssBF68UMqMSkZl8H0j+2LSDuiAOxI1tskDw+7OWsGA/ZLpOHOdjZSTUNMHxAzcWrAH3YDRg1YQkzecbOIVU9Zvtd8KCKwkhLvqecTTtmXEOfeWGQEPAgl20RfQprbWg7Rf6QgYQ3MvWkqp+SeeW036eeoMaUdDeB5/CHdA9CnoqdYjYrQpTsIMaeE+DHs2VqXYkIKzPvO+KPRv0W66FMrVCEAqqShV+rqc1IRiq8p4Je0A+ooTT775ASViPPokfSZGoV86YoJBWcttw8yxihk1c+jIDPxrYOL/B3AX1dbt9i8+LN3Bu8LvXG3lKPM3Yy4md6XxIjoAFkkudAP7vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T1XtFe1TXZS+94f13UCiJmRDSKMtXMpb+GSsv83gw8I=; b=cX8ZCfy2+9pWX8GUSyYCMLNzLe24FMI0cHLvcz7Gf09IdLKa/oM0yTCrSnGXd6VqjD23t2rHQ3SIbLC6AV94XpkbnGyXVPIAr0ZvrJzdBGnHTi3EF9W8ifj8o+4v7wbU7zyksvbmgc4uLZ+1Kbb/pMCoBZdXC566YOF5QCKUuGlk53MwPcDLttYHCwTEsem7+9kV4sQn0K6+W1BxKcsSoHOv86MYvroHUvCiWiNT453jTMbfLe8Fsswcz0CkVtPCwLgq6J91K7yis4SbFOibE8RyNgcyf2I1Fpc/z+Gm4jKdZ6du8CHM81d6SjQAIYhEROwnS68L0nWQ1/s/6mhawg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DM8PR11MB5751.namprd11.prod.outlook.com (2603:10b6:8:12::16) by BL1PR11MB5461.namprd11.prod.outlook.com (2603:10b6:208:30b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Wed, 9 Feb 2022 09:10:37 +0000 Received: from DM8PR11MB5751.namprd11.prod.outlook.com ([fe80::8196:21f4:d6a7:524]) by DM8PR11MB5751.namprd11.prod.outlook.com ([fe80::8196:21f4:d6a7:524%6]) with mapi id 15.20.4951.019; Wed, 9 Feb 2022 09:10:37 +0000 From: "Wang, Xiao W" To: "Richardson, Bruce" , "dev@dpdk.org" CC: Maxime Coquelin , "Xia, Chenbo" , Matan Azrad , Viacheslav Ovsiienko Subject: RE: [PATCH 6/7] vhost: remove non-C++ compatible includes Thread-Topic: [PATCH 6/7] vhost: remove non-C++ compatible includes Thread-Index: AQHYGe6n8UYv9zg+W0eRhj0q0Wty3qyDs3MAgAdAmRA= Date: Wed, 9 Feb 2022 09:10:36 +0000 Message-ID: References: <20220204174209.440207-1-bruce.richardson@intel.com> <20220204174209.440207-7-bruce.richardson@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9a53bc98-5990-49c1-5da0-08d9ebac094b x-ms-traffictypediagnostic: BL1PR11MB5461:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /qklRPOr+hqKAEpw7ZOfNjSu3fCtUaBqGDLAKieREy5scCVQJ8AvTb05fR4ox8urfvEoRc30FbwQuLl5i8UqGC7HfeUY8wgzfFXS1Oqism5eOMJ4GrlLAQh9/j4ogOUGWzQQz7um2h1fRBzBcVAid/l5c2j5voeS19wlcgRMiDIOibdphQ01WV1hDXAiU3P+XYhvUM3dq+n26vYXh0ulncRanK/gwEsW3+fA6PhybsdXjVpxrZOxcxDpNGY4RfVlq2nXDBLA0euyY6A8dMPfPRLJu6MiUYkohF1OD7f4NbOYzxoiNgcqQhm/ElrAVYt0A/9A8PEqoIZ2JP48/NgTtOGnFPyGpI3VUM0BSg2DKFtqb6JECeTK23pwLdV9ljSpNd3c303IWZfIRgqVFOIrTo5Ni2cxh27uH9m5znV4Wb/z9fnDvHYs7P5nflcPsf79DIIY23J7q9CUgBgx2gp8ZfiVy77vkGKztJBeiBxsoemGQYmm+7rau7vUghOsMgEIFEOBsNcozZZfH3inYoKhzjnNDv0cMSA74WjnGj0EGFEovJdt/EVRMHd6Y/NbOjs2HAQSY+lKCgFEFwECrjna6snEmV8wfBSR/DJhdDdk1hjwE3HCN0nK4zLXdHcCcy9YK/qeJqTUFL7ZZSNHCDXjYCzt6x/D3OKXI6vxOcijG3ewQFZpZZgBw8uwIU30BAPG8O95pOWsYxbzDbGMjGhE+w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5751.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(33656002)(9686003)(7696005)(6506007)(55016003)(53546011)(186003)(26005)(82960400001)(38100700002)(122000001)(86362001)(38070700005)(83380400001)(66476007)(64756008)(66946007)(76116006)(66446008)(66556008)(4326008)(8676002)(52536014)(8936002)(5660300002)(508600001)(316002)(54906003)(110136005)(71200400001)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?zp3WdQskfK3Ny7V4/Fc+gPQ38JLMhNhHFh671HICkTTKlCV0oX8DkuSj?= =?Windows-1252?Q?OrABeNO16ZIw7sD/BeJlYtIqhmGGwhNu1eGTfO5bGoqigEeAPjrItoh2?= =?Windows-1252?Q?kA/tXVtLGxlsLUHzL+rpBfCUsrxfPALHt0C8l5Ls/RfwI3WD8jFJrMZK?= =?Windows-1252?Q?b6knRiC1oxdzHzjM8fFEQ7wBm/1ZlfVo8zi/CBCiLbxQr8vMmT7GHUSQ?= =?Windows-1252?Q?4vphN5o7423oEGOO4DNK2IU65qE3vjjP9tMNnfamDcV2fhDOr0muy7ht?= =?Windows-1252?Q?3FyvJevSayY0kjUcMwqAVvwdfI1FJ//rPOblKZmpTBesBiJ2AuwIJFVK?= =?Windows-1252?Q?cYJbHY8MudRebuObG7E1UifDDpg62FteUCex2X1Rodf1foK4XWHCmEa5?= =?Windows-1252?Q?xmJTOV1UNjUq5UNdKnrqS3BNwhKgXVaTcfOuZ2X6Jxsw4snrati84v2B?= =?Windows-1252?Q?JBSvFx1+Eo9JWbs4Hl7ggY2kslMLX4licMQCS4zP/L4y7w/0P7DuVD7p?= =?Windows-1252?Q?U5NOSOeB7DQa4etxCYPpY3yK9DgDOWvMrNwwHY0vfiV5K+dXSyre2pqw?= =?Windows-1252?Q?ZUl3qkbOUcKkrKEflPZUcEIN3iaWqrKSnp0Ha3ujDjojUT110y0ZZ/4d?= =?Windows-1252?Q?aSCJcJKsqMvBkc6lgThYrJYjEas+Aidw2cMhMR9XgDddApo31Hre2qz3?= =?Windows-1252?Q?Se3usXI/YcUo6fuYddZEAKy/0FZ6s6oBkD5UrSSBV/quDDssF7xHBB4T?= =?Windows-1252?Q?5dw+3Qz8REX/KRsKAWiktcCEOXYqq2g11nphtzL1y8sBNJs4DPLa3gnE?= =?Windows-1252?Q?xPyPHTIzPDkaamXywO8y5PRULiOh3YWo3tNCf8J1PVb731PfECJCpijd?= =?Windows-1252?Q?CsgkLJvNFZvmEyD9UGOR4B/XYbukddVTABWX9qJq84C2xE3+G+7dc7bZ?= =?Windows-1252?Q?Hpm6xX7OkQcZq1XllOF6H6BW1Rh0XTQjZz0DX+pus4LCR/8CmaYKZOQc?= =?Windows-1252?Q?nyVw7Lj0FJYAMAkyLf+EVZGklyVV4ie1olxhDR/6pKrt1UqYUq+1tMVI?= =?Windows-1252?Q?eOrUJGLLovzTMVeCQR+ZV5mDNsNrXi/ptDOnzvUOVd0x/pWdPlqAvNL+?= =?Windows-1252?Q?fMqYO9VuzLrKj5EhMOvjT1qWFSDfvcMzwfTon9xcGVi1LE4egV2XWlha?= =?Windows-1252?Q?eMDr+Lzp82IHgs8vEErGLGYsyVxHdfwuuI8EASYbpc8Q+G2OnV2XXlQU?= =?Windows-1252?Q?EOIh0R061ncTXkCeVYlrrft6+8whd80qMGNcBzYhRhALmt7byYTRO+OF?= =?Windows-1252?Q?WkjDCiJed8pHviRnJeFmkIwB2RLd75T9rCgs4W5w03cmTUvUx/BCAg34?= =?Windows-1252?Q?sjeiv4Uz2cV+hdRbDQ+j8kBkc7VmMzGBoymqy0FxveEDwlNjgreYL4+G?= =?Windows-1252?Q?Wx2GfmT8pgXbT4wHGgSI95hcT3KM7BXNVm4jstjm8XLo2bNNyX36T0wJ?= =?Windows-1252?Q?gLbYfk+7UxWWFQEpuPgPoWX2A537ESkdmTkHm4vCfN2JFf0vibsfgQlP?= =?Windows-1252?Q?RM3UhH3HjkYZeY57QL5CRgr5L5WX9bYl5b14ULdxnRtbcWOlq5WL6Mz2?= =?Windows-1252?Q?/K3UVKMdZ9LeqU2L8n5wQkw8YTXkdfdRf4dZaVjx3nH6T6u5m+PP+1sY?= =?Windows-1252?Q?MOx5NPmjMQmTSXnsbeUoaeTeHaHDC4rolva5whZ756LoBhATEigSbw?= =?Windows-1252?Q?=3D=3D?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5751.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a53bc98-5990-49c1-5da0-08d9ebac094b X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2022 09:10:37.1691 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 50vfSLF3x9KDg1/aeJ9xsTG8Fie6ne5b5MRtGGmvcwlCpJOELRXrWTKOA0gJBHKEQ+/YFXsvZdPaTDHPCvlCLg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5461 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Bruce, > -----Original Message----- > From: Richardson, Bruce > Sent: Saturday, February 5, 2022 2:19 AM > To: dev@dpdk.org > Cc: Maxime Coquelin ; Xia, Chenbo > ; Wang, Xiao W ; Matan > Azrad ; Viacheslav Ovsiienko > > Subject: Re: [PATCH 6/7] vhost: remove non-C++ compatible includes >=20 > On Fri, Feb 04, 2022 at 05:42:08PM +0000, Bruce Richardson wrote: > > Some of the linux header includes are explicitly noted as being > > incompatible with C++. However, these headers can included by C files > > directly, or by internal headers, to avoid polluting the public DPDK > > headers with non-C++ safe includes. > > > > Signed-off-by: Bruce Richardson > > --- >=20 > CI is reporting build issues with this patch on examples, something I'm n= ot > surprised to see. I will wait for maintainer feedback on best approach > before respinning patchset. >=20 > /Bruce Could we move these c++ incompatible linux headers into #ifndef __cplusplus ... #endif. Then we just need to change rte_vhost.h file, and don't break build for the= drivers and samples. BRs, Xiao