RE: [PATCH] net/mlx5: support matching optional fields of GRE

["Sean Zhang (Networking SW)" <xiazhang@nvidia.com>]

Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Thursday, February 17, 2022 4:34 PM
> To: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Sean Zhang (Networking SW)
> <xiazhang@nvidia.com>
> Cc: dev@dpdk.org
> Subject: Re: [PATCH] net/mlx5: support matching optional fields of GRE
> 
> External email: Use caution opening links or attachments
> 
> 
> 17/02/2022 07:27, Sean Zhang:
> > This patch adds matching on the optional fields
> > (checksum/key/sequence) of GRE header. The matching on checksum and
> > sequence fields requests support from rdma-core with the capability of
> misc5 and tunnel_header 0-3.
> >
> > For patterns without checksum and sequence specified, keep using misc
> > for matching as before, but for patterns with checksum or sequence,
> > validate capability first and then use misc5 for the matching.
> >
> > Signed-off-by: Sean Zhang <xiazhang@nvidia.com>
> > Acked-by: Slava Ovsiienko <viacheslavo@nvidia.com>
> >
> > ---
> > v3 - some code style change
> > v2 - replace default mask with nic mask
> > ---
> >  doc/guides/nics/mlx5.rst             |  10 +++
> >  drivers/common/mlx5/mlx5_devx_cmds.c |   3 +
> >  drivers/net/mlx5/linux/mlx5_os.c     |   2 +
> >  drivers/net/mlx5/mlx5.h              |   1 +
> >  drivers/net/mlx5/mlx5_flow.c         | 101
> +++++++++++++++++++++++++++++
> >  drivers/net/mlx5/mlx5_flow.h         |   6 ++
> >  drivers/net/mlx5/mlx5_flow_dv.c      | 121
> +++++++++++++++++++++++++++++++++++
> >  7 files changed, 244 insertions(+)
> 
> Should we add a line in the release notes?
> 

This patch is v3 of the forth patch of patch set: https://patches.dpdk.org/project/dpdk/cover/20220211014530.77711-1-xiazhang@nvidia.com/
The release notes changed in the second patch of the patch set and applied in v2.

--- a/doc/guides/rel_notes/release_22_03.rst
+++ b/doc/guides/rel_notes/release_22_03.rst
@@ -87,6 +87,11 @@  New Features
 
   The new API ``rte_event_eth_rx_adapter_event_port_get()`` was added.
 
+* **Added rte_flow support for matching GRE optional fields.**
+
+  * Added ``gre_option`` item in rte_flow to support checksum/key/sequence
+    matching in GRE packets.
+
 * **Updated testpmd.**

Sorry the subject-prefix missing v3 information.

Thanks,
Sean