From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 28EC1A0C47;
	Tue, 12 Oct 2021 09:56:18 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id D69BC40151;
	Tue, 12 Oct 2021 09:56:17 +0200 (CEST)
Received: from NAM11-CO1-obe.outbound.protection.outlook.com
 (mail-co1nam11on2043.outbound.protection.outlook.com [40.107.220.43])
 by mails.dpdk.org (Postfix) with ESMTP id 39BA64003C
 for <dev@dpdk.org>; Tue, 12 Oct 2021 09:56:16 +0200 (CEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Oz0TRxbnm0BpX4FNM9e4m9fRoyhSgo1n36pk+Swc3FoSZ+8T3XJsuqhGkZddxCP88Kmr6cWuHGn1P1kEj3O+ZwfqskuXmOhGz2QlT4peOx9om2+Ug0DK04pf/jFRuQtFUR5A1F5CZX5OPf7uT5uGRcS5Hn6ZWpyP5pL4v/I48xX2/JGXySJq/vi/CJ71AkZvueGz4CIJc/zbGqRgzxC2o0oryeUlOfGdRRXfEIRjZvD1zPyOHt3GPFNCDqpdvCQh/tNPhPUWKnyr8xTH6WvddlfhAZmBrWg51bJjXVDnRk3OR7/kdRwOCSusozAvmEZn8wIDyoxC/52ybs+CfAPiCA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JwNy9ryYSJptk4a8AW7/wbPNImRx0kJe4COuhZY3Odo=;
 b=JlQsHTGnW6gams5h8GNllQWM2ynZ12ML95ft9zxxNKCpg/qyyFGidGnbywqRIZCDd6PEG2APo+nXaW6zgHH5MBRgg/TmD8bwR7lqhD+AjT68kJpHfCL+CYjrZLYnj+0P3+m5cm456tsbsLGNqqgm62jhWnQXbPMdIqLZ6urGtY+wlWeKp2P+17TlmM3L6r82Mg9IU5zCmoOQBQc6eLPXKu5RMzRYn2GD1iok1RtFUyXtj8ELudhAOEfLRjMc0PbMGE0JAFPaZQNyCN1PnDHk13alzrW6Yyrtc1rDnhBmpz2nKpGh25d3CoIQvwpqw3i7HzhsrM97awEh8wTIY+/vNg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=JwNy9ryYSJptk4a8AW7/wbPNImRx0kJe4COuhZY3Odo=;
 b=Hn2MJyBRtXegBvna5Bc5JncqlZVzkakU7rtJNwU0Z5HJgp0570lBCy0rfCna+vraYArsh/Sl1e6ycwd4h9YPBKn+lKVaoUMfL43lwg+YO2lecNHH+OdCsLX9CNcH365MDAXCASDZcazxQYx+Z6I5UjH6OE33iVGBRLxut7+EjcBoVaupGZZj0aRZMjTd0MosGiarpvOHxwWWUkWT8fsy134ubGipFvBdwRGg9RkepSK/1ZmYl9pL40vPOGkOhYUj/lvmU25K9RcCWrO8pj1um99CdJTTEaiPsP7BHkfChKrNBklE6AnJ4fHPeIOaHVy+C9MF9q++nFckWwxSvLV3yg==
Received: from DM8PR12MB5400.namprd12.prod.outlook.com (2603:10b6:8:3b::12) by
 DM4PR12MB5118.namprd12.prod.outlook.com (2603:10b6:5:391::12) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4587.19; Tue, 12 Oct 2021 07:56:14 +0000
Received: from DM8PR12MB5400.namprd12.prod.outlook.com
 ([fe80::d03d:1f75:ca20:6a32]) by DM8PR12MB5400.namprd12.prod.outlook.com
 ([fe80::d03d:1f75:ca20:6a32%6]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021
 07:56:14 +0000
From: Ori Kam <orika@nvidia.com>
To: Slava Ovsiienko <viacheslavo@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: Raslan Darawsheh <rasland@nvidia.com>, Matan Azrad <matan@nvidia.com>,
 Shahaf Shuler <shahafs@nvidia.com>, Gregory Etelson <getelson@nvidia.com>,
 NBU-Contact-Thomas Monjalon <thomas@monjalon.net>
Thread-Topic: [PATCH v3 4/5] app/testpmd: add jansson library
Thread-Index: AQHXvswXG8qui+ssrkaFIPrKlV7w16vO/uwQ
Date: Tue, 12 Oct 2021 07:56:14 +0000
Message-ID: <DM8PR12MB540031FA02E7DD926A4726FED6B69@DM8PR12MB5400.namprd12.prod.outlook.com>
References: <20210922180418.20663-1-viacheslavo@nvidia.com>
 <20211011181528.517-1-viacheslavo@nvidia.com>
 <20211011181528.517-5-viacheslavo@nvidia.com>
In-Reply-To: <20211011181528.517-5-viacheslavo@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: nvidia.com; dkim=none (message not signed)
 header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: c78be5aa-a025-441b-a460-08d98d55c3f8
x-ms-traffictypediagnostic: DM4PR12MB5118:
x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <DM4PR12MB5118282AD1ADE9E99923948CD6B69@DM4PR12MB5118.namprd12.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:4502;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: RvS5AfEyIRHaHQynddNUZusfJtt3BiqtgHNhqC+C2Dxqg4AJdVAchY6xLEgHutC1XYfXu83RRbJEBa8o8cPsgmbZaaRPYoqV+NL3ikJYDbh1ugWOw7n45eTdoEyGMl5djZOdQslxueONPRBzCaEUjXBnGw3ercp+5inB8fpRxg5Yg4QAMc9Qs9RAlxvpG0BTef5y7RRKVlvrTXBKDiijR+olLYaGlP6kNqnT4obfY+WpDVhyMTyzpYheH2H1VYkA8lnlm/SCNmLCcFUMsiziBfVPx0ESrvxjMdARhW2YfbT1FjHHOuRpCgsu7iGzYjWsREEKQW24g0/yOg8hUzUUmW2XBTJh+PoK2xiiyExUWGaa15/i1MlxSD4Mqez/JFZGYIaYJvcUwBK5CPGjSO6INNOSwLeyNa4KKU8B33H3pP8DSNFhL3B4tIiW2SKzeYKjhQkeLLYYClgXh2XzWjQ493l4oLcvBL74YUwlVkdzRL5MEr2zXMHfsPTclLb2Wjog0JXQAyvI/bBat0NFVoJvN3xWEcNi3o/CQD6te0v9+5U6WgRQdvU1GjKAuwqSMf54zUIItjKoF21eM1f53thMnEx8i9n08s6kjY1dj23XbHOFK8DnC4qL0ci0AxwqXMMKJGet1XwgPtwOrVvXrtNaZIJx9W5UUTNxKXgUNL6NhkPfFfQLNVvLuldyl0WYC9/pQfR3qp4Bop57ApX6a83dxg==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:DM8PR12MB5400.namprd12.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(4636009)(366004)(38100700002)(316002)(54906003)(110136005)(508600001)(55016002)(5660300002)(33656002)(26005)(86362001)(9686003)(122000001)(7696005)(52536014)(6506007)(38070700005)(53546011)(4326008)(2906002)(83380400001)(66446008)(64756008)(8936002)(66476007)(66556008)(66946007)(71200400001)(186003)(76116006)(8676002);
 DIR:OUT; SFP:1101; 
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?v+XC2wVH8Qif1uNB6+DBWc2pjIXcGq0xUyrHzE/7Tt1fC21IG2RiBfDEYDJA?=
 =?us-ascii?Q?QKpv6O6WgdSM5SKm7g7mtPABh2YdknVJh/mtTRjDsWmydb1QAt2+gaQFhY7X?=
 =?us-ascii?Q?MzGwVx5fNVXktyEW/JcP6QdLMnkUReoFLxW2JEJb/KqapQKCEQBnaPJPidlc?=
 =?us-ascii?Q?9Km4WVJ1A6x3ysoVNciijaCuRc3Bp2H3Yz16ueFfm+tLxQfGQwa9PBs/Ddkm?=
 =?us-ascii?Q?usiFv2V+q9kpndl1nTpQ7QI/l8InO/4iaTUHi4xOpFeNbQKQ4pHXB0wQlQz8?=
 =?us-ascii?Q?kVSPYgx8gvaLZkCplgXimX3Iu9bdWvkYf3dztY+SXWNMQrlq9EEberIk3lkK?=
 =?us-ascii?Q?WHpjYGKwF5oHd17vM/HaGUUk5Z4bv/TR7uofHb53BbABAG5DwcRy9x7pqfe9?=
 =?us-ascii?Q?LyWSP0DifMB3XXVEazrqLHUtLkB7oACaMrxVhDUGQMotb+taXne6qkzXgWRX?=
 =?us-ascii?Q?yAnfpqw5hjf0FyDgZBT9FIJhKXEZm6kAyTCRdsqERi5EXTK599euD+u4L5wa?=
 =?us-ascii?Q?LPyLwBaD7vPfvfJjVCIZhfw5GQGqhqA4WmtaVHvtlH78RstvzHpkO8Ykv5Fo?=
 =?us-ascii?Q?ibNMDeDr300EId/XaqVKeBqV2o8erSKEyOG2v2Uq5zjWhtKj55rJyRMP/kW6?=
 =?us-ascii?Q?NglA5hSId0UmG4IjvTolpP5vT0PKUc0maSJybZmRSVLYFkow693/8wDzGM+1?=
 =?us-ascii?Q?w25+Kw/KEjeWkK3e8bgbZ6VnrdBuTkZw8S/s4OTJBe1mk4NKQ/rMuU5+7LnI?=
 =?us-ascii?Q?5hWa+/8Ks1n56d0XPOXhqcMwYtSe5pMzLtv7AR1pheFxtjqA2arrHMUVVMzp?=
 =?us-ascii?Q?N4sexBwsnZOlwqCkCHgn6UrltB5Rf0KIo1OB9l25Vg+Us6StCCEU7QaLMl+k?=
 =?us-ascii?Q?IMWzFrMHwrmvcJk7z/eGQ/KFIHEgkZGEwnTDhz1txKEFR+dE2hhuipCCfRyo?=
 =?us-ascii?Q?dJsQvKIrtKM4ru8xq8FtUlTOsl6Rn3f5jXuJOr9+16SZ2QOG0tw0zj3pQowk?=
 =?us-ascii?Q?2nsSLXvuuIjSESik6hk8jv2GJBDta2e7IdZBUIGxFRAfH+VoQXpDlEmW/+So?=
 =?us-ascii?Q?NRsXDkpZOeHrd2njWjmzzBF7rcSC635hH1O133lUDN9o+lmzU8p2hnaQEkPa?=
 =?us-ascii?Q?v378golzQAKuDTvhvn8uBYT/k/cInoL2sgOUYC1k9cJlP3cbj3kYqFIpaaY6?=
 =?us-ascii?Q?A+t01Sn0OMHe0d8MP/md47z9D4EzfGc2wuhAU5y6iRC5c/pXcItJ1lF4Flrq?=
 =?us-ascii?Q?aIZ5nt8Jp664Qt0yjZEnn+B0bcPTlY9ry4NV6rGd8lP3v5V8nLTy9RDG1MY5?=
 =?us-ascii?Q?SpSxA+fj8eOa/0ZkLZeB7R9k?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5400.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c78be5aa-a025-441b-a460-08d98d55c3f8
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2021 07:56:14.8014 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: EFlVToXcRSHoQZxQ4uFcnP4kihhUYTlcLC/NrVdM5IXvDf7xCOZqA1J4K9PMWumgfDxUIfzGbPnRXvz/uQUKtw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5118
Subject: Re: [dpdk-dev] [PATCH v3 4/5] app/testpmd: add jansson library
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


Hi Gregory,

> -----Original Message-----
> From: Slava Ovsiienko <viacheslavo@nvidia.com>
> Sent: Monday, October 11, 2021 9:15 PM
> Subject: [PATCH v3 4/5] app/testpmd: add jansson library
>=20
> From: Gregory Etelson <getelson@nvidia.com>
>=20
> Testpmd interactive mode provides CLI to configure application commands. =
Testpmd reads CLI command
> and parameters from STDIN, and converts input into C objects with interna=
l parser.
> The patch adds jansson dependency to testpmd.
> With jansson, testpmd can read input in JSON format from STDIN or input f=
ile and convert it into C object
> using jansson library calls.
>=20
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> Reviewed-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
>  app/test-pmd/meson.build | 5 +++++
>  app/test-pmd/testpmd.h   | 3 +++
>  2 files changed, 8 insertions(+)
>=20
> diff --git a/app/test-pmd/meson.build b/app/test-pmd/meson.build index 98=
f3289bdf..3a8babd604
> 100644
> --- a/app/test-pmd/meson.build
> +++ b/app/test-pmd/meson.build
> @@ -61,3 +61,8 @@ if dpdk_conf.has('RTE_LIB_BPF')
>      sources +=3D files('bpf_cmd.c')
>      deps +=3D 'bpf'
>  endif
> +jansson_dep =3D dependency('jansson', required: false, method:
> +'pkg-config') if jansson_dep.found()
> +    dpdk_conf.set('RTE_HAS_JANSSON', 1)
> +    ext_deps +=3D jansson_dep
> +endif
> diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index 5863b2=
f43f..876a341cf0 100644
> --- a/app/test-pmd/testpmd.h
> +++ b/app/test-pmd/testpmd.h
> @@ -14,6 +14,9 @@
>  #include <rte_os_shim.h>
>  #include <cmdline.h>
>  #include <sys/queue.h>
> +#ifdef RTE_HAS_JANSSON
> +#include <jansson.h>
> +#endif
>=20
>  #define RTE_PORT_ALL            (~(portid_t)0x0)
>=20
> --
> 2.18.1

Acked-by: Ori Kam <orika@nvidia.com>
Best,
Ori