From: Ori Kam <orika@nvidia.com>
To: Ivan Malov <ivan.malov@oktetlabs.ru>, "dev@dpdk.org" <dev@dpdk.org>
Cc: David Marchand <david.marchand@redhat.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Xiaoyun Li <xiaoyun.li@intel.com>
Subject: RE: [PATCH] app/testpmd: fix flow transfer proxy port handling
Date: Tue, 16 Nov 2021 19:23:25 +0000 [thread overview]
Message-ID: <DM8PR12MB54004AD025E63BC7E14236EBD6999@DM8PR12MB5400.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20211116153817.19116-1-ivan.malov@oktetlabs.ru>
Hi Ivan,
> -----Original Message-----
> From: Ivan Malov <ivan.malov@oktetlabs.ru>
> Sent: Tuesday, November 16, 2021 5:38 PM
> Subject: [PATCH] app/testpmd: fix flow transfer proxy port handling
>
> The current approach detects the proxy port on each port (re-)plug and
> may spam the log with error messages if the PMD does not support flows.
> As testpmd is a debug tool, it must not do such implicit port handling.
> Instead, the new API should be called only when the user requests that.
>
> Revoke the existing code. Implement an explicit command-line primitive
> to let the user find the proxy port themselves. Provide relevant hints.
>
> Fixes: 1179f05cc9a0 ("ethdev: query proxy port to manage transfer flows")
>
> Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> ---
Acked-by: Ori Kam <orika@nvidia.com>
Best,
Ori
next prev parent reply other threads:[~2021-11-16 19:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 9:00 [dpdk-dev] [PATCH] ethdev: fine tune error reporting in pick transfer proxy API Ivan Malov
2021-10-27 9:46 ` Thomas Monjalon
2021-10-27 9:55 ` Ivan Malov
2021-10-27 10:57 ` Thomas Monjalon
2021-10-28 16:24 ` Ivan Malov
2021-10-29 8:11 ` Thomas Monjalon
2021-11-01 9:41 ` Andrew Rybchenko
2021-11-02 15:45 ` Thomas Monjalon
2021-11-02 15:58 ` Andrew Rybchenko
2021-11-02 17:04 ` David Marchand
2021-11-10 14:21 ` Ferruh Yigit
2021-11-15 14:15 ` Ivan Malov
2021-11-15 15:09 ` Thomas Monjalon
2021-11-15 15:30 ` Ori Kam
2021-11-03 14:38 ` Ori Kam
2021-11-16 15:38 ` [PATCH] app/testpmd: fix flow transfer proxy port handling Ivan Malov
2021-11-16 19:23 ` Ori Kam [this message]
2021-11-17 7:41 ` Slava Ovsiienko
2021-11-17 10:54 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8PR12MB54004AD025E63BC7E14236EBD6999@DM8PR12MB5400.namprd12.prod.outlook.com \
--to=orika@nvidia.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=ivan.malov@oktetlabs.ru \
--cc=thomas@monjalon.net \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).