From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D7C35A0C53; Wed, 1 Sep 2021 10:11:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1EC7E4068A; Wed, 1 Sep 2021 10:11:08 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam08on2056.outbound.protection.outlook.com [40.107.100.56]) by mails.dpdk.org (Postfix) with ESMTP id C537240041; Wed, 1 Sep 2021 10:11:06 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jVIgEP+5n32M7k01TkFhIbulPj7+ferp6a6feDjR7uvTPFPG4YlSPQYlmIBoplGeIvRkaw+azprtNrS17SgqO52g/f6quRi1aUuQ3YA51yCgISo22EWoVViLl7bM5dnTn2QehR0mTEvTJZl20/CWANKovmcUIC3dukvv3UGVv7SM462X2PeCdW+Y98xc5qFBPaZysQOlMXIlFYAf+yOisgocE74MmyGJKXF+0Rjo3HSnbciCtQvYkQZLXPmgGvOI5lA+vBkzP/Tx913XApWRXWUPkEXq39xBHpQnHOL8WhsV65SMtEvW25yLcIG1O1hHyJT2HwWfddkhwV4EOi9hCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gn3iR+7lpDt00yiKhjZRlyVN1iJHhOeqJxDbe9c/oYM=; b=APjyLJXikt1E3Hw0KSj+68U4PCzsXmmdKyEhHs0kvQsYFKbhZeTwKftZeyOyHcpsvh+KnKS7fBLzVLLUTpDK39PnXQ0He1iIQuNr9/WmoIYKfham3x3U/glSfU5CryTqLbtJUMCFshIHfnjAEUPQvOIyU/w4wbDJjI3Q1RNIMWJHmXrMgyZmh5GprtqawN1K3z6ZI0RCtJNAg8iEr7KO6SUjBMu4U4zSIxhh/CBDgZ/jWLb+iEjnzC0wr+t/8cmnODZuKM2LcrZRu/YKa45BKgtjJGvMSR23hutyKNMFR7OQdFsCi2UMFY1i1QRkkMaDUTa7GS2Ms6a08QCKbSxOFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gn3iR+7lpDt00yiKhjZRlyVN1iJHhOeqJxDbe9c/oYM=; b=ZPGDW3Gz4uRVAeKlRN3+pJPVGYIL9TgcHy8Q47cCoYcbhMgVZz/j+dDu41Vw6cnpMwNf731JDok9SVVD5x2JZTxl+VVpDNmmY0DeJy4suTQrb5X5hpeqPH8vekC1tQkDkEg8ldtGff4uhuuV+nFpAg6AkmLnx4EYg05zmb/J2Df3HVLc34lvpDJXCSks0YUqVqeyxMTqHkZ7I2xbTh4+5eXlOzUfB0PTUTI7K8a8HTrfhngtbZyYTpVTRLmlqlsdyJCOUe5IMnycVx8aZIon3iSId5cLTVNKtpIKNgzXJHiDFJd1oouulP9ucodbBazbxJdm1coYBHD9dT7NmV9Eug== Received: from DM8PR12MB5400.namprd12.prod.outlook.com (2603:10b6:8:3b::12) by DM8PR12MB5478.namprd12.prod.outlook.com (2603:10b6:8:29::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.24; Wed, 1 Sep 2021 08:11:05 +0000 Received: from DM8PR12MB5400.namprd12.prod.outlook.com ([fe80::d03d:1f75:ca20:6a32]) by DM8PR12MB5400.namprd12.prod.outlook.com ([fe80::d03d:1f75:ca20:6a32%6]) with mapi id 15.20.4457.024; Wed, 1 Sep 2021 08:11:05 +0000 From: Ori Kam To: Michael Baum , "dev@dpdk.org" CC: Matan Azrad , NBU-Contact-Thomas Monjalon , "stable@dpdk.org" Thread-Topic: [PATCH] regex/mlx5: fix RegEx probing error flow Thread-Index: AQHXnqg9un9LU6SZa064Pt9iDAnvdauO1EWw Date: Wed, 1 Sep 2021 08:11:05 +0000 Message-ID: References: <20210831203838.3411249-1-michaelba@nvidia.com> In-Reply-To: <20210831203838.3411249-1-michaelba@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: eb899b4b-a880-42bd-cb20-08d96d200be9 x-ms-traffictypediagnostic: DM8PR12MB5478: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3173; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dEJGn5PG1FGWNXSFD+UD5RfYWdm18svMcAAnYWBhDDbAbifcUSHkndAhEv5ItaZIVUe4VQ+B/w2XRtQUGC1a6HIZ+kK7JQCf+W8L7Vo/hJP5xl+86UddP60XRCCSeNKmKBZUC5EVNSNxYfGL6enmnJGpcxyukHA4kRtq4kWK+ckO/VJ4BeSDCXqVb9zM6Kgcd7GIR05kW6v7eb3GGtBG9fbJ1zlnKyy47tslc2KmXTyKtXXGb3TrtF1VEWnht9UWSfM6p7HQFlBiab8CQhot22fRCPOdRe1DOBC2uF9hHb4A/RtozGPI3ECAzfwqjA/pv/UJczHjgcLEXHuiKsc6S6haoS/F/o4cVZ+FE9koCgZGNmW6gxlpg5Am/Ty81myiPei+w4bwUCjLfuH53vjkQ1MHJ5VUFjT50HckVZkkrBw9FOBmQtJVisNqWAwu4S5FK1Fuznr4hrCTg0XScSrGuferTlkK/Oo0okQ8QCSS/wXgKHYpnLfRb+TzEakvsxF+jkNzz7b/e5aoC3i4T+TQtFFIqYwdnp06aDQBjmhiif4S6FN2pF+hzaVO/BdbsHuJCRznPrEZTlJAWORoacleJznGRxCsJHKzw1MHBELBSgOIKlQ63pWRUeCrWHYFPsNCG3j807WIbPUHl/DMHAb3ZylsQqzbsZFvX02cLPE7Lkx8QJnoxqALHzDvkswQcAaqdIdrMZT6hwulrqw61gShgg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR12MB5400.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(366004)(396003)(376002)(136003)(39860400002)(66476007)(38070700005)(5660300002)(478600001)(54906003)(33656002)(64756008)(4744005)(38100700002)(26005)(316002)(110136005)(122000001)(6506007)(83380400001)(66946007)(2906002)(186003)(66446008)(55016002)(66556008)(76116006)(4326008)(52536014)(8936002)(8676002)(7696005)(71200400001)(86362001)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zjLtqSnvNFjBiYh7NQnXgd0k16WLOZnkLkd3srXsAcyvMY6RZ79qFCGLwOPv?= =?us-ascii?Q?YakBJvtb0NZQF+vcH8ordGJjULuR5G2qciPNtAqs+5ymHByJg04cAJwFq5zz?= =?us-ascii?Q?9SGlSrKDbkm3sPIuuTdLcHlliFN/g4O8gvAaCSda+XALD7e1A8J3XVyFzjil?= =?us-ascii?Q?rS+ScD+/ZVNBokDIrtJef26GcjcJk+3vBxoc8SynvcqzGuITVqnjCik5Ehff?= =?us-ascii?Q?pjgqXFk7VtJahkBkYC5aKrfbQ5x0zDvGbuI8PsNvg/aLN5BAKbOxcjYd+PPs?= =?us-ascii?Q?UvVSrSW0z23E4JTVzQxRjMxVfH/VH8g8/OBUPZQICVrv56fhtLSxVhJuda/n?= =?us-ascii?Q?6y1LfzTqhtr3Qcmhve6IVUkbY0953ZrsHVRDTogl/S6o/JpjY3innFlPrOXD?= =?us-ascii?Q?Ch77eZZIEEura1JIEN/6YkkrRnNvpooX0SEqEERSoNyeBFkKySjgBmN1raxb?= =?us-ascii?Q?etmtLpkDbvV/L3K7RHTJkUJacElwXV4vQ/5WliG4/l6TQp7YvUbclS1MAQ6+?= =?us-ascii?Q?Wl5FWimH20FgleXZgnXDT7ggylXKvHFgab+fNNvL3SL/8A/af1EzSjC9LQZE?= =?us-ascii?Q?Y6e91vfhdLxTgaad+Cq2D1O0KdfNqFmCfGMDQdoZiTaI3uImnHzFxCYN04Tf?= =?us-ascii?Q?80MUPPDhJvCVCPeDHZ+DkAFzhISkJ44a+RemfkhuGJmnpEK3H4CiCDfxPLs1?= =?us-ascii?Q?jWptl7R+/kbDHEeMak830STHMRREIK1smORzeLAdAWleWTOTMc3hD/rytUdu?= =?us-ascii?Q?qmtFfyA2M+wWMiB4qcIEmxUG9HYGxcmX3GFVVEPT5tybDCVQFAnGJttFMJO1?= =?us-ascii?Q?bQKC8hHTw3WbWlxytNCtSet0jKLAz2BTq4/nFEd9Jwsmq6LTkuqUQ4awSFRW?= =?us-ascii?Q?UAbyMRNfPf2UY145osnQaz5hKEANpSEfKchl/Ltxo2q4QjrB1P0kCbZ0xETv?= =?us-ascii?Q?ehiLmtYWLMuYcWuSyvcTqFyixoLraGl1C2TBhXdrLMjM0bGdTAJY3f7C3P6D?= =?us-ascii?Q?yYVrav9s2aKphxaEef0jEpBXW4kpkazM5UyqcRngn6K7J1Ga3e0niKvA4q+f?= =?us-ascii?Q?vBQrteSnFtT5ZVr6H9ZWl6LODs95bYjj3+sopBDVvqWNlIk7l7uvjh1zwP54?= =?us-ascii?Q?Y3f8D85IphxeVe3z/mYHffEpWbVvSXXQVZeYsgCmxikmF15pRNZyJl1ueyVQ?= =?us-ascii?Q?n2biHDH4ciKjaux5VbDectuvhymwWP2rwyG3Ij5up25HaNY0HpEyKyElx+y4?= =?us-ascii?Q?XH+m+IidRYDuzdXnj6DHB4krnyHGeu0ZrCuJ7z0DbaLvi4WsVl/WHr2foiDl?= =?us-ascii?Q?IoWsTqjnepMOVSQAdaVn0qRz?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5400.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb899b4b-a880-42bd-cb20-08d96d200be9 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2021 08:11:05.5300 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: S27x+7qJS+wmIMfcMJNmbVhUNes/fE6lvRmwAYDWTpV1sgBF7ZeZxqrhR66Wrs6oiPkaD6sya37axkIvm7N1mw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5478 Subject: Re: [dpdk-dev] [PATCH] regex/mlx5: fix RegEx probing error flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Michael Baum >=20 > In RegEx device probing, there is register read trying after context devi= ce > creation. >=20 > When the reading fails, the context device was not freed what caused a > memory leak. >=20 > Free it. >=20 > Fixes: f324162e8e77 ("regex/mlx5: support combined rule file") > Cc: stable@dpdk.org >=20 > Signed-off-by: Michael Baum > --- > drivers/regex/mlx5/mlx5_regex.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/regex/mlx5/mlx5_regex.c > b/drivers/regex/mlx5/mlx5_regex.c index f17b6df47f..8866a4d0c6 100644 > --- a/drivers/regex/mlx5/mlx5_regex.c > +++ b/drivers/regex/mlx5/mlx5_regex.c > @@ -171,7 +171,7 @@ mlx5_regex_dev_probe(struct rte_device *rte_dev) > MLX5_RXP_CSR_IDENTIFIER, &val); > if (ret) { > DRV_LOG(ERR, "CSR read failed!"); > - return -1; > + goto dev_error; > } > if (val =3D=3D MLX5_RXP_BF2_IDENTIFIER) > priv->is_bf2 =3D 1; > -- > 2.25.1 Thanks, Acked-by: Ori Kam