From: Ori Kam <orika@nvidia.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>
Cc: "NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
David Marchand <david.marchand@redhat.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
"dev@dpdk.org" <dev@dpdk.org>, Ray Kinsella <mdr@ashroe.eu>
Subject: RE: [PATCH v3] ethdev: deprecate header fields and metadata flow actions
Date: Thu, 25 Nov 2021 13:56:58 +0000 [thread overview]
Message-ID: <DM8PR12MB5400BFC8FA9F1CEBB73449E7D6629@DM8PR12MB5400.namprd12.prod.outlook.com> (raw)
In-Reply-To: <843154cd-4ed4-046e-e01c-3fb154ddad86@intel.com>
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Thursday, November 25, 2021 2:47 PM
> To: Ori Kam <orika@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>
> Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>; David Marchand
> <david.marchand@redhat.com>; Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>;
> dev@dpdk.org; Ray Kinsella <mdr@ashroe.eu>
> Subject: Re: [PATCH v3] ethdev: deprecate header fields and metadata flow actions
>
> On 11/25/2021 12:29 PM, Ori Kam wrote:
> > Hi
> >
> >> -----Original Message-----
> >> From: Ferruh Yigit <ferruh.yigit@intel.com>
> >> Sent: Thursday, November 25, 2021 2:19 PM
> >> Subject: Re: [PATCH v3] ethdev: deprecate header fields and metadata flow actions
> >>
> >> On 11/24/2021 3:37 PM, Viacheslav Ovsiienko wrote:
> >>> @@ -3331,6 +3430,9 @@ struct rte_flow_action_set_tag {
> >>> };
> >>>
> >>> /**
> >>> + * @deprecated
> >>> + * @see RTE_FLOW_ACTION_TYPE_MODIFY_FIELD
> >>> + *
> >>> * @warning
> >>> * @b EXPERIMENTAL: this structure may change without prior notice
> >>> *
> >>> @@ -3355,6 +3457,9 @@ struct rte_flow_action_set_meta {
> >>> };
> >>>
> >>> /**
> >>> + * @deprecated
> >>> + * @see RTE_FLOW_ACTION_TYPE_MODIFY_FIELD
> >>> + *
> >>> * RTE_FLOW_ACTION_TYPE_SET_IPV4_DSCP
> >>> * RTE_FLOW_ACTION_TYPE_SET_IPV6_DSCP
> >>> *
> >>
> >> Hi Viacheslav, Ori,
> >>
> >> Just recognized that some of the "struct rte_flow_*" added as experimental
> >> (experimental note in the struct comment), some without experimental note.
> >>
> >> Is it because some forgotten the add the experimental note?
> >>
> >> What is the rule to add new "struct rte_flow_*"?
> >>
> >
> > In the beginning struct were never experimental,
> > and in the last few releases we started to put experimental also on structs
> > which I think is much better since at the end this is a new API and just like any other
> > new API it is not stable.
> >
>
> Got it, thanks.
>
> So to record for archives, new "struct rte_flow_*" structs should be
> experimental by default.
>
> Does it applies to enums too?
Yes, I think that anything new is experimental don't you?
next prev parent reply other threads:[~2021-11-25 13:57 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 7:59 [PATCH] " Viacheslav Ovsiienko
2021-11-24 8:06 ` [PATCH v2] " Viacheslav Ovsiienko
2021-11-24 14:56 ` Thomas Monjalon
2021-11-24 15:37 ` [PATCH v3] " Viacheslav Ovsiienko
2021-11-24 15:59 ` Thomas Monjalon
2021-11-24 16:21 ` Ori Kam
2021-11-24 16:37 ` Slava Ovsiienko
2021-11-24 17:32 ` Thomas Monjalon
2021-11-24 18:09 ` Ori Kam
2021-11-25 11:53 ` Ferruh Yigit
2021-11-25 12:03 ` Somnath Kotur
2021-11-25 13:06 ` Thomas Monjalon
2021-11-25 14:13 ` Slava Ovsiienko
2021-11-25 14:40 ` Ferruh Yigit
2021-11-25 14:52 ` Slava Ovsiienko
2021-11-25 14:15 ` Ferruh Yigit
2021-11-25 13:56 ` Slava Ovsiienko
2021-11-25 15:14 ` Ferruh Yigit
2021-11-25 15:53 ` Thomas Monjalon
2021-11-25 12:18 ` Ferruh Yigit
2021-11-25 12:29 ` Ori Kam
2021-11-25 12:46 ` Ferruh Yigit
2021-11-25 13:56 ` Ori Kam [this message]
2021-11-25 14:28 ` Ferruh Yigit
2021-11-25 12:31 ` Ferruh Yigit
2021-11-25 12:50 ` Thomas Monjalon
2021-11-26 9:51 ` [PATCH v4] " Viacheslav Ovsiienko
2021-11-26 12:53 ` Ferruh Yigit
2021-11-26 13:06 ` Thomas Monjalon
2021-11-26 14:52 ` Olivier Matz
2021-11-26 17:07 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8PR12MB5400BFC8FA9F1CEBB73449E7D6629@DM8PR12MB5400.namprd12.prod.outlook.com \
--to=orika@nvidia.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=mdr@ashroe.eu \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).