From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD94AA0C52; Wed, 24 Nov 2021 19:09:33 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4997240040; Wed, 24 Nov 2021 19:09:33 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2086.outbound.protection.outlook.com [40.107.243.86]) by mails.dpdk.org (Postfix) with ESMTP id 8D1314003C for ; Wed, 24 Nov 2021 19:09:32 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e9P663CN/+geuS9kC/NM4mZEcW5aijE5cJfs9W4HFMeCRCpJcOpaCbFMzUhBid9zOan3yXi7l0r+lCNrdZhKVkSeEplq8/U95YG1f+27n2yag0TFajj788up5ELTs31Iihirkr6Zi0fcsf9ok4FPxAWmO4GTLBop352wVe4uCjm9DFa0i8vnWW/BHoy8Mghq9J8LWA+lYaQSKPbd7wgygknNA32yz5z3JRbumqgpcNGeg8GTOJx150/HRhKr+Q6mcDK2Uz5dASsc1gFq86Yy87DKdfh/INcd42KRqf76EZgq51iR5G1Rl+FTFNs9I8NioLVcqV43u7b/gSIgfy+cZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mOstaE0EaBvLdtLn7Z5NoPpMDm6KrO4fomv8MK+5dkk=; b=Ivx+CXtbzwlxRsr/YcSizJo0A8nrFV/GL0Rstsn93ISlb9HEfASYrIZ9oUcYgLA7g4K/3n+7YpprRTOO31Bxf8Q2DiWh7gDvh750xunLiPjab857wGSf/yIM7LIuvElxqTM07RIR2SlLePFhtW1F0bnr2XFgSvrMvOt52czRRyaZH7WJvlPwxnGCQiINFdz7t5OAew70+3zgzk1K5YzLz+g/PRQkC1KyPT9qot5XbBiMFvLVxvNft8rwRsrDSTNB8DX1IkpgSmEqXXW0GvQ030Ab83ooRdse6daL7KnYUr6/MuDZpUHkXKrtYcTkyaoGDAbtx5HHIqsFpXL9LyQgRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mOstaE0EaBvLdtLn7Z5NoPpMDm6KrO4fomv8MK+5dkk=; b=WjIrvaUtj8QyZiMzeo98XoZHL3tOpWhFO+l8EkYlnMofR3z8DgLP9DRIAY2npC6eJR61C/0It7YivEhfvBpuCoNhpVhcsBzYTyBkvkzMeb2jrz/nLA6/MIj+PeS0HW3hlNS9mEzVs+o9zhz8zmTFwPcRpl3PijLskxgjs11kx35i53a+9r3GPo5c5aHGla5ZOe9GKU1Z6v26LYj5WqQyBCqz0/QwMA6dOEnglv4onyWM0in3UJFZjUz+8j9a1CrKobhkEhgZxIQDtv4woN+ta71LVt5NzX0jv5S+cHggfe1eRFOWDJEkhcuD7zPIIRFoN+ktleaxh6a9E7u+niKRMg== Received: from DM8PR12MB5400.namprd12.prod.outlook.com (2603:10b6:8:3b::12) by DM4PR12MB5344.namprd12.prod.outlook.com (2603:10b6:5:39f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22; Wed, 24 Nov 2021 18:09:31 +0000 Received: from DM8PR12MB5400.namprd12.prod.outlook.com ([fe80::4c7b:3be1:176b:f77f]) by DM8PR12MB5400.namprd12.prod.outlook.com ([fe80::4c7b:3be1:176b:f77f%4]) with mapi id 15.20.4713.025; Wed, 24 Nov 2021 18:09:31 +0000 From: Ori Kam To: "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Slava Ovsiienko CC: "dev@dpdk.org" , "ferruh.yigit@intel.com" Subject: RE: [PATCH v3] ethdev: deprecate header fields and metadata flow actions Thread-Topic: [PATCH v3] ethdev: deprecate header fields and metadata flow actions Thread-Index: AQHX4UlXKsp2VpIVhkisCn1rc01r4awS17IAgAAI34CAAA9sgIAAB8aA Date: Wed, 24 Nov 2021 18:09:31 +0000 Message-ID: References: <20211123075940.5521-1-viacheslavo@nvidia.com> <3238712.SzvLOqgLnN@thomas> In-Reply-To: <3238712.SzvLOqgLnN@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cc772ab4-6461-4215-5721-08d9af758ffa x-ms-traffictypediagnostic: DM4PR12MB5344: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GnZnPhzmacTU+PB0B1uN+BoReKWPFzMCeQyh37eFyTTnKCrLw3Fee5yK19DwF6jVgD8k4x8t0Ahkomk1lX++H+ny2k+yMFmv7OZKqGE0zTGdvBsWUUArJB/QY1MdTOVdvtlw6gHj+/76NUs8fpVLQ5mHPnI0mDG56+rCiGoh1CttVnZ22kAdVCmr637yL/ph8sJEadCb37rQ7JVd830498r5ziAIlId4gaWWl1OHqZMHTtMAgnY8osb8n3ES05BPLh5PmbhKfy0n+sPzq9QXKdV9bVsgZAO5UPkSADGS73JqZDh88x3Po6OO4ilzwdm9r+JpetdXoV/HvnSQDzKMhH1CR4zOeVixfM4ZRH5VDeELi9HIYPlhbJR8gHEHaRqFcpbvgpd48fjXp6aNm8Q8Wd3Lmaz/2w80g07bFs6Kv1qNNUre3gFzpN2CEfdMMPZLVlz78HzKu9yr2W6s6sKGQf1jjPpZ0520BR9q9vaFq88avHx55QVXqRG2+YmAosZvtjX3HX9em104fgxxXvWTWsvRvNGqIxiUNAliQvCYx1k0hXjHiNWc9AYvdfpaq9FLLKSM+VQCETY6iV9mmEohLrqbDdaxTExt9b5f6tNa5XxeW+NvAsbT8ua8u0IAC16Q+k/AoElMewqHAAZICv8hYXZBP8hUf0+sTvbDcP2mo1Q9857wX5a+SsiyISq/U15RP32SV0YsA92Ce83qWh7lHQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR12MB5400.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(5660300002)(86362001)(7696005)(83380400001)(6506007)(52536014)(55016003)(508600001)(2906002)(66946007)(38070700005)(76116006)(54906003)(8936002)(8676002)(316002)(71200400001)(38100700002)(33656002)(4326008)(6636002)(26005)(9686003)(66556008)(186003)(64756008)(66446008)(122000001)(66476007)(110136005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?x8pOTUppsB3twPQL8zlEz3Wv4TlYhtoQxaPsT6vKbo+kjRGNe0iir/jIj1y4?= =?us-ascii?Q?PTJpd9zYL0oze3upHW3VQB1OG/cHzLwW6lk/lG9tZyawgixA4zanhT8u7v0i?= =?us-ascii?Q?u4QLOiyLRrDMUH/ECLfMlBd79HAW6bSGUCgyxEnPyMGs2lrI02lKnW8Nwojr?= =?us-ascii?Q?NaVF8IB8u9GR6TUyrCA6Ukr/uKMuvzomAY3pelXeOznT2Fuf3a1eLCEBtQaT?= =?us-ascii?Q?HEH3xRMLekI7br6mjNGGz3wDPzMiZnJDnNoMws8mBWXODplafNppDJmQOJNw?= =?us-ascii?Q?a4PK//tieyg2KdRDVeZez3OSRNCzffVux/X5/5obsDzqRS+oEQeIeySi8ViS?= =?us-ascii?Q?nowTKbet59j9IdW6tXKpvo4gmk0B/crBoyMHxELmztKYgmWjGLuJ9yvVnpkP?= =?us-ascii?Q?lqbUiFa3sEqpoK0eiiRp5nnK5XjdA7LDh40Bv+23guFBiz6aIGTg3jz19g5T?= =?us-ascii?Q?rBS+JUspeXjm/pZrYfoMJOXw1z4UDBSY2H7Vtv3MUbL1hpnltpjng/wY8nIm?= =?us-ascii?Q?DlZcjnTC82zGj1P9UXL3q1BD0YbkMJLMcmHBss2/e2L4DjTCzuz3H3mozPoR?= =?us-ascii?Q?9+HPel/sGKz+WJqwZ5pNWO4txLV2wvL1k3yjIjQGPzco5kCMDkBJx+A/QGCZ?= =?us-ascii?Q?+F12V0XkWB+X1CTsTpIWfdzNm9O+FTapRxj9fzzfmxx0pHV0Rmq0htMy6sS2?= =?us-ascii?Q?rQuzyxZ3rD2W9KjIfRYW8zHe0hh5h2aYNjYyXy2Yo8h8+UvAbloAYx4BxIJA?= =?us-ascii?Q?CGvkCiOuORa84YIurlTPiysV41c/MZJ4vnsVvWZrlFmTtyazV79Ceah0AQ9V?= =?us-ascii?Q?xYmGmwYDZQ8HnD4OSTvr9tkdjSaahKp8/9Nyj1Pe9AR+5HLIONNcnYcQnjEH?= =?us-ascii?Q?si63oCwwZoIViRpILD4EiAHSyvX4RLAU6vzSyfWvVju1tlJMBVl0kxxUJLDM?= =?us-ascii?Q?QASZVv7PdaC9D+MkIw8vM5s4IyMqyvMukfqIVEYuV56lRTgmkja8zzIt1ovW?= =?us-ascii?Q?oYtdklUyUlbA17tRb9r5q1OvAhlr0HUGIh4m9DnUmVS6xnoLuVgw3e0accc/?= =?us-ascii?Q?jhoXbqLJLahfQma1kZEdnd0zTIu8wsyc+LZ1JmzfjjbbXm9tIGIgkcoM1uOi?= =?us-ascii?Q?6FSv5L5k47TtKDe413NZhnYjlWT8NYOv47dwWZxorGsZJV4+S0XOZRpbQoV8?= =?us-ascii?Q?iHMkZ/NuxGwnkEvWjRiSHfXf3JOa2GIOxGn5+AABcolSiNujkn2FGjG5Bz9Y?= =?us-ascii?Q?HOk8Xr8ff7POJsdMiOqH2M2VPX3D37x1KWBWiK4jULFm8YNZr3eU6snjC/MB?= =?us-ascii?Q?mAXo34f5HkJrp8z+LxSMxOK6g6GDwJ5e9FdW0xJD4Hy4ZPbb+Zr6d2SmMpuf?= =?us-ascii?Q?CVzR5zPaSM8qKoqZBOJSb7FLN3NUcpgXSEKCuVPUZAOcbScd14Uie5opmLW6?= =?us-ascii?Q?GL8yA4HJKZpf44bGlmCVu9nW82ohQEKJB6XzwM3NKpGV4LVzxNKV7FQSoE7o?= =?us-ascii?Q?Z2ERTeiaXGPJsxCqcao/jukj49SrnxU8IG9jt9wtMSESRnzFzfRAeoNl+psf?= =?us-ascii?Q?eIueXRL4a9mo9hQaNUMzw2A+tWHM42kf5Eg0RbI+G4L7JJM/K2xUtvv/OtZ9?= =?us-ascii?Q?jw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5400.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc772ab4-6461-4215-5721-08d9af758ffa X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Nov 2021 18:09:31.0431 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0jel6Qs2OevvRM8a8Fy8U0wZ8XIriaa5PhlPgJ+zEnpzpMdv+cRlzJxj26BDLoOpKbHUkFQR6y10hAKppAHAzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5344 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi > -----Original Message----- > From: Thomas Monjalon > Sent: Wednesday, November 24, 2021 7:33 PM >=20 > 24/11/2021 17:37, Slava Ovsiienko: > > From: Ori Kam > > > From: Viacheslav Ovsiienko > > > > Action: ``OF_SET_MPLS_TTL`` > > > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > > > +This action is deprecated. Consider `Action: MODIFY_FIELD`_. > > > > > > > > > > Since no PMD support this action why set reference to MODIFY_FIELD_? > > > Same for all unsupported actions. > > > > There are some references to this action in PMDs (for example bnxt), > > but the ENOTSUP returned. I.e., action is in source code, but actually > > not supported. Hence (due to this and in general), we can't just occasi= onally > > remove existing actions, we should deprecate these first. > > Other point - if someone will decide to implement support for this > > action in his/her PMD - the deprecation notice will point out the right= way - > > "consider MODIFY_FIELD." > > If someone will want to create such action he can see how all the rest of t= he actions are done. I don't think we need to point a user incorrect path. > > > > > > > Implements ``OFPAT_SET_MPLS_TTL`` ("MPLS TTL") as defined by the > > > > `OpenFlow Switch Specification`_. > > > > @@ -2254,6 +2255,7 @@ Switch Specification`_. > > > > > > [..snip..] > > > > > > If no PMD support this why do we want to add it to the modify_field? > > > Same for all of the unsupported actions. > > As I said above - we just propose to consider MODIFY_FIELD actions > > if someone has intention to implement deprecated OFPAT_SET_MPLS_TTL. >=20 > It was an API, we must guide the API reader in the right direction. > BTW, it can be implemented in a driver which is not yet upstream. >=20 So you think we should keep it? The guideline is that if there is no implementation it should not go in. I see that this API was added in 2018 if someone is using this API let him rise his voice.