From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C4436A0C43; Wed, 20 Oct 2021 15:50:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ACB034118F; Wed, 20 Oct 2021 15:50:01 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2073.outbound.protection.outlook.com [40.107.243.73]) by mails.dpdk.org (Postfix) with ESMTP id 8366840142 for ; Wed, 20 Oct 2021 15:50:00 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CFMCXKVdi195GYetSlU3wwBaIxXiNpgV/oYopl6bEKiLLhaFHi4rVqcACWs4KIyl8tlBJaiSulRGR5ZSHthNQdg089Rjl2U2KBsJ08bL60AMkpMYqWScyxS/wfmUKZJFd/vrKDZFDFiXUlGX42wg9bCFl/1psvOXDst51bKFXgb67zzIwg6v6MalkzbQFRHKixQJHmitkRwLYELLwsQMsY7Bmahtd9f5V72A+ea2juN9oJjFR9+hmlw8ZO2Yn0YWymlagdpE61mwqxJXye97ui8OGJtdXVvdDqWx55GUn/JgTS/1ZuiCIVgD5YwH3+MzuzadxuAlpCZLELEOhNQJ8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kcrJWHImaMEse1PSLBm9S5945fwnw4NZrTHKLhJlOAY=; b=LwiQ4jvG8h0Bm23nZv1+gxmim8ll+LfCU33iEVWrk5Ox1Z939CER5rWDy//Oa7jg1Qt/idpfOrkZ99ggLqVZqprliy/kfVPcAyZzeBdyHMqV4lqw1lhAzqSGQJe3w5S+DRkJHDp3u9f2+t5u0kmdtLRmPJ1xE/nGVaG2RM+Kds6v1M9Q9mN3NjfFEiRoVsFe3WnubUUa04TKgLMEFu+cmBc0wNYvv9fWBjcMNncZEeb0l1WvwhfSIPjxQ2kGWy55SzRZVZmQT5UI5KESLHcWwL897TFbny4NTHcY8QEYrLZTNY5Z/aR+WYxfPrU295AinY+a0c/K+lrgaPIDB6kl1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kcrJWHImaMEse1PSLBm9S5945fwnw4NZrTHKLhJlOAY=; b=Nz93O5wSPlW0PRR6g11Ao+S2ICDsInGWKTwk9LQTJo+9c/NZdFsmagUaQjDF2FWQRfPf4pjlWtNGTD5/7Jld2Dde9oa4Guz4tgzexbGYe1aLcI3pJvQylpjvvgUua21/2v3AxfoN6Ccua61qU3V6+OoWsM16k/xrrLk112r030fvBdXKQhkvPTRA7wUa628CBRADqWqN9FcsAygNbH09KZ7EsqRSUQCQaeABt6ougB599gYmuh8bQfYqwM2uWIK7q/3Pu28g7TZD+S8A6CCj+FyFvpoG8DB7uAhqjuK27cWEDoFXjjtGJ0E9U/BJZVtqJNvu+A3l0nYkQWg7aNxDxg== Received: from DM8PR12MB5400.namprd12.prod.outlook.com (2603:10b6:8:3b::12) by DM4PR12MB5072.namprd12.prod.outlook.com (2603:10b6:5:38b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Wed, 20 Oct 2021 13:49:59 +0000 Received: from DM8PR12MB5400.namprd12.prod.outlook.com ([fe80::d03d:1f75:ca20:6a32]) by DM8PR12MB5400.namprd12.prod.outlook.com ([fe80::d03d:1f75:ca20:6a32%6]) with mapi id 15.20.4628.016; Wed, 20 Oct 2021 13:49:59 +0000 From: Ori Kam To: Andrew Rybchenko , Ferruh Yigit , NBU-Contact-Thomas Monjalon CC: "dev@dpdk.org" Thread-Topic: [PATCH v3 05/10] ethdev: fix VLAN spelling including VLAN ID case Thread-Index: AQHXxbC0mkvGu3eeZUO4l/rUnRHeDavb5zvg Date: Wed, 20 Oct 2021 13:49:59 +0000 Message-ID: References: <20211014083704.2542493-1-andrew.rybchenko@oktetlabs.ru> <20211020124727.2829268-1-andrew.rybchenko@oktetlabs.ru> <20211020124727.2829268-6-andrew.rybchenko@oktetlabs.ru> In-Reply-To: <20211020124727.2829268-6-andrew.rybchenko@oktetlabs.ru> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: oktetlabs.ru; dkim=none (message not signed) header.d=none;oktetlabs.ru; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2c47a6d3-1aaf-4aa9-45ba-08d993d081f5 x-ms-traffictypediagnostic: DM4PR12MB5072: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ce6s2Sxd6MqhZwRc7VoKfPpiQVD2CIVHzGE9Ix5Btzi3XjgMv+Tup4OaS1Rt+mceNwKG+XCtI4Y/ZfC2ipzEMOz+lzsmjY/eBK2LiokbFmCCihATF/U0jen64elhlzYFTCGMJhhYMvMwvGIaEUKvn1oCG9RmNQZTHyUbiD6m598nxZxQkfbmOb5dSsmKjD1DKsH4Gceiw6nm9r3cijQOcRtxtpG9S9brNo8eOP/i/SiQmVT7eRQlbjMqqHfQw85Jhwp3SEUR2bW3TBWoGraoGGSD6u0f5edIFFdrmondss5LeAD8qEfO5oNfq1tFxLGvA7g0XEWNoedQYgwUiuj6J5l+ZbbTslQFZUTkSCToftvuuhia6b4CR72yZnGqtBPJq3ByQmLGpVAVyTv+oe/JSlYqVqkdgiC5X2NnibybRWxpnq8TuWtS6GAmd8E+rqG0oJhLbfgRm8jP0MPx3YxXADGsebj+kXPSltwpgSxFLdFC+5WAk7dbGfD+k/a85GktUIEojygOry++4SUkiDAwYxyHWM8D27Iz34q97utVpuY3hRqNX44bxJ3TtbpFrvyut+2TeDuTpbqwGOkACbw7u84M2xbvSkwXM4HyNwQPvAC63h+qd8vX+OtCvy2JVYoH/jUWyWt96GzgGZqjEuhgopJoPgJMvX8fi5VJ4p6mj21j1eVD+ar/aOdew55IuheV8vr+MRqAqZPVx6vnf3nGyA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR12MB5400.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6506007)(53546011)(186003)(7696005)(8936002)(8676002)(71200400001)(86362001)(508600001)(4326008)(55016002)(9686003)(316002)(64756008)(110136005)(66476007)(66946007)(76116006)(5660300002)(33656002)(2906002)(38100700002)(52536014)(83380400001)(38070700005)(122000001)(66556008)(66446008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: iQDFGUzCDly99utWjf67DW4pX70ffDZTHx1FUzUfYnjmVPG+ercjlL/n6mSCdifgh3rv5VjHjUwYZP0HESD+3IyBexl/k2gp1o4AhrFQstKrbHkoYAn1GYEIaNBW8eISQIgHNk5SShg47SFUDYEid0kkWIlo5m9ZdxotHvhHem3vgZ84iyxKOniq992D7c98sqkwEjvNRnnU5zSVYM9bVXL/mK17aREpoAsxt4lnONoeyzBmhKFLwIoYA5dtW/uWWMLdKBQ8d9O+VdQGVgfjTlAYasy2xSygYl/ZzvV7MMESSLqrj9iJ+kQNFochiPOmV+jifJSakYU/j9rharA8BDMGM9I7+OuGfrWprJ8KSqg= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5400.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c47a6d3-1aaf-4aa9-45ba-08d993d081f5 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2021 13:49:59.1804 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: orika@nvidia.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5072 Subject: Re: [dpdk-dev] [PATCH v3 05/10] ethdev: fix VLAN spelling including VLAN ID case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Andrew, > -----Original Message----- > From: Andrew Rybchenko > Sent: Wednesday, October 20, 2021 3:47 PM > Subject: [PATCH v3 05/10] ethdev: fix VLAN spelling including VLAN ID cas= e >=20 > Signed-off-by: Andrew Rybchenko > --- > lib/ethdev/rte_ethdev.c | 2 +- > lib/ethdev/rte_ethdev.h | 30 +++++++++++++++--------------- > lib/ethdev/rte_flow.h | 6 +++--- > 3 files changed, 19 insertions(+), 19 deletions(-) >=20 > diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c > index acb667c112..9d1793e216 100644 > --- a/lib/ethdev/rte_ethdev.c > +++ b/lib/ethdev/rte_ethdev.c > @@ -3707,7 +3707,7 @@ rte_eth_dev_vlan_filter(uint16_t port_id, uint16_t = vlan_id, int on) >=20 > if (!(dev->data->dev_conf.rxmode.offloads & > DEV_RX_OFFLOAD_VLAN_FILTER)) { > - RTE_ETHDEV_LOG(ERR, "Port %u: vlan-filtering disabled\n", > + RTE_ETHDEV_LOG(ERR, "Port %u: VLAN-filtering disabled\n", > port_id); > return -ENOSYS; > } > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h > index d903f51196..2c35caf000 100644 > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -444,7 +444,7 @@ enum rte_vlan_type { > }; >=20 > /** > - * A structure used to describe a vlan filter. > + * A structure used to describe a VLAN filter. > * If the bit corresponding to a VID is set, such VID is on. > */ > struct rte_vlan_filter_conf { > @@ -805,7 +805,7 @@ rte_eth_rss_hf_refine(uint64_t rss_hf) > #define RTE_RETA_GROUP_SIZE 64 >=20 > /**@{@name VMDq and DCB maximums */ > -#define ETH_VMDQ_MAX_VLAN_FILTERS 64 /**< Maximum nb. of VMDq vlan fil= ters. */ > +#define ETH_VMDQ_MAX_VLAN_FILTERS 64 /**< Maximum nb. of VMDq VLAN fil= ters. */ > #define ETH_DCB_NUM_USER_PRIORITIES 8 /**< Maximum nb. of DCB prioritie= s. */ > #define ETH_VMDQ_DCB_NUM_QUEUES 128 /**< Maximum nb. of VMDq DCB que= ues. */ > #define ETH_DCB_NUM_QUEUES 128 /**< Maximum nb. of DCB queues. = */ > @@ -906,11 +906,11 @@ struct rte_eth_vmdq_tx_conf { > * of an Ethernet port. > * > * Using this feature, packets are routed to a pool of queues, based > - * on the vlan id in the vlan tag, and then to a specific queue within > - * that pool, using the user priority vlan tag field. > + * on the VLAN ID in the VLAN tag, and then to a specific queue within > + * that pool, using the user priority VLAN tag field. > * > * A default pool may be used, if desired, to route all traffic which > - * does not match the vlan filter rules. > + * does not match the VLAN filter rules. > */ > struct rte_eth_vmdq_dcb_conf { > enum rte_eth_nb_pools nb_queue_pools; /**< With DCB, 16 or 32 pools */ > @@ -918,9 +918,9 @@ struct rte_eth_vmdq_dcb_conf { > uint8_t default_pool; /**< The default pool, if applicable */ > uint8_t nb_pool_maps; /**< We can have up to 64 filters/mappings */ > struct { > - uint16_t vlan_id; /**< The vlan id of the received frame */ > + uint16_t vlan_id; /**< The VLAN ID of the received frame */ > uint64_t pools; /**< Bitmask of pools for packet Rx */ > - } pool_map[ETH_VMDQ_MAX_VLAN_FILTERS]; /**< VMDq vlan pool maps. */ > + } pool_map[ETH_VMDQ_MAX_VLAN_FILTERS]; /**< VMDq VLAN pool maps. */ > /** Selects a queue in a pool */ > uint8_t dcb_tc[ETH_DCB_NUM_USER_PRIORITIES]; > }; > @@ -930,8 +930,8 @@ struct rte_eth_vmdq_dcb_conf { > * not combined with the DCB feature. > * > * Using this feature, packets are routed to a pool of queues. By defaul= t, > - * the pool selection is based on the MAC address, the vlan id in the > - * vlan tag as specified in the pool_map array. > + * the pool selection is based on the MAC address, the VLAN ID in the > + * VLAN tag as specified in the pool_map array. > * Passing the ETH_VMDQ_ACCEPT_UNTAG in the rx_mode field allows pool > * selection using only the MAC address. MAC address to pool mapping is = done > * using the rte_eth_dev_mac_addr_add function, with the pool parameter > @@ -941,7 +941,7 @@ struct rte_eth_vmdq_dcb_conf { > * it is enabled or revert to the first queue of the pool if not. > * > * A default pool may be used, if desired, to route all traffic which > - * does not match the vlan filter rules or any pool MAC address. > + * does not match the VLAN filter rules or any pool MAC address. > */ > struct rte_eth_vmdq_rx_conf { > enum rte_eth_nb_pools nb_queue_pools; /**< VMDq only mode, 8 or 64 pool= s */ > @@ -951,9 +951,9 @@ struct rte_eth_vmdq_rx_conf { > uint8_t nb_pool_maps; /**< We can have up to 64 filters/mappings */ > uint32_t rx_mode; /**< Flags from ETH_VMDQ_ACCEPT_* */ > struct { > - uint16_t vlan_id; /**< The vlan id of the received frame */ > + uint16_t vlan_id; /**< The VLAN ID of the received frame */ > uint64_t pools; /**< Bitmask of pools for packet Rx */ > - } pool_map[ETH_VMDQ_MAX_VLAN_FILTERS]; /**< VMDq vlan pool maps. */ > + } pool_map[ETH_VMDQ_MAX_VLAN_FILTERS]; /**< VMDq VLAN pool maps. */ > }; >=20 > /** > @@ -3127,9 +3127,9 @@ int rte_eth_dev_fw_version_get(uint16_t port_id, > * and RTE_PTYPE_L3_IPV4 are announced, the PMD must return the followin= g > * packet types for these packets: > * - Ether/IPv4 -> RTE_PTYPE_L2_ETHER | RTE_PTYPE_L3_IPV4 > - * - Ether/Vlan/IPv4 -> RTE_PTYPE_L2_ETHER_VLAN | RTE_PTYPE_L3_I= PV4 > + * - Ether/VLAN/IPv4 -> RTE_PTYPE_L2_ETHER_VLAN | RTE_PTYPE_L3_I= PV4 > * - Ether/[anything else] -> RTE_PTYPE_L2_ETHER > - * - Ether/Vlan/[anything else] -> RTE_PTYPE_L2_ETHER_VLAN > + * - Ether/VLAN/[anything else] -> RTE_PTYPE_L2_ETHER_VLAN > * > * When a packet is received by a PMD, the most precise type must be > * returned among the ones supported. However a PMD is allowed to set > @@ -3275,7 +3275,7 @@ int rte_eth_dev_set_vlan_strip_on_queue(uint16_t po= rt_id, uint16_t > rx_queue_id, > * @param port_id > * The port identifier of the Ethernet device. > * @param vlan_type > - * The vlan type. > + * The VLAN type. > * @param tag_type > * The Tag Protocol ID > * @return > diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h > index 45b360d4ac..e3c2277582 100644 > --- a/lib/ethdev/rte_flow.h > +++ b/lib/ethdev/rte_flow.h > @@ -2181,7 +2181,7 @@ enum rte_flow_action_type { > RTE_FLOW_ACTION_TYPE_OF_PUSH_VLAN, >=20 > /** > - * Implements OFPAT_SET_VLAN_VID ("set the 802.1q VLAN id") as > + * Implements OFPAT_SET_VLAN_VID ("set the 802.1q VLAN ID") as > * defined by the OpenFlow Switch Specification. > * > * See struct rte_flow_action_of_set_vlan_vid. > @@ -2853,11 +2853,11 @@ struct rte_flow_action_of_push_vlan { > /** > * RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_VID > * > - * Implements OFPAT_SET_VLAN_VID ("set the 802.1q VLAN id") as defined b= y > + * Implements OFPAT_SET_VLAN_VID ("set the 802.1q VLAN ID") as defined b= y > * the OpenFlow Switch Specification. > */ > struct rte_flow_action_of_set_vlan_vid { > - rte_be16_t vlan_vid; /**< VLAN id. */ > + rte_be16_t vlan_vid; /**< VLAN ID. */ > }; >=20 > /** > -- > 2.30.2 Acked-by: Ori Kam Best, Ori