Re: [dpdk-dev v6 1/2] eal: introduce rte_memeq_timingsafe() based on FreeBSD API

["Ji, Kai" <kai.ji@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2640 bytes --]

What needed to get it merged within RC1 window ?


________________________________
From: Morten Brørup <mb@smartsharesystems.com>
Sent: Friday, October 03, 2025 08:35
To: Ji, Kai <kai.ji@intel.com>; dev@dpdk.org <dev@dpdk.org>
Cc: gakhil@marvell.com <gakhil@marvell.com>; konstantin.ananyev@huawei.com <konstantin.ananyev@huawei.com>; Richardson, Bruce <bruce.richardson@intel.com>; thomas@monjalon.net <thomas@monjalon.net>; stephen@networkplumber.org <stephen@networkplumber.org>
Subject: RE: [dpdk-dev v6 1/2] eal: introduce rte_memeq_timingsafe() based on FreeBSD API

> From: Kai Ji [mailto:kai.ji@intel.com]
> Sent: Thursday, 2 October 2025 17.32
>
> Bugzilla ID: 1773
> https://bugs.dpdk.org/show_bug.cgi?id=1773
>
> Signed-off-by: Kai Ji <kai.ji@intel.com>
> ---
>  lib/eal/include/rte_memory.h | 38 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
>
> diff --git a/lib/eal/include/rte_memory.h
> b/lib/eal/include/rte_memory.h
> index dcc0e69cfe..2d24e091af 100644
> --- a/lib/eal/include/rte_memory.h
> +++ b/lib/eal/include/rte_memory.h
> @@ -746,6 +746,44 @@ __rte_experimental
>  void
>  rte_memzero_explicit(void *dst, size_t sz);
>
> +/**
> + * @warning
> + * @b EXPERIMENTAL: this API may change without prior notice.
> + *
> + * Timing-safe memory equality comparison.
> + *
> + * This function compares two memory regions in constant time, making
> it
> + * resistant to timing side-channel attacks. The execution time
> depends only
> + * on the length parameter, not on the actual data values being
> compared.
> + *
> + * This is particularly important for cryptographic operations where
> timing
> + * differences could leak information about secret keys, passwords, or
> other
> + * sensitive data.
> + *
> + * @param a
> + *   Pointer to the first memory region to compare
> + * @param b
> + *   Pointer to the second memory region to compare
> + * @param n
> + *   Number of bytes to compare
> + * @return
> + *   true if the memory regions are identical, false if they differ
> + */
> +__rte_experimental
> +static inline bool
> +rte_memeq_timingsafe(const void *a, const void *b, size_t n)
> +{
> +     const volatile uint8_t *pa = (const volatile uint8_t *)a;
> +     const volatile uint8_t *pb = (const volatile uint8_t *)b;
> +     uint8_t result = 0;
> +     size_t i;
> +
> +     for (i = 0; i < n; i++)
> +             result |= pa[i] ^ pb[i];
> +
> +     return result == UINT8_C(0);
> +}
> +
>  #ifdef __cplusplus
>  }
>  #endif
> --
> 2.34.1

Reviewed-by: Morten Brørup <mb@smartsharesystems.com>


[-- Attachment #2: Type: text/html, Size: 4599 bytes --]