From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E18EC45AAC; Fri, 4 Oct 2024 11:04:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5C21E4027F; Fri, 4 Oct 2024 11:04:23 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by mails.dpdk.org (Postfix) with ESMTP id DB89340268; Fri, 4 Oct 2024 11:04:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1728032661; x=1759568661; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=GkFzNbiV/mGsmbzze124GQNAdGT50pqR5IkhnkDUFX4=; b=VuuqgIv+Ib51q9MkTdw14lLtcGaCTxAAfX39BAw6RiXcDVYo7Ci4/NvP xNXSGkTO5oyQbJgcELUPyDAsv1neQjZ0315rT+LGJs8OWbvsD5iqVt3qc JU4eeLPNlltobFtfXdtmGInpWmTZngCkjkcf4qfB4ZH697k6y81KjZscT ejFQgjaJbPFCkb1WTyn3jQBFFtWvUN6Lm9uc+wGLB/IvMq1/aknGWZsZ2 YAhbqXmIKjbM9rhMX5kG4AszFpDrnNawXO0Vnr76fQFdnOM3NFR/r+sUI 5/D24QzMvrUcy5aAZ1jmxXOYcCL8U91kFNALRjgbE/hUh08WIMRIlSf1h Q==; X-CSE-ConnectionGUID: GAvvkB24TEqnbshCCNLxBQ== X-CSE-MsgGUID: l4F/4eJuTjumcLkR3EG0uA== X-IronPort-AV: E=McAfee;i="6700,10204,11214"; a="38639061" X-IronPort-AV: E=Sophos;i="6.11,177,1725346800"; d="scan'208,217";a="38639061" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2024 02:04:19 -0700 X-CSE-ConnectionGUID: F92gOoULTGiDJ3BqtheA4Q== X-CSE-MsgGUID: 8JOuEopXS/KnLucoFG9p3w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,177,1725346800"; d="scan'208,217";a="75074952" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa007.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 04 Oct 2024 02:04:17 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 4 Oct 2024 02:04:16 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 4 Oct 2024 02:04:16 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.49) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 4 Oct 2024 02:04:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LT5KRsFKmVgrmTY82TZyA912wFpIuKu8Nn3OjCVymL1uLpYUHlFTFSq7Mjwr8XTrmn+lIAxz6+ccUc+hBCemvWaRgFnlb8NTENlMj5f8n4lPqtw+Z74pbrBDFL1q/t0JVF2Wtd3rjLqvacqehWmUv1jNckhvZosqIRGVWLE5eOG4rwjNCdWdQk9Ju4nlQxH97k9IigIXH76H67Vp126ccBMPDeAI67wnpwTdYmptZIMPYgX3VXB4IiLvzlzL5I/KVIFIX1lJvEfeZPTwNm1oZPCT9Vk1F/VqFrs+05LaSrFOux4hzx3jX5Ckm1xUFMLK5oG8qdIdoH1591l/KqSTfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Kr5ScKEyySJBMStTTZA8DMUwcKqNk48k5wP1T17qk3o=; b=XaSJ56VxlstB9ZybjMT8KQyErQK0A3cSUWMqv/oKL0e0BzyF1zEsjnXZ5Cme3z0+wD/dlRtEgccl4YNRAqjdHOkH5Lj/XK4j3aSxjCPcZPKEWKdtnGOd9Kgd5bso9dqrRpj7RE6ApCe9TP8e9i4yy0gdSIxAs6/wUtwyI2+43RfklIuL4wJfv3ak9sYTb86JMa/AYEIwXpy/QP3O2TYlYksINp8NgNzRaRgD2VVLE6SCc8bWmMpUwrxwM4xZ1QZFZo5g8Ri55ZNO4X+vQFOENLXVFq2e+Tajxfdu8AqYgZzZM+DHUOA+DJ/vxlmF9hQNBDLgcVWHbemkuLUOPiI17Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DS0PR11MB7458.namprd11.prod.outlook.com (2603:10b6:8:145::13) by CH3PR11MB8315.namprd11.prod.outlook.com (2603:10b6:610:17e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.18; Fri, 4 Oct 2024 09:04:14 +0000 Received: from DS0PR11MB7458.namprd11.prod.outlook.com ([fe80::1a9e:53a6:9603:8f79]) by DS0PR11MB7458.namprd11.prod.outlook.com ([fe80::1a9e:53a6:9603:8f79%4]) with mapi id 15.20.8026.017; Fri, 4 Oct 2024 09:04:13 +0000 From: "Ji, Kai" To: Akhil Goyal , "dev@dpdk.org" , "Mcnamara, John" CC: "stable@dpdk.org" , "O'Sullivan, Kevin" , jhascoet , "Coyle, David" , Anoob Joseph Subject: Re: [EXTERNAL] [PATCH] driver: crypto: scheduler: fix session size computation Thread-Topic: [EXTERNAL] [PATCH] driver: crypto: scheduler: fix session size computation Thread-Index: AQHaztr/bCunEChjSU2TcK4zW+I0qLH+G0IAgHi/uhE= Date: Fri, 4 Oct 2024 09:04:13 +0000 Message-ID: References: <20240705125756.227677-1-jhascoet@kalrayinc.com> In-Reply-To: Accept-Language: en-GB, en-US, en-IE Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DS0PR11MB7458:EE_|CH3PR11MB8315:EE_ x-ms-office365-filtering-correlation-id: cd71b8da-4a2c-4e83-079e-08dce45384a6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|10070799003|1800799024|366016|376014|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?Jd13nisu3fZAwjLyF2EO7TZcaCEfcTPDwNTAuTIfwAiZWiwOIvRIFUN6LxFs?= =?us-ascii?Q?hK6067ReVHwNtU089XlITGQxGhVNX+delN8GmTg0jxw8Z6s2W0BLmWo9nM2M?= =?us-ascii?Q?t/BHMBMHEGVi8323wsLBqHJZmVJp+AixmuxCihVPmRinUzAX3WharDWd5s0g?= =?us-ascii?Q?lb8fyKh9zThl+xOBZYS8WUXyYAUkSVN6eo4CpAacASRdVlna8EFdn7SENghK?= =?us-ascii?Q?6EQQgnRb3M2jsqz9mBDbnw3Ce5bkoGKZAznQ0nRcejGi98qweyegaTJ/obBs?= =?us-ascii?Q?CmvbsfUHoPwXUBUntRsY//c64ZbwzwWqjZX9wIvZhAc2as862dNzm4+j01t2?= =?us-ascii?Q?bGx897XWlI0xk3N4S+nYwJQYLAqc3/1OL5X6XCifoX5UsW6wr24vj9gem32M?= =?us-ascii?Q?zNNP3tOyD29tcEsO6U1EQsqwfmfTeOb9iQ/78wTKRcLJFME9jOzBBO2jVHVB?= =?us-ascii?Q?cVesaQNJ1AF4/lOp4rVFs6hZd/D9K3FhKP6exGe4kOkxKbrq7bXyVa0puivl?= =?us-ascii?Q?V/aZrJd2vX/2WXqD5yVH9YU2nYM5t/xMEvEr8l56L8jw+jIpgAs9OhK/KvfE?= =?us-ascii?Q?3J3vLnqZWZsqwkESjuRD95ajbCIGlrdpCOwWiOPH4LqxNakEqtI/yjfXW6UH?= =?us-ascii?Q?EYY6xOqhB5ohBM5uXlKlAU5xKyXodH+i96yAwToouc2CsyhHQgjoNXp4+ssY?= =?us-ascii?Q?3LQgSnG3jl47t/gipVihegIHp5dAg7kNQlHc1LjHsdFdBiWu1pK2YqVOcZC9?= =?us-ascii?Q?joF5EIRhPxo7MbYwaMj2Ed3jJ9AZz3/OOhSL4R4QdpxcoShAb4LA7MBypKuP?= =?us-ascii?Q?m5EN8lnMrwA88ISPl4RmjOnV8g+h+vgAvRXH4r69uaErdwIcyZgfGo3h3rEG?= =?us-ascii?Q?XjWwUpTM+oc3POx8OMPRmyibyscvwEHK9mFUYjPQaLjH4oQKR8CR4NlUmHFb?= =?us-ascii?Q?W4N/I78a0xqkThqPGdUxOGNRIqJacWmTAkFn1fDFPwqNj9ADdBdwcjH3rd5z?= =?us-ascii?Q?0f/qSYuMpBlDxfMm2sqj5j11qBBsms13IflLXseGqO5uyCveKAP2QjNe+kEV?= =?us-ascii?Q?LpgIoL2glKU6+W3eBYOFo/0s6f7O8DIS5Xy8FDVlk2G0eJXiKIJhEecqOx7A?= =?us-ascii?Q?MNTRLyxHcZnR+1MvFJLmlleatDcyOY6iiDqXG1zjwvwg9a/4aXhx2i2X1Zgy?= =?us-ascii?Q?Xygo12Hsu5U5Pqt/HZR9JAHp/M4qNfGSKUXDYK1qD4hViSe3JSR6DWtrMclJ?= =?us-ascii?Q?vpDR0F5orUv4lXl1EGW/R04QvFLRTk+O21POjjQtSoftFpUZNyRsVFZGi0ls?= =?us-ascii?Q?YrpY8Z9nIBa+p6cs88t4blZgE86TH6uz4GXXTudDayicQg=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7458.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(10070799003)(1800799024)(366016)(376014)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qUABdxW6Td8t0kS16+u0XbrlnNVWDy9aTWvoIj7+Klniaxbnn2uPS1AdkXak?= =?us-ascii?Q?1fYGM/Vr/ph6WAC+CJgz6VKZNTSNmDBDaXHh3cjUhuTghT7NoTVvhYRK768m?= =?us-ascii?Q?SCD4MltHvNMAra8RBi4z2VwpYIx08HRayExiD74xXPV+J+hEWcEHvVvetros?= =?us-ascii?Q?kf87Hv4zBg83xXxnibV+O0YLB1MVOAXs1UFKNo7XFycpSLx0FkOXxXs7PnCS?= =?us-ascii?Q?M6EF3FUE+8ltx/SDPyqqhM8EV7OT15WSRpUbQ7zsKO/jxUbaCk0LthBfSndA?= =?us-ascii?Q?8vGhfSAn8kBgaI/QadjPt0yFVaVxY7dRhrA4g7rbOcPiFQJLwvZ6oVXVlzFY?= =?us-ascii?Q?UvNKFOTaf3njrb3crJxvZ3xLKpo73NMsl/48EgB/Ucw4tY9ONH8xF9mn+Rq6?= =?us-ascii?Q?yOJG+2sfFJHbwLwstoDiec11G+9V8p446ya4QKR65k6K6k0rh52lLj7N9br6?= =?us-ascii?Q?2wrHJ5ZByOF27QFFHHccLxbWGXLov7dekVeyIEhPlcQjPLKhokmI5zN6frrO?= =?us-ascii?Q?YVKXh+iHzlkxBdUbZdxJiWFpDzVcNygSGq73BTm0AyaH5vrfPqDA36kApz+C?= =?us-ascii?Q?nvbuahj9PWVfKdXBSApRaqasdLBjrJ5aa/FwrSk1Q4N7DQ6VnEGo67NE2Mhv?= =?us-ascii?Q?olSf+3fhyjwFZ4HMIV/8tWSMxCqbfVa7WLQA6QehfkhzeiFdNNZAsUvAsDXt?= =?us-ascii?Q?DkyDn0xV40HK3rwAk2Wy6ndgWpdCJK6JDiDJ7qmDZ+ZqsBCe21a4oKfIHFJk?= =?us-ascii?Q?TEspL05/vrEGbwv0pETP6V/aEQPYeto0Op46ph3Hbz3GJH7UdBDerzdWXTyb?= =?us-ascii?Q?N73Pds23nljfmaC+/h2Th21WYxBgRRV9ziqNN6UEcUh88lZz16UTafxckYAi?= =?us-ascii?Q?2rjaHVZQwVGlszRtYgTn259z/AYSsRLQVeAWGroNhiWq4OQX8VmEQbFWk6Rv?= =?us-ascii?Q?9KHt1DwHaXKunrHnBA0X7EtU2lgfupnC8jkhD7LbQ77iw4tFeNDEEx8cvLoa?= =?us-ascii?Q?x4on0pGhvvTAzzqwrGiG5jxG5o3zjB3YdXgxDomt+GuSm0m2OQO+oR/0sYQS?= =?us-ascii?Q?97iK835o3BdL5evXSK5oZbfD++yNIHfPi//tJjbgEOmD5psdQsiWkfROQnhz?= =?us-ascii?Q?yK+fuEV0YLtFY+yPsVv8PPrq45Uty2qWjjeNYEz1eCop1R9YgRteQQTr933E?= =?us-ascii?Q?xW98v3IyhtPiCm66RlQijW8QYHJMsjuCCYMqsVrTMLN8dNBoq4Pk4hIXq8qY?= =?us-ascii?Q?D5dZIM/7p60GFoFRSzDaBRB9tivyNJ87iuuJQkHuuhZ/6AutDVh5TNBTDikV?= =?us-ascii?Q?d1GgR/9gx5uvCWuwp27V6gL5Ht8G+yGQDjTIXkIqsvOIZ6pl1vhh+nB1r5dA?= =?us-ascii?Q?jGVLLRMFu9ga8ayr6X/np62g7JmKmypRwqz7+QEQ+dbooDoJufV84Czt1Iae?= =?us-ascii?Q?XGdxh18UeQhxvOtvsYR3KsWqkopM5MJBQpdI6Kp9KmuNyH2EGTaCJPz7Hftb?= =?us-ascii?Q?qBXMPDoVrPaarOPSOsEuIbsElFEQmjkUjUR2r4TH2o+XeDPO6OOLSWOAySH8?= =?us-ascii?Q?6QWCHmuJVKjWiahtJUEBsIoy+tw7/WuyxISc6LaglbC3hJUZ3GUL4TZEcUcs?= =?us-ascii?Q?WuBHJC2cUr/ZMkCRqd3czk4=3D?= Content-Type: multipart/alternative; boundary="_000_DS0PR11MB7458E0C38C0EC00885BBCB1981722DS0PR11MB7458namp_" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7458.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cd71b8da-4a2c-4e83-079e-08dce45384a6 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Oct 2024 09:04:13.8438 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: j0biOzYd8DTh51jhovcXZdj/WdnDY5dj3UFdPoSpSYmOSv0VztlyT3lejdC5HaYFuGB6hkV5pOYBJdG/JLZmkA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8315 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --_000_DS0PR11MB7458E0C38C0EC00885BBCB1981722DS0PR11MB7458namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Acked-by: Kai Ji ________________________________ From: Akhil Goyal Sent: 19 July 2024 14:06 To: dev@dpdk.org ; Ji, Kai ; Mcnamara, John= Cc: stable@dpdk.org ; O'Sullivan, Kevin ; jhascoet ; Coyle, David ; Anoob Joseph Subject: RE: [EXTERNAL] [PATCH] driver: crypto: scheduler: fix session size= computation Hi Kai, Please review. > From: Julien Hascoet > > The crypto scheduler session size computation was taking > into account only the worker session sizes and not its own. > > Fixes: e2af4e403c1 ("crypto/scheduler: support DOCSIS security protocol") > Cc: stable@dpdk.org > > Signed-off-by: Julien Hascoet > --- > drivers/crypto/scheduler/scheduler_pmd_ops.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/crypto/scheduler/scheduler_pmd_ops.c > b/drivers/crypto/scheduler/scheduler_pmd_ops.c > index a18f7a08b0..6e43438469 100644 > --- a/drivers/crypto/scheduler/scheduler_pmd_ops.c > +++ b/drivers/crypto/scheduler/scheduler_pmd_ops.c > @@ -185,7 +185,7 @@ scheduler_session_size_get(struct scheduler_ctx > *sched_ctx, > uint8_t session_type) > { > uint8_t i =3D 0; > - uint32_t max_priv_sess_size =3D 0; > + uint32_t max_priv_sess_size =3D sizeof(struct scheduler_session_ctx= ); > > /* Check what is the maximum private session size for all workers = */ > for (i =3D 0; i < sched_ctx->nb_workers; i++) { --_000_DS0PR11MB7458E0C38C0EC00885BBCB1981722DS0PR11MB7458namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Acked-by: Kai Ji <kai.ji@intel.com>
From: Akhil Goyal <gakhi= l@marvell.com>
Sent: 19 July 2024 14:06
To: dev@dpdk.org <dev@dpdk.org>; Ji, Kai <kai.ji@intel.com&= gt;; Mcnamara, John <john.mcnamara@intel.com>
Cc: stable@dpdk.org <stable@dpdk.org>; O'Sullivan, Kevin <k= evin.osullivan@intel.com>; jhascoet <ju.hascoet@gmail.com>; Coyle,= David <david.coyle@intel.com>; Anoob Joseph <anoobj@marvell.com&g= t;
Subject: RE: [EXTERNAL] [PATCH] driver: crypto: scheduler: fix sessi= on size computation
 
Hi Kai,
Please review.

> From: Julien Hascoet <ju.hascoet@gmail.com>
>
> The crypto scheduler session size computation was taking
> into account only the worker session sizes and not its own.
>
> Fixes: e2af4e403c1 ("crypto/scheduler: support DOCSIS security pr= otocol")
> Cc: stable@dpdk.org
>
> Signed-off-by: Julien Hascoet <ju.hascoet@gmail.com>
> ---
>  drivers/crypto/scheduler/scheduler_pmd_ops.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/scheduler/scheduler_pmd_ops.c
> b/drivers/crypto/scheduler/scheduler_pmd_ops.c
> index a18f7a08b0..6e43438469 100644
> --- a/drivers/crypto/scheduler/scheduler_pmd_ops.c
> +++ b/drivers/crypto/scheduler/scheduler_pmd_ops.c
> @@ -185,7 +185,7 @@ scheduler_session_size_get(struct scheduler_ctx > *sched_ctx,
>            = ;    uint8_t session_type)
>  {
>        uint8_t i =3D 0;
> -     uint32_t max_priv_sess_size =3D 0;
> +     uint32_t max_priv_sess_size =3D sizeof(struc= t scheduler_session_ctx);
>
>        /* Check what is the maximum= private session size for all workers */
>        for (i =3D 0; i < sched_c= tx->nb_workers; i++) {

--_000_DS0PR11MB7458E0C38C0EC00885BBCB1981722DS0PR11MB7458namp_--