From: Yogev Chaimovich <yogev@cgstowernetworks.com>
To: Dariusz Sosnowski <dsosnowski@nvidia.com>
Cc: Maayan Kashani <mkashani@nvidia.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Bing Zhao <bingz@nvidia.com>, Ori Kam <orika@nvidia.com>,
Suanming Mou <suanmingm@nvidia.com>,
Matan Azrad <matan@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH] net/mlx5: fix transceiver warning when not exist
Date: Thu, 26 Jun 2025 23:16:42 +0000 [thread overview]
Message-ID: <DU2PR09MB5486CBB7ADC2068692C28DA9D67AA@DU2PR09MB5486.eurprd09.prod.outlook.com> (raw)
In-Reply-To: <20250626113617.fekttwech4w75jqt@ds-vm-debian.local>
[-- Attachment #1: Type: text/plain, Size: 1874 bytes --]
OK.
I wished there was a DPDK function to verify if transceiver is plugged in or not, without log errors. Such as rte_eth_dev_is_module_exist()
So, 1'st I would have checked if it's plugged in. Then I would have used rte_eth_dev_get_module_info().
The workaround is setting the module's log level so the error won't be seen before calling rte_eth_dev_get_module_info(), and set it back to default afterwards.
Thanks,
Yogev
________________________________
From: Dariusz Sosnowski <dsosnowski@nvidia.com>
Sent: Thursday, June 26, 2025 14:36
To: Yogev Chaimovich <yogev@cgstowernetworks.com>
Cc: Maayan Kashani <mkashani@nvidia.com>; Stephen Hemminger <stephen@networkplumber.org>; Slava Ovsiienko <viacheslavo@nvidia.com>; Bing Zhao <bingz@nvidia.com>; Ori Kam <orika@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>; Matan Azrad <matan@nvidia.com>; dev@dpdk.org <dev@dpdk.org>
Subject: Re: [PATCH] net/mlx5: fix transceiver warning when not exist
Hi Yogev,
On Mon, Jun 09, 2025 at 01:11:27PM +0000, Yogev Chaimovich wrote:
> Hi,
> Actually looks like we're going with another workaround, so I might not be needing my original patch.
Could you tell us what kind of workaround you applied?
Also, I'm not sure if this warning should be suppressed on EIO.
mlx5 PMD relies on the kernel driver to get the module info,
and from what I've seen for ETHTOOL_GMODULEINFO kernel can return EIO
also for cases other than transceiver not existing
(for example error on NIC register access).
So mlx5 PMD cannot discern between "no transceiver" and
"other I/O error".
For this reason I would keep the log and keep it at warn level.
> Also, I do not understand how my patch (not printing a log) makes a test fail - I couldn't find that test in DPDK to verify. I'm not that familiar though..
>
> Yogev
*snip*
Best regards,
Dariusz Sosnowski
[-- Attachment #2: Type: text/html, Size: 4088 bytes --]
next prev parent reply other threads:[~2025-06-26 23:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-05 12:14 Yogev Chaimovich
2025-05-20 18:49 ` Stephen Hemminger
2025-06-04 7:02 ` Maayan Kashani
2025-06-09 13:11 ` Yogev Chaimovich
2025-06-10 5:47 ` Maayan Kashani
2025-06-26 11:36 ` Dariusz Sosnowski
2025-06-26 23:16 ` Yogev Chaimovich [this message]
2025-05-06 13:31 yogev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DU2PR09MB5486CBB7ADC2068692C28DA9D67AA@DU2PR09MB5486.eurprd09.prod.outlook.com \
--to=yogev@cgstowernetworks.com \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=matan@nvidia.com \
--cc=mkashani@nvidia.com \
--cc=orika@nvidia.com \
--cc=stephen@networkplumber.org \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).