* [dpdk-dev] dpdk-1.7.0 bug report @ 2014-07-23 14:24 David Binderman 2014-07-23 14:31 ` Thomas Monjalon 2014-08-01 15:58 ` Thomas Monjalon 0 siblings, 2 replies; 4+ messages in thread From: David Binderman @ 2014-07-23 14:24 UTC (permalink / raw) To: dev Hello there, dpdk-1.7.0/lib/librte_ether/rte_ether.h:208]: (style) Expression '(X & 0x2) == 0x1' is always false. Source code is return ((ea->addr_bytes[0] & ETHER_LOCAL_ADMIN_ADDR) == 1); but #define ETHER_LOCAL_ADMIN_ADDR 0x02 /**< Locally assigned Eth. address. */ Regards David Binderman ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] dpdk-1.7.0 bug report 2014-07-23 14:24 [dpdk-dev] dpdk-1.7.0 bug report David Binderman @ 2014-07-23 14:31 ` Thomas Monjalon 2014-07-23 14:35 ` David Binderman 2014-08-01 15:58 ` Thomas Monjalon 1 sibling, 1 reply; 4+ messages in thread From: Thomas Monjalon @ 2014-07-23 14:31 UTC (permalink / raw) To: David Binderman; +Cc: dev Hi, 2014-07-23 14:24, David Binderman: > dpdk-1.7.0/lib/librte_ether/rte_ether.h:208]: (style) Expression '(X & 0x2) == 0x1' is always false. Which tool are you using? Thanks for the report -- Thomas ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] dpdk-1.7.0 bug report 2014-07-23 14:31 ` Thomas Monjalon @ 2014-07-23 14:35 ` David Binderman 0 siblings, 0 replies; 4+ messages in thread From: David Binderman @ 2014-07-23 14:35 UTC (permalink / raw) To: Thomas Monjalon; +Cc: dev Hello there, ---------------------------------------- > 2014-07-23 14:24, David Binderman: >> dpdk-1.7.0/lib/librte_ether/rte_ether.h:208]: (style) Expression '(X & 0x2) == 0x1' is always false. > > Which tool are you using? cppcheck, available from sourceforge. Strongly recommended. Regards David Binderman ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] dpdk-1.7.0 bug report 2014-07-23 14:24 [dpdk-dev] dpdk-1.7.0 bug report David Binderman 2014-07-23 14:31 ` Thomas Monjalon @ 2014-08-01 15:58 ` Thomas Monjalon 1 sibling, 0 replies; 4+ messages in thread From: Thomas Monjalon @ 2014-08-01 15:58 UTC (permalink / raw) To: David Binderman; +Cc: dev 2014-07-23 14:24, David Binderman: > dpdk-1.7.0/lib/librte_ether/rte_ether.h:208]: (style) Expression '(X & 0x2) == 0x1' is always false. > > Source code is > > return ((ea->addr_bytes[0] & ETHER_LOCAL_ADMIN_ADDR) == 1); > > but > > #define ETHER_LOCAL_ADMIN_ADDR 0x02 /**< Locally assigned Eth. address. */ It's now fixed: http://dpdk.org/browse/dpdk/commit/?id=030df0102ce762360 Thanks -- Thomas ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-08-01 15:56 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2014-07-23 14:24 [dpdk-dev] dpdk-1.7.0 bug report David Binderman 2014-07-23 14:31 ` Thomas Monjalon 2014-07-23 14:35 ` David Binderman 2014-08-01 15:58 ` Thomas Monjalon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).