From: "Wang, Yinan" <yinan.wang@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/kni: fix crash caused by double stop
Date: Tue, 26 Nov 2019 15:42:51 +0000 [thread overview]
Message-ID: <E0CBA5A1980F1F408E1F28F9991B5B1D50F4DEEE@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <065bb172-1999-492f-60ea-46be9612bb89@intel.com>
Test-by :Wang, Yinan <yinan.wang@intel.com>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Ferruh Yigit
> Sent: 2019年11月26日 22:47
> To: Yigit, Ferruh <ferruh.yigit@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/kni: fix crash caused by double stop
>
> On 11/26/2019 10:50 AM, Ferruh Yigit wrote:
> > 'close()' calls 'stop()' and 'stop()' cancels pthread without any check.
> > Calling 'stop()' & 'close()' sequentially tries to cancel pthread
> > twice which will cause a crash.
> >
> > Adding a state check in 'stop()' before canceling the pthread to
> > prevent multiple stop.
> >
> > Fixes: 696fbc7bb4fc ("net/kni: remove resources when port is closed")
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Applied to dpdk-next-net/master, thanks.
>
> (Applied quickly to make the fix for rc4)
prev parent reply other threads:[~2019-11-26 15:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 10:50 Ferruh Yigit
2019-11-26 14:46 ` Ferruh Yigit
2019-11-26 15:42 ` Wang, Yinan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E0CBA5A1980F1F408E1F28F9991B5B1D50F4DEEE@SHSMSX104.ccr.corp.intel.com \
--to=yinan.wang@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).