From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 2B160AFD6 for ; Wed, 16 Apr 2014 13:11:05 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 16 Apr 2014 04:06:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,871,1389772800"; d="scan'208";a="521931859" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga002.jf.intel.com with ESMTP; 16 Apr 2014 04:11:03 -0700 Received: from irsmsx106.ger.corp.intel.com (163.33.3.31) by IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS) id 14.3.123.3; Wed, 16 Apr 2014 12:09:47 +0100 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.172]) by IRSMSX106.ger.corp.intel.com ([169.254.8.26]) with mapi id 14.03.0123.003; Wed, 16 Apr 2014 12:09:47 +0100 From: "De Lara Guarch, Pablo" To: Neil Horman Thread-Topic: [dpdk-dev] [PATCH v5] eal_common_cpuflags: Fix %rbx corruption, and simplify the code Thread-Index: AQHPWWGr0X0gIMgFHUekUHmzmJjodZsUFW+w Date: Wed, 16 Apr 2014 11:09:46 +0000 Message-ID: References: <20140416104955.GA26829@hmsreliant.think-freely.org> In-Reply-To: <20140416104955.GA26829@hmsreliant.think-freely.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v5] eal_common_cpuflags: Fix %rbx corruption, and simplify the code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Apr 2014 11:11:06 -0000 Hi Neil, >Oh wow, yes, the if conditionals definately should be checked for each ite= ration of the for loop. Good eye. >Still though, seems like a bug in gcc to check the state of the loop index= on exit, when its never used to index the array at that value. Seems a bi= t like this bug: >http://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D45180 >Thomas I'll send a patch to fix this directly Neil Actually, that index may be used in cause last "ret" value is 0: if (!ret) { fprintf(stderr, "ERROR: This system does not support \"%s\"= .\n" "Please check that RTE_MACHINE is set corre= ctly.\n", cpu_feature_table[compile_time_flags[i]].na= me); exit(1); } Thanks, Pablo de Lara DPDK SW Engineer -------------------------------------------------------------- Intel Shannon Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Reg= istered Number: 308263 Business address: Dromore House, East Park, Shannon,= Co. Clare =20