From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] EAL: fix usage of printf-like functions
Date: Fri, 20 Jun 2014 08:24:45 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D897082CC6E5@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <1403202092-12384-1-git-send-email-bruce.richardson@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson
> Sent: Thursday, June 19, 2014 7:22 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] EAL: fix usage of printf-like functions
>
> Mark the rte_log, cmdline_printf and rte_snprintf functions as
> being printf-style functions. This causes compilation errors
> due to mis-matched parameter types, so the parameter types are
> fixed where appropriate.
>
> Changes in V2:
> * Additional fixes for ivshmem-target compilation
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
This patch compiles correctly before the 1.7 rc1. After it, i40e library introduces a compilation error that can be fixed by making the following change:
--- a/lib/librte_pmd_i40e/i40e_ethdev.c
+++ b/lib/librte_pmd_i40e/i40e_ethdev.c
@@ -1536,7 +1536,7 @@ i40e_allocate_dma_mem_d(__attribute__((unused)) struct i40e_hw *hw,
return I40E_ERR_PARAM;
id++;
- rte_snprintf(z_name, sizeof(z_name), "i40e_dma_%lu", id);
+ rte_snprintf(z_name, sizeof(z_name), "i40e_dma_%"PRIu64, id);
mz = rte_memzone_reserve_aligned(z_name, size, 0, 0, alignment);
if (!mz)
return I40E_ERR_NO_MEMORY;
Thanks,
Pablo
next prev parent reply other threads:[~2014-06-20 8:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 18:42 [dpdk-dev] [PATCH] EAL: add format(printf) attrib. to appropriate fns Bruce Richardson
2014-06-19 8:37 ` Thomas Monjalon
2014-06-19 18:21 ` [dpdk-dev] [PATCH v2] EAL: fix usage of printf-like functions Bruce Richardson
2014-06-20 8:24 ` De Lara Guarch, Pablo [this message]
2014-06-20 23:34 ` [dpdk-dev] [PATCH v3] " Bruce Richardson
2014-06-20 23:58 ` Stephen Hemminger
2014-06-21 0:02 ` Richardson, Bruce
2014-06-27 0:48 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D897082CC6E5@IRSMSX103.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).