From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id BAB0EB0B4 for ; Fri, 20 Jun 2014 10:25:03 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 20 Jun 2014 01:19:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,512,1400050800"; d="scan'208";a="531439249" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga001.jf.intel.com with ESMTP; 20 Jun 2014 01:25:17 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.58]) by IRSMSX104.ger.corp.intel.com ([169.254.5.136]) with mapi id 14.03.0123.003; Fri, 20 Jun 2014 09:24:46 +0100 From: "De Lara Guarch, Pablo" To: "Richardson, Bruce" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] EAL: fix usage of printf-like functions Thread-Index: AQHPi+uEfRz74pQ/jEq2Vl8vVtcF15t5qItw Date: Fri, 20 Jun 2014 08:24:45 +0000 Message-ID: References: <2073250.y3o0MLvXtd@xps13> <1403202092-12384-1-git-send-email-bruce.richardson@intel.com> In-Reply-To: <1403202092-12384-1-git-send-email-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] EAL: fix usage of printf-like functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jun 2014 08:25:04 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > Sent: Thursday, June 19, 2014 7:22 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2] EAL: fix usage of printf-like functions >=20 > Mark the rte_log, cmdline_printf and rte_snprintf functions as > being printf-style functions. This causes compilation errors > due to mis-matched parameter types, so the parameter types are > fixed where appropriate. >=20 > Changes in V2: > * Additional fixes for ivshmem-target compilation >=20 > Signed-off-by: Bruce Richardson > --- This patch compiles correctly before the 1.7 rc1. After it, i40e library in= troduces a compilation error that can be fixed by making the following chan= ge: --- a/lib/librte_pmd_i40e/i40e_ethdev.c +++ b/lib/librte_pmd_i40e/i40e_ethdev.c @@ -1536,7 +1536,7 @@ i40e_allocate_dma_mem_d(__attribute__((unused)) struc= t i40e_hw *hw, return I40E_ERR_PARAM; id++; - rte_snprintf(z_name, sizeof(z_name), "i40e_dma_%lu", id); + rte_snprintf(z_name, sizeof(z_name), "i40e_dma_%"PRIu64, id); mz =3D rte_memzone_reserve_aligned(z_name, size, 0, 0, alignment); if (!mz) return I40E_ERR_NO_MEMORY; Thanks, Pablo