From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 87A755910 for ; Fri, 27 Jun 2014 17:47:07 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 27 Jun 2014 08:47:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,561,1400050800"; d="scan'208";a="535116557" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga001.jf.intel.com with ESMTP; 27 Jun 2014 08:47:22 -0700 Received: from irsmsx108.ger.corp.intel.com (163.33.3.3) by IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS) id 14.3.123.3; Fri, 27 Jun 2014 16:47:08 +0100 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.62]) by IRSMSX108.ger.corp.intel.com ([169.254.11.100]) with mapi id 14.03.0123.003; Fri, 27 Jun 2014 16:47:08 +0100 From: "De Lara Guarch, Pablo" To: Neil Horman , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] test: Ring PMD unit test rollback Thread-Index: AQHPkhar8MxMZFlZOEKv8Tj8xMVVfpuE/PYAgAAY6AA= Date: Fri, 27 Jun 2014 15:47:07 +0000 Message-ID: References: <1403880399-16777-1-git-send-email-pablox.de.lara.guarch@intel.com> <20140627150328.GB9138@hmsreliant.think-freely.org> In-Reply-To: <20140627150328.GB9138@hmsreliant.think-freely.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] test: Ring PMD unit test rollback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jun 2014 15:47:08 -0000 Hi Neil, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Neil Horman > Sent: Friday, June 27, 2014 4:03 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] test: Ring PMD unit test rollback >=20 > On Fri, Jun 27, 2014 at 03:46:39PM +0100, Pablo de Lara wrote: > > From: Pablo de Lara > > > > New ring PMD unit test requires extra EAL option (vdev), > > in order to pass, which I believe is incorrect, as this > > test should be focused on testing the API, without needing > > to pass any argument. > > > > Added again all functions that create all the ring devices > > necessary for the test, and remove the last two tests > > (test_pmd_ring_pair_create and test_pmd_ring_pair_attach), > > as they call functions that are deprecated. > > > > Signed-off-by: Pablo de Lara >=20 > Nak, this also re-adds the need to link the pmd to the application, eithe= r > statically or at runtime (i.e. this implicitly obviates the -d option in > rte_eal_parse_args). If you really want to re-add these api calls, I > recommend > that you split them into a separate ring library and ring_pmd library. >=20 > Neil >=20 > P.S. you did remember to use the -d option in your testing, right? Witho= ut it > the pmd won't load and the vdev option won't find the proper pmd to parse > it. >=20 Why does it need the -d? I could use the vdev option without loading any dy= namic pmds, and it created the devices, but it is just difficult to run a simple unit test,= by having to know which ethdevs you have to create, instead of letting the test itself to create th= e ones that it needs, if you know what I mean. So, if this solution is not good enough, another i= dea could be to let=20 the unit test make calls to the application, creating the virtual devices n= eeded. What I don't=20 like is the idea of having to pass the vdev to the generic test application= , as it is intended to=20 run other tests and not just the ring pmd (we could do something like in th= e eal_flags test, where several test app instances are run, with different parameters, althou= gh I am not sure, if this is possible for this kind of test). Thanks, Pablo