DPDK patches and discussions
 help / color / mirror / Atom feed
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] app/test: fix build switches to enable cmdline	tests
Date: Mon, 30 Jun 2014 10:19:26 +0000	[thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8971A794922@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8971A78F2A3@IRSMSX103.ger.corp.intel.com>

> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> > Sent: Friday, June 27, 2014 10:47 AM
> > To: dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH] app/test: fix build switches to enable cmdline
> > tests
> >
> > There were 2 typos since these commits (in 1.6.0 releases):
> > 	21a7f4e264 fix build without librte_cmdline
> > 	cac6d08c8b replace --use-device option by --pci-whitelist and --vdev
> > In makefiles, the build options are prefixed with CONFIG_RTE_
> > but in .c file, it is only RTE_.
> >
> > These typos were disabling cmdline unit tests and test of "--vdev eth_ring"
> > option.
> >
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> > ---
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Actually, I am thinking of removing the vdev eth_ring test. It doesn't work, as a secondary process
cannot allocate memzone, if I am not wrong, so it cannot create an the ethdev. Any objections on this?

Thanks,
Pablo

  reply	other threads:[~2014-06-30 10:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-27  9:46 Thomas Monjalon
2014-06-27 10:12 ` De Lara Guarch, Pablo
2014-06-30 10:19   ` De Lara Guarch, Pablo [this message]
2014-07-01 22:07   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8971A794922@IRSMSX103.ger.corp.intel.com \
    --to=pablo.de.lara.guarch@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).